[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681368#comment-17681368 ] ASF GitHub Bot commented on MNG-7598: - gnodet merged PR #971: URL: https://github.com/apache/maven/pull/971 > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 4.0.0-alpha-4, 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647972#comment-17647972 ] Konrad Windszus commented on MNG-7598: -- Partially resolved (in core and plugin-api) in https://github.com/apache/maven/commit/ce18c5620631c859ebb319689aef68a3004a1f17. > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647971#comment-17647971 ] ASF GitHub Bot commented on MNG-7598: - kwin merged PR #874: URL: https://github.com/apache/maven/pull/874 > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > Fix For: 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[
https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647927#comment-17647927
]
ASF GitHub Bot commented on MNG-7598:
-
gnodet commented on code in PR #874:
URL: https://github.com/apache/maven/pull/874#discussion_r1049352600
##
maven-core/src/main/java/org/apache/maven/settings/SettingsUtils.java:
##
@@ -51,9 +37,9 @@ private SettingsUtils()
* @param recessive
* @param recessiveSourceLevel
*/
-public static Settings merge( Settings dominant, Settings recessive,
String recessiveSourceLevel )
+public static void merge( Settings dominant, Settings recessive, String
recessiveSourceLevel )
{
-return new MavenSettingsMerger().merge( dominant, recessive,
recessiveSourceLevel );
+SettingsUtilsV4.merge( dominant.getDelegate(),
recessive.getDelegate(), recessiveSourceLevel );
Review Comment:
The method now reads:
```
public static void merge(Settings dominant, Settings recessive, String
recessiveSourceLevel) {
if (dominant != null && recessive != null) {
dominant.delegate =
SettingsUtilsV4.merge(dominant.getDelegate(), recessive.getDelegate());
}
}
```
As for the source level, I think it would be better to leverage the
InputLocationTracker in the model, which is way more powerful, for both
settings and toolchains. And get rid of the TrackableBase in the v4 models.
But this is an enhancement for another PR.
> Enforce binary backwards-compatibility with Maven 3 of all exported packages
>
>
> Key: MNG-7598
> URL: https://issues.apache.org/jira/browse/MNG-7598
> Project: Maven
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0
>
>
> All packages exported through the API classloader (indicated in
> https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml)
> should be binary backwards-compatible in Maven 4.
> To enforce this the
> [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html]
> should be leveraged during the build.
> Compare with the discussion at
> https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[
https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647925#comment-17647925
]
ASF GitHub Bot commented on MNG-7598:
-
gnodet commented on code in PR #874:
URL: https://github.com/apache/maven/pull/874#discussion_r1049352600
##
maven-core/src/main/java/org/apache/maven/settings/SettingsUtils.java:
##
@@ -51,9 +37,9 @@ private SettingsUtils()
* @param recessive
* @param recessiveSourceLevel
*/
-public static Settings merge( Settings dominant, Settings recessive,
String recessiveSourceLevel )
+public static void merge( Settings dominant, Settings recessive, String
recessiveSourceLevel )
{
-return new MavenSettingsMerger().merge( dominant, recessive,
recessiveSourceLevel );
+SettingsUtilsV4.merge( dominant.getDelegate(),
recessive.getDelegate(), recessiveSourceLevel );
Review Comment:
The method now reads:
```
public static void merge(Settings dominant, Settings recessive, String
recessiveSourceLevel) {
if (dominant != null && recessive != null) {
dominant.delegate =
SettingsUtilsV4.merge(dominant.getDelegate(), recessive.getDelegate());
}
}
```
As for the source level, I think it would be better to leverage the
InputLocationTracker in the model, which is way more powerful, for both
settings and toolchains. And get rid of the TrackableBase in the v4 models.
> Enforce binary backwards-compatibility with Maven 3 of all exported packages
>
>
> Key: MNG-7598
> URL: https://issues.apache.org/jira/browse/MNG-7598
> Project: Maven
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0
>
>
> All packages exported through the API classloader (indicated in
> https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml)
> should be binary backwards-compatible in Maven 4.
> To enforce this the
> [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html]
> should be leveraged during the build.
> Compare with the discussion at
> https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[
https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647662#comment-17647662
]
ASF GitHub Bot commented on MNG-7598:
-
slawekjaranowski commented on code in PR #874:
URL: https://github.com/apache/maven/pull/874#discussion_r1048805974
##
maven-core/src/main/java/org/apache/maven/settings/SettingsUtils.java:
##
@@ -51,9 +37,9 @@ private SettingsUtils()
* @param recessive
* @param recessiveSourceLevel
*/
-public static Settings merge( Settings dominant, Settings recessive,
String recessiveSourceLevel )
+public static void merge( Settings dominant, Settings recessive, String
recessiveSourceLevel )
{
-return new MavenSettingsMerger().merge( dominant, recessive,
recessiveSourceLevel );
+SettingsUtilsV4.merge( dominant.getDelegate(),
recessive.getDelegate(), recessiveSourceLevel );
Review Comment:
`dominant` and `recessive` can be null in v3.
caller expect that `dominant` will have a result of merge , so we need
```
dominant.delegate = SettingsUtilsV4.merge( ...
```
> Enforce binary backwards-compatibility with Maven 3 of all exported packages
>
>
> Key: MNG-7598
> URL: https://issues.apache.org/jira/browse/MNG-7598
> Project: Maven
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0
>
>
> All packages exported through the API classloader (indicated in
> https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml)
> should be binary backwards-compatible in Maven 4.
> To enforce this the
> [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html]
> should be leveraged during the build.
> Compare with the discussion at
> https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643216#comment-17643216 ] ASF GitHub Bot commented on MNG-7598: - kwin commented on PR #874: URL: https://github.com/apache/maven/pull/874#issuecomment-1337080224 @gnodet Any objection to merge this (after fixing the conflicts)? > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > Fix For: 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636567#comment-17636567 ] ASF GitHub Bot commented on MNG-7598: - kwin commented on PR #874: URL: https://github.com/apache/maven/pull/874#issuecomment-1321722446 This is just a start for sure to allow us to incrementally merge. Let us first fix Core and Plugin API and then follow-up with subsequent PRs for the other modules. > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > Fix For: 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636558#comment-17636558 ] ASF GitHub Bot commented on MNG-7598: - gnodet commented on PR #874: URL: https://github.com/apache/maven/pull/874#issuecomment-1321706362 I think it needs to be enabled on not only maven-core. It's missing stuff like https://github.com/apache/maven/pull/841/files#diff-a660bdaa2e580478c65a557fd7001c80e129c0e9d4766840b4072c3b72c1863f > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > Fix For: 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634884#comment-17634884 ] ASF GitHub Bot commented on MNG-7598: - kwin commented on PR #874: URL: https://github.com/apache/maven/pull/874#issuecomment-1317193067 @gnodet I fixed most of the issues in Maven Core. Can you look at the others and either fix or ignore with a comment? > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > Fix For: 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://siom79.github.io/japicmp/MavenPlugin.html. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634778#comment-17634778 ] ASF GitHub Bot commented on MNG-7598: - kwin opened a new pull request, #874: URL: https://github.com/apache/maven/pull/874 For now only enabled in core and plugin-api Currently breaks build due to incompatible changes compared to 3.8.6 > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > Fix For: 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://siom79.github.io/japicmp/MavenPlugin.html. -- This message was sent by Atlassian Jira (v8.20.10#820010)
