[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-12-05 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643242#comment-17643242
 ] 

Hudson commented on MNG-7611:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #91

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/91/

> java.lang.IllegalStateException: Required Java version 1.8 is not met by 
> current version: 17.0.5
> 
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not 
> met by current version: 17.0.5
>at 
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-12-05 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643217#comment-17643217
 ] 

ASF GitHub Bot commented on MNG-7611:
-

kwin merged PR #184:
URL: https://github.com/apache/maven-plugin-tools/pull/184




> java.lang.IllegalStateException: Required Java version 1.8 is not met by 
> current version: 17.0.5
> 
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not 
> met by current version: 17.0.5
>at 
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-12-01 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642179#comment-17642179
 ] 

Hudson commented on MNG-7611:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » master #141

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/141/

> java.lang.IllegalStateException: Required Java version 1.8 is not met by 
> current version: 17.0.5
> 
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not 
> met by current version: 17.0.5
>at 
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-12-01 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642164#comment-17642164
 ] 

ASF GitHub Bot commented on MNG-7611:
-

kwin merged PR #888:
URL: https://github.com/apache/maven/pull/888




> java.lang.IllegalStateException: Required Java version 1.8 is not met by 
> current version: 17.0.5
> 
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not 
> met by current version: 17.0.5
>at 
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-12-01 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642157#comment-17642157
 ] 

ASF GitHub Bot commented on MNG-7611:
-

michael-o commented on code in PR #888:
URL: https://github.com/apache/maven/pull/888#discussion_r1037533787


##
maven-core/src/main/java/org/apache/maven/plugin/internal/MavenPluginJavaPrerequisiteChecker.java:
##
@@ -18,26 +18,57 @@
  */
 package org.apache.maven.plugin.internal;
 
+import javax.inject.Inject;
 import javax.inject.Named;
 import javax.inject.Singleton;
-import org.apache.maven.model.profile.activation.JdkVersionProfileActivator;
 import org.apache.maven.plugin.MavenPluginPrerequisitesChecker;
 import org.apache.maven.plugin.descriptor.PluginDescriptor;
 import org.codehaus.plexus.util.StringUtils;
+import org.eclipse.aether.version.InvalidVersionSpecificationException;
+import org.eclipse.aether.version.Version;
+import org.eclipse.aether.version.VersionConstraint;
+import org.eclipse.aether.version.VersionScheme;
 
 @Named
 @Singleton
 public class MavenPluginJavaPrerequisiteChecker implements 
MavenPluginPrerequisitesChecker {
 
+private final VersionScheme versionScheme;
+
+@Inject
+public MavenPluginJavaPrerequisiteChecker(final VersionScheme 
versionScheme) {
+this.versionScheme = versionScheme;
+}
+
 @Override
 public void accept(PluginDescriptor pluginDescriptor) {
 String requiredJavaVersion = pluginDescriptor.getRequiredJavaVersion();
 if (StringUtils.isNotBlank(requiredJavaVersion)) {
 String currentJavaVersion = System.getProperty("java.version");
-if 
(!JdkVersionProfileActivator.isJavaVersionCompatible(requiredJavaVersion, 
currentJavaVersion)) {
+if (!matchesVersion(requiredJavaVersion, currentJavaVersion)) {
 throw new IllegalStateException("Required Java version " + 
requiredJavaVersion
 + " is not met by current version: " + 
currentJavaVersion);
 }
 }
 }
+
+boolean matchesVersion(String requiredVersion, String currentVersion) {
+VersionConstraint constraint;
+try {
+constraint = versionScheme.parseVersionConstraint(requiredVersion);
+} catch (InvalidVersionSpecificationException e) {
+throw new IllegalArgumentException(
+"Invalid requiredJavaVersion given in plugin descriptor: " 
+ e.getMessage(), e);
+}
+Version current;
+try {
+current = versionScheme.parseVersion(currentVersion);
+} catch (InvalidVersionSpecificationException e) {
+throw new IllegalStateException("Could not parse current Java 
version: " + e.getMessage(), e);

Review Comment:
   When you look at our codebase and stack traces you will see duplicate 
messages all over. It is a pain to filter out the relevant information.





> java.lang.IllegalStateException: Required Java version 1.8 is not met by 
> current version: 17.0.5
> 
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not 
> met by current version: 17.0.5
>at 
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-12-01 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642154#comment-17642154
 ] 

ASF GitHub Bot commented on MNG-7611:
-

gnodet commented on code in PR #888:
URL: https://github.com/apache/maven/pull/888#discussion_r1037528525


##
maven-core/src/main/java/org/apache/maven/plugin/internal/MavenPluginJavaPrerequisiteChecker.java:
##
@@ -18,26 +18,57 @@
  */
 package org.apache.maven.plugin.internal;
 
+import javax.inject.Inject;
 import javax.inject.Named;
 import javax.inject.Singleton;
-import org.apache.maven.model.profile.activation.JdkVersionProfileActivator;
 import org.apache.maven.plugin.MavenPluginPrerequisitesChecker;
 import org.apache.maven.plugin.descriptor.PluginDescriptor;
 import org.codehaus.plexus.util.StringUtils;
+import org.eclipse.aether.version.InvalidVersionSpecificationException;
+import org.eclipse.aether.version.Version;
+import org.eclipse.aether.version.VersionConstraint;
+import org.eclipse.aether.version.VersionScheme;
 
 @Named
 @Singleton
 public class MavenPluginJavaPrerequisiteChecker implements 
MavenPluginPrerequisitesChecker {
 
+private final VersionScheme versionScheme;
+
+@Inject
+public MavenPluginJavaPrerequisiteChecker(final VersionScheme 
versionScheme) {
+this.versionScheme = versionScheme;
+}
+
 @Override
 public void accept(PluginDescriptor pluginDescriptor) {
 String requiredJavaVersion = pluginDescriptor.getRequiredJavaVersion();
 if (StringUtils.isNotBlank(requiredJavaVersion)) {
 String currentJavaVersion = System.getProperty("java.version");
-if 
(!JdkVersionProfileActivator.isJavaVersionCompatible(requiredJavaVersion, 
currentJavaVersion)) {
+if (!matchesVersion(requiredJavaVersion, currentJavaVersion)) {
 throw new IllegalStateException("Required Java version " + 
requiredJavaVersion
 + " is not met by current version: " + 
currentJavaVersion);
 }
 }
 }
+
+boolean matchesVersion(String requiredVersion, String currentVersion) {
+VersionConstraint constraint;
+try {
+constraint = versionScheme.parseVersionConstraint(requiredVersion);
+} catch (InvalidVersionSpecificationException e) {
+throw new IllegalArgumentException(
+"Invalid requiredJavaVersion given in plugin descriptor: " 
+ e.getMessage(), e);
+}
+Version current;
+try {
+current = versionScheme.parseVersion(currentVersion);
+} catch (InvalidVersionSpecificationException e) {
+throw new IllegalStateException("Could not parse current Java 
version: " + e.getMessage(), e);

Review Comment:
   Why not ? For the record, I would argue that gives a hint to the cause 
without having to read the full stack trace. Maybe even `("xxx" + e, e)` can be 
useful some time...



##
maven-core/src/main/java/org/apache/maven/plugin/internal/MavenPluginJavaPrerequisiteChecker.java:
##
@@ -18,26 +18,57 @@
  */
 package org.apache.maven.plugin.internal;
 
+import javax.inject.Inject;
 import javax.inject.Named;
 import javax.inject.Singleton;
-import org.apache.maven.model.profile.activation.JdkVersionProfileActivator;
 import org.apache.maven.plugin.MavenPluginPrerequisitesChecker;
 import org.apache.maven.plugin.descriptor.PluginDescriptor;
 import org.codehaus.plexus.util.StringUtils;
+import org.eclipse.aether.version.InvalidVersionSpecificationException;
+import org.eclipse.aether.version.Version;
+import org.eclipse.aether.version.VersionConstraint;
+import org.eclipse.aether.version.VersionScheme;
 
 @Named
 @Singleton
 public class MavenPluginJavaPrerequisiteChecker implements 
MavenPluginPrerequisitesChecker {
 
+private final VersionScheme versionScheme;
+
+@Inject
+public MavenPluginJavaPrerequisiteChecker(final VersionScheme 
versionScheme) {
+this.versionScheme = versionScheme;
+}
+
 @Override
 public void accept(PluginDescriptor pluginDescriptor) {
 String requiredJavaVersion = pluginDescriptor.getRequiredJavaVersion();
 if (StringUtils.isNotBlank(requiredJavaVersion)) {
 String currentJavaVersion = System.getProperty("java.version");
-if 
(!JdkVersionProfileActivator.isJavaVersionCompatible(requiredJavaVersion, 
currentJavaVersion)) {
+if (!matchesVersion(requiredJavaVersion, currentJavaVersion)) {
 throw new IllegalStateException("Required Java version " + 
requiredJavaVersion
 + " is not met by current version: " + 
currentJavaVersion);
 }
 }
 }
+
+boolean matchesVersion(String requiredVersion, String currentVersion) {
+VersionConstraint constraint;
+try {
+constraint =

[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-12-01 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641749#comment-17641749
 ] 

ASF GitHub Bot commented on MNG-7611:
-

kwin commented on code in PR #888:
URL: https://github.com/apache/maven/pull/888#discussion_r1036814051


##
maven-core/src/main/java/org/apache/maven/plugin/internal/MavenPluginJavaPrerequisiteChecker.java:
##
@@ -18,26 +18,57 @@
  */
 package org.apache.maven.plugin.internal;
 
+import javax.inject.Inject;
 import javax.inject.Named;
 import javax.inject.Singleton;
-import org.apache.maven.model.profile.activation.JdkVersionProfileActivator;
 import org.apache.maven.plugin.MavenPluginPrerequisitesChecker;
 import org.apache.maven.plugin.descriptor.PluginDescriptor;
 import org.codehaus.plexus.util.StringUtils;
+import org.eclipse.aether.version.InvalidVersionSpecificationException;
+import org.eclipse.aether.version.Version;
+import org.eclipse.aether.version.VersionConstraint;
+import org.eclipse.aether.version.VersionScheme;
 
 @Named
 @Singleton
 public class MavenPluginJavaPrerequisiteChecker implements 
MavenPluginPrerequisitesChecker {
 
+private final VersionScheme versionScheme;
+
+@Inject
+public MavenPluginJavaPrerequisiteChecker(final VersionScheme 
versionScheme) {
+this.versionScheme = versionScheme;
+}
+
 @Override
 public void accept(PluginDescriptor pluginDescriptor) {
 String requiredJavaVersion = pluginDescriptor.getRequiredJavaVersion();
 if (StringUtils.isNotBlank(requiredJavaVersion)) {
 String currentJavaVersion = System.getProperty("java.version");
-if 
(!JdkVersionProfileActivator.isJavaVersionCompatible(requiredJavaVersion, 
currentJavaVersion)) {
+if (!matchesVersion(requiredJavaVersion, currentJavaVersion)) {
 throw new IllegalStateException("Required Java version " + 
requiredJavaVersion
 + " is not met by current version: " + 
currentJavaVersion);
 }
 }
 }
+
+boolean matchesVersion(String requiredVersion, String currentVersion) {
+VersionConstraint constraint;
+try {
+constraint = versionScheme.parseVersionConstraint(requiredVersion);
+} catch (InvalidVersionSpecificationException e) {
+throw new IllegalArgumentException(
+"Invalid requiredJavaVersion given in plugin descriptor: " 
+ e.getMessage(), e);
+}
+Version current;
+try {
+current = versionScheme.parseVersion(currentVersion);
+} catch (InvalidVersionSpecificationException e) {
+throw new IllegalStateException("Could not parse current Java 
version: " + e.getMessage(), e);

Review Comment:
   fixed in 
https://github.com/apache/maven/pull/888/commits/c407bbb997ed472a414d24e5d4c2b065984c6f31.





> java.lang.IllegalStateException: Required Java version 1.8 is not met by 
> current version: 17.0.5
> 
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not 
> met by current version: 17.0.5
>at 
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-12-01 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641746#comment-17641746
 ] 

ASF GitHub Bot commented on MNG-7611:
-

kwin opened a new pull request, #184:
URL: https://github.com/apache/maven-plugin-tools/pull/184

   Generate simple version constraints automatically
   Fix Javadoc




> java.lang.IllegalStateException: Required Java version 1.8 is not met by 
> current version: 17.0.5
> 
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not 
> met by current version: 17.0.5
>at 
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-12-01 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641741#comment-17641741
 ] 

ASF GitHub Bot commented on MNG-7611:
-

michael-o commented on code in PR #888:
URL: https://github.com/apache/maven/pull/888#discussion_r1036802620


##
maven-core/src/main/java/org/apache/maven/plugin/internal/MavenPluginJavaPrerequisiteChecker.java:
##
@@ -18,26 +18,57 @@
  */
 package org.apache.maven.plugin.internal;
 
+import javax.inject.Inject;
 import javax.inject.Named;
 import javax.inject.Singleton;
-import org.apache.maven.model.profile.activation.JdkVersionProfileActivator;
 import org.apache.maven.plugin.MavenPluginPrerequisitesChecker;
 import org.apache.maven.plugin.descriptor.PluginDescriptor;
 import org.codehaus.plexus.util.StringUtils;
+import org.eclipse.aether.version.InvalidVersionSpecificationException;
+import org.eclipse.aether.version.Version;
+import org.eclipse.aether.version.VersionConstraint;
+import org.eclipse.aether.version.VersionScheme;
 
 @Named
 @Singleton
 public class MavenPluginJavaPrerequisiteChecker implements 
MavenPluginPrerequisitesChecker {
 
+private final VersionScheme versionScheme;
+
+@Inject
+public MavenPluginJavaPrerequisiteChecker(final VersionScheme 
versionScheme) {
+this.versionScheme = versionScheme;
+}
+
 @Override
 public void accept(PluginDescriptor pluginDescriptor) {
 String requiredJavaVersion = pluginDescriptor.getRequiredJavaVersion();
 if (StringUtils.isNotBlank(requiredJavaVersion)) {
 String currentJavaVersion = System.getProperty("java.version");
-if 
(!JdkVersionProfileActivator.isJavaVersionCompatible(requiredJavaVersion, 
currentJavaVersion)) {
+if (!matchesVersion(requiredJavaVersion, currentJavaVersion)) {
 throw new IllegalStateException("Required Java version " + 
requiredJavaVersion
 + " is not met by current version: " + 
currentJavaVersion);
 }
 }
 }
+
+boolean matchesVersion(String requiredVersion, String currentVersion) {
+VersionConstraint constraint;
+try {
+constraint = versionScheme.parseVersionConstraint(requiredVersion);
+} catch (InvalidVersionSpecificationException e) {
+throw new IllegalArgumentException(
+"Invalid requiredJavaVersion given in plugin descriptor: " 
+ e.getMessage(), e);
+}
+Version current;
+try {
+current = versionScheme.parseVersion(currentVersion);
+} catch (InvalidVersionSpecificationException e) {
+throw new IllegalStateException("Could not parse current Java 
version: " + e.getMessage(), e);

Review Comment:
   Please don't provide duplicate messages with `e.getMessage(), e`.





> java.lang.IllegalStateException: Required Java version 1.8 is not met by 
> current version: 17.0.5
> 
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not 
> met by current version: 17.0.5
>at 
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-11-30 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641733#comment-17641733
 ] 

ASF GitHub Bot commented on MNG-7611:
-

kwin opened a new pull request, #888:
URL: https://github.com/apache/maven/pull/888

   Always assume version constraint (the same as in requiredMavenVersion)
   
   




> java.lang.IllegalStateException: Required Java version 1.8 is not met by 
> current version: 17.0.5
> 
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not 
> met by current version: 17.0.5
>at 
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-11-30 Thread Konrad Windszus (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641717#comment-17641717
 ] 

Konrad Windszus commented on MNG-7611:
--

This is an expected behaviour as the javaRequirement in the plugin descriptor 
is not always interpreted as value range, but in this case as mere prefix.

> java.lang.IllegalStateException: Required Java version 1.8 is not met by 
> current version: 17.0.5
> 
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not 
> met by current version: 17.0.5
>at 
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at 
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)