[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784545#comment-17784545
 ] 

ASF GitHub Bot commented on MNG-7648:
-

hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1804183734

   Sorry never got around to opening a ticket on this but tried out alpha 8, it 
works perfect now.  Confirmed with java 11, 17, and 21.  No issues.  So 
whatever was wrong was magically fixed ;)




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756566#comment-17756566
 ] 

ASF GitHub Bot commented on MNG-7648:
-

hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1685350878

   Yes will do.
   
   Sent from my Verizon, Samsung Galaxy smartphone
   Get Outlook for Android
   
   From: Guillaume Nodet ***@***.***>
   Sent: Sunday, August 20, 2023 3:49:17 AM
   To: apache/maven ***@***.***>
   Cc: Jeremy Landis ***@***.***>; Comment ***@***.***>
   Subject: Re: [apache/maven] [MNG-7648] Fix locationTracking in 
DefaultModelBuildingRequest copy constructor. (PR #940)
   
   
   And yes my super pom - not maven's defines it in dependency management at 
3.11.0. So clearly something is wrong here.
   
   Could your raise a new issue so that it's not forgotten ?
   
   —
   Reply to this email directly, view it on 
GitHub, or 
unsubscribe.
   You are receiving this because you commented.Message ID: ***@***.***>
   




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756458#comment-17756458
 ] 

ASF GitHub Bot commented on MNG-7648:
-

gnodet commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1685214103

   > And yes my super pom - not maven's defines it in dependency management at 
3.11.0. So clearly something is wrong here.
   
   Could your raise a new issue so that it's not forgotten ?




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756424#comment-17756424
 ] 

ASF GitHub Bot commented on MNG-7648:
-

hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1685137955

   And yes my super pom - not maven's defines it in dependency management at 
3.11.0.  So clearly something is wrong here.




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756422#comment-17756422
 ] 

ASF GitHub Bot commented on MNG-7648:
-

hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1685137650

   You can see the issue additionally here 
https://github.com/spotbugs/spotbugs-maven-plugin/pull/626.  Its using same 
base parent and maven 3.3.9 and 3.9.4 are working fine.  If I use 4 alpha 4 its 
fine.  Only a problem on 4 afterwards.




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756423#comment-17756423
 ] 

ASF GitHub Bot commented on MNG-7648:
-

hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1685137746

   ```
[INFO] 

   Error:  Failed to execute goal 
org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (enforce-clean) on 
project spotbugs-maven-plugin: 
   Error:  Rule 6: org.apache.maven.enforcer.rules.RequirePluginVersions failed 
with message:
   Error:  Some plugins are missing valid versions or depend on Maven 
4.0.0-alpha-5 defaults (LATEST, RELEASE, SNAPSHOT, TIMESTAMP SNAPSHOT as plugin 
version are not allowed)
   Error: org.apache.maven.plugins:maven-compiler-plugin.   The version 
currently in use is 3.11.0 via super POM or default lifecycle bindings
   Error: ] Best Practice is to always define plugin versions!
   Error:  -> [Help 1]
   Error:  
   Error:  To see the full stack trace of the errors, re-run Maven with the 
'-e' switch
   Error:  Re-run Maven using the '-X' switch to enable verbose output
   Error:  
   Error:  For more information about the errors and possible solutions, please 
read the following articles:
   Error:  [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
   Error: Process completed with exit code 1.
   ```




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756421#comment-17756421
 ] 

ASF GitHub Bot commented on MNG-7648:
-

hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1685137331

   Reporting again here, alpha 7 has same issue.  Only Alpha 4 of maven works 
as expected.  Any maven version before 4-alpha-5 and all 3.x as far as I can 
remember - like 10 years ago, do not require the version to be additional 
restated inside a profile.  Its always properly inherited it as far as I'm 
aware.  As @pavelhoral noted possible plugin definitions are not merged.  I 
presume they always were before, can anyone confirm?  Trying to understand why 
now after decade of doing profiles like this, its only an issue now.




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737405#comment-17737405
 ] 

ASF GitHub Bot commented on MNG-7648:
-

hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1608572067

   As far as I know it should be inherited.  At least it would not make sense 
to redefined versions all over.




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735148#comment-17735148
 ] 

ASF GitHub Bot commented on MNG-7648:
-

pavelhoral commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1598178832

   > @pavelhoral Do you know if alpha 5 has this regression again? Testing 
alpha 4 here 
https://github.com/hazendaz/spotbugs-maven-plugin/actions/workflows/it-maven-4.0.0.yaml
 and it works, the prior runs for same job used alpha 5 and seems broken again. 
Just wonder if you are seeing same behaviour.
   
   It shouldn't be the same bug as that would have been caught by the unit 
tests (I hope).
   
   Interesting thing is that the enforcer rule fails only on Java 17 and not 
Java 11:
   
   Java 11 run
   
   ```console
   /tmp/spotbugs-maven-plugin$ JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64/ 
/srv/repo/maven/apache-maven-4.0.0-alpha-5/bin/mvn  -B -V clean install 
-Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-5 --no-transfer-progress
   Apache Maven 4.0.0-alpha-5 (26d10a4bf9a2df75feef60da01d8706f2bf77a47)
   Maven home: /srv/repo/maven/apache-maven-4.0.0-alpha-5
   Java version: 11.0.19, vendor: Ubuntu, runtime: 
/usr/lib/jvm/java-11-openjdk-amd64
   Default locale: en_US, platform encoding: UTF-8
   OS name: "linux", version: "5.19.0-43-generic", arch: "amd64", family: "unix"
   [INFO] Scanning for projects...
   [INFO] 
   [INFO] --< 
com.github.spotbugs:spotbugs-maven-plugin 
>---
   [INFO] Building spotbugs-maven-plugin 4.7.3.6-SNAPSHOT
   [INFO]   from pom.xml
   [INFO] -[ maven-plugin 
]-
   [INFO] 
   [INFO] -

> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735139#comment-17735139
 ] 

ASF GitHub Bot commented on MNG-7648:
-

gnodet commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1598165246

   @pavelhoral I'm planning a release of 4.0.0-alpha-6 in the coming days, so a 
quick check with the latest master branch would be welcomed !




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734577#comment-17734577
 ] 

ASF GitHub Bot commented on MNG-7648:
-

hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1597870102

   @pavelhoral Do you know if alpha 5 has this regression again?  Testing alpha 
4 here 
https://github.com/hazendaz/spotbugs-maven-plugin/actions/workflows/it-maven-4.0.0.yaml
 and it works, the prior runs for same job used alpha 5 and seems broken again. 
 Just wonder if you are seeing same behaviour.




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690610#comment-17690610
 ] 

Michael Osipov commented on MNG-7648:
-

Fixed with 
[91d8c6594e881151d2feabf8c3d4119d9aa05497|https://gitbox.apache.org/repos/asf?p=maven.git=commit=91d8c6594e881151d2feabf8c3d4119d9aa05497]
 for {{maven-3.8.x}} branch.

> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-4, 4.0.0, 3.8.8
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653404#comment-17653404
 ] 

ASF GitHub Bot commented on MNG-7648:
-

slawekjaranowski merged PR #943:
URL: https://github.com/apache/maven/pull/943




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653064#comment-17653064
 ] 

ASF GitHub Bot commented on MNG-7648:
-

pavelhoral opened a new pull request, #943:
URL: https://github.com/apache/maven/pull/943

   This is backport / cherry-pick of #940.
   
   --
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`,
  where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA 
issue.
- [x] Also format the first line of the commit message like `[MNG-XXX] 
SUMMARY`.
  Best practice is to use the JIRA issue title in both the pull request 
title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652856#comment-17652856
 ] 

ASF GitHub Bot commented on MNG-7648:
-

slawekjaranowski commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1367359702

   @pavelhoral please create PR for `maven-3.9.x` 




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652851#comment-17652851
 ] 

ASF GitHub Bot commented on MNG-7648:
-

pavelhoral commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1367330916

   > In 3.9.x there is no such issue - looks like `DefaultModelBuildingRequest` 
constructor is not used but I think that we can cherry pick this commit to be 
sure that is working as expected with next changes
   
   @slawekjaranowski Should I create another PR with the unit test targeting 
`maven-3.9.x` branch? Or was that comment meant in a way that you will do that?




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652836#comment-17652836
 ] 

ASF GitHub Bot commented on MNG-7648:
-

slawekjaranowski commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1367306455

   @pavelhoral thanks
   
   I squashed to one final commit 
   
   In 3.9.x there is no such issue - looks like `DefaultModelBuildingRequest` 
constructor is not used
   but I think that we can cherry pick this commit to be sure that is working 
as expected with next changes




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652834#comment-17652834
 ] 

ASF GitHub Bot commented on MNG-7648:
-

slawekjaranowski merged PR #940:
URL: https://github.com/apache/maven/pull/940




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652787#comment-17652787
 ] 

ASF GitHub Bot commented on MNG-7648:
-

pavelhoral commented on code in PR #940:
URL: https://github.com/apache/maven/pull/940#discussion_r1058848533


##
maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java:
##
@@ -347,4 +349,32 @@ public void testBuildFromModelSourceResolvesBasedir() 
throws Exception {
 }
 assertEquals(0, errors);
 }
+
+@Test
+public void testLocationTrackingResolution() throws Exception {
+File pom = getProject("MNG-7654");

Review Comment:
   Fixed (such a stupid mistake).





> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652785#comment-17652785
 ] 

ASF GitHub Bot commented on MNG-7648:
-

pavelhoral commented on code in PR #940:
URL: https://github.com/apache/maven/pull/940#discussion_r1058846209


##
maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java:
##
@@ -347,4 +349,32 @@ public void testBuildFromModelSourceResolvesBasedir() 
throws Exception {
 }
 assertEquals(0, errors);
 }
+
+@Test
+public void testLocationTrackingResolution() throws Exception {
+File pom = getProject("MNG-7654");

Review Comment:
   OMG how have I switched that :facepalm: 





> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652782#comment-17652782
 ] 

ASF GitHub Bot commented on MNG-7648:
-

slawekjaranowski commented on code in PR #940:
URL: https://github.com/apache/maven/pull/940#discussion_r1058827912


##
maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java:
##
@@ -347,4 +349,32 @@ public void testBuildFromModelSourceResolvesBasedir() 
throws Exception {
 }
 assertEquals(0, errors);
 }
+
+@Test
+public void testLocationTrackingResolution() throws Exception {
+File pom = getProject("MNG-7654");

Review Comment:
   Should be `MNG-7648` - 7654 it is not issue for this PR.





> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652539#comment-17652539
 ] 

ASF GitHub Bot commented on MNG-7648:
-

pavelhoral commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1366796782

   I have added the unit test to this PR and I have also fixed `assertNotNull` 
argument order in the test next to the one I have added.




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652474#comment-17652474
 ] 

ASF GitHub Bot commented on MNG-7648:
-

slawekjaranowski commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1366585458

   Please add test to this PR - we will have a complete change.




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652472#comment-17652472
 ] 

ASF GitHub Bot commented on MNG-7648:
-

pavelhoral commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1366577981

   @slawekjaranowski I have created unit test for location tracking but I have 
kept it in a separate branch for now - 
https://github.com/pavelhoral/maven/commit/c25b984b24e46985a45f034535b8030437355642
 . Let me know if this is something you had in mind and if I should add it to 
this PR or keep it separate.




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[Slawomir Jaranowski (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652277#comment-17652277
 ] 

Slawomir Jaranowski commented on MNG-7648:
--

Only for reference, I bisected and found:

619973b91cff5af7b5695bda11761a982a159349 is the first bad commit
https://github.com/apache/maven/commit/619973b91cff5af7b5695bda11761a982a159349


 

> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652229#comment-17652229
 ] 

ASF GitHub Bot commented on MNG-7648:
-

pavelhoral commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1365831055

   I can verify that with the fixed version I am able to successfully build my 
test project (i.e. this fix fixes problems in enforcer):
   
   ```console
   $ ../apache-maven-4.0.0-alpha-4-SNAPSHOT/bin/mvn -s ../settings.xml verify 
-f project/pom.xml
   [INFO] Scanning for projects...
   [INFO] 
   [INFO] --< 
org.example:enforcer-test-project >---
   [INFO] Building enforcer-test-project 1.0.0-SNAPSHOT
   [INFO]   from pom.xml
   [INFO] -[ pom 
]--
   [INFO] 
   [INFO] -

> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[Slawomir Jaranowski (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652225#comment-17652225
 ] 

Slawomir Jaranowski commented on MNG-7648:
--

[~pavel.horal] thanks for investigation, can you provide a PR for it?

> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652227#comment-17652227
 ] 

ASF GitHub Bot commented on MNG-7648:
-

pavelhoral opened a new pull request, #940:
URL: https://github.com/apache/maven/pull/940

   This fixes missing `locationTracking` in project model.
   
   Missing `locationTracking` was causing issues down the line in enforcer 
plugin that was not able to verify source of the model configuration.
   
   --
   
   Following this checklist to help us incorporate your contribution quickly 
and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`,
  where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA 
issue.
- [x] Also format the first line of the commit message like `[MNG-XXX] 
SUMMARY`.
  Best practice is to use the JIRA issue title in both the pull request 
title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[Pavel Horal (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652221#comment-17652221
 ] 

Pavel Horal commented on MNG-7648:
--

Ah... it is actually pretty simple - copy constructor of 
{{DefaultModelBuildingRequest}} is not setting {{locationTracking}} which is 
probably a bug.

> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[Pavel Horal (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652218#comment-17652218
 ] 

Pavel Horal commented on MNG-7648:
--

I have tried to debug the code flow and end up in DefaultModelBuilder that does 
not set {{locationTracking}} when requesting parent model - 
https://github.com/apache/maven/blob/8150c62749a637a98fbb9489fb8162034956220b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java#L1535
 . This is my first dive into Maven internals so I am not sure I will be able 
to add any additional context. I might try to compare with Maven 3.9.x to 
verify this is regression, but I am affraid that the code will be too different.

> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

[Pavel Horal (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651869#comment-17651869
 ] 

Pavel Horal commented on MNG-7648:
--

FYI component that I used when creating this issue is nonsense (as well as the 
link in the description - I did not realize that the file is generated). 
Correct component should be Core or General. Other than that the issue is valid.

> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Toolchains
>Affects Versions: 4.0.0-alpha-3
>Reporter: Pavel Horal
>Priority: Major
>
> Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  . This causes issues for example in Maven Enforcer Plugin which uses this 
> information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)