[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[ https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709475#comment-17709475 ] ASF GitHub Bot commented on MNG-7713: - anatolVasin commented on PR #1018: URL: https://github.com/apache/maven/pull/1018#issuecomment-1499458903 > resolver option Hello @cstamas , could you clarify what particular resolver option do you mean? Thanks. Such capabilities really requires for emulate closed environments without access to Maven Central in tests. > Drop option legacy-local-repository > --- > > Key: MNG-7713 > URL: https://issues.apache.org/jira/browse/MNG-7713 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.1, 4.0.0-alpha-5, 4.0.0 > > > The option offers several ways to make Maven 3 use Maven 2 legacy local > repository, the option help text states: "Use Maven 2 Legacy Local Repository > behaviour, ie no use of _remote.repositories. Can also be activated by using > -Dmaven.legacyLocalRepo=true". > Let's drop this option, as there is no need to make Maven 3.9 support Maven 2 > local repository, that is (should be) transient anyway. Also, if really > needed, there IS a resolver configuration that offers somewhat similar > semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility > anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[ https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695053#comment-17695053 ] ASF GitHub Bot commented on MNG-7713: - cstamas merged PR #1022: URL: https://github.com/apache/maven/pull/1022 > Drop option legacy-local-repository > --- > > Key: MNG-7713 > URL: https://issues.apache.org/jira/browse/MNG-7713 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1 > > > The option offers several ways to make Maven 3 use Maven 2 legacy local > repository, the option help text states: "Use Maven 2 Legacy Local Repository > behaviour, ie no use of _remote.repositories. Can also be activated by using > -Dmaven.legacyLocalRepo=true". > Let's drop this option, as there is no need to make Maven 3.9 support Maven 2 > local repository, that is (should be) transient anyway. Also, if really > needed, there IS a resolver configuration that offers somewhat similar > semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility > anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[ https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695048#comment-17695048 ] ASF GitHub Bot commented on MNG-7713: - cstamas opened a new pull request, #1022: URL: https://github.com/apache/maven/pull/1022 As with previous PR (simple removal) the `-llr` got interpreted as `-l lr`, it logged all output to `lr` file. This would maean that use of `-llr` would still sneakily 'work' and probably cause surprise down the road to users. Returned the option, and expicitly checking for it's presence to be able to fail with meaningful message. --- https://issues.apache.org/jira/browse/MNG-7713 > Drop option legacy-local-repository > --- > > Key: MNG-7713 > URL: https://issues.apache.org/jira/browse/MNG-7713 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1 > > > The option offers several ways to make Maven 3 use Maven 2 legacy local > repository, the option help text states: "Use Maven 2 Legacy Local Repository > behaviour, ie no use of _remote.repositories. Can also be activated by using > -Dmaven.legacyLocalRepo=true". > Let's drop this option, as there is no need to make Maven 3.9 support Maven 2 > local repository, that is (should be) transient anyway. Also, if really > needed, there IS a resolver configuration that offers somewhat similar > semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility > anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[ https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695045#comment-17695045 ] ASF GitHub Bot commented on MNG-7713: - cstamas merged PR #1021: URL: https://github.com/apache/maven/pull/1021 > Drop option legacy-local-repository > --- > > Key: MNG-7713 > URL: https://issues.apache.org/jira/browse/MNG-7713 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1 > > > The option offers several ways to make Maven 3 use Maven 2 legacy local > repository, the option help text states: "Use Maven 2 Legacy Local Repository > behaviour, ie no use of _remote.repositories. Can also be activated by using > -Dmaven.legacyLocalRepo=true". > Let's drop this option, as there is no need to make Maven 3.9 support Maven 2 > local repository, that is (should be) transient anyway. Also, if really > needed, there IS a resolver configuration that offers somewhat similar > semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility > anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[
https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695010#comment-17695010
]
ASF GitHub Bot commented on MNG-7713:
-
cstamas commented on code in PR #1021:
URL: https://github.com/apache/maven/pull/1021#discussion_r1121553055
##
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java:
##
@@ -280,6 +280,12 @@ public CLIManager() {
.desc("Ineffective, only kept for backward compatibility")
.build());
+// Adding this back to make Maven fail if used
Review Comment:
We need it not only to avoid conflicting `-l lr` but also to emit sane error
message (so we really want to parse it from CLI but fail if present). So, I
started a new "section" here (below the "ineffective section") for those that
should fail.
> Drop option legacy-local-repository
> ---
>
> Key: MNG-7713
> URL: https://issues.apache.org/jira/browse/MNG-7713
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> The option offers several ways to make Maven 3 use Maven 2 legacy local
> repository, the option help text states: "Use Maven 2 Legacy Local Repository
> behaviour, ie no use of _remote.repositories. Can also be activated by using
> -Dmaven.legacyLocalRepo=true".
> Let's drop this option, as there is no need to make Maven 3.9 support Maven 2
> local repository, that is (should be) transient anyway. Also, if really
> needed, there IS a resolver configuration that offers somewhat similar
> semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility
> anymore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[
https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695009#comment-17695009
]
ASF GitHub Bot commented on MNG-7713:
-
slawekjaranowski commented on code in PR #1021:
URL: https://github.com/apache/maven/pull/1021#discussion_r1121551376
##
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java:
##
@@ -280,6 +280,12 @@ public CLIManager() {
.desc("Ineffective, only kept for backward compatibility")
.build());
+// Adding this back to make Maven fail if used
Review Comment:
Please add info about conflict with `-l lr` - why we need it
> Drop option legacy-local-repository
> ---
>
> Key: MNG-7713
> URL: https://issues.apache.org/jira/browse/MNG-7713
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> The option offers several ways to make Maven 3 use Maven 2 legacy local
> repository, the option help text states: "Use Maven 2 Legacy Local Repository
> behaviour, ie no use of _remote.repositories. Can also be activated by using
> -Dmaven.legacyLocalRepo=true".
> Let's drop this option, as there is no need to make Maven 3.9 support Maven 2
> local repository, that is (should be) transient anyway. Also, if really
> needed, there IS a resolver configuration that offers somewhat similar
> semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility
> anymore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[ https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695003#comment-17695003 ] ASF GitHub Bot commented on MNG-7713: - cstamas opened a new pull request, #1021: URL: https://github.com/apache/maven/pull/1021 As with previous PR (simple removal) the `-llr` got interpreted as `-l lr`, it logged all output to `lr` file. This would maean that use of `-llr` would still sneakily 'work' and probably cause surprise down the road to users. Returned the option, and expicitly checking for it's presence to be able to fail with meaningful message. --- https://issues.apache.org/jira/browse/MNG-7713 > Drop option legacy-local-repository > --- > > Key: MNG-7713 > URL: https://issues.apache.org/jira/browse/MNG-7713 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1 > > > The option offers several ways to make Maven 3 use Maven 2 legacy local > repository, the option help text states: "Use Maven 2 Legacy Local Repository > behaviour, ie no use of _remote.repositories. Can also be activated by using > -Dmaven.legacyLocalRepo=true". > Let's drop this option, as there is no need to make Maven 3.9 support Maven 2 > local repository, that is (should be) transient anyway. Also, if really > needed, there IS a resolver configuration that offers somewhat similar > semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility > anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[ https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694986#comment-17694986 ] ASF GitHub Bot commented on MNG-7713: - cstamas merged PR #1018: URL: https://github.com/apache/maven/pull/1018 > Drop option legacy-local-repository > --- > > Key: MNG-7713 > URL: https://issues.apache.org/jira/browse/MNG-7713 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1 > > > The option offers several ways to make Maven 3 use Maven 2 legacy local > repository, the option help text states: "Use Maven 2 Legacy Local Repository > behaviour, ie no use of _remote.repositories. Can also be activated by using > -Dmaven.legacyLocalRepo=true". > Let's drop this option, as there is no need to make Maven 3.9 support Maven 2 > local repository, that is (should be) transient anyway. Also, if really > needed, there IS a resolver configuration that offers somewhat similar > semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility > anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[
https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694982#comment-17694982
]
ASF GitHub Bot commented on MNG-7713:
-
michael-o commented on code in PR #1020:
URL: https://github.com/apache/maven/pull/1020#discussion_r1121469512
##
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##
@@ -843,13 +842,6 @@ private void encryption(CliRequest cliRequest) throws
Exception {
}
}
-private void repository(CliRequest cliRequest) throws Exception {
-if
(cliRequest.commandLine.hasOption(CLIManager.LEGACY_LOCAL_REPOSITORY)
-|| Boolean.getBoolean("maven.legacyLocalRepo")) {
Review Comment:
Interesting, it has been wrong. It should have been user prop, then sys
prop...
> Drop option legacy-local-repository
> ---
>
> Key: MNG-7713
> URL: https://issues.apache.org/jira/browse/MNG-7713
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> The option offers several ways to make Maven 3 use Maven 2 legacy local
> repository, the option help text states: "Use Maven 2 Legacy Local Repository
> behaviour, ie no use of _remote.repositories. Can also be activated by using
> -Dmaven.legacyLocalRepo=true".
> Let's drop this option, as there is no need to make Maven 3.9 support Maven 2
> local repository, that is (should be) transient anyway. Also, if really
> needed, there IS a resolver configuration that offers somewhat similar
> semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility
> anymore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[ https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694984#comment-17694984 ] ASF GitHub Bot commented on MNG-7713: - cstamas merged PR #1020: URL: https://github.com/apache/maven/pull/1020 > Drop option legacy-local-repository > --- > > Key: MNG-7713 > URL: https://issues.apache.org/jira/browse/MNG-7713 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1 > > > The option offers several ways to make Maven 3 use Maven 2 legacy local > repository, the option help text states: "Use Maven 2 Legacy Local Repository > behaviour, ie no use of _remote.repositories. Can also be activated by using > -Dmaven.legacyLocalRepo=true". > Let's drop this option, as there is no need to make Maven 3.9 support Maven 2 > local repository, that is (should be) transient anyway. Also, if really > needed, there IS a resolver configuration that offers somewhat similar > semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility > anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[
https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694979#comment-17694979
]
ASF GitHub Bot commented on MNG-7713:
-
cstamas commented on code in PR #1020:
URL: https://github.com/apache/maven/pull/1020#discussion_r1121464442
##
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java:
##
@@ -443,12 +443,20 @@ public interface MavenExecutionRequest {
/**
* @since 3.1
+ * @deprecated Since 3.9 there is no direct Maven2 interop offered at LRM
level. See
+ * https://maven.apache.org/resolver/configuration.html";>Resolver
Configuration page option
+ * {@code aether.artifactResolver.simpleLrmInterop} that provides similar
semantics.
*/
+@Deprecated
boolean isUseLegacyLocalRepository();
/**
* @since 3.1
+ * @deprecated Since 3.9 there is no direct Maven2 interop offered at LRM
level. See
+ * https://maven.apache.org/resolver/configuration.html";>Resolver
Configuration page option
+ * {@code aether.artifactResolver.simpleLrmInterop} that provides similar
semantics.
*/
+@Deprecated
MavenExecutionRequest setUseLegacyLocalRepository(boolean
useLegacyLocalRepository);
Review Comment:
fixed
> Drop option legacy-local-repository
> ---
>
> Key: MNG-7713
> URL: https://issues.apache.org/jira/browse/MNG-7713
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> The option offers several ways to make Maven 3 use Maven 2 legacy local
> repository, the option help text states: "Use Maven 2 Legacy Local Repository
> behaviour, ie no use of _remote.repositories. Can also be activated by using
> -Dmaven.legacyLocalRepo=true".
> Let's drop this option, as there is no need to make Maven 3.9 support Maven 2
> local repository, that is (should be) transient anyway. Also, if really
> needed, there IS a resolver configuration that offers somewhat similar
> semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility
> anymore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[
https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694975#comment-17694975
]
ASF GitHub Bot commented on MNG-7713:
-
michael-o commented on code in PR #1020:
URL: https://github.com/apache/maven/pull/1020#discussion_r1121456848
##
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java:
##
@@ -443,12 +443,20 @@ public interface MavenExecutionRequest {
/**
* @since 3.1
+ * @deprecated Since 3.9 there is no direct Maven2 interop offered at LRM
level. See
+ * https://maven.apache.org/resolver/configuration.html";>Resolver
Configuration page option
+ * {@code aether.artifactResolver.simpleLrmInterop} that provides similar
semantics.
*/
+@Deprecated
boolean isUseLegacyLocalRepository();
/**
* @since 3.1
+ * @deprecated Since 3.9 there is no direct Maven2 interop offered at LRM
level. See
+ * https://maven.apache.org/resolver/configuration.html";>Resolver
Configuration page option
+ * {@code aether.artifactResolver.simpleLrmInterop} that provides similar
semantics.
*/
+@Deprecated
MavenExecutionRequest setUseLegacyLocalRepository(boolean
useLegacyLocalRepository);
Review Comment:
Those commens should say that those are noop or *always* `false`
> Drop option legacy-local-repository
> ---
>
> Key: MNG-7713
> URL: https://issues.apache.org/jira/browse/MNG-7713
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> The option offers several ways to make Maven 3 use Maven 2 legacy local
> repository, the option help text states: "Use Maven 2 Legacy Local Repository
> behaviour, ie no use of _remote.repositories. Can also be activated by using
> -Dmaven.legacyLocalRepo=true".
> Let's drop this option, as there is no need to make Maven 3.9 support Maven 2
> local repository, that is (should be) transient anyway. Also, if really
> needed, there IS a resolver configuration that offers somewhat similar
> semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility
> anymore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[ https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694965#comment-17694965 ] ASF GitHub Bot commented on MNG-7713: - cstamas opened a new pull request, #1020: URL: https://github.com/apache/maven/pull/1020 There is really no need for it, and there is a resolver option if really must (but really should not, local repo is and should be considered as transient). --- https://issues.apache.org/jira/browse/MNG-7713 > Drop option legacy-local-repository > --- > > Key: MNG-7713 > URL: https://issues.apache.org/jira/browse/MNG-7713 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1 > > > The option offers several ways to make Maven 3 use Maven 2 legacy local > repository, the option help text states: "Use Maven 2 Legacy Local Repository > behaviour, ie no use of _remote.repositories. Can also be activated by using > -Dmaven.legacyLocalRepo=true". > Let's drop this option, as there is no need to make Maven 3.9 support Maven 2 > local repository, that is (should be) transient anyway. Also, if really > needed, there IS a resolver configuration that offers somewhat similar > semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility > anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[
https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694731#comment-17694731
]
ASF GitHub Bot commented on MNG-7713:
-
cstamas commented on code in PR #1018:
URL: https://github.com/apache/maven/pull/1018#discussion_r1120742965
##
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java:
##
@@ -256,8 +256,7 @@ public CLIManager() {
.build());
options.addOption(Option.builder(LEGACY_LOCAL_REPOSITORY)
.longOpt("legacy-local-repository")
-.desc(
-"Use Maven 2 Legacy Local Repository behaviour, ie no
use of _remote.repositories. Can also be activated by using
-Dmaven.legacyLocalRepo=true")
+.desc("Ineffective, only kept for backward compatibility.")
Review Comment:
Agreed, i was drawn by other left defunct options...
> Drop option legacy-local-repository
> ---
>
> Key: MNG-7713
> URL: https://issues.apache.org/jira/browse/MNG-7713
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1-candidate
>
>
> The option offers several ways to make Maven 3 use Maven 2 legacy local
> repository, the option help text states: "Use Maven 2 Legacy Local Repository
> behaviour, ie no use of _remote.repositories. Can also be activated by using
> -Dmaven.legacyLocalRepo=true".
> Let's drop this option, as there is no need to make Maven 3.9 support Maven 2
> local repository, that is (should be) transient anyway. Also, if really
> needed, there IS a resolver configuration that offers somewhat similar
> semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility
> anymore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[
https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694708#comment-17694708
]
ASF GitHub Bot commented on MNG-7713:
-
slawekjaranowski commented on code in PR #1018:
URL: https://github.com/apache/maven/pull/1018#discussion_r1120679215
##
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java:
##
@@ -256,8 +256,7 @@ public CLIManager() {
.build());
options.addOption(Option.builder(LEGACY_LOCAL_REPOSITORY)
.longOpt("legacy-local-repository")
-.desc(
-"Use Maven 2 Legacy Local Repository behaviour, ie no
use of _remote.repositories. Can also be activated by using
-Dmaven.legacyLocalRepo=true")
+.desc("Ineffective, only kept for backward compatibility.")
Review Comment:
If such option will have no effect - why we want to preserve it ...
If user use it - it will not works as user expect - so we will have silently
different behavior that user think
For me will be better to drop at all - it will more clear for user and do
not make confusing
> Drop option legacy-local-repository
> ---
>
> Key: MNG-7713
> URL: https://issues.apache.org/jira/browse/MNG-7713
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1-candidate
>
>
> The option offers several ways to make Maven 3 use Maven 2 legacy local
> repository, the option help text states: "Use Maven 2 Legacy Local Repository
> behaviour, ie no use of _remote.repositories. Can also be activated by using
> -Dmaven.legacyLocalRepo=true".
> Let's drop this option, as there is no need to make Maven 3.9 support Maven 2
> local repository, that is (should be) transient anyway. Also, if really
> needed, there IS a resolver configuration that offers somewhat similar
> semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility
> anymore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7713) Drop option legacy-local-repository
[ https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694070#comment-17694070 ] Michael Osipov commented on MNG-7713: - This is wrong is a patch version. Drop in 4 and warn in 3.9. > Drop option legacy-local-repository > --- > > Key: MNG-7713 > URL: https://issues.apache.org/jira/browse/MNG-7713 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.1-candidate > > > The option offers several ways to make Maven 3 use Maven 2 legacy local > repository, the option help text states: "Use Maven 2 Legacy Local Repository > behaviour, ie no use of _remote.repositories. Can also be activated by using > -Dmaven.legacyLocalRepo=true". > Let's drop this option, as there is no need to make Maven 3.9 support Maven 2 > local repository, that is (should be) transient anyway. Also, if really > needed, there IS a resolver configuration that offers somewhat similar > semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility > anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
