[jira] [Commented] (MNG-7750) Interpolated properties in originalModel in an active profile.
[ https://issues.apache.org/jira/browse/MNG-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711296#comment-17711296 ] Tamas Cservenak commented on MNG-7750: -- Many thanks for PRs! > Interpolated properties in originalModel in an active profile. > -- > > Key: MNG-7750 > URL: https://issues.apache.org/jira/browse/MNG-7750 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.1 >Reporter: Niels Basjes >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.2, 4.0.0-alpha-6, 4.0.0 > > > The originalModel in a MavenProject instance has some properties interpolated > if they are in an active profile. The same properties are NOT interpolated if > they are in an INactive profile or if they are outside any profile. > This problem was first reported in > https://issues.apache.org/jira/browse/MSHADE-440 but turns out to have its > root cause in the Maven core. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7750) Interpolated properties in originalModel in an active profile.
[ https://issues.apache.org/jira/browse/MNG-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711294#comment-17711294 ] ASF GitHub Bot commented on MNG-7750: - cstamas merged PR #1076: URL: https://github.com/apache/maven/pull/1076 > Interpolated properties in originalModel in an active profile. > -- > > Key: MNG-7750 > URL: https://issues.apache.org/jira/browse/MNG-7750 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.1 >Reporter: Niels Basjes >Priority: Major > Fix For: 3.9.2, 4.0.0-alpha-6, 4.0.0 > > > The originalModel in a MavenProject instance has some properties interpolated > if they are in an active profile. The same properties are NOT interpolated if > they are in an INactive profile or if they are outside any profile. > This problem was first reported in > https://issues.apache.org/jira/browse/MSHADE-440 but turns out to have its > root cause in the Maven core. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7750) Interpolated properties in originalModel in an active profile.
[ https://issues.apache.org/jira/browse/MNG-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711295#comment-17711295 ] ASF GitHub Bot commented on MNG-7750: - cstamas merged PR #1075: URL: https://github.com/apache/maven/pull/1075 > Interpolated properties in originalModel in an active profile. > -- > > Key: MNG-7750 > URL: https://issues.apache.org/jira/browse/MNG-7750 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.1 >Reporter: Niels Basjes >Priority: Major > Fix For: 3.9.2, 4.0.0-alpha-6, 4.0.0 > > > The originalModel in a MavenProject instance has some properties interpolated > if they are in an active profile. The same properties are NOT interpolated if > they are in an INactive profile or if they are outside any profile. > This problem was first reported in > https://issues.apache.org/jira/browse/MSHADE-440 but turns out to have its > root cause in the Maven core. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7750) Interpolated properties in originalModel in an active profile.
[ https://issues.apache.org/jira/browse/MNG-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705124#comment-17705124 ] ASF GitHub Bot commented on MNG-7750: - nielsbasjes commented on PR #1076: URL: https://github.com/apache/maven/pull/1076#issuecomment-1484210393 FYI: @rmannibucau @slachiewicz Just to be sure the maven 4.x does not have the same problem. > Interpolated properties in originalModel in an active profile. > -- > > Key: MNG-7750 > URL: https://issues.apache.org/jira/browse/MNG-7750 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.1 >Reporter: Niels Basjes >Priority: Major > > The originalModel in a MavenProject instance has some properties interpolated > if they are in an active profile. The same properties are NOT interpolated if > they are in an INactive profile or if they are outside any profile. > This problem was first reported in > https://issues.apache.org/jira/browse/MSHADE-440 but turns out to have its > root cause in the Maven core. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7750) Interpolated properties in originalModel in an active profile.
[ https://issues.apache.org/jira/browse/MNG-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705123#comment-17705123 ] ASF GitHub Bot commented on MNG-7750: - nielsbasjes opened a new pull request, #1076: URL: https://github.com/apache/maven/pull/1076 This is the port of https://github.com/apache/maven/pull/1075 to the master branch. The good thing is that this is ONLY the tests because the maven 4 does not have the problem of MNG-7750. A few small changes in the tests were needed to handle the internal differences between maven 3.x and maven 4.x. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) > Interpolated properties in originalModel in an active profile. > -- > > Key: MNG-7750 > URL: https://issues.apache.org/jira/browse/MNG-7750 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.1 >Reporter: Niels Basjes >Priority: Major > > The originalModel in a MavenProject instance has some properties interpolated > if they are in an active profile. The same properties are NOT interpolated if > they are in an INactive profile or if they are outside any profile. > This problem was first reported in > https://issues.apache.org/jira/browse/MSHADE-440 but turns out to have its > root cause in the Maven core. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7750) Interpolated properties in originalModel in an active profile.
[ https://issues.apache.org/jira/browse/MNG-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705097#comment-17705097 ] ASF GitHub Bot commented on MNG-7750: - nielsbasjes commented on PR #1075: URL: https://github.com/apache/maven/pull/1075#issuecomment-1484144621 My suspicion was correct. A plugin from a profile was being referenced (not cloned) from the `originalModel` fully if it was not present at the global scale yet, and only the `execution` was referenced (not cloned) if it was and only the execution needed to be available. Later the interpolation would then change the one in the `originalModel` also because it was simply referenced. Close inspection of the code showed the exact same problem for the `reporting plugins` and each `reportSet`. This affects only the plugins in the active profiles as they are the only ones for which this link is created. > Interpolated properties in originalModel in an active profile. > -- > > Key: MNG-7750 > URL: https://issues.apache.org/jira/browse/MNG-7750 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.1 >Reporter: Niels Basjes >Priority: Major > > The originalModel in a MavenProject instance has some properties interpolated > if they are in an active profile. The same properties are NOT interpolated if > they are in an INactive profile or if they are outside any profile. > This problem was first reported in > https://issues.apache.org/jira/browse/MSHADE-440 but turns out to have its > root cause in the Maven core. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7750) Interpolated properties in originalModel in an active profile.
[ https://issues.apache.org/jira/browse/MNG-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705077#comment-17705077 ] ASF GitHub Bot commented on MNG-7750: - nielsbasjes commented on PR #1075: URL: https://github.com/apache/maven/pull/1075#issuecomment-1484089609 I **suspect** I have found the reason this happens. A model aggregates all executions for a plugin together in a list of executions for a single instance of that plugin. There these executions are linked (not cloned) from the source. Then when the interpolation happens the executions in the model are interpolated which are the same instances as are in the original. > Interpolated properties in originalModel in an active profile. > -- > > Key: MNG-7750 > URL: https://issues.apache.org/jira/browse/MNG-7750 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.1 >Reporter: Niels Basjes >Priority: Major > > The originalModel in a MavenProject instance has some properties interpolated > if they are in an active profile. The same properties are NOT interpolated if > they are in an INactive profile or if they are outside any profile. > This problem was first reported in > https://issues.apache.org/jira/browse/MSHADE-440 but turns out to have its > root cause in the Maven core. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7750) Interpolated properties in originalModel in an active profile.
[
https://issues.apache.org/jira/browse/MNG-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705053#comment-17705053
]
ASF GitHub Bot commented on MNG-7750:
-
nielsbasjes commented on PR #1075:
URL: https://github.com/apache/maven/pull/1075#issuecomment-1484053918
Ubuntu build fails with
```
Error:PomConstructionTest.testProfileInterpolation:173 expected:<...side
active profile [${project.basedir}].> but was:<...side active profile
[/home/runner/work/maven/maven/maven-core/src/test/resources-project-builder/profile-interpolation].>
```
macOS build fails with
```
Error:PomConstructionTest.testProfileInterpolation:173 expected:<...side
active profile [${project.basedir}].> but was:<...side active profile
[/Users/runner/work/maven/maven/maven-core/src/test/resources-project-builder/profile-interpolation].>
```
Windows build fails with
```
Error:PomConstructionTest.testProfileInterpolation:173 expected:<...side
active profile [${project.basedir}].> but was:<...side active profile
[D:\a\maven\maven\maven-core\src\test\resources-project-builder\profile-interpolation].>
```
> Interpolated properties in originalModel in an active profile.
> --
>
> Key: MNG-7750
> URL: https://issues.apache.org/jira/browse/MNG-7750
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.1
>Reporter: Niels Basjes
>Priority: Major
>
> The originalModel in a MavenProject instance has some properties interpolated
> if they are in an active profile. The same properties are NOT interpolated if
> they are in an INactive profile or if they are outside any profile.
> This problem was first reported in
> https://issues.apache.org/jira/browse/MSHADE-440 but turns out to have its
> root cause in the Maven core.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7750) Interpolated properties in originalModel in an active profile.
[
https://issues.apache.org/jira/browse/MNG-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705052#comment-17705052
]
ASF GitHub Bot commented on MNG-7750:
-
nielsbasjes opened a new pull request, #1075:
URL: https://github.com/apache/maven/pull/1075
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [x] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
This is ONLY the reproduction of the problem I found.
If you disable the `activeProfile` (in buildPom and remove the assert) then
all checks pass.
If you enable this profile (provided code) then in several places the
`${project.basedir}` has been interpolated and shows the path of the build and
the assertions fail the build.
> Interpolated properties in originalModel in an active profile.
> --
>
> Key: MNG-7750
> URL: https://issues.apache.org/jira/browse/MNG-7750
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.1
>Reporter: Niels Basjes
>Priority: Major
>
> The originalModel in a MavenProject instance has some properties interpolated
> if they are in an active profile. The same properties are NOT interpolated if
> they are in an INactive profile or if they are outside any profile.
> This problem was first reported in
> https://issues.apache.org/jira/browse/MSHADE-440 but turns out to have its
> root cause in the Maven core.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
