[jira] [Commented] (MNG-7982) Make classic transitive depMgr the default, provide fallback to classic and transitive
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799031#comment-17799031 ] ASF GitHub Bot commented on MNG-7982: - cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864547699 ITs look good. And thinking more about this, this should be maybe just a boolean flag? `classic(transitive)`? As I would leave out completely the "transitive" and the "default" as they do introduce unwanted behaviour for sure (fail ITs), rendering existing working build possibly broken. > Make classic transitive depMgr the default, provide fallback to classic and > transitive > -- > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > As it turned out, Maven3 since existence of Resolver used the "classic" > depMgr that works like Maven2 (does not apply depMgt). Maven4 may be point to > apply "transitive" depMgr as default, while offer fallback to classic? > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7982) Make classic transitive depMgr the default, provide fallback to classic and transitive
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799010#comment-17799010 ] ASF GitHub Bot commented on MNG-7982: - cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864470425 I see no difference to what happens if you use two libs that declare different version on some artifact, really. And depMgt (_unlike BOM imports_) let it all to you to sort it out in "maven way". > Make classic transitive depMgr the default, provide fallback to classic and > transitive > -- > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > As it turned out, Maven3 since existence of Resolver used the "classic" > depMgr that works like Maven2 (does not apply depMgt). Maven4 may be point to > apply "transitive" depMgr as default, while offer fallback to classic? > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7982) Make classic transitive depMgr the default, provide fallback to classic and transitive
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799009#comment-17799009 ] ASF GitHub Bot commented on MNG-7982: - rmannibucau commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864468358 @cstamas right, now consider 2 lib authors for your project (3rd maven build to make it clear) and also maven 3 consumers (let's ignore 2, agree), it becomes a mess for us :( > Make classic transitive depMgr the default, provide fallback to classic and > transitive > -- > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > As it turned out, Maven3 since existence of Resolver used the "classic" > depMgr that works like Maven2 (does not apply depMgt). Maven4 may be point to > apply "transitive" depMgr as default, while offer fallback to classic? > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7982) Make classic transitive depMgr the default, provide fallback to classic and transitive
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799006#comment-17799006 ] ASF GitHub Bot commented on MNG-7982: - cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864465206 IMO, this change > Make classic transitive depMgr the default, provide fallback to classic and > transitive > -- > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > As it turned out, Maven3 since existence of Resolver used the "classic" > depMgr that works like Maven2 (does not apply depMgt). Maven4 may be point to > apply "transitive" depMgr as default, while offer fallback to classic? > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7982) Make classic transitive depMgr the default, provide fallback to classic and transitive
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799004#comment-17799004 ] ASF GitHub Bot commented on MNG-7982: - rmannibucau commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864461670 @cstamas I understand that and ultimately I hope we reach your proposal I do like, but I don't want to be at the cost of making builds more complex and user most lost, this is how I end on the "strict" mode for depMgt in maven 4 but I'm not 100% happy with that so any idea welcomed ;). > Make classic transitive depMgr the default, provide fallback to classic and > transitive > -- > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > As it turned out, Maven3 since existence of Resolver used the "classic" > depMgr that works like Maven2 (does not apply depMgt). Maven4 may be point to > apply "transitive" depMgr as default, while offer fallback to classic? > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7982) Make classic transitive depMgr the default, provide fallback to classic and transitive
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799003#comment-17799003 ] ASF GitHub Bot commented on MNG-7982: - cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864458580 And as regarding "blowing", lets see what ITs has to say. Also we could maybe add IT for https://issues.apache.org/jira/browse/MRESOLVER-235 > Make classic transitive depMgr the default, provide fallback to classic and > transitive > -- > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > As it turned out, Maven3 since existence of Resolver used the "classic" > depMgr that works like Maven2 (does not apply depMgt). Maven4 may be point to > apply "transitive" depMgr as default, while offer fallback to classic? > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7982) Make classic transitive depMgr the default, provide fallback to classic and transitive
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799002#comment-17799002 ] ASF GitHub Bot commented on MNG-7982: - cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864456808 This setting cannot be per dependency, at least resolver does not support that. The depMgr is set per session. And what current PR changes is really only this: are depMgt sections obeyed only 2 level deep or to the end of pit. The "2 level depth" comes from Maven2 times, and was artificial limit just to make Maven3 (resolver in it) work like Maven2 did. Unsure why Maven4 would need to work in this respect as Maven2 did. > Make classic transitive depMgr the default, provide fallback to classic and > transitive > -- > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > As it turned out, Maven3 since existence of Resolver used the "classic" > depMgr that works like Maven2 (does not apply depMgt). Maven4 may be point to > apply "transitive" depMgr as default, while offer fallback to classic? > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7982) Make classic transitive depMgr the default, provide fallback to classic and transitive
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799000#comment-17799000 ] ASF GitHub Bot commented on MNG-7982: - rmannibucau commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864449457 What I worry about it is the fact we are moving the current issues a step further but I don't understand yet how it does fix anything, this kind of configuration looks per dependency, so while I fully agree we can make it global or per version, it will keep blowing up as soon as you have > 2 dep there no? Don't get me wrong, I think the transitive feature is rather a good thing if we can instantiate it without more side effects than we have today but alone it looks like mixing behaviors which all have pitfalls and therefore just make it more complex. Ultimately it can mean we become stricter on the depMgt and forbid not resolved conflicts (a bit like what enforcer plugin enables), this way the resolution of a built project (not transitive deps alone) is always deterministic at a little user cost. Still thinking out loud to try to get this feature onboard without realizing in some months we are back where we were in terms of issues with new ones due to the behavior change and "resolution merge" logic we would need from consumed poms. > Make classic transitive depMgr the default, provide fallback to classic and > transitive > -- > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > As it turned out, Maven3 since existence of Resolver used the "classic" > depMgr that works like Maven2 (does not apply depMgt). Maven4 may be point to > apply "transitive" depMgr as default, while offer fallback to classic? > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7982) Make classic transitive depMgr the default, provide fallback to classic and transitive
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798998#comment-17798998 ] ASF GitHub Bot commented on MNG-7982: - gnodet commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864442381 > Hi @cstamas , what is the plan to identify mvn 4 consumed artifacts to switch the impl, using the mvn4 specific pom metadata file? in current state it breaks probably too easily IMHO and I didn't find how we enable this behavior in the produced pom for the consumed artifact - I don't think it is good to be a config prop, it should belong to the pom only to avoid a global toggle which will work only under a closed ecosystem. The consumer has no knowledge. I also kinda saw that as a problem... I wonder if this should be automatically toggled by the modelVersion of the root project: if using a 4.1.0 model, then use the new depMgr, if using 4.0.0 model, use the Maven 3 compatible one This piece can be easily detected very early at boot time and could be used to configure the resolver. > Make classic transitive depMgr the default, provide fallback to classic and > transitive > -- > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > As it turned out, Maven3 since existence of Resolver used the "classic" > depMgr that works like Maven2 (does not apply depMgt). Maven4 may be point to > apply "transitive" depMgr as default, while offer fallback to classic? > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7982) Make classic transitive depMgr the default, provide fallback to classic and transitive
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798993#comment-17798993 ] ASF GitHub Bot commented on MNG-7982: - cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864436787 @rmannibucau this PR is draft on purpose. Actually, I'd say "consider all resolver related Maven PRs draft" I do, as am just throwing ideas or missing Maven features, to improve use of (so far unused or newly made) Resolver features in Maven, but HOW are they gonna be consumed/integrated into Maven I'd leave to @gnodet and probably you :smile: This PR would fix for example these issues, reported by many, while providing "escape hatch" to go back to "classic" if needed: https://issues.apache.org/jira/browse/MRESOLVER-235 https://issues.apache.org/jira/browse/MNG-7003 > Make classic transitive depMgr the default, provide fallback to classic and > transitive > -- > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > As it turned out, Maven3 since existence of Resolver used the "classic" > depMgr that works like Maven2 (does not apply depMgt). Maven4 may be point to > apply "transitive" depMgr as default, while offer fallback to classic? > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
