[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (Jira)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638281#comment-17638281
 ] 

Alex O'Ree commented on MPDF-81:


> Given your experience on new configuration that would be required to enhance 
> pdf results, do you have proposals on model evolution?

i can get you a listing of the things i've added some what recently...

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>Priority: Major
>  Labels: intern
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (Jira)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638279#comment-17638279
 ] 

Alex O'Ree commented on MPDF-81:


is it possible to override the footer text by specifying a property file? 
doxia-fo.properties in the default package. Although i'm not clear where to put 
it, it might be an option

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>Priority: Major
>  Labels: intern
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255482#comment-16255482
 ] 

Hervé Boutemy commented on MPDF-81:
---

I continued my work on the topic: I did DOXIA-556, to get 
http://maven.apache.org/doxia/doxia-archives/doxia-LATEST/doxia-core/document.html

now I think that the new configuration should just go into new fields in 
Document descriptor, ie pdf.xml: this descriptor did not evolve for years, but 
that's just because there was not so much work on pdf

we just need to define what field we want to put in this descriptor to have a 
clean structure
Currently, fields are grouped in 3 groups: meta, toc and cover

Given your experience on new configuration that would be required to enhance 
pdf results, do you have proposals on model evolution?

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248693#comment-16248693
 ] 

Alex O'Ree commented on MPDF-81:


push it if you want, i'm tied up working on other things currently

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Robert Scholte (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248675#comment-16248675
 ] 

Robert Scholte commented on MPDF-81:


Just a note: the maven-site-plugin should be released soon, since there are 
some Java9 issues in it. They've already been fixed, it's only waiting for a 
released version of Doxia. This issue seems to slow down the release, so maybe 
this issue should be moved to a next release. 
To me having plugins working with Java 9 is more important to me right now.
Any problem pushing this to Doxia 1.8.1?

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239469#comment-16239469
 ] 

Hervé Boutemy commented on MPDF-81:
---

to better work together, I migrated Doxia and Doxia Sitetools to git: see 
http://maven.apache.org/doxia/source-repository.html
you can now easily create GitHub pull requests.
I expect this will permit little focused PRs (easier than patches attached to 
Jira): DOXIA-562 monolithic patch for example requires multiple PRs

notice maven-pdf-plugin is not yet migrated to git: this won't happen before a 
few weeks, because we must split 1 svn repo to more than 40 git repositories, 
with Jenkins associated configuration. See 
https://cwiki.apache.org/confluence/display/MAVEN/Git+Migration#GitMigration-Migratinganaggregatortreeintoacollectionofgitrepos
 if you're interested in details

on the reflection trickery: I understand that adding a bunch of setter in 
FoAggregateSink is not welcome. Reflection on an object that comes from 
maven-pdf-plugin is not an option either.
What can be done IMHO is to create a FoAggregateContext class in Doxia FO 
module: then FO AggregateSink can use it as wanted, and maven-pdf-plugin can 
populate it also.

We can initialize this FoAggregateContext structure with the footerText 
attribute.
WDYT?




> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223464#comment-16223464
 ] 

Alex O'Ree commented on MPDF-81:


well if you want the change to be exactly like it is on my fork which renders 
the header like this:

||Chapter Title||User defined string||Page number||

and the footer like this

||empty||User defined content (was the copyright part)||empty||

then change set then includes
* changes to the xslt which is one of the doxia repos
* pdf plugin changes to enable user definition of the centered parts
* a way to pass that information from the pdf plugin to DocumentRendererContext
* a way to access that information from FoAggregateSink

the one patch i added attached solves the last problem via reflection but a 
better solution would be to add a bunch of setters in FoAggregateSink. That 
kind of defeats the purpose of the context object but will enable this setup 
without the dirty reflection trickery. Does that sound better 
[~roller_hboutemy]?

For [DOXIA-562] i already have a functioning solution so i know it is possible



> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215121#comment-16215121
 ] 

Hervé Boutemy commented on MPDF-81:
---

[~spyhunter99] Doxia and Doxia Sitetools just switched from svn to Git, with 
GitHub integration (ie Apache GitBox): see DOXIA-563 and DOXIASITETOOLS-180

do you want to try to do the footer enhancement, before doing more complex 
DOXIA-562?
do you want me to do this MPDF-81/DOXIA-555/DOXIASITETOOLS as a sample?

I'd like to do a release in a week or 2, then we just need to know how to work 
together on what's feasible: and I'm confident that this copyright footer can 
be done (I don't know yet about DOXIA-562)

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204606#comment-16204606
 ] 

Hervé Boutemy commented on MPDF-81:
---

1. implement DOXIA-555 as adding a new FoAggregateSink.setFooterText(String) 
method to override the default value from getFooterText()
2. create a DOXIASITETOOLS issue for doxia-doc-renderer FoPdfRenderer to get a 
parameter from DocumentRendererContext and inject it in FoAggregateSink if 
defined (like curently generateTOC)
3. add a configuration in PdfMojo

doing this, you don't create any unwanted dependency but create configuration 
endpoints from the Mojo to the Doc Renderer to the FoAggregateSink

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204601#comment-16204601
 ] 

Alex O'Ree commented on MPDF-81:


The problem isn't the diagram.

>From the doxia-fo module, i need a reference to DocumentRendererContext. That 
>class is in doxia-sitetools.

Doxia-site-tools has a pom dependency on doxia-fo
Doxia-fo needs a dependency to doxia-site-tools

see where i'm going with this? These modules need to be restructured, 
condensed, or combined OR, (and perhaps i'm just not smart enough) use some 
kind of plexus magic to inject configuration settings that are available at 
DocumentRendererContext into FoAggregateSink. That only solves part of the 
problem as there are several (minor) api changes. The only thing that makes 
sense is to merge the doxia-fo module into doxia-site-tools


> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204440#comment-16204440
 ] 

Hervé Boutemy commented on MPDF-81:
---

the high-level answer is http://maven.apache.org/doxia/overview.html : it's a 
structuration of concerns in layers
what is not represented in this schema is that maven-site-plugin uses Doxia 
Sitetools Site Renderer, while maven-pdf-plugin uses Doxia Sitetools Doc 
Renderer (Doc in a pdf context is equivalent to Site in a website context)

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204420#comment-16204420
 ] 

Alex O'Ree commented on MPDF-81:


i'm working on it. unfortunately the changes made when split up create 
dependency spaghetti between doxia and doxia site tools. I'm not sure why all 
the PDF/FO related stuff ended up two different repos. 

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203087#comment-16203087
 ] 

Hervé Boutemy commented on MPDF-81:
---

we have at least a few days, since {{maven-reporting-exec}} vote is on for 72h, 
which is a prerequisite. Then there is the Git migration of Doxia and Doxia 
SItetools (INFRA-15253) which are also prerequisites to code integration here

other people interested in maven-pdf-plugin release (like [~sgarelle]), please 
chime in if you have some strong timing requirements: I think it is worth 
integrating as many changes as possible, checking that what Alex proposes makes 
sense for you
because, of course, new features require to be usable by every user

Alex, please cut your improvements in small parts and tell where to integrate 
the changes from

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
> Attachments: maven-pdf-plugin2.pdf
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202894#comment-16202894
 ] 

Alex O'Ree commented on MPDF-81:


[~roller_hboutemy] cool, i have a bunch of other features that could be rolled 
into the pdf plugin too if you wanted to wait. They also require changes to the 
Doxia FO code.

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199674#comment-16199674
 ] 

Hervé Boutemy commented on MPDF-81:
---

I just had a deeper look at the way to implement this feature, respecting 
natural dependencies, and the result is:
1. implement DOXIA-555 as adding a new 
{{FoAggregateSink.setFooterText(String)}} method to override the default value 
from {{getFooterText()}}
2. create a DOXIASITETOOLS issue for {{doxia-doc-renderer}} {{FoPdfRenderer}} 
to get a parameter from {{DocumentRendererContext}} and inject it in 
FoAggregateSink if defined (like curently {{generateTOC}})
3. add a configuration in {{PdfMojo}}

[~spyhunter99]are you interested in implementing this?
I should release maven-pdf-plugin in a few weeks, now that MPDF-48 is fixed, 
then having this issue fixed at the same time would be nice, isn't it?
looks feasible: the modification is not complex, it just requires coordination 
between 3 components...

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
> Fix For: 1.4
>
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160752#comment-16160752
 ] 

Hervé Boutemy commented on MPDF-81:
---

regarding "Chekstyle findings" on Doxia Sink API, no, don't change: it's a case 
with something like a fluent API, that does not use traditional Java classical 
naming rules

And if you look at Doxia parent pom, you'll find 
{code:xml}RedundantThrows,NewlineAtEndOfFile,ParameterNumber,MethodLength,FileLength,MethodName,InnerAssignment,MagicNumber{code}
 that disables MethodName checks: isn't it detected by your IDE tooling?

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160485#comment-16160485
 ] 

Hervé Boutemy commented on MPDF-81:
---

adding some methods does not break too much: in fact, we don't have choice. 
Let's try and we'll see.
I had a look (I don't know the pdf parts): looks like there is a DocumentModel 
already there to enhance 
http://maven.apache.org/doxia/doxia/doxia-modules/doxia-module-fo/apidocs/index.html
 . Looks a good place to add info, since it won't affect every Sink, and is 
quite natural

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160455#comment-16160455
 ] 

Alex O'Ree commented on MPDF-81:


I'll add the modifying the sink api while requirement modifications in a number 
of different repos and projects and will likely cause compatibility issues

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159890#comment-16159890
 ] 

Alex O'Ree commented on MPDF-81:


the doxia sink api does not adhere to the checkstyle rules for method naming. 
Specifically the end tag underscore naming convention. This is in the API and 
has been for quite a while.

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159865#comment-16159865
 ] 

Hervé Boutemy commented on MPDF-81:
---

bq. doxia plays by different check style rules than the maven plugins.
really? I'm surprised: please explain

bq. grrr. is check style really needed?
Yes, it's a critical helper to keep code style consistent that permit us to 
work together efficiently on code content: learning Maven code conventions at 
home while working on code is a lot more efficient than waiting for a review by 
a committer and human explanations, that eventually lead to hot discussions 
between people. I prefer to have people being hot against Checkstyle instead of 
hot against a committer who tries to explain Maven code style conventions 
(which are written in http://maven.apache.org/developers/conventions/code.html 
if you want to learn them by reading instead of learning them by having 
Checkstyle point to errors)

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159675#comment-16159675
 ] 

Alex O'Ree commented on MPDF-81:


that issue was resolved, PR opened at 
https://github.com/apache/maven-plugins/pull/129

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159674#comment-16159674
 ] 

ASF GitHub Bot commented on MPDF-81:


GitHub user spyhunter99 opened a pull request:

https://github.com/apache/maven-plugins/pull/129

MPDF-81 merging in the needed doxia modules required for copyright ov…

…errides, Add property based overrides for the copyright headers. Most of 
the real changes were in FoAggregatedSink

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/spyhunter99/maven-plugins feature/MPDF-81

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-plugins/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #129


commit 27c221e8cece7a5b8574a0aeb593efbd02547ccf
Author: Alex O'Ree 
Date:   2017-09-09T02:14:14Z

MPDF-81 merging in the needed doxia modules required for copyright 
overrides, Add property based overrides for the copyright headers. Most of the 
real changes were in FoAggregatedSink




> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159658#comment-16159658
 ] 

Alex O'Ree commented on MPDF-81:


part of the difficult here is that doxia plays by different check style rules 
than the maven plugins. grrr. is check style really needed?

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159603#comment-16159603
 ] 

Alex O'Ree commented on MPDF-81:


sure thing

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[JIRA]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157966#comment-16157966
 ] 

Hervé Boutemy commented on MPDF-81:
---

I'll work with you on this: once we're successful for one issue and we're 
confident Maven conventions are known, I'll work with the team to have you 
committer so you can be autonomous to work on other issues

I had a look on your GitHub repo: it's not forked from 
https://github.com/apache/maven-plugins , then it's not easy to define what to 
merge

can you either create a patch to attach to Jira or prepare a GitHub PR for 
https://github.com/apache/maven-plugins , please?

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157880#comment-16157880
 ] 

Alex O'Ree commented on MPDF-81:


ASF committer here, who can I lobby to get write access to this repo?

FYI, I've forked this plugin and merged the needed doxia code into a single git 
repo and have charged forward with this and have published the changes to 
central. For anyone else that's interested and for consideration to merging 
back into the asf baseline

https://github.com/spyhunter99/maven-pdf-plugin

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027606#comment-16027606
 ] 

Alex O'Ree commented on MPDF-81:


if my patch for 555 is merged, then all that's needed for the maven pdf plugin 
is to revise the pom versions

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969989#comment-15969989
 ] 

Alex O'Ree commented on MPDF-81:


https://issues.apache.org/jira/browse/DOXIA-555

correction, it's within the doxia-fo resource bundle. Doesn't look like it's 
overridable via properties

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969965#comment-15969965
 ] 

Alex O'Ree commented on MPDF-81:


Found it, it's in the default site template
https://github.com/apache/maven-doxia-sitetools/blob/trunk/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm

looks like it can be overridden with $decoration.body.footer, now to find a way 
to pass that from the pdf plugin configuration to doxia...

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969964#comment-15969964
 ] 

Alex O'Ree commented on MPDF-81:


Ahh. I had the pdf plugin source, but didn't think to pull in the doxia stuff. 
Ookie dookie. thanks

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969961#comment-15969961
 ] 

Michael Osipov commented on MPDF-81:


Start with the plugin source code itself and then it will lead you 
[here|https://github.com/apache/maven-doxia-sitetools/blob/trunk/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/pdf/fo/FoPdfRenderer.java].

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Alex O'Ree (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969950#comment-15969950
 ] 

Alex O'Ree commented on MPDF-81:


I'm more than willing to fix it, but I have no clue where the xslt is loaded or 
what file the content is in. 

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MPDF-81) Override the copyright footer

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969945#comment-15969945
 ] 

Michael Osipov commented on MPDF-81:


Patches are welcome.

> Override the copyright footer
> -
>
> Key: MPDF-81
> URL: https://issues.apache.org/jira/browse/MPDF-81
> Project: Maven PDF Plugin
>  Issue Type: New Feature
>Affects Versions: 1.3
>Reporter: Alex O'Ree
>
> As of right now, it doesn't look possible to override the content of the 
> footer which is on all non-title page pages. It currently reads (c) year - 
> organization All rights reserved.
> I don't see anywhere in the code where this is defined or in any of the 
> resource files. It is in the generated fo files but it's not obvious where 
> the xslt is.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)