[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642963#comment-17642963 ] ASF GitHub Bot commented on MPLUGIN-447: slawekjaranowski commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336365886 > > @kwin look for duplicate License headers > > can help: > > ``` > > git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1" > > ``` > > Thanks for the hint. Is there a configuration in spotless to remove those duplicates or do you have a script for that available as well? Seems that almost all files have duplicate license headers after the automated formatting… In IDE I copy old header and use options replace all. > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642904#comment-17642904 ] ASF GitHub Bot commented on MPLUGIN-447: kwin commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336243709 > @kwin look for duplicate License headers > > can help: > > ``` > git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1" > ``` Thanks for the hint. Is there a configuration in spotless to remove those duplicates or do you have a script for that available as well? Seems that almost all files have duplicate license headers after the automated formatting… > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642903#comment-17642903 ] ASF GitHub Bot commented on MPLUGIN-447: slawekjaranowski commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336224816 @kwin look for duplicate License headers can help: ``` git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1" ``` > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642900#comment-17642900 ] ASF GitHub Bot commented on MPLUGIN-447: kwin commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336222545 > Why does upgrading the parent POM reformat pretty much every file? That seems like a very different thing. That is because the code format conventions have changed. There was a mailing list discussion around that. > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642855#comment-17642855 ] ASF GitHub Bot commented on MPLUGIN-447: elharo commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336186154 Why does upgrading the parent POM reformat pretty much every file? That seems like a very different thing. > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641185#comment-17641185 ] ASF GitHub Bot commented on MPLUGIN-447: kwin commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1331871245 > Please fix checkstyle configuration like in: [apache/maven-dependency-plugin#266](https://github.com/apache/maven-dependency-plugin/pull/266) and check site reports Done now. > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641161#comment-17641161 ] ASF GitHub Bot commented on MPLUGIN-447: slawekjaranowski commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1331820737 Please fix checkstyle configuration like in: https://github.com/apache/maven-dependency-plugin/pull/266 and check site reports > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
