[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare when using svn
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545749#comment-17545749
]
Herve Boutemy commented on MRELEASE-1072:
-
[~sleberrigaud] the issue :)
because I need feedback to make sure the new feature make sense and deserves
the new maintenance
I want to start the vote this WE, with this issue integrated or not
> scm.tag removed for next snapshot during prepare when using svn
> ---
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare when using svn
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545336#comment-17545336
]
Samuel Le Berrigaud commented on MRELEASE-1072:
---
[~hboutemy] just to be clear, are you postponing the release or the issue?
> scm.tag removed for next snapshot during prepare when using svn
> ---
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare when using svn
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545300#comment-17545300
]
Herve Boutemy commented on MRELEASE-1072:
-
I want to do the release, this issue is the only one remaining, I will postpone
it
> scm.tag removed for next snapshot during prepare when using svn
> ---
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare when using svn
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544638#comment-17544638
]
Herve Boutemy commented on MRELEASE-1072:
-
it's not a bug, it's a new feature: you're trying to do something that was
never done/intended
abstract description is too abstract
please show concrete scm configuration you're wanting to support
> scm.tag removed for next snapshot during prepare when using svn
> ---
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare when using svn
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544565#comment-17544565
]
Michael Osipov commented on MRELEASE-1072:
--
Honestly, I will need some time to understand the problem. I still haven't.
[~hboutemy], did you understand the problem?
> scm.tag removed for next snapshot during prepare when using svn
> ---
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare when using svn
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544164#comment-17544164
]
Konrad Windszus commented on MRELEASE-1072:
---
There is no limitation around using the scm tag element mentioned anywhere
(neither in https://maven.apache.org/pom.html#SCM nor anywhere in
https://maven.apache.org/maven-release/maven-release-plugin/index.html) and it
is helpful for purposes when using both SVN and a GitHub mirror in the SCM
section. In any case just clearing it after the release is unexpected, so
release should either
1. try to keep (reset) the tag or
2. fail with an explicit error
> scm.tag removed for next snapshot during prepare when using svn
> ---
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare when using svn
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544067#comment-17544067
]
Herve Boutemy commented on MRELEASE-1072:
-
I had a look at our old svn repositories: tag is not expected to be set during
normal development
see for example
[https://svn.apache.org/viewvc/maven/shared/trunk/maven-shared-utils/pom.xml?revision=1804471&view=markup]
I feel you are using tag with svn the way it is used for Git: but that is not
expected
> scm.tag removed for next snapshot during prepare when using svn
> ---
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543703#comment-17543703
]
Herve Boutemy commented on MRELEASE-1072:
-
I'm trying to figure out if it is a regression or a missing edge case, to know
if I should study teh MRELEASE-988 big refactoring or if it's really about
adding new code
do you have a real work example visible, so I can look at dry run tests, before
digging into code, please?
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543606#comment-17543606
]
Konrad Windszus commented on MRELEASE-1072:
---
I am not sure this is a regression as using the tag in svn branches is an edge
case. Still it should work, though
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543589#comment-17543589
]
Herve Boutemy commented on MRELEASE-1072:
-
we used that svn release support for years without any problem: did you find in
which release the issue was introduced?
FYI, working on MRELEASE-1079, I found a stupid algorithm mistake in
MRELEASE-988 ({{!Map.containsKey(projectId)}} is not equivalent to
{{Map.get(projectId) == null}}): there may be other little bugs like that
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467661#comment-17467661
]
Konrad Windszus commented on MRELEASE-1072:
---
Test failure in my PR is fixed now. Please check again.
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467581#comment-17467581
]
Michael Osipov commented on MRELEASE-1072:
--
I didn't say {{null}} is wrong. The issue is that the tag is modified for all
providers, not just Subversion. Did you get a chance to take a look at the
failure?
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467566#comment-17467566
]
Konrad Windszus commented on MRELEASE-1072:
---
bq. Shouldn't this be fixed in the translator itself?
According to
https://github.com/apache/maven-release/blob/a9e30c63ea8071234e9a7bb1f433178963ecf93c/maven-release-manager/src/main/java/org/apache/maven/shared/release/scm/ScmTranslator.java#L54
it is totally valid for the translator to return {{null}}.
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467474#comment-17467474
]
Michael Osipov commented on MRELEASE-1072:
--
Shouldn't this be fixed in the translator itself? I am still trying to
understand the problem.
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439645#comment-17439645
]
Konrad Windszus commented on MRELEASE-1072:
---
This only happens with SubversionScmTranslater as that always returns {{null}}
for {{resolveTag}}
(https://github.com/apache/maven-release/blob/a9e30c63ea8071234e9a7bb1f433178963ecf93c/maven-release-manager/src/main/java/org/apache/maven/shared/release/scm/SubversionScmTranslator.java#L61)
which is called from
https://github.com/apache/maven-release/blob/a9e30c63ea8071234e9a7bb1f433178963ecf93c/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForDevelopmentPhase.java#L68.
IMHO in case the {{ScmTranslator}} does return {{null}} rather the original tag
should be reused in {{RewritePomsForReleasePhase}} as very often the tag is
used as property in the URLs (like in
https://github.com/apache/maven-javadoc-plugin/blob/e4438401582c1e1e19cdd4f6c21f05f443e7f56e/pom.xml#L50).
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
>
> In case the original {{project.scm}} section contains a tag element (e.g.
> with value "trunk") this is removed during prepare for the next snapshot
> version. The tagged/release version contains the properly adjusted tag
> element.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439640#comment-17439640
]
Michael Osipov commented on MRELEASE-1072:
--
Where is the bug? You mean it is not readied afterwards?
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
>
> In case the original {{project.scm}} section contains a tag element (e.g.
> with value "trunk") this is removed during prepare for the next snapshot
> version. The tagged/release version contains the properly adjusted tag
> element.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
