[jira] [Commented] (MRELEASE-797) support semantic versioning

2018-11-06 Thread Robert Scholte (JIRA)


[ 
https://issues.apache.org/jira/browse/MRELEASE-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677294#comment-16677294
 ] 

Robert Scholte commented on MRELEASE-797:
-

I still don't understand the problem with a policy.

The code is NOT like (if projectA then X, if projectB then Y, etc...) . The 
implementation now fill pick the next minor, resetting the fix-value, so it is 
only looking at versions. Maybe it would help if you could write some unittests 
to better understand your requests.

> support semantic versioning
> ---
>
> Key: MRELEASE-797
> URL: https://issues.apache.org/jira/browse/MRELEASE-797
> Project: Maven Release Plugin
>  Issue Type: Improvement
>  Components: update-versions
>Affects Versions: 2.3.2
> Environment: Maven 3.0.4
>Reporter: Matthew Daniel
>Assignee: Robert Scholte
>Priority: Minor
>
> When a project is using [semantic versioning|http://semver.org/], the 
> maven-release-plugin will only increment the right-most version identifier 
> (which corresponds to a "patch" release in semver terminology). It would be 
> helpful if the maven-release-plugin understood the 3 normal release 
> severities: major, minor and patch.
> Current behavior:
> # Given a {{pom.xml}} with version {{1.0.50-SNAPSHOT}}
> # When the user executes {{mvn release:update-versions -Dsemver=major}} (as a 
> hypothetical syntax)
> # Then observe that {{pom.xml}} contains {{1.0.51-SNAPSHOT}}, not 
> {{2.0.0-SNAPSHOT}} as a "major" release would dictate
> Expected behavior:
> # Given a pom version in {{X.Y.Z}} format
> # When one indicates the desired semantic version release level to 
> maven-release-plugin
> # Then maven-release-plugin increments {{X.Y.Z}} according to the user's 
> indicated release level
> It would be an error condition for the user to request a semantic version 
> release level when the pom's version is not in {{X.Y.Z}} format (plus any 
> miscellaneous trailing text as specified in rules 10, 11 or 12 of the semver 
> specification).
> It is currently possible to work around this via manual construction of a 
> {{release.properties}} file, but that requires a 2 step build process: run 
> the script then run the Maven targets. Further, one would expect that all 
> Maven projects that use semantic versioning would need to implement their own 
> pre-release scripts, which is wasteful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRELEASE-797) support semantic versioning

2018-11-03 Thread Thomas Meyer (JIRA)


[ 
https://issues.apache.org/jira/browse/MRELEASE-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674046#comment-16674046
 ] 

Thomas Meyer commented on MRELEASE-797:
---

mhh. okay. My use case is to create release versions with the maven 
release-plugin. I either want to automatically increment the minor or patch 
version. I want to set an java property and let do the maven-release-plugin the 
magic. It feels wrong to bind the version policy to a given maven project. the 
release number policy should only be an command line option and not bound to a 
given project at least that's my view on this topic.

but for the current SemVerPolicy to work and having tens of different maven 
project, for each project you must configure a dependency to this artifact and 
change their pom. yes you could do an parent pom, but its very complicated 
given that you just want to create a releae version of a given artifact.

I bet this is the reason that most users of the maven-release-plugin just 
manually provide the release and snapshot version via command line options.

searching the net for the already available OddEvenPolicy reveals nearly no 
hits, besides the plugin itself, and some source code.

 

> support semantic versioning
> ---
>
> Key: MRELEASE-797
> URL: https://issues.apache.org/jira/browse/MRELEASE-797
> Project: Maven Release Plugin
>  Issue Type: Improvement
>  Components: update-versions
>Affects Versions: 2.3.2
> Environment: Maven 3.0.4
>Reporter: Matthew Daniel
>Assignee: Robert Scholte
>Priority: Minor
>
> When a project is using [semantic versioning|http://semver.org/], the 
> maven-release-plugin will only increment the right-most version identifier 
> (which corresponds to a "patch" release in semver terminology). It would be 
> helpful if the maven-release-plugin understood the 3 normal release 
> severities: major, minor and patch.
> Current behavior:
> # Given a {{pom.xml}} with version {{1.0.50-SNAPSHOT}}
> # When the user executes {{mvn release:update-versions -Dsemver=major}} (as a 
> hypothetical syntax)
> # Then observe that {{pom.xml}} contains {{1.0.51-SNAPSHOT}}, not 
> {{2.0.0-SNAPSHOT}} as a "major" release would dictate
> Expected behavior:
> # Given a pom version in {{X.Y.Z}} format
> # When one indicates the desired semantic version release level to 
> maven-release-plugin
> # Then maven-release-plugin increments {{X.Y.Z}} according to the user's 
> indicated release level
> It would be an error condition for the user to request a semantic version 
> release level when the pom's version is not in {{X.Y.Z}} format (plus any 
> miscellaneous trailing text as specified in rules 10, 11 or 12 of the semver 
> specification).
> It is currently possible to work around this via manual construction of a 
> {{release.properties}} file, but that requires a 2 step build process: run 
> the script then run the Maven targets. Further, one would expect that all 
> Maven projects that use semantic versioning would need to implement their own 
> pre-release scripts, which is wasteful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRELEASE-797) support semantic versioning

2018-11-03 Thread Robert Scholte (JIRA)


[ 
https://issues.apache.org/jira/browse/MRELEASE-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673979#comment-16673979
 ] 

Robert Scholte commented on MRELEASE-797:
-

It has been quite some time since I had a look at that code.

Pure SemVer is now not possible, because the major version should be based on 
compatibility. You can only do that after compilation, however Maven expects a 
version from the start. I don't know about the status of the current module, 
would be nice to see improvements on it when possible.

You should only have to specify the policy in the root-folder, from where the 
maven-release-plugin is executed.

 

> support semantic versioning
> ---
>
> Key: MRELEASE-797
> URL: https://issues.apache.org/jira/browse/MRELEASE-797
> Project: Maven Release Plugin
>  Issue Type: Improvement
>  Components: update-versions
>Affects Versions: 2.3.2
> Environment: Maven 3.0.4
>Reporter: Matthew Daniel
>Assignee: Robert Scholte
>Priority: Minor
>
> When a project is using [semantic versioning|http://semver.org/], the 
> maven-release-plugin will only increment the right-most version identifier 
> (which corresponds to a "patch" release in semver terminology). It would be 
> helpful if the maven-release-plugin understood the 3 normal release 
> severities: major, minor and patch.
> Current behavior:
> # Given a {{pom.xml}} with version {{1.0.50-SNAPSHOT}}
> # When the user executes {{mvn release:update-versions -Dsemver=major}} (as a 
> hypothetical syntax)
> # Then observe that {{pom.xml}} contains {{1.0.51-SNAPSHOT}}, not 
> {{2.0.0-SNAPSHOT}} as a "major" release would dictate
> Expected behavior:
> # Given a pom version in {{X.Y.Z}} format
> # When one indicates the desired semantic version release level to 
> maven-release-plugin
> # Then maven-release-plugin increments {{X.Y.Z}} according to the user's 
> indicated release level
> It would be an error condition for the user to request a semantic version 
> release level when the pom's version is not in {{X.Y.Z}} format (plus any 
> miscellaneous trailing text as specified in rules 10, 11 or 12 of the semver 
> specification).
> It is currently possible to work around this via manual construction of a 
> {{release.properties}} file, but that requires a 2 step build process: run 
> the script then run the Maven targets. Further, one would expect that all 
> Maven projects that use semantic versioning would need to implement their own 
> pre-release scripts, which is wasteful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRELEASE-797) support semantic versioning

2018-11-02 Thread Thomas Meyer (JIRA)


[ 
https://issues.apache.org/jira/browse/MRELEASE-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673732#comment-16673732
 ] 

Thomas Meyer commented on MRELEASE-797:
---

Hi, any plans to actually release maven-release-semver-policy? The module is 
currently disabled in the project parent pom.

Also the SemVerVersionPolicy always seems to increment the MAJOR component of 
the version. Sadly above suggestion -Dsemver=major is not implemented.

Also to use SemVerVersionPolicy or OddEvenVersionPolicy you need to add an 
dependency to the given maven coordinate to each project. there seems to be no 
way to use the version policy independently from a given maven project? or is 
it possbile without adding an dependencies entry to the maven-release plugin 
config?

> support semantic versioning
> ---
>
> Key: MRELEASE-797
> URL: https://issues.apache.org/jira/browse/MRELEASE-797
> Project: Maven Release Plugin
>  Issue Type: Improvement
>  Components: update-versions
>Affects Versions: 2.3.2
> Environment: Maven 3.0.4
>Reporter: Matthew Daniel
>Assignee: Robert Scholte
>Priority: Minor
>
> When a project is using [semantic versioning|http://semver.org/], the 
> maven-release-plugin will only increment the right-most version identifier 
> (which corresponds to a "patch" release in semver terminology). It would be 
> helpful if the maven-release-plugin understood the 3 normal release 
> severities: major, minor and patch.
> Current behavior:
> # Given a {{pom.xml}} with version {{1.0.50-SNAPSHOT}}
> # When the user executes {{mvn release:update-versions -Dsemver=major}} (as a 
> hypothetical syntax)
> # Then observe that {{pom.xml}} contains {{1.0.51-SNAPSHOT}}, not 
> {{2.0.0-SNAPSHOT}} as a "major" release would dictate
> Expected behavior:
> # Given a pom version in {{X.Y.Z}} format
> # When one indicates the desired semantic version release level to 
> maven-release-plugin
> # Then maven-release-plugin increments {{X.Y.Z}} according to the user's 
> indicated release level
> It would be an error condition for the user to request a semantic version 
> release level when the pom's version is not in {{X.Y.Z}} format (plus any 
> miscellaneous trailing text as specified in rules 10, 11 or 12 of the semver 
> specification).
> It is currently possible to work around this via manual construction of a 
> {{release.properties}} file, but that requires a 2 step build process: run 
> the script then run the Maven targets. Further, one would expect that all 
> Maven projects that use semantic versioning would need to implement their own 
> pre-release scripts, which is wasteful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)