[jira] [Commented] (MRELEASE-948) Add options to verify release based on release.zip

2022-01-01 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467483#comment-17467483
 ] 

Michael Osipov commented on MRELEASE-948:
-

I consider this to be very ASF-specific and partially out of scope for a 
general plugin.

> Add options to verify release based on release.zip
> --
>
> Key: MRELEASE-948
> URL: https://issues.apache.org/jira/browse/MRELEASE-948
> Project: Maven Release Plugin
>  Issue Type: New Feature
>  Components: perform
>Affects Versions: 2.5.3
>Reporter: Robert Scholte
>Priority: Major
>
> For Apache projects, the release.zip is the official release and not the 
> scm-tag(!). In such case it is much more important to verify that file, 
> especially if there generated files like DEPENDENCIES are added, which might 
> cause the rat-plugin to fail. These failures are not detected when building 
> based on the tag.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MRELEASE-948) Add options to verify release based on release.zip

2019-12-22 Thread Robert Scholte (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001920#comment-17001920
 ] 

Robert Scholte commented on MRELEASE-948:
-

The complex thing here is that the perform-phase is based on the tag, where the 
official release should be based on the mentioned zip.
But this implies that the perform should not only tag the sources, but also 
stage the zip-file the ASFs dist-folder.
When that's in place, we could verify during prepare the artifact for ASF, 
during perform the artifact for Central.

> Add options to verify release based on release.zip
> --
>
> Key: MRELEASE-948
> URL: https://issues.apache.org/jira/browse/MRELEASE-948
> Project: Maven Release Plugin
>  Issue Type: New Feature
>  Components: perform
>Affects Versions: 2.5.3
>Reporter: Robert Scholte
>Priority: Major
>
> For Apache projects, the release.zip is the official release and not the 
> scm-tag(!). In such case it is much more important to verify that file, 
> especially if there generated files like DEPENDENCIES are added, which might 
> cause the rat-plugin to fail. These failures are not detected when building 
> based on the tag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MRELEASE-948) Add options to verify release based on release.zip

2019-12-22 Thread Elliotte Rusty Harold (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001903#comment-17001903
 ] 

Elliotte Rusty Harold commented on MRELEASE-948:


can this be done unconditionally? i.e. always verify both?

> Add options to verify release based on release.zip
> --
>
> Key: MRELEASE-948
> URL: https://issues.apache.org/jira/browse/MRELEASE-948
> Project: Maven Release Plugin
>  Issue Type: New Feature
>  Components: perform
>Affects Versions: 2.5.3
>Reporter: Robert Scholte
>Priority: Major
>
> For Apache projects, the release.zip is the official release and not the 
> scm-tag(!). In such case it is much more important to verify that file, 
> especially if there generated files like DEPENDENCIES are added, which might 
> cause the rat-plugin to fail. These failures are not detected when building 
> based on the tag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)