[
https://issues.apache.org/jira/browse/MSCRIPTING-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822873#comment-17822873
]
ASF GitHub Bot commented on MSCRIPTING-13:
--
bmarwell opened a new pull request, #24:
URL: https://github.com/apache/maven-scripting-plugin/pull/24
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSCRIPTING) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MSCRIPTING-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MSCRIPTING-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Remove unused dependencies
> --
>
> Key: MSCRIPTING-13
> URL: https://issues.apache.org/jira/browse/MSCRIPTING-13
> Project: Maven Scripting
> Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: up-for-grabs
>
> [WARNING] Unused declared dependencies found:
> [WARNING]org.apache.maven.shared:maven-shared-utils:jar:3.3.3:compile
> [WARNING]junit:junit:jar:4.12:test
> [WARNING]
> org.apache.maven.plugin-testing:maven-plugin-testing-harness:jar:2.1:test
> [WARNING]org.apache.maven:maven-compat:jar:3.0:test
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
