[jira] [Commented] (MSHADE-145) Site not generated correctly when overriding dependencyReducedPomLocation with relocation
[
https://issues.apache.org/jira/browse/MSHADE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331669#comment-17331669
]
Alexander Kriegisch commented on MSHADE-145:
Besides, I agree with [~awhitford] that the build directory should be the
default for the DRP. Otherwise we need a custom Maven Clean action plus
specific entried in {{.gitignore}} in order to have a fairly clean project
without warnings of newly added XML files, maybe accidentally committing them
to the SCM. Even if that does not happen, it is simply annoying.
> Site not generated correctly when overriding dependencyReducedPomLocation
> with relocation
> -
>
> Key: MSHADE-145
> URL: https://issues.apache.org/jira/browse/MSHADE-145
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: Windows XP, Java 6 Update 24, Maven 3.0.4
>Reporter: Anthony Whitford
>Priority: Major
> Attachments: shade-site-bug.zip
>
>
> My release failed because the project uses the {{maven-shade-plugin}} and it
> generated a {{dependency-reduced-pom.xml}} in the {{basedir}}, so the release
> plugin complains that there are local, uncommitted modifications.
> To get my release working, I overrode the {{dependencyReducedPomLocation}}
> configuration parameter to place it in {{project.build.directory}}:
> {code:xml}
>
>
> ${project.build.directory}/dependency-reduced-pom.xml
> ...
>
> {code}
> My release worked, but then I noticed that this had a nasty side effect: my
> site was not generated properly!
> The project has {{src\site}} with a {{site.xml}} and APT pages. Those were
> no longer generated... I have no idea how one thing is connected to the
> other, but I did prove it by creating a sample application that illustrates
> the problem.
> Note that the problem seems to a combination of at least 2 things:
> * {{dependencyReducedPomLocation}}
> * {{relocations}}
> In other words, if you comment out the {{dependencyReducedPomLocation}} or
> the {{relocations}}, you can see the site being generated correctly. But if
> you have these, then the site will NOT generate properly.
> To be clear, the site generation is incorrect if you don't see the menu
> layout like:
> * About
> ** Introduction
> ** Usage
> * Project Documentation
> * Project Information
> A broken site, you will notice that the About menu and Usage page do not
> exist, for example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSHADE-145) Site not generated correctly when overriding dependencyReducedPomLocation with relocation
[
https://issues.apache.org/jira/browse/MSHADE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331667#comment-17331667
]
Alexander Kriegisch commented on MSHADE-145:
Because I want to use
{{${project.build.directory}/dependency-reduced-pom.xml}}
in my own project and did not notice any issues with it, I became curious,
trying to reproduce this problem the documentation is still warning about in
Maven Shade 3.2.4. I wondered if it was an issue with older plugin or Maven
versions. So I downloaded the sample project attached here and tried to
reproduce it, running on Java 8 and compiling with Java 8 source/target.
Findings:
* Maven 3.0.x is no longer working because it wants to download using HTTP, but
Maven Central needs HTTPS nowadays.
* Next, I tried Maven 3.1.1. Because of [this
problem|https://cwiki.apache.org/confluence/display/MAVEN/AetherClassNotFound],
I upgraded to Maven Shade 2.1 and Maven Site 3.3, as recommended.
* The next problem was with site generation because it could not find a class,
requiring me to specify a version for Project Info Reports (PIP). I chose 2.7,
which was released about the same time as Site 3.3.
* There again, I had problems with HTTP instead of HTTPS download, this time
inside Site 3.3, so I upgraded to Maven 3.2.3 which was said to have fixed
HTTPS-related download problems.
* Finally, I could run `mvn clean install site`, but did not see any issues
with site generation. Maybe the reproducer project was inadequate in the first
place, but I do not think so. Maybe the changes necessary to run this ancient
setup with the oldest versions of Maven and used plugins necessary to build in
2021.
* I even checked with Maven Antrun, if the base directory was changed using the
setting for the dependency-reduced POM (DRP) location: {code:xml}
[basedir] ${basedir}
[project.basedir] ${project.basedir}
{code}
* Next, I upgraded to my usual setting: Maven 3.6.3 - not the latest, but still
a pretty much recent version - and also upgraded to Shade 3.2.4, Site 3.9.1 and
PIP 3.1.1. Again, no issues with a changed base directory.
*Conclusion:* Either this problem does not exist anymore in all but ancient
setups and the issue can be closed, also removing the warning from the
{{dependencyReducedPomLocation}} property help text, or we need another
reproducer project from someone who is still suffering from this problem.
> Site not generated correctly when overriding dependencyReducedPomLocation
> with relocation
> -
>
> Key: MSHADE-145
> URL: https://issues.apache.org/jira/browse/MSHADE-145
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: Windows XP, Java 6 Update 24, Maven 3.0.4
>Reporter: Anthony Whitford
>Priority: Major
> Attachments: shade-site-bug.zip
>
>
> My release failed because the project uses the {{maven-shade-plugin}} and it
> generated a {{dependency-reduced-pom.xml}} in the {{basedir}}, so the release
> plugin complains that there are local, uncommitted modifications.
> To get my release working, I overrode the {{dependencyReducedPomLocation}}
> configuration parameter to place it in {{project.build.directory}}:
> {code:xml}
>
>
> ${project.build.directory}/dependency-reduced-pom.xml
> ...
>
> {code}
> My release worked, but then I noticed that this had a nasty side effect: my
> site was not generated properly!
> The project has {{src\site}} with a {{site.xml}} and APT pages. Those were
> no longer generated... I have no idea how one thing is connected to the
> other, but I did prove it by creating a sample application that illustrates
> the problem.
> Note that the problem seems to a combination of at least 2 things:
> * {{dependencyReducedPomLocation}}
> * {{relocations}}
> In other words, if you comment out the {{dependencyReducedPomLocation}} or
> the {{relocations}}, you can see the site being generated correctly. But if
> you have these, then the site will NOT generate properly.
> To be clear, the site generation is incorrect if you don't see the menu
> layout like:
> * About
> ** Introduction
> ** Usage
> * Project Documentation
> * Project Information
> A broken site, you will notice that the About menu and Usage page do not
> exist, for example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSHADE-145) Site not generated correctly when overriding dependencyReducedPomLocation with relocation
[
https://issues.apache.org/jira/browse/MSHADE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394380#comment-16394380
]
Anthony Whitford commented on MSHADE-145:
-
I think this is still valid.
> Site not generated correctly when overriding dependencyReducedPomLocation
> with relocation
> -
>
> Key: MSHADE-145
> URL: https://issues.apache.org/jira/browse/MSHADE-145
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: Windows XP, Java 6 Update 24, Maven 3.0.4
>Reporter: Anthony Whitford
>Priority: Major
> Attachments: shade-site-bug.zip
>
>
> My release failed because the project uses the {{maven-shade-plugin}} and it
> generated a {{dependency-reduced-pom.xml}} in the {{basedir}}, so the release
> plugin complains that there are local, uncommitted modifications.
> To get my release working, I overrode the {{dependencyReducedPomLocation}}
> configuration parameter to place it in {{project.build.directory}}:
> {code:xml}
>
>
> ${project.build.directory}/dependency-reduced-pom.xml
> ...
>
> {code}
> My release worked, but then I noticed that this had a nasty side effect: my
> site was not generated properly!
> The project has {{src\site}} with a {{site.xml}} and APT pages. Those were
> no longer generated... I have no idea how one thing is connected to the
> other, but I did prove it by creating a sample application that illustrates
> the problem.
> Note that the problem seems to a combination of at least 2 things:
> * {{dependencyReducedPomLocation}}
> * {{relocations}}
> In other words, if you comment out the {{dependencyReducedPomLocation}} or
> the {{relocations}}, you can see the site being generated correctly. But if
> you have these, then the site will NOT generate properly.
> To be clear, the site generation is incorrect if you don't see the menu
> layout like:
> * About
> ** Introduction
> ** Usage
> * Project Documentation
> * Project Information
> A broken site, you will notice that the About menu and Usage page do not
> exist, for example.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
