[jira] [Commented] (MSHADE-323) Flatten Maven Plugin conflicts with Maven Shade Plugin
[
https://issues.apache.org/jira/browse/MSHADE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599113#comment-17599113
]
Jesse Glick commented on MSHADE-323:
https://github.com/mojohaus/flatten-maven-plugin/releases/tag/flatten-maven-plugin-1.3.0
> Flatten Maven Plugin conflicts with Maven Shade Plugin
> --
>
> Key: MSHADE-323
> URL: https://issues.apache.org/jira/browse/MSHADE-323
> Project: Maven Shade Plugin
> Issue Type: Bug
>Reporter: lakunma
>Priority: Minor
>
> When using Flatten Maven Plugin in the same project with Maven Shade Plugin
> then the dependency reduced POM is _not_ flattened.
> What i encountered that having flatten plugin configured according to
> [https://maven.apache.org/maven-ci-friendly.html], and having shade plugin
> configured with the default settings to produce uber jar the ${revision}
> variable remains and gets installed/deployed within the final pom, thus
> making the pom in the repository invalid.
> It seems that both plugins transform original pom. And then what gets
> installed in the last one, which is the 'shades' one. I'm not sure that's a
> bug (in a sense that it is shade's fault).
> See also [https://github.com/mojohaus/flatten-maven-plugin/issues/100]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-323) Flatten Maven Plugin conflicts with Maven Shade Plugin
[
https://issues.apache.org/jira/browse/MSHADE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521142#comment-17521142
]
Ilya Kasnacheev commented on MSHADE-323:
Unfortunately I'm not a committer to Maven and can't carry modified Maven
around. Still, thank you.
> Flatten Maven Plugin conflicts with Maven Shade Plugin
> --
>
> Key: MSHADE-323
> URL: https://issues.apache.org/jira/browse/MSHADE-323
> Project: Maven Shade Plugin
> Issue Type: Bug
>Reporter: lakunma
>Priority: Minor
>
> When using Flatten Maven Plugin in the same project with Maven Shade Plugin
> then the dependency reduced POM is _not_ flattened.
> What i encountered that having flatten plugin configured according to
> [https://maven.apache.org/maven-ci-friendly.html], and having shade plugin
> configured with the default settings to produce uber jar the ${revision}
> variable remains and gets installed/deployed within the final pom, thus
> making the pom in the repository invalid.
> It seems that both plugins transform original pom. And then what gets
> installed in the last one, which is the 'shades' one. I'm not sure that's a
> bug (in a sense that it is shade's fault).
> See also [https://github.com/mojohaus/flatten-maven-plugin/issues/100]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MSHADE-323) Flatten Maven Plugin conflicts with Maven Shade Plugin
[
https://issues.apache.org/jira/browse/MSHADE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517764#comment-17517764
]
James Z.M. Gao commented on MSHADE-323:
---
[~ilyak] this [pr|https://github.com/apache/maven-shade-plugin/pull/129] makes
it possible to chain the flatten and shade plugins on rewriting the project pom.
This pr does not change the `originalModel`. But imo the root cause of the
conflicts should be the inconsistent of `project.getOriginalModel()` and
`readModel(project.getFile())`. So every plugin rewriting the pom file should
also update original model to reflect the new pom file content, whereas the
flatten and shade plugins both lack this step after switching the project pom.
> Flatten Maven Plugin conflicts with Maven Shade Plugin
> --
>
> Key: MSHADE-323
> URL: https://issues.apache.org/jira/browse/MSHADE-323
> Project: Maven Shade Plugin
> Issue Type: Bug
>Reporter: lakunma
>Priority: Minor
>
> When using Flatten Maven Plugin in the same project with Maven Shade Plugin
> then the dependency reduced POM is _not_ flattened.
> What i encountered that having flatten plugin configured according to
> [https://maven.apache.org/maven-ci-friendly.html], and having shade plugin
> configured with the default settings to produce uber jar the ${revision}
> variable remains and gets installed/deployed within the final pom, thus
> making the pom in the repository invalid.
> It seems that both plugins transform original pom. And then what gets
> installed in the last one, which is the 'shades' one. I'm not sure that's a
> bug (in a sense that it is shade's fault).
> See also [https://github.com/mojohaus/flatten-maven-plugin/issues/100]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MSHADE-323) Flatten Maven Plugin conflicts with Maven Shade Plugin
[
https://issues.apache.org/jira/browse/MSHADE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466457#comment-17466457
]
Ilya Kasnacheev commented on MSHADE-323:
This is a Shade bug, since it works the other way around: Flatten maven plugin
will pick up changes made by Shade, but Shade will ignore changes made by
Flatten.
> Flatten Maven Plugin conflicts with Maven Shade Plugin
> --
>
> Key: MSHADE-323
> URL: https://issues.apache.org/jira/browse/MSHADE-323
> Project: Maven Shade Plugin
> Issue Type: Bug
>Reporter: lakunma
>Priority: Minor
>
> When using Flatten Maven Plugin in the same project with Maven Shade Plugin
> then the dependency reduced POM is _not_ flattened.
> What i encountered that having flatten plugin configured according to
> [https://maven.apache.org/maven-ci-friendly.html], and having shade plugin
> configured with the default settings to produce uber jar the ${revision}
> variable remains and gets installed/deployed within the final pom, thus
> making the pom in the repository invalid.
> It seems that both plugins transform original pom. And then what gets
> installed in the last one, which is the 'shades' one. I'm not sure that's a
> bug (in a sense that it is shade's fault).
> See also [https://github.com/mojohaus/flatten-maven-plugin/issues/100]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
