[jira] [Commented] (MSHARED-1032) API change: let MavenReport#canGenerateReport() throw an exception
[ https://issues.apache.org/jira/browse/MSHARED-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741166#comment-17741166 ] ASF GitHub Bot commented on MSHARED-1032: - michael-o merged PR #156: URL: https://github.com/apache/maven-site-plugin/pull/156 > API change: let MavenReport#canGenerateReport() throw an exception > -- > > Key: MSHARED-1032 > URL: https://issues.apache.org/jira/browse/MSHARED-1032 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api >Affects Versions: maven-reporting-api-3.0 >Reporter: Benjamin Marwell >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0-M7 > > > Hi everyone, > the [{{AbstractReportMojo}} in > reporting-impl|https://maven.apache.org/shared/maven-reporting-impl/apidocs/org/apache/maven/reporting/AbstractMavenReport.html] > implements a method [{{canGenerateReport()}} from > reporting-api|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReport.html]. > However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}} > or {{MavenReportEx}}, which is most unfortunate. > It is being used twice: > Once in {{execute() throws MojoExEx}} > and in > {{generate() throws MavenReportEx}} (and is called by execute()). > This way, there is no way for reporting plugins to scan for files, because > {{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot > be wrapped. However, the {{IOException}} from that method is useless anyway, > because it is never declared in any methods it calls. > Therefore please consider: > * Declaring any Exception on {{canGenerateReport()}} > * Removing the declared {{IOException}} in PlexusUtils ([PR > exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and > Maven-Utils (issue: tbd). > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1032) API change: let MavenReport#canGenerateReport() throw an exception
[ https://issues.apache.org/jira/browse/MSHARED-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741096#comment-17741096 ] ASF GitHub Bot commented on MSHARED-1032: - michael-o commented on PR #22: URL: https://github.com/apache/maven-reporting-impl/pull/22#issuecomment-1625597614 Merged manually. > API change: let MavenReport#canGenerateReport() throw an exception > -- > > Key: MSHARED-1032 > URL: https://issues.apache.org/jira/browse/MSHARED-1032 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api >Affects Versions: maven-reporting-api-3.0 >Reporter: Benjamin Marwell >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0-M7 > > > Hi everyone, > the [{{AbstractReportMojo}} in > reporting-impl|https://maven.apache.org/shared/maven-reporting-impl/apidocs/org/apache/maven/reporting/AbstractMavenReport.html] > implements a method [{{canGenerateReport()}} from > reporting-api|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReport.html]. > However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}} > or {{MavenReportEx}}, which is most unfortunate. > It is being used twice: > Once in {{execute() throws MojoExEx}} > and in > {{generate() throws MavenReportEx}} (and is called by execute()). > This way, there is no way for reporting plugins to scan for files, because > {{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot > be wrapped. However, the {{IOException}} from that method is useless anyway, > because it is never declared in any methods it calls. > Therefore please consider: > * Declaring any Exception on {{canGenerateReport()}} > * Removing the declared {{IOException}} in PlexusUtils ([PR > exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and > Maven-Utils (issue: tbd). > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1032) API change: let MavenReport#canGenerateReport() throw an exception
[ https://issues.apache.org/jira/browse/MSHARED-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741097#comment-17741097 ] ASF GitHub Bot commented on MSHARED-1032: - michael-o closed pull request #22: MSHARED-1032 URL: https://github.com/apache/maven-reporting-impl/pull/22 > API change: let MavenReport#canGenerateReport() throw an exception > -- > > Key: MSHARED-1032 > URL: https://issues.apache.org/jira/browse/MSHARED-1032 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api >Affects Versions: maven-reporting-api-3.0 >Reporter: Benjamin Marwell >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0-M7 > > > Hi everyone, > the [{{AbstractReportMojo}} in > reporting-impl|https://maven.apache.org/shared/maven-reporting-impl/apidocs/org/apache/maven/reporting/AbstractMavenReport.html] > implements a method [{{canGenerateReport()}} from > reporting-api|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReport.html]. > However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}} > or {{MavenReportEx}}, which is most unfortunate. > It is being used twice: > Once in {{execute() throws MojoExEx}} > and in > {{generate() throws MavenReportEx}} (and is called by execute()). > This way, there is no way for reporting plugins to scan for files, because > {{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot > be wrapped. However, the {{IOException}} from that method is useless anyway, > because it is never declared in any methods it calls. > Therefore please consider: > * Declaring any Exception on {{canGenerateReport()}} > * Removing the declared {{IOException}} in PlexusUtils ([PR > exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and > Maven-Utils (issue: tbd). > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1032) API change: let MavenReport#canGenerateReport() throw an exception
[ https://issues.apache.org/jira/browse/MSHARED-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740622#comment-17740622 ] ASF GitHub Bot commented on MSHARED-1032: - asfgit closed pull request #17: [MSHARED-1032] API change: let MavenReport#canGenerateReport() throw … URL: https://github.com/apache/maven-reporting-api/pull/17 > API change: let MavenReport#canGenerateReport() throw an exception > -- > > Key: MSHARED-1032 > URL: https://issues.apache.org/jira/browse/MSHARED-1032 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api >Affects Versions: maven-reporting-api-3.0 >Reporter: Benjamin Marwell >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0-M7 > > > Hi everyone, > the [{{AbstractReportMojo}} in > reporting-impl|https://maven.apache.org/shared/maven-reporting-impl/apidocs/org/apache/maven/reporting/AbstractMavenReport.html] > implements a method [{{canGenerateReport()}} from > reporting-api|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReport.html]. > However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}} > or {{MavenReportEx}}, which is most unfortunate. > It is being used twice: > Once in {{execute() throws MojoExEx}} > and in > {{generate() throws MavenReportEx}} (and is called by execute()). > This way, there is no way for reporting plugins to scan for files, because > {{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot > be wrapped. However, the {{IOException}} from that method is useless anyway, > because it is never declared in any methods it calls. > Therefore please consider: > * Declaring any Exception on {{canGenerateReport()}} > * Removing the declared {{IOException}} in PlexusUtils ([PR > exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and > Maven-Utils (issue: tbd). > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1032) API change: let MavenReport#canGenerateReport() throw an exception
[ https://issues.apache.org/jira/browse/MSHARED-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739329#comment-17739329 ] Michael Osipov commented on MSHARED-1032: - Guys, please have a look at the PR. For me, it looks good. I'd like to merge it in a week and move over to the last issue (MSHARED-193) before release. > API change: let MavenReport#canGenerateReport() throw an exception > -- > > Key: MSHARED-1032 > URL: https://issues.apache.org/jira/browse/MSHARED-1032 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api >Affects Versions: maven-reporting-api-3.0 >Reporter: Benjamin Marwell >Assignee: Michael Osipov >Priority: Major > Labels: doxia-2.0.0-stack > Fix For: maven-reporting-api-4.0.0-M7 > > > Hi everyone, > the [{{AbstractReportMojo}} in > reporting-impl|https://maven.apache.org/shared/maven-reporting-impl/apidocs/org/apache/maven/reporting/AbstractMavenReport.html] > implements a method [{{canGenerateReport()}} from > reporting-api|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReport.html]. > However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}} > or {{MavenReportEx}}, which is most unfortunate. > It is being used twice: > Once in {{execute() throws MojoExEx}} > and in > {{generate() throws MavenReportEx}} (and is called by execute()). > This way, there is no way for reporting plugins to scan for files, because > {{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot > be wrapped. However, the {{IOException}} from that method is useless anyway, > because it is never declared in any methods it calls. > Therefore please consider: > * Declaring any Exception on {{canGenerateReport()}} > * Removing the declared {{IOException}} in PlexusUtils ([PR > exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and > Maven-Utils (issue: tbd). > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1032) API change: let MavenReport#canGenerateReport() throw an exception
[ https://issues.apache.org/jira/browse/MSHARED-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736791#comment-17736791 ] ASF GitHub Bot commented on MSHARED-1032: - michael-o opened a new pull request, #156: URL: https://github.com/apache/maven-site-plugin/pull/156 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > API change: let MavenReport#canGenerateReport() throw an exception > -- > > Key: MSHARED-1032 > URL: https://issues.apache.org/jira/browse/MSHARED-1032 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api >Affects Versions: maven-reporting-api-3.0 >Reporter: Benjamin Marwell >Assignee: Michael Osipov >Priority: Major > Labels: doxia-2.0.0-stack > Fix For: maven-reporting-api-4.0.0-M7 > > > Hi everyone, > the [{{AbstractReportMojo}} in > reporting-impl|https://maven.apache.org/shared/maven-reporting-impl/apidocs/org/apache/maven/reporting/AbstractMavenReport.html] > implements a method [{{canGenerateReport()}} from > reporting-api|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReport.html]. > However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}} > or {{MavenReportEx}}, which is most unfortunate. > It is being used twice: > Once in {{execute() throws MojoExEx}} > and in > {{generate() throws MavenReportEx}} (and is called by execute()). > This way, there is no way for reporting plugins to scan for files, because > {{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot > be wrapped. However, the {{IOException}} from that method is useless anyway, > because it is never declared in any methods it calls. > Therefore please consider: > * Declaring any Exception on {{canGenerateReport()}} > * Removing the declared {{IOException}} in PlexusUtils ([PR > exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and > Maven-Utils (issue: tbd). > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1032) API change: let MavenReport#canGenerateReport() throw an exception
[ https://issues.apache.org/jira/browse/MSHARED-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736776#comment-17736776 ] ASF GitHub Bot commented on MSHARED-1032: - michael-o opened a new pull request, #17: URL: https://github.com/apache/maven-reporting-api/pull/17 …an exception This closes #17 > API change: let MavenReport#canGenerateReport() throw an exception > -- > > Key: MSHARED-1032 > URL: https://issues.apache.org/jira/browse/MSHARED-1032 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api >Affects Versions: maven-reporting-api-3.0 >Reporter: Benjamin Marwell >Assignee: Michael Osipov >Priority: Major > Labels: doxia-2.0.0-stack > Fix For: maven-reporting-api-4.0.0-M7 > > > Hi everyone, > the [{{AbstractReportMojo}} in > reporting-impl|https://maven.apache.org/shared/maven-reporting-impl/apidocs/org/apache/maven/reporting/AbstractMavenReport.html] > implements a method [{{canGenerateReport()}} from > reporting-api|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReport.html]. > However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}} > or {{MavenReportEx}}, which is most unfortunate. > It is being used twice: > Once in {{execute() throws MojoExEx}} > and in > {{generate() throws MavenReportEx}} (and is called by execute()). > This way, there is no way for reporting plugins to scan for files, because > {{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot > be wrapped. However, the {{IOException}} from that method is useless anyway, > because it is never declared in any methods it calls. > Therefore please consider: > * Declaring any Exception on {{canGenerateReport()}} > * Removing the declared {{IOException}} in PlexusUtils ([PR > exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and > Maven-Utils (issue: tbd). > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)