[jira] [Commented] (MSHARED-1136) Deprecate verifier.forkMode in favor of maven.verifier.forkMode

2022-09-18 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606254#comment-17606254
 ] 

Slawomir Jaranowski commented on MSHARED-1136:
--

Additional we have next option in Verifier - {{forkJvm}} - so we have two 
options for the same, one from property and by settings Verifier.

ok, but when we drop this property - we will stop to have possibility to 
execute whole test in embedded or forked mode, like in core-its we have profile 
{{embedded}}

> Deprecate verifier.forkMode in favor of maven.verifier.forkMode
> ---
>
> Key: MSHARED-1136
> URL: https://issues.apache.org/jira/browse/MSHARED-1136
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Michael Osipov
>Priority: Major
>  Labels: up-for-grabs
> Fix For: maven-verifier-2.0.0
>
>
> We should have all system properties under our namespace, thus all prefixed 
> with {{{}maven.{}}}. Query {{maven.verifier.forkMode}} first and then fall 
> back to {{{}verifier.forkMode{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1136) Deprecate verifier.forkMode in favor of maven.verifier.forkMode

2022-09-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606096#comment-17606096
 ] 

Michael Osipov commented on MSHARED-1136:
-

How do you mean?

> Deprecate verifier.forkMode in favor of maven.verifier.forkMode
> ---
>
> Key: MSHARED-1136
> URL: https://issues.apache.org/jira/browse/MSHARED-1136
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Michael Osipov
>Priority: Major
>  Labels: up-for-grabs
> Fix For: maven-verifier-2.0.0
>
>
> We should have all system properties under our namespace, thus all prefixed 
> with {{{}maven.{}}}. Query {{maven.verifier.forkMode}} first and then fall 
> back to {{{}verifier.forkMode{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1136) Deprecate verifier.forkMode in favor of maven.verifier.forkMode

2022-09-17 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606093#comment-17606093
 ] 

Slawomir Jaranowski commented on MSHARED-1136:
--

Maybe we don't need such property at all.
Caller can easy set it during test prepare.

> Deprecate verifier.forkMode in favor of maven.verifier.forkMode
> ---
>
> Key: MSHARED-1136
> URL: https://issues.apache.org/jira/browse/MSHARED-1136
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Michael Osipov
>Priority: Major
>  Labels: up-for-grabs
> Fix For: maven-verifier-2.0.0
>
>
> We should have all system properties under our namespace, thus all prefixed 
> with {{{}maven.{}}}. Query {{maven.verifier.forkMode}} first and then fall 
> back to {{{}verifier.forkMode{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)