[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770090#comment-16770090
]
Michael Osipov commented on MSHARED-362:
Everything has been adapted. You can configure Maven Archiver now to have
{{Manifest-Version}} only.
> Support removing default manifest entries with Maven Archiver
> -
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: maven-archiver-3.4.0
>
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762068#comment-16762068 ] Michael Osipov commented on MSHARED-362: [~richardneish], please have a look at MSHARED-800 too. > Support removing default manifest entries with Maven Archiver > - > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-archiver-3.4.0 > > Attachments: MSHARED-362-01.patch > > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753772#comment-16753772 ] Michael Osipov commented on MSHARED-362: Yes, there will be. > Support removing default manifest entries with Maven Archiver > - > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-archiver-3.4.0 > > Attachments: MSHARED-362-01.patch > > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753673#comment-16753673 ] Hervé Boutemy commented on MSHARED-362: --- Yes, that’s a good idea: I don’t know why people will configure that, but it will be their choice. What is important to me is that by default the entries are in the manifest > Support removing default manifest entries with Maven Archiver > - > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-archiver-3.4.0 > > Attachments: MSHARED-362-01.patch > > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753602#comment-16753602
]
Michael Osipov commented on MSHARED-362:
[~hboutemy], since we agreed on {{Build-Jdk-Spec}}. Why not add a property
{{addDefaultEntries: true}} which groups {{Build-Jdk-Spec}} and {{Created-By}}?
You will have you repro entries which can be *explicitly* disabled.
> Support removing default manifest entries with Maven Archiver
> -
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: maven-archiver-3.4.0
>
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749929#comment-16749929 ] Hervé Boutemy commented on MSHARED-362: --- no, he wants reproducible results: I want it also and I can tell you that if you don't get the same java.specification.version, you won't have the same bytecode I confirm: let's close this issue as Won't fix and once other issues are fixed, if someone really require a little change, we'll see which one > Support removing default manifest entries with Maven Archiver > - > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-archiver-3.4.0 > > Attachments: MSHARED-362-01.patch > > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749842#comment-16749842
]
Michael Osipov commented on MSHARED-362:
Though, it is not explicitly written, the [~richardneish] wants the
{{MANIFEST.MF}} contain {{Manifest-Version: 1.0}} nothing else. By retaining
{{Build-Jdk}} thi isn't possible.
> Support removing default manifest entries with Maven Archiver
> -
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: maven-archiver-3.4.0
>
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749820#comment-16749820
]
Hervé Boutemy commented on MSHARED-362:
---
I don't understand
what we can do with this issue is just close it as "Won't fix" since we have
found a better strategy:
* removed {{Built-By}} in MSHARED-661
* made {{Build-Jdk}} reproducible in MSHARED-796
* working on making every non-reproducible field optional in MSHARED-787 (WIP)
> Support removing default manifest entries with Maven Archiver
> -
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: maven-archiver-3.3.1
>
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749796#comment-16749796
]
Michael Osipov commented on MSHARED-362:
[~hboutemy], please document that with the recent change {{Build-Jdk}} this
issue cannot be completely solved.
> Support removing default manifest entries with Maven Archiver
> -
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: maven-archiver-3.3.1
>
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741599#comment-16741599 ] Michael Osipov commented on MSHARED-362: Haven't received any feedback on MSHARED-787. I will perform the merge somewhere next week. > Support removing default manifest entries with Maven Archiver > - > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-archiver-3.3.1 > > Attachments: MSHARED-362-01.patch > > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with Maven Archiver
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728829#comment-16728829 ] Michael Osipov commented on MSHARED-362: Please have a look at the discussion in MSHARED-787. > Support removing default manifest entries with Maven Archiver > - > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > Attachments: MSHARED-362-01.patch > > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728803#comment-16728803
]
Michael Osipov commented on MSHARED-362:
Friends, {{Built-By}} is gone.
I am considering adding a config element {{
which will add {{Created-By}}, {{Build-Jdk}}, and {{Build-Jdk-Vendor}}. This
will easily allow to disable those entries.
> Support removing default manifest entries with maven-archiver plugin
>
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Priority: Minor
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670810#comment-16670810 ] Michael Osipov commented on MSHARED-362: I fully agree here. > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > Attachments: MSHARED-362-01.patch > > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670644#comment-16670644
]
Rostislav Krasny commented on MSHARED-362:
--
[~rfscholte], then let's just remove the:
*{{addManifestAttribute( m, entries, "Built-By", System.getProperty(
"user.name" ) );}}*
code line from the {{MavenArchiver.java}}. So by default the {{Built-By}} will
be disabled and people who want it in their manifests will define it in the
{{manifestEntries}} section of the {{maven-jar-plugin}} configuration, as in
your example.
> Support removing default manifest entries with maven-archiver plugin
>
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Priority: Minor
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670367#comment-16670367
]
Robert Scholte commented on MSHARED-362:
*_IF_* we want to have By-Built empty by default, just make it {{null}}.
Document that if you want to original value, you must add the following entry
{code:xml}
${user.name}
{code}
So only 1 entry to control this key, not multiple (which implies some kind of
redundency to me)
> Support removing default manifest entries with maven-archiver plugin
>
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Priority: Minor
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669278#comment-16669278 ] Michael Osipov commented on MSHARED-362: Robert, I consider your approach a bit overengineered. > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > Attachments: MSHARED-362-01.patch > > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669276#comment-16669276 ] Michael Osipov commented on MSHARED-362: I also s have seen Perl scripts on within for reproducible builds which remove this manifest entry. I consider this information sensitive and useless. It can easily added manually w/o a new property which is overkill imho. > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > Attachments: MSHARED-362-01.patch > > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669244#comment-16669244
]
Rostislav Krasny commented on MSHARED-362:
--
[~rfscholte], why you call this solution redundant? With my patch you need no
configuration to disable the {{Built-By}} manifest property, since it's already
disabled by default. The above configuration examples are for cases when you
want to enable it and optionally with some custom value. The final goal of this
ticket, as I understand it, is not an *empty* manifest file but manifest file
with as less as possible redundant properties. I don't think someone want to
disable properties like {{Class-Path}} or {{Main-Class}} together with
{{Built-By}}, etc. If this is not what you meant the {{EmptyManifest}} will be
confusing.
Also this ticket was originally opened after a question at Stackoverflow about
removing only the {{Built-By}} property. I think other redundant manifest
properties are less wishful to be removable. Also I think much of those who
want to remove the {{Built-By}} would like to keep {{Built-Jdk}} and
{{Created-By}} because it could be useful in some cases, for example for DevOps
and other professional services staff. For example to check what versions of
JDK and Maven were used by Jenkins to build this or that particular JAR.
> Support removing default manifest entries with maven-archiver plugin
>
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Priority: Minor
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669199#comment-16669199
]
Robert Scholte commented on MSHARED-362:
I'd prefer to see a less redundant solution for the addBuiltBy-boolean. Maybe
we should think of a second implementation of manifest, one you can trigger
with {{}}
> Support removing default manifest entries with maven-archiver plugin
>
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Priority: Minor
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668931#comment-16668931
]
Rostislav Krasny commented on MSHARED-362:
--
Hi. Please consider the attached [^MSHARED-362-01.patch]
It introduces following changes:
# The {{Built-By}} manifest property is now disabled by default
# The {{Built-By}} manifest property could be enabled again with the previous
behavior (e.g. {{user.name}}) by following configuration of the maven-jar-plugin
{code:java}
true
{code}
# Value of the {{Built-By}} manifest property could be customized if enabled
by following {{builtByName}} new configuration property:
{code:java}
true
build machine name
{code}
Rationale:
# Currently the {{Built-By}} manifest property usually is different on
different machines and this prevents repeating the build with the same internal
content of JAR files.
# Currently the {{Built-By}} manifest property has no really useful
information. I think a user may want to put a more useful information into that
property, for example the build machine name.
# Using the {{user.name}} in the {{Build-By}} manifest property could be
considered as privacy issue.
Rest of the manifest properties discussed in this Jira ticket seems less
problematic to me. Let's start fixing the main issue with the {{Built-By}}
manifest property and continue discussion of the rest later.
> Support removing default manifest entries with maven-archiver plugin
>
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Priority: Minor
> Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691046#comment-15691046 ] Michael Osipov commented on MSHARED-362: We have another candidate for this, MNG-6124. It is really time to remove some stuff from Maven archiver. > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295304#comment-15295304
]
Michael Osipov commented on MSHARED-362:
Several months passed..for those who would like to drop {{Built-By}} is for
reproducibility reasons? This is probably part of MSHARED-494 and MSHARED-505.
I would also add to {{Build-Jdk}} the VM vendor.
> Support removing default manifest entries with maven-archiver plugin
>
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Priority: Minor
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125512#comment-15125512 ] Michael Osipov commented on MSHARED-362: Here is a similar request to the matter. > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116026#comment-15116026 ] Michael Osipov commented on MSHARED-362: [~rfscholte], any thought on my comment? > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116121#comment-15116121 ] Michael Osipov commented on MSHARED-362: I think it is going to be hard to determine to deployed it. There shouldn't be much magic involved in the code. Adjusting isn't easy as you have noticed. You cannot remove this attribute. We either provide sensible defaults which do not cause trouble or we omit them. Like i said before, everything in the default section can be aligned on dev machines but not the username, of course. If we chose to leave the attribute out, you can always readd them -- granted this takes some config though. > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116119#comment-15116119 ] Michael Osipov commented on MSHARED-362: I think it is going to be hard to determine to deployed it. There shouldn't be much magic involved in the code. Adjusting isn't easy as you have noticed. You cannot remove this attribute. We either provide sensible defaults which do not cause trouble or we omit them. Like i said before, everything in the default section can be aligned on dev machines but not the username, of course. If we chose to leave the attribute out, you can always readd them -- granted this takes some config though. > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116087#comment-15116087 ] Robert Scholte commented on MSHARED-362: I agree that the local machine username is not always the preferred one. Instead it should probably be the username used to deploy the artifact. So we should think for a better approach for that. But I still think we should keep the entry by default, especially because a lot of users probably expect it to be there. It is easier for those who have issues with it to adjust the configuration of the manifest. > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076643#comment-15076643 ] Robert Scholte commented on MSHARED-362: For easy traceability I still would prefer to have it here by default. Instead I would suggest that if people choose to not include it, they should use a custom manifest and the archiver should respect a missing value for Build-By. > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076656#comment-15076656 ] Robert Scholte commented on MSHARED-362: IIRC some elements are still added, even when you don't specify them in a custom manifest file. So it is personal that you don't like it. It is the fact that the local machine username is used, or that the jar can be traced back to you? In both private (work) and open development I see enough benefits of it. In case I'm hitting issues with a specific jar and can't regenerate that artifact it might help to know who made it and how he did it. Why don't you see it as some kind of reward that you released this jar? The original request was about an option to remove the Build-By, not to drop it by default. > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1507#comment-1507
]
Michael Osipov commented on MSHARED-362:
I don't like the local machine username. At work, you see the uploader username
in Nexus anyway. What if an OSS JAR contains a cryptic name, this won't help
anyway.
The reward is fine but since I do the votes and announces, my display name is
visible to the entire community. I can live with that. People don't unzip JARs
to read credit information ;-)
I cannot even globally override that to add my display name instead of my local
username. The problem is that in my company the username is a generated ID
(company-wide personal ID) and considered as company-only information. I don't
want this information to be public, therefore I avoid to deploy snapshots or
releases from work.
I agree to the original request. The issue is that the remaining entries are
reproducible (Maven version, Java version) but not the username. Even if we add
{{addDefaultEntries}}, the removal would lose a lot of information, plus Plexus
Archiver adds a {{Created-By}} by default.
> Support removing default manifest entries with maven-archiver plugin
>
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Priority: Minor
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[
https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076155#comment-15076155
]
Michael Osipov commented on MSHARED-362:
While some find the
[{{Built-By}}|https://mail-archives.apache.org/mod_mbox/maven-dev/201506.mbox/%3Cop.xzvea6m2kdkhrr%40robertscholte.dynamic.ziggo.nl%3E]
entry useful, I think it is most of the time useless. From an external point
of view, you have no idea who this user is because it is the local username of
the person who built this JAR on his machine. Someone doesn't even want to have
this information disclosed. It doesn't help you much after all. You will file
an issue anyway. In a company this might be a valueable information but can be
added anyway.
I am actually inclined to drop this manifest entry at all. I see no general
purpose information in this entry. [~khmarbaise], [~rfscholte], what you do
think? We have a new major. Safe to remove, I guess. I would also change the
title of the issue to: "Remove Built-By manifest entry due to limited
use/information".
> Support removing default manifest entries with maven-archiver plugin
>
>
> Key: MSHARED-362
> URL: https://issues.apache.org/jira/browse/MSHARED-362
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>Reporter: Richard Neish
>Priority: Minor
>
> As described in the StackOverflow question at
> http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the
> user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but
> not to remove them from the manifest.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076153#comment-15076153 ] Michael Osipov commented on MSHARED-362: What about "Build-JDK"? Is it the same on all machines? > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
[ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076162#comment-15076162 ] Karl Heinz Marbaise commented on MSHARED-362: - As we are new major i see no problem to remove such thing...and as you mentioned already it can simply re-added if you need it... > Support removing default manifest entries with maven-archiver plugin > > > Key: MSHARED-362 > URL: https://issues.apache.org/jira/browse/MSHARED-362 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5 >Reporter: Richard Neish >Priority: Minor > > As described in the StackOverflow question at > http://stackoverflow.com/q/25098307/274350 maven-archiver should allow the > user to remove the default manifest entries, such as "Built-By:" > Currently it is possible to set an empty value for these default entries, but > not to remove them from the manifest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
