[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758260#comment-16758260
]
Hudson commented on MSHARED-787:
Build succeeded in Jenkins: Maven TLP » maven-archiver » master #54
See https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/54/
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Build-Tool: ${maven.build.version:-Apache Maven}
> Build-Jdk: ${java.version} (${java.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch})
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757760#comment-16757760
]
Hervé Boutemy commented on MSHARED-787:
---
MSHARED-799 issue created for the {{Created-By}} entry value change
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Build-Tool: ${maven.build.version:-Apache Maven}
> Build-Jdk: ${java.version} (${java.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch})
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753600#comment-16753600
]
Michael Osipov commented on MSHARED-787:
[~hboutemy], I have now pushed an updated version of the branch. Please have a
look.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Build-Tool: ${maven.build.version:-Apache Maven}
> Build-Jdk: ${java.version} (${java.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch})
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753232#comment-16753232
]
Michael Osipov commented on MSHARED-787:
The value of {{Build-Tool}} will be replaced with the value of the property
{{maven.build.version}}.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750372#comment-16750372
]
Michael Osipov commented on MSHARED-787:
Agreed.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750044#comment-16750044
]
Hervé Boutemy commented on MSHARED-787:
---
almost:
1. as optional build environment information (= the current MSHARED-787 issue),
put:
{noformat}
Build-Tool: Apache Maven ${maven.version} (${commit-id})
Build-Jdk: ${java.version} (${java.vm.vendor})
Build-Os: ${os.name} (${os.version}; (${os.arch})
{noformat}
2. keep {{Created-By}} in the default manifest but change the value to
{noformat}
Created-By: Maven Archiver ${ma.version}
{noformat}
as a separate issue (since it would be there by default)
3. improve the API for calling plugins to be able to easily replace the default
{{Maven Archiver ${ma.version} }} value with {{Maven xxx Plugin
${pluginversion} }}
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749954#comment-16749954
]
Michael Osipov commented on MSHARED-787:
So, your proposal is:
{noformat}
Created-By: Maven Archiver ${ma.version}
Build-Tool: Apache Maven ${maven.version} (${commit-id})
Build-Jdk: ${java.version} (${java.vm.vendor})
Build-Os: ${os.name} (${os.version}; (${os.arch})
{noformat}
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749934#comment-16749934
]
Hervé Boutemy commented on MSHARED-787:
---
then don't call it {{Build-Archiver}} but keep {{Created-By}}
and when plugins will integrate the new version, it would be nice that they
override the value with the plugin name and version
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749849#comment-16749849
]
Michael Osipov commented on MSHARED-787:
Great, I will change the branch for {{Build-Archiver}} with Maven Archiver,
using Plexus Archiver is just an implementation detail of Maven Archiver.
As for the {{maven.vendor}}, yes this just just an idea, but must be handled
separately.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749814#comment-16749814
]
Hervé Boutemy commented on MSHARED-787:
---
I like the whole approach
On {{Build-Archiver}}, we can easily put {{Maven Archiver $\{ma.version}}}, and
ideally, this would be overridden by the plugin which did the archive: and this
could even be kept as default manifest entry, since reproducible!!!
on {{maven.vendor}} property, this could be a good idea, but it is something
that goes beyond this Jira issue: it's something for Maven core and build
instructions...
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749774#comment-16749774
]
Michael Osipov commented on MSHARED-787:
What I was also considering is to have a {{maven.vendor}} property, because a
lot of Linux distro modify Maven which is not the canonical anymore. Our value
would be {{ASF}}, those who did not modify our binary releases can retain it,
other can say {{Debian}}, {{Fedora}}, etc.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749771#comment-16749771
]
Michael Osipov commented on MSHARED-787:
[~hboutemy], the {{Created-By}} can be disabled in Plexus Archiver now, in
fact. I have disabled it in 4.0.1 (not by default) along with this branch.
Since Plexus Archiver seems to in interesting. Why not say:
{noformat}
Build-Tool: Apache Maven ${maven.version} (${commit-id})
Build-Archiver: Plexus Archiver ${pa.version}
Build-Jdk: ${java.version} (${java.vm.vendor})
Build-Os: ${os.name} (${os.version}; (${os.arch})
{noformat}
The prefix is completely consistent. Note: {{Build-Jdk}} will overwrite the
value you have changed recently.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749275#comment-16749275
]
Hervé Boutemy commented on MSHARED-787:
---
to me, "Created By: Plexus Archiver " is
reproducible
then for MSHARED-362 either we keep this default value, either we remove this
entry in maven-archiver by default
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749270#comment-16749270
]
Hervé Boutemy commented on MSHARED-787:
---
"Created-By" is defined by Plexus Archiver: it's only overridden in
maven-archiver to provide a better value than the "Plexus Archiver" value
defined by Plexus Archiver
On the proposed value, while at it, consistency with "mvn -v" output can be
interesting: sometimes, the build is done with a SNAPSHOT...
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748161#comment-16748161
]
Michael Osipov commented on MSHARED-787:
[~hboutemy], it is worth (in terms of consistency) to rename {{Created-By}} to
{{Build-Maven}}: {{${maven.version}}} ({{${commit-id}}})?
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748160#comment-16748160
]
Michael Osipov commented on MSHARED-787:
By
bq. while with buildinfo, it will be "the reproducible way"
you mean that this information will be held out of band (outside of the JAR)?
My problem isn't having {{java.specification.version}} by default, but what
benefit gives it to the user when you don't have the {{Build-Maven-Version}}
also.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748081#comment-16748081
]
Hervé Boutemy commented on MSHARED-787:
---
what is important to me is that by default we have only
java.specification.version
but if people configure it, they can get very detailed info like java.version,
os details and so on in Manifest if they want: in Manifest, this will be "the
non-reproducible way", while with buildinfo, it will be "the reproducible way":
it's good to have both options available and people choose their preferred
option
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748067#comment-16748067
]
Michael Osipov commented on MSHARED-787:
I think that many people won't care for the additional file. They be fine with
the info in the manifest. If they don' need it at all, they won't turn it on. I
believe that {{java.version}} is a better value than
{{java.specification.version}} because the source is tested also. It can happen
that code fals on 1.8.120, but work on 1.8.202 because of a fix.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748023#comment-16748023
]
Hervé Boutemy commented on MSHARED-787:
---
the idea currently is to produce a separate buildinfo file instead of putting
everything in the jar: https://reproducible-builds.org/docs/jvm/
with the buildinfo in place for people who want reproducible builds, I'm not
convinced the feature in the manifest is really useful
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738657#comment-16738657
]
Michael Osipov commented on MSHARED-787:
I don't understand your problem. If you don't want it, just don't use it.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738623#comment-16738623
]
Eduardo Pérez Ureta commented on MSHARED-787:
-
You seem to have made it optional, instead of removing it.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738198#comment-16738198
]
Michael Osipov commented on MSHARED-787:
[~edpeur], you obviously did not check what I have done.
* I have removed that entry from Plexus Archiver:
https://github.com/codehaus-plexus/plexus-archiver/commit/b4674dceb0cc737b3623619aed182fa39c697cb4
* The build information is completely optional, and not enabled by default.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737914#comment-16737914
]
Eduardo Pérez Ureta commented on MSHARED-787:
-
Is there any reason to keep Created-By: Plexus Archiver ${version} ?
Should it be removed altogether?
What is the reason to keep:
Build-Os: ${os.name} (${os.version}; (${os.arch})
?
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.3.1
>
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732105#comment-16732105
]
Michael Osipov commented on MSHARED-787:
If I don't hear any objections by the end of next week, I'd go on and merge it.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728832#comment-16728832
]
Michael Osipov commented on MSHARED-787:
I have pushed a new Plexus Archiver branch solving this issue and updated this
branch accordingly. All should be fine now. If all participants agree, I'll fix
Plexus Archiver first and then I can resolve this issue.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest
[
https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728830#comment-16728830
]
Michael Osipov commented on MSHARED-787:
I have now pushed a branch which contains all necessary changes, but the
documentation. What needs to be changed in Plexus Archiver not to add
{{Created-By: Plexus Archiver $\{version\}}}.
> Add optional buildEnvironment information to the manifest
> -
>
> Key: MSHARED-787
> URL: https://issues.apache.org/jira/browse/MSHARED-787
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> People are demanding to have more control about the build information
> (MSHARED-362). We should add the following to control this:
> {{ which is by default disabled. It will
> contain the folling properties (akin to {{mvn- v}}):
> {noformat}
> Created-By: Apache Maven ${maven.version}
> Build-Jdk: ${java.version} (${java.vm.vendor})
> Build-Os: ${os.name} (${os.version}; (${os.arch}){noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
