[jira] [Commented] (MSHARED-826) Require Java 7

2019-12-18 Thread Maarten Mulders (Jira) 


[ 
https://issues.apache.org/jira/browse/MSHARED-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999110#comment-16999110
 ] 

Maarten Mulders commented on MSHARED-826:
-

I think this one can be closed. Maven Shared Utils is on Java 7 now.

> Require Java 7
> --
>
> Key: MSHARED-826
> URL: https://issues.apache.org/jira/browse/MSHARED-826
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-shared-utils
>Reporter: Maarten Mulders
>Assignee: Robert Scholte
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> While working on 
> [MSHARED-822|https://issues.apache.org/jira/browse/MSHARED-822] I noticed 
> that this project still has {{maven.compiler.source}} and 
> {{maven.compiler.target}} on 1.6.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MSHARED-826) Require Java 7

2019-06-11 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/MSHARED-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861246#comment-16861246
 ] 

Hudson commented on MSHARED-826:


Build succeeded in Jenkins: Maven TLP » maven-shared-utils » master #7

See https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/master/7/

> Require Java 7
> --
>
> Key: MSHARED-826
> URL: https://issues.apache.org/jira/browse/MSHARED-826
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-shared-utils
>Reporter: Maarten Mulders
>Assignee: Robert Scholte
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> While working on 
> [MSHARED-822|https://issues.apache.org/jira/browse/MSHARED-822] I noticed 
> that this project still has {{maven.compiler.source}} and 
> {{maven.compiler.target}} on 1.6.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MSHARED-826) Require Java 7

2019-06-08 Thread Maarten Mulders (JIRA) 


[ 
https://issues.apache.org/jira/browse/MSHARED-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859296#comment-16859296
 ] 

Maarten Mulders commented on MSHARED-826:
-

Yep, done. Thanks for the suggestion!

> Require Java 7
> --
>
> Key: MSHARED-826
> URL: https://issues.apache.org/jira/browse/MSHARED-826
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-shared-utils
>Reporter: Maarten Mulders
>Assignee: Robert Scholte
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> While working on 
> [MSHARED-822|https://issues.apache.org/jira/browse/MSHARED-822] I noticed 
> that this project still has {{maven.compiler.source}} and 
> {{maven.compiler.target}} on 1.6.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MSHARED-826) Require Java 7

2019-06-06 Thread Robert Scholte (JIRA) 


[ 
https://issues.apache.org/jira/browse/MSHARED-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858093#comment-16858093
 ] 

Robert Scholte commented on MSHARED-826:


The OsTest only works if the OS class hasn't been loaded yet. To ensure this, 
add the following to the pom:
{code:xml}
  
org.apache.maven.plugins
maven-surefire-plugin

  false

  
{code}

> Require Java 7
> --
>
> Key: MSHARED-826
> URL: https://issues.apache.org/jira/browse/MSHARED-826
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-shared-utils
>Reporter: Maarten Mulders
>Assignee: Robert Scholte
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> While working on 
> [MSHARED-822|https://issues.apache.org/jira/browse/MSHARED-822] I noticed 
> that this project still has {{maven.compiler.source}} and 
> {{maven.compiler.target}} on 1.6.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MSHARED-826) Require Java 7

2019-06-06 Thread Maarten Mulders (JIRA) 


[ 
https://issues.apache.org/jira/browse/MSHARED-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857455#comment-16857455
 ] 

Maarten Mulders commented on MSHARED-826:
-

Currently,  {{OsTest.java}} fails on Java 12 because it alters System 
properties. I don't see how we could fix that without touching {{Os.java}} 
itself. Its Javadoc says that it got copied over from Apache ANT. It appears to 
me that today in ANT, this class has the same testability issues as it has in 
Maven.

So what do we want to do? Refactor the class to make it easier to test? Or 
accept that test coverage drops?

> Require Java 7
> --
>
> Key: MSHARED-826
> URL: https://issues.apache.org/jira/browse/MSHARED-826
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-shared-utils
>Reporter: Maarten Mulders
>Assignee: Robert Scholte
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> While working on 
> [MSHARED-822|https://issues.apache.org/jira/browse/MSHARED-822] I noticed 
> that this project still has {{maven.compiler.source}} and 
> {{maven.compiler.target}} on 1.6.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)