[jira] [Commented] (MWRAPPER-134) Provide a reliable way to determine the Maven Wrapper version
[
https://issues.apache.org/jira/browse/MWRAPPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843693#comment-17843693
]
Nils Breunese commented on MWRAPPER-134:
[~dalbani] See here:
[https://github.com/renovatebot/renovate/discussions/28648]. A colleague of
mine is willing to work on this, but hasn't found the time for it yet.
> Provide a reliable way to determine the Maven Wrapper version
> -
>
> Key: MWRAPPER-134
> URL: https://issues.apache.org/jira/browse/MWRAPPER-134
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Plugin
>Affects Versions: 3.3.0
>Reporter: Nils Breunese
>Assignee: Tamas Cservenak
>Priority: Normal
> Fix For: 3.3.1
>
>
> I use [Renovate|https://github.com/renovatebot/renovate] to automatically
> keep dependencies up-to-date and I noticed that the upgrade to Maven Wrapper
> 3.3.0 removed the {{wrapperUrl}} line from
> {{{}.mvn/wrapper/maven-wrapper.properties{}}}. I guess that is related to
> MWRAPPER-120.
> A couple of my colleagues implemented the support for keeping Maven Wrapper
> up-to-date in Renovate, and I believe Renovate currently determines the
> version of Maven Wrapper based on the {{wrapperUrl}} property, so I think
> that logic may need to be updated after this change. Without the
> {{wrapperUrl}} property, I think currently the only option to determine the
> Maven Wrapper version is parsing the {{mvnw}} / \{{mvnw.cmd}} scripts
> themselves, but that sounds like a clunky and unreliable way.
> In a discussion on the maven-users mailinglist, the idea was posted to add a
> dedicated property for this (e.g. {{{}wrapperVersion{}}}), which can be read
> by external tools.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-134) Provide a reliable way to determine the Maven Wrapper version
[
https://issues.apache.org/jira/browse/MWRAPPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843686#comment-17843686
]
Damiano Albani commented on MWRAPPER-134:
-
{quote}[~breun]
A couple of my colleagues implemented the support for keeping Maven Wrapper
up-to-date in Renovate, and I believe Renovate currently determines the version
of Maven Wrapper based on the {{wrapperUrl}} property, so I think that logic
may need to be updated after this change.
{quote}
Do you have information to share about the change in Renovate Bot to support
this new "wrapperVersion"?
I couldn't find anything relevant on https://github.com/renovatebot/renovate/.
> Provide a reliable way to determine the Maven Wrapper version
> -
>
> Key: MWRAPPER-134
> URL: https://issues.apache.org/jira/browse/MWRAPPER-134
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Plugin
>Affects Versions: 3.3.0
>Reporter: Nils Breunese
>Assignee: Tamas Cservenak
>Priority: Normal
> Fix For: 3.3.1
>
>
> I use [Renovate|https://github.com/renovatebot/renovate] to automatically
> keep dependencies up-to-date and I noticed that the upgrade to Maven Wrapper
> 3.3.0 removed the {{wrapperUrl}} line from
> {{{}.mvn/wrapper/maven-wrapper.properties{}}}. I guess that is related to
> MWRAPPER-120.
> A couple of my colleagues implemented the support for keeping Maven Wrapper
> up-to-date in Renovate, and I believe Renovate currently determines the
> version of Maven Wrapper based on the {{wrapperUrl}} property, so I think
> that logic may need to be updated after this change. Without the
> {{wrapperUrl}} property, I think currently the only option to determine the
> Maven Wrapper version is parsing the {{mvnw}} / \{{mvnw.cmd}} scripts
> themselves, but that sounds like a clunky and unreliable way.
> In a discussion on the maven-users mailinglist, the idea was posted to add a
> dedicated property for this (e.g. {{{}wrapperVersion{}}}), which can be read
> by external tools.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-134) Provide a reliable way to determine the Maven Wrapper version
[
https://issues.apache.org/jira/browse/MWRAPPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839771#comment-17839771
]
ASF GitHub Bot commented on MWRAPPER-134:
-
cstamas merged PR #135:
URL: https://github.com/apache/maven-wrapper/pull/135
> Provide a reliable way to determine the Maven Wrapper version
> -
>
> Key: MWRAPPER-134
> URL: https://issues.apache.org/jira/browse/MWRAPPER-134
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Plugin
>Affects Versions: 3.3.0
>Reporter: Nils Breunese
>Assignee: Tamas Cservenak
>Priority: Normal
> Fix For: 3.3.1
>
>
> I use [Renovate|https://github.com/renovatebot/renovate] to automatically
> keep dependencies up-to-date and I noticed that the upgrade to Maven Wrapper
> 3.3.0 removed the {{wrapperUrl}} line from
> {{{}.mvn/wrapper/maven-wrapper.properties{}}}. I guess that is related to
> MWRAPPER-120.
> A couple of my colleagues implemented the support for keeping Maven Wrapper
> up-to-date in Renovate, and I believe Renovate currently determines the
> version of Maven Wrapper based on the {{wrapperUrl}} property, so I think
> that logic may need to be updated after this change. Without the
> {{wrapperUrl}} property, I think currently the only option to determine the
> Maven Wrapper version is parsing the {{mvnw}} / \{{mvnw.cmd}} scripts
> themselves, but that sounds like a clunky and unreliable way.
> In a discussion on the maven-users mailinglist, the idea was posted to add a
> dedicated property for this (e.g. {{{}wrapperVersion{}}}), which can be read
> by external tools.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-134) Provide a reliable way to determine the Maven Wrapper version
[
https://issues.apache.org/jira/browse/MWRAPPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839722#comment-17839722
]
ASF GitHub Bot commented on MWRAPPER-134:
-
breun commented on PR #135:
URL: https://github.com/apache/maven-wrapper/pull/135#issuecomment-2069725218
@cstamas Thanks, I think this should work! 👍
> Provide a reliable way to determine the Maven Wrapper version
> -
>
> Key: MWRAPPER-134
> URL: https://issues.apache.org/jira/browse/MWRAPPER-134
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Plugin
>Affects Versions: 3.3.0
>Reporter: Nils Breunese
>Assignee: Tamas Cservenak
>Priority: Normal
> Fix For: 3.3.1
>
>
> I use [Renovate|https://github.com/renovatebot/renovate] to automatically
> keep dependencies up-to-date and I noticed that the upgrade to Maven Wrapper
> 3.3.0 removed the {{wrapperUrl}} line from
> {{{}.mvn/wrapper/maven-wrapper.properties{}}}. I guess that is related to
> MWRAPPER-120.
> A couple of my colleagues implemented the support for keeping Maven Wrapper
> up-to-date in Renovate, and I believe Renovate currently determines the
> version of Maven Wrapper based on the {{wrapperUrl}} property, so I think
> that logic may need to be updated after this change. Without the
> {{wrapperUrl}} property, I think currently the only option to determine the
> Maven Wrapper version is parsing the `mvnw` / `./mvnw.bat` scripts
> themselves, but that sounds like a clunky and unreliable way.
> In a discussion on the maven-users mailinglist, the idea was posted to add a
> dedicated property for this (e.g. {{{}wrapperVersion{}}}), which can be read
> by external tools.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-134) Provide a reliable way to determine the Maven Wrapper version
[
https://issues.apache.org/jira/browse/MWRAPPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839675#comment-17839675
]
ASF GitHub Bot commented on MWRAPPER-134:
-
cstamas commented on PR #135:
URL: https://github.com/apache/maven-wrapper/pull/135#issuecomment-2069595291
@breun ping
> Provide a reliable way to determine the Maven Wrapper version
> -
>
> Key: MWRAPPER-134
> URL: https://issues.apache.org/jira/browse/MWRAPPER-134
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Plugin
>Affects Versions: 3.3.0
>Reporter: Nils Breunese
>Assignee: Tamas Cservenak
>Priority: Normal
> Fix For: 3.3.1
>
>
> I use [Renovate|https://github.com/renovatebot/renovate] to automatically
> keep dependencies up-to-date and I noticed that the upgrade to Maven Wrapper
> 3.3.0 removed the {{wrapperUrl}} line from
> {{{}.mvn/wrapper/maven-wrapper.properties{}}}. I guess that is related to
> MWRAPPER-120.
> A couple of my colleagues implemented the support for keeping Maven Wrapper
> up-to-date in Renovate, and I believe Renovate currently determines the
> version of Maven Wrapper based on the {{wrapperUrl}} property, so I think
> that logic may need to be updated after this change. Without the
> {{wrapperUrl}} property, I think currently the only option to determine the
> Maven Wrapper version is parsing the `mvnw` / `./mvnw.bat` scripts
> themselves, but that sounds like a clunky and unreliable way.
> In a discussion on the maven-users mailinglist, the idea was posted to add a
> dedicated property for this (e.g. {{{}wrapperVersion{}}}), which can be read
> by external tools.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-134) Provide a reliable way to determine the Maven Wrapper version
[
https://issues.apache.org/jira/browse/MWRAPPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839673#comment-17839673
]
ASF GitHub Bot commented on MWRAPPER-134:
-
cstamas opened a new pull request, #135:
URL: https://github.com/apache/maven-wrapper/pull/135
That contains the current version of the deployed Maven Wrapper
---
https://issues.apache.org/jira/browse/MWRAPPER-134
> Provide a reliable way to determine the Maven Wrapper version
> -
>
> Key: MWRAPPER-134
> URL: https://issues.apache.org/jira/browse/MWRAPPER-134
> Project: Maven Wrapper
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Nils Breunese
>Assignee: Tamas Cservenak
>Priority: Normal
> Fix For: 3.3.1
>
>
> I use [Renovate|https://github.com/renovatebot/renovate] to automatically
> keep dependencies up-to-date and I noticed that the upgrade to Maven Wrapper
> 3.3.0 removed the {{wrapperUrl}} line from
> {{{}.mvn/wrapper/maven-wrapper.properties{}}}. I guess that is related to
> MWRAPPER-120.
> A couple of my colleagues implemented the support for keeping Maven Wrapper
> up-to-date in Renovate, and I believe Renovate currently determines the
> version of Maven Wrapper based on the {{wrapperUrl}} property, so I think
> that logic may need to be updated after this change. Without the
> {{wrapperUrl}} property, I think currently the only option to determine the
> Maven Wrapper version is parsing the `mvnw` / `./mvnw.bat` scripts
> themselves, but that sounds like a clunky and unreliable way.
> In a discussion on the maven-users mailinglist, the idea was posted to add a
> dedicated property for this (e.g. {{{}wrapperVersion{}}}), which can be read
> by external tools.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
