[jira] [Commented] (MWRAPPER-135) Provide a reliable way to determine the Maven Wrapper type
[ https://issues.apache.org/jira/browse/MWRAPPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847414#comment-17847414 ] ASF GitHub Bot commented on MWRAPPER-135: - cstamas merged PR #140: URL: https://github.com/apache/maven-wrapper/pull/140 > Provide a reliable way to determine the Maven Wrapper type > -- > > Key: MWRAPPER-135 > URL: https://issues.apache.org/jira/browse/MWRAPPER-135 > Project: Maven Wrapper > Issue Type: Task > Components: Maven Wrapper Plugin >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.3.2 > > > Just like MWRAPPER-134 but for type. I completely forgot about this. As this > way, tooling can figure out not only version but type (also for humans, just > peek at properties). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-135) Provide a reliable way to determine the Maven Wrapper type
[
https://issues.apache.org/jira/browse/MWRAPPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847367#comment-17847367
]
Nils Breunese commented on MWRAPPER-135:
Also, if {{wrapper:wrapper}} is run on a project that already contains this
property in {{{}maven-wrapper.properties{}}}(to update Maven Wrapper), would it
make sense to use this type by default when {{type}} is not explicitly set via
{{{}-Dtype={}}}?
> Provide a reliable way to determine the Maven Wrapper type
> --
>
> Key: MWRAPPER-135
> URL: https://issues.apache.org/jira/browse/MWRAPPER-135
> Project: Maven Wrapper
> Issue Type: Task
> Components: Maven Wrapper Plugin
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.3.2
>
>
> Just like MWRAPPER-134 but for type. I completely forgot about this. As this
> way, tooling can figure out not only version but type (also for humans, just
> peek at properties).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-135) Provide a reliable way to determine the Maven Wrapper type
[
https://issues.apache.org/jira/browse/MWRAPPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847365#comment-17847365
]
Nils Breunese commented on MWRAPPER-135:
[~cstamas] I've created a pull request for this feature. Currently the property
name is {{{}distributionType{}}}, because that is also what it is called in the
{{WrapperMojo}} class internally. Do you think that is the best name, or should
it maybe be {{{}wrapperType{}}}?
> Provide a reliable way to determine the Maven Wrapper type
> --
>
> Key: MWRAPPER-135
> URL: https://issues.apache.org/jira/browse/MWRAPPER-135
> Project: Maven Wrapper
> Issue Type: Task
> Components: Maven Wrapper Plugin
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.3.2
>
>
> Just like MWRAPPER-134 but for type. I completely forgot about this. As this
> way, tooling can figure out not only version but type (also for humans, just
> peek at properties).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-135) Provide a reliable way to determine the Maven Wrapper type
[ https://issues.apache.org/jira/browse/MWRAPPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847364#comment-17847364 ] ASF GitHub Bot commented on MWRAPPER-135: - breun opened a new pull request, #140: URL: https://github.com/apache/maven-wrapper/pull/140 Adds `distributionType` to `maven-wrapper.properties`. https://issues.apache.org/jira/browse/MWRAPPER-135 > Provide a reliable way to determine the Maven Wrapper type > -- > > Key: MWRAPPER-135 > URL: https://issues.apache.org/jira/browse/MWRAPPER-135 > Project: Maven Wrapper > Issue Type: Task > Components: Maven Wrapper Plugin >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.3.2 > > > Just like MWRAPPER-134 but for type. I completely forgot about this. As this > way, tooling can figure out not only version but type (also for humans, just > peek at properties). -- This message was sent by Atlassian Jira (v8.20.10#820010)
