[jira] [Commented] (MWRAPPER-86) Trim trailing slash in Repo URL
[
https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823928#comment-17823928
]
ASF GitHub Bot commented on MWRAPPER-86:
bmarwell merged PR #119:
URL: https://github.com/apache/maven-wrapper/pull/119
> Trim trailing slash in Repo URL
> ---
>
> Key: MWRAPPER-86
> URL: https://issues.apache.org/jira/browse/MWRAPPER-86
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Plugin
>Affects Versions: 3.1.1
>Reporter: Björn Michael
>Assignee: Benjamin Marwell
>Priority: Major
>
> If repository URL ends with a trailing slash then the URLs in
> {{maven-wrapper.properties}} contain double slashes.
> E.g. {{MVNW_REPOURL=[https://myrepo.local/]}} ends up with
> {code:java}
> distributionUrl=https://myrepo.local//org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip
> wrapperUrl=https://myrepo.local//org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar{code}
> This also occurs when mirror * URL ends with trailing slash.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-86) Trim trailing slash in Repo URL
[
https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816119#comment-17816119
]
ASF GitHub Bot commented on MWRAPPER-86:
bmarwell opened a new pull request, #119:
URL: https://github.com/apache/maven-wrapper/pull/119
* first commit tries to fixes the problem, except I actually used `- 2`
instead of `- 1`
* Refactored the methods a bit to make them easier to test
* Added a few tests for the most common cases
* Opened a field and method for testing to `protected`
* Don't use too short repo URLs where not even the protocol could fit.
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Trim trailing slash in Repo URL
> ---
>
> Key: MWRAPPER-86
> URL: https://issues.apache.org/jira/browse/MWRAPPER-86
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Plugin
>Affects Versions: 3.1.1
>Reporter: Björn Michael
>Assignee: Benjamin Marwell
>Priority: Major
>
> If repository URL ends with a trailing slash then the URLs in
> {{maven-wrapper.properties}} contain double slashes.
> E.g. {{MVNW_REPOURL=[https://myrepo.local/]}} ends up with
> {code:java}
> distributionUrl=https://myrepo.local//org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip
> wrapperUrl=https://myrepo.local//org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar{code}
> This also occurs when mirror * URL ends with trailing slash.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-86) Trim trailing slash in Repo URL
[
https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654146#comment-17654146
]
Björn Michael commented on MWRAPPER-86:
---
The URLs were corrected manually after the double slashes were discovered.
Examples in [RFC3986|https://www.rfc-editor.org/rfc/rfc3986] use single slash
syntax. {{a/b/c}} and {{a/b//c}} technically represent different paths but are
irrelevant for repository URL here.
??So: yes, it is valid, no, don't use it.??
[https://stackoverflow.com/questions/20523318/is-a-url-with-in-the-path-section-valid]
??As mentioned by
[@RandomBen|https://webmasters.stackexchange.com/questions/8354/what-does-the-double-slash-mean-in-urls/8356#8356],
the double slash is most likely the result of an error somewhere.??
[https://webmasters.stackexchange.com/questions/8354/what-does-a-double-slash-in-the-url-path-mean]
> Trim trailing slash in Repo URL
> ---
>
> Key: MWRAPPER-86
> URL: https://issues.apache.org/jira/browse/MWRAPPER-86
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Plugin
>Affects Versions: 3.1.1
>Reporter: Björn Michael
>Priority: Major
>
> If repository URL ends with a trailing slash then the URLs in
> {{maven-wrapper.properties}} contain double slashes.
> E.g. {{MVNW_REPOURL=[https://myrepo.local/]}} ends up with
> {code:java}
> distributionUrl=https://myrepo.local//org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip
> wrapperUrl=https://myrepo.local//org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar{code}
> This also occurs when mirror * URL ends with trailing slash.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-86) Trim trailing slash in Repo URL
[
https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654023#comment-17654023
]
Michael Osipov commented on MWRAPPER-86:
Which problem do you experience, according to RFC 3986 this is valid.
> Trim trailing slash in Repo URL
> ---
>
> Key: MWRAPPER-86
> URL: https://issues.apache.org/jira/browse/MWRAPPER-86
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Plugin
>Affects Versions: 3.1.1
>Reporter: Björn Michael
>Priority: Major
>
> If repository URL ends with a trailing slash then the URLs in
> {{maven-wrapper.properties}} contain double slashes.
> E.g. {{MVNW_REPOURL=[https://myrepo.local/]}} ends up with
> {code:java}
> distributionUrl=https://myrepo.local//org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip
> wrapperUrl=https://myrepo.local//org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar{code}
> This also occurs when mirror * URL ends with trailing slash.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
