[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656274#comment-17656274 ] Benjamin Marwell commented on MWRAPPER-89: -- fixed with https://github.com/apache/maven-wrapper/commit/8a1ded6cc4de5b2c9e238efe84ae122fdd8db050 > Update maven-parent to v39 > -- > > Key: MWRAPPER-89 > URL: https://issues.apache.org/jira/browse/MWRAPPER-89 > Project: Maven Wrapper > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655129#comment-17655129 ] ASF GitHub Bot commented on MWRAPPER-89: bmarwell merged PR #81: URL: https://github.com/apache/maven-wrapper/pull/81 > Update maven-parent to v39 > -- > > Key: MWRAPPER-89 > URL: https://issues.apache.org/jira/browse/MWRAPPER-89 > Project: Maven Wrapper > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655106#comment-17655106 ] ASF GitHub Bot commented on MWRAPPER-89: bmarwell commented on code in PR #81: URL: https://github.com/apache/maven-wrapper/pull/81#discussion_r1062817962 ## maven-wrapper/src/main/java/org/apache/maven/wrapper/DefaultDownloader.java: ## @@ -1,3 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ Review Comment: Done, I also removed the 3rd commit. It would have worked without squashing (e.g. fast-forward) and without rebasing. > Update maven-parent to v39 > -- > > Key: MWRAPPER-89 > URL: https://issues.apache.org/jira/browse/MWRAPPER-89 > Project: Maven Wrapper > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655086#comment-17655086 ] ASF GitHub Bot commented on MWRAPPER-89: slawekjaranowski commented on code in PR #81: URL: https://github.com/apache/maven-wrapper/pull/81#discussion_r1062764007 ## maven-wrapper/src/main/java/org/apache/maven/wrapper/DefaultDownloader.java: ## @@ -1,3 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ Review Comment: Pleas check for duplicate license header ... > Update maven-parent to v39 > -- > > Key: MWRAPPER-89 > URL: https://issues.apache.org/jira/browse/MWRAPPER-89 > Project: Maven Wrapper > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654937#comment-17654937 ] ASF GitHub Bot commented on MWRAPPER-89: bmarwell commented on PR #81: URL: https://github.com/apache/maven-wrapper/pull/81#issuecomment-1372137154 > Please create two commits - one with upgrade and one with refactor Second commit with refactor can be added to excluded from git blame > > https://maven.apache.org/pom/maven/#the-format-profile done > Update maven-parent to v39 > -- > > Key: MWRAPPER-89 > URL: https://issues.apache.org/jira/browse/MWRAPPER-89 > Project: Maven Wrapper > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654934#comment-17654934 ] ASF GitHub Bot commented on MWRAPPER-89: slawekjaranowski commented on PR #81: URL: https://github.com/apache/maven-wrapper/pull/81#issuecomment-1372125545 Please create two commits - one with upgrade and one with refactor Second commit with refactor can be added to excluded from git blame https://maven.apache.org/pom/maven/#the-format-profile > Update maven-parent to v39 > -- > > Key: MWRAPPER-89 > URL: https://issues.apache.org/jira/browse/MWRAPPER-89 > Project: Maven Wrapper > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654927#comment-17654927 ] ASF GitHub Bot commented on MWRAPPER-89: bmarwell opened a new pull request, #81: URL: https://github.com/apache/maven-wrapper/pull/81 We need (should use) v38+ for this PR: https://github.com/apache/maven-wrapper/pull/61 However, v39 requires the new style to be applied. --- Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Update maven-parent to v39 > -- > > Key: MWRAPPER-89 > URL: https://issues.apache.org/jira/browse/MWRAPPER-89 > Project: Maven Wrapper > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
