[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
[ https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325238#comment-16325238 ] Hudson commented on SUREFIRE-1403: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=578ada73b724151f0cbce3b6ae39e55d242ef430]) * (add) surefire-booter/src/test/resources/jdk/bin/java * (edit) maven-surefire-common/pom.xml * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java * (edit) maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml * (edit) surefire-api/pom.xml * (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java * (edit) surefire-booter/pom.xml * (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml * (edit) README.md * (add) surefire-booter/src/test/resources/jdk8-oracle/release * (add) surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java * (delete) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java * (add) surefire-booter/src/test/resources/jdk8-IBM/release * (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java * (edit) pom.xml * (add) surefire-booter/src/test/resources/jdk/jre/bin/java * (edit) maven-surefire-plugin/src/site/site.xml * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java * (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb * (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java * (edit) surefire-setup-integration-tests/pom.xml * (edit) maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java * (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java * (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml * (add) maven-surefire-plugin/src/site/markdown/java9.md * (add) surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java * (add) surefire-booter/src/test/resources/jdk9-oracle/release * (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java * (edit) maven-surefire-plugin/pom.xml * (edit) surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java * (edit) maven-failsafe-plugin/pom.xml * (edit) surefire-integration-tests/pom.xml * (edit) maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java * (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java [Agreed with Oracle] [SUREFIRE-1403] [Jigsaw] [Java 9] add (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=0635d25e9d273c48196c1c9cb40eefc38393daba]) * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java [Agreed with Oracle] [SUREFIRE-1403] [DOC] [Jigsaw] [Java 9] add (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=100f696029a53d57dbacd0f3962f3c305891588c]) * (edit) maven-surefire-plugin/src/site/markdown/java9.md > [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument > --- > > Key: SUREFIRE-1403 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1403 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.1 > > Attachments: surefire-1403.zip > > > Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not > help and does not do anything because the module is ignored in Java
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303341#comment-16303341
]
Enrico Olivelli commented on SUREFIRE-1403:
---
David, please see comments above.
We have dropped this implementation on master brach.
We will release a new version as soon as possible.
Maybe you can give a try to current master
> [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules java.se.ee}}
> The fix would be to add "--add-modules java.se.ee" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303335#comment-16303335
]
David J. M. Karlsen commented on SUREFIRE-1403:
---
I don't think surefire should force any modules onto the user - the user should
control the environment. See https://github.com/JavaMoney/jsr354-ri/issues/178
which will fail with surefire 2.20.1 but pass with 2.20
> [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules java.se.ee}}
> The fix would be to add "--add-modules java.se.ee" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289207#comment-16289207
]
Enrico Olivelli commented on SUREFIRE-1403:
---
This has already been fixed on master branch.
I hope we will have a release soon.
The fix is to revert thus issue basically
> [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules java.se.ee}}
> The fix would be to add "--add-modules java.se.ee" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288995#comment-16288995
]
Jan Bartel commented on SUREFIRE-1403:
--
The solution to add java.se.ee to the surefire command line is not a good idea
IMHO. The java.se.ee module is scheduled for removal from the jdk. Moreover it
does not contain all necessary ee classes (for example it only contains a
couple of javax.transaction exception classes and not the whole
javax.transaction package). The latter causes problems if you're trying to unit
test with a jdk 1.9 jvm - because surefire puts the java.se.ee module onto the
modulepath it ignores any other jars on the classpath that actually have the
full javax.transaction package in it and you get class does not exist
exceptions. I've had to back down to surefire 2.20 because of this problem in
some of the jetty unit tests.
See http://openjdk.java.net/jeps/320 for info on the java.se.ee debacle.
> [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules java.se.ee}}
> The fix would be to add "--add-modules java.se.ee" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160553#comment-16160553
]
Hudson commented on SUREFIRE-1403:
--
SUCCESS: Integrated in Jenkins build maven-surefire #1757 (See
[https://builds.apache.org/job/maven-surefire/1757/])
[Agreed with Oracle] [SUREFIRE-1403] [Jigsaw] [Java 9] add (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=0635d25e9d273c48196c1c9cb40eefc38393daba])
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
[Agreed with Oracle] [SUREFIRE-1403] [DOC] [Jigsaw] [Java 9] add (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=100f696029a53d57dbacd0f3962f3c305891588c])
* (edit) maven-surefire-plugin/src/site/markdown/java9.md
> [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules java.se.ee}}
> The fix would be to add "--add-modules java.se.ee" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
