[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-12-03 Thread Matthew Wang (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243591#comment-17243591
 ] 

Matthew Wang commented on SUREFIRE-1840:


I have submitted a PR with the aforementioned change.

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-12-01 Thread Matthew Wang (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241328#comment-17241328
 ] 

Matthew Wang commented on SUREFIRE-1840:


I am new to working with the website and the maven build system in general, so 
I'm having difficulty running the surefire website locally to view changes.

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-28 Thread Matthew Wang (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240064#comment-17240064
 ] 

Matthew Wang commented on SUREFIRE-1840:


I will see to reflecting that information on the website.

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-28 Thread Sebb (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239939#comment-17239939
 ] 

Sebb commented on SUREFIRE-1840:


I'm not saying sudo should be removed, merely that the reason for it should be 
documented.
Since it appears it is only required on Linux, that should be noted.

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-27 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239833#comment-17239833
 ] 

Tibor Digana commented on SUREFIRE-1840:


[~sebb]
[~mslwang]
If you guys both would agree on removing sudo, feel free to open a pullrequest 
on Github.
It is a little change but it has to work for our users.
T

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-27 Thread Matthew Wang (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239830#comment-17239830
 ] 

Matthew Wang commented on SUREFIRE-1840:


Still helpful for anyone setting it up.

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-27 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239825#comment-17239825
 ] 

Tibor Digana commented on SUREFIRE-1840:


[~mslwang]
;-) but again, we did not post the web site as a Docker tutorial, ;-), it has 
another purpose than teaching dev on how to use Docker.
It is just the marketing.
People usually use Maven in Carlo's docker images...

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-27 Thread Matthew Wang (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239821#comment-17239821
 ] 

Matthew Wang commented on SUREFIRE-1840:


In terms of what to modify in the website, it's possible that highlighting OS 
differences would be valuable.

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-27 Thread Matthew Wang (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239819#comment-17239819
 ] 

Matthew Wang commented on SUREFIRE-1840:


So, I currently mainly use Manjaro Linux, but I do have a Mac, so I will say 
that I have encountered both usages.

 

After doing some looking, here is the reasoning docker on Linux and macOS act 
differently:

[https://www.amazee.io/blog/post/docker-on-mac-performance-docker-machine-vs-docker-for-mac]
 

 

" On Linux systems, Docker directly leverages the kernel of the host system, 
and file system mounts are native.
 
On Windows and Mac, it’s slightly different. These operating systems do not 
provide a Linux Kernel, so Docker starts a virtual machine with a small Linux 
installed and runs Docker containers in there. File system mounts are also not 
possible natively and need a helper-system in between, which both Docker and 
Cachalot provide."

 

I ran `docker build` on my Linux system without sudo and it denied permission 
since I'd assume the Docker daemon runs directly on the Linux system instead of 
in a VM, which I'd assume affects how users interact with docker from the 
outside.

 

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-27 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239811#comment-17239811
 ] 

Tibor Digana commented on SUREFIRE-1840:


[~sebb]
Use sudo or not, it's your job!
You do not understand the reason why this page exists.
The page doe not tell you HOW you should use Docker. It tells you that now it 
is possible to use Maven build in Docker container.
It is whole marketing point.
Some old versions were unstable due to they used PPID checker which killed the 
JVM. We disabled the checker, every user can enable the checked in the config, 
but the important message is that these problems are gone. Whole marketing 
trick, nothing more!

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-27 Thread Sebb (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239717#comment-17239717
 ] 

Sebb commented on SUREFIRE-1840:


Two comments:

1) I use Docker on macOS, and sudo is NOT needed for building or running.

2) The reason for requiring sudo needs to be explained on the website, not just 
here

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Assignee: Tibor Digana
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-26 Thread Matthew Wang (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239558#comment-17239558
 ] 

Matthew Wang commented on SUREFIRE-1840:


I would expect that this is because the docker daemon generally requires root 
level privileges.

For more information (~5 years old, but still applies from what I've seen):

[https://unix.stackexchange.com/questions/156938/why-does-docker-need-root-privileges]

Using docker without sudo/ root level access is currently experimental.

[https://docs.docker.com/engine/security/rootless/] 

> Why sudo docker?
> 
>
> Key: SUREFIRE-1840
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1840
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sebb
>Priority: Major
>  Labels: up-for-grabs
>
> The page
> https://maven.apache.org/surefire/maven-surefire-plugin/docker.html
> says
> "$ sudo docker build --no-cache -t my-image:1 -f ./Dockerfile ."
> Is sudo really needed here?
> If so, the reason should be explained and any limitations noted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)