[jira] [Commented] (SUREFIRE-1911) Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468167#comment-17468167
]
Jesse Glick commented on SUREFIRE-1911:
---
Good to know that is a resolution once the problem is noticed, but it is still
very dangerous for the mojo to silently decline to run any tests.
> Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
> --
>
> Key: SUREFIRE-1911
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1911
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Jesse Glick
>Assignee: Tibor Digana
>Priority: Major
> Labels: regression
>
> Using Maven 3.8.1 and JDK 8,
> https://github.com/jenkins-infra/pipeline-library/commit/48fc69bdd3f7e3adbebea76b8bf68edfe5ed3e32
> causes {{mvn test}} to not do anything:
> {code:none}
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {code}
> In 3.0.0-M3, or for that matter 3.0.0-M4, this runs a variety of tests as
> expected. {{git bisect}} points to the fix of SUREFIRE-1787 as the culprit:
> {code:none}
> d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041 is the first bad commit
> commit d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041
> Author: tibordigana
> Date: Sat May 2 13:08:16 2020 +0200
> [SUREFIRE-1787] Support multiple runners (JUnit4, TestNG, other) and
> their API in JUnit5 Provider
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-1911) Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467300#comment-17467300
]
Réda Housni Alaoui commented on SUREFIRE-1911:
--
Here is the associated pull request =>
https://github.com/jenkins-infra/pipeline-library/pull/272
> Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
> --
>
> Key: SUREFIRE-1911
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1911
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Jesse Glick
>Assignee: Tibor Digana
>Priority: Major
> Labels: regression
>
> Using Maven 3.8.1 and JDK 8,
> https://github.com/jenkins-infra/pipeline-library/commit/48fc69bdd3f7e3adbebea76b8bf68edfe5ed3e32
> causes {{mvn test}} to not do anything:
> {code:none}
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {code}
> In 3.0.0-M3, or for that matter 3.0.0-M4, this runs a variety of tests as
> expected. {{git bisect}} points to the fix of SUREFIRE-1787 as the culprit:
> {code:none}
> d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041 is the first bad commit
> commit d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041
> Author: tibordigana
> Date: Sat May 2 13:08:16 2020 +0200
> [SUREFIRE-1787] Support multiple runners (JUnit4, TestNG, other) and
> their API in JUnit5 Provider
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-1911) Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467297#comment-17467297
]
Réda Housni Alaoui commented on SUREFIRE-1911:
--
[~jgl...@netbeans.org] , I don't know if you tried it, but adding
junit-vintage-engine fixes the issue of
[https://github.com/jenkins-infra/pipeline-library/commit/48fc69bdd3f7e3adbebea76b8bf68edfe5ed3e32]
. I just tested that.
> Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
> --
>
> Key: SUREFIRE-1911
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1911
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Jesse Glick
>Assignee: Tibor Digana
>Priority: Major
> Labels: regression
>
> Using Maven 3.8.1 and JDK 8,
> https://github.com/jenkins-infra/pipeline-library/commit/48fc69bdd3f7e3adbebea76b8bf68edfe5ed3e32
> causes {{mvn test}} to not do anything:
> {code:none}
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {code}
> In 3.0.0-M3, or for that matter 3.0.0-M4, this runs a variety of tests as
> expected. {{git bisect}} points to the fix of SUREFIRE-1787 as the culprit:
> {code:none}
> d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041 is the first bad commit
> commit d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041
> Author: tibordigana
> Date: Sat May 2 13:08:16 2020 +0200
> [SUREFIRE-1787] Support multiple runners (JUnit4, TestNG, other) and
> their API in JUnit5 Provider
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-1911) Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411203#comment-17411203
]
Jesse Glick commented on SUREFIRE-1911:
---
Struck again, this time in Jenkins core, and apparently causing Java-based
JUnit 4 tests to be silently skipped:
* https://github.com/jnr/jnr-ffi/pull/269
* https://github.com/jenkinsci/jenkins/pull/5703
* https://github.com/jenkinsci/jenkins/pull/5712
* https://github.com/jenkinsci/jenkins/pull/5713
> Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
> --
>
> Key: SUREFIRE-1911
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1911
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Jesse Glick
>Assignee: Tibor Digana
>Priority: Major
> Labels: regression
>
> Using Maven 3.8.1 and JDK 8,
> https://github.com/jenkins-infra/pipeline-library/commit/48fc69bdd3f7e3adbebea76b8bf68edfe5ed3e32
> causes {{mvn test}} to not do anything:
> {code:none}
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {code}
> In 3.0.0-M3, or for that matter 3.0.0-M4, this runs a variety of tests as
> expected. {{git bisect}} points to the fix of SUREFIRE-1787 as the culprit:
> {code:none}
> d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041 is the first bad commit
> commit d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041
> Author: tibordigana
> Date: Sat May 2 13:08:16 2020 +0200
> [SUREFIRE-1787] Support multiple runners (JUnit4, TestNG, other) and
> their API in JUnit5 Provider
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1911) Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407518#comment-17407518
]
Robert Sandiford commented on SUREFIRE-1911:
Perhaps related. Using Spring Boot 2.5.4, with maven-surefire-plugin 3.0.0.M5,
and spring-boot-starter-test.
Unit tests won't run - same output as above, 0 tests run, 0 failures, 0 errors.
changing to maven-surefire-plugin 3.0.0.M4 works fine. (This was detected
while upgrading dependencies in an existing maven based project).
I was able to work around the issue by changing the spring-boot-starter-test
dependency to exclude the junit components, like this:
{quote}{{}}
{{ org.springframework.boot}}
{{ spring-boot-starter-test}}
{{ ${spring-boot.version}}}
{{ }}
{{ }}
{{ org.junit.jupiter}}
{{ junit-jupiter}}
{{ }}
{{ }}
{{ org.mockito}}
{{ mockito-junit-jupiter}}
{{ }}
{{ }}
{{}}{quote}
> Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
> --
>
> Key: SUREFIRE-1911
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1911
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Jesse Glick
>Assignee: Tibor Digana
>Priority: Major
> Labels: regression
>
> Using Maven 3.8.1 and JDK 8,
> https://github.com/jenkins-infra/pipeline-library/commit/48fc69bdd3f7e3adbebea76b8bf68edfe5ed3e32
> causes {{mvn test}} to not do anything:
> {code:none}
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {code}
> In 3.0.0-M3, or for that matter 3.0.0-M4, this runs a variety of tests as
> expected. {{git bisect}} points to the fix of SUREFIRE-1787 as the culprit:
> {code:none}
> d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041 is the first bad commit
> commit d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041
> Author: tibordigana
> Date: Sat May 2 13:08:16 2020 +0200
> [SUREFIRE-1787] Support multiple runners (JUnit4, TestNG, other) and
> their API in JUnit5 Provider
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1911) Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346381#comment-17346381
]
Jesse Glick commented on SUREFIRE-1911:
---
{code:none}
$ mvn dependency:tree
…
[INFO] io.jenkins.infra:pipeline-library:jar:0.0.1
[INFO] +- org.codehaus.groovy:groovy-all:pom:3.0.7:test
…
[INFO] | +- org.codehaus.groovy:groovy-test:jar:3.0.7:test
[INFO] | | \- junit:junit:jar:4.13.1:test
[INFO] | | \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] | +- org.codehaus.groovy:groovy-test-junit5:jar:3.0.7:test
[INFO] | | +- org.junit.platform:junit-platform-launcher:jar:1.7.0:test
[INFO] | | | \- org.junit.platform:junit-platform-engine:jar:1.7.0:test
[INFO] | | \- org.junit.jupiter:junit-jupiter-engine:jar:5.7.0:test
…
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.7.0:test
[INFO] | +- org.apiguardian:apiguardian-api:jar:1.1.0:test
[INFO] | +- org.opentest4j:opentest4j:jar:1.2.0:test
[INFO] | \- org.junit.platform:junit-platform-commons:jar:1.7.0:test
…
{code}
> Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
> --
>
> Key: SUREFIRE-1911
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1911
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Jesse Glick
>Assignee: Tibor Digana
>Priority: Major
> Labels: regression
>
> Using Maven 3.8.1 and JDK 8,
> https://github.com/jenkins-infra/pipeline-library/commit/48fc69bdd3f7e3adbebea76b8bf68edfe5ed3e32
> causes {{mvn test}} to not do anything:
> {code:none}
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {code}
> In 3.0.0-M3, or for that matter 3.0.0-M4, this runs a variety of tests as
> expected. {{git bisect}} points to the fix of SUREFIRE-1787 as the culprit:
> {code:none}
> d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041 is the first bad commit
> commit d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041
> Author: tibordigana
> Date: Sat May 2 13:08:16 2020 +0200
> [SUREFIRE-1787] Support multiple runners (JUnit4, TestNG, other) and
> their API in JUnit5 Provider
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1911) Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337647#comment-17337647
]
Tibor Digana commented on SUREFIRE-1911:
[~jgl...@netbeans.org]
I have analysed the POM but I did not see any transient {{junit:junit}} nor the
{{junit-vintage-engine}}.
Maybe your groovy compler is able to compile the code including
{{@org.junit.Test}} because the compiler dependencies have the transitive junit
dependency. Pls have a look again, thx.
> Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
> --
>
> Key: SUREFIRE-1911
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1911
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Jesse Glick
>Assignee: Tibor Digana
>Priority: Major
> Labels: regression
>
> Using Maven 3.8.1 and JDK 8,
> https://github.com/jenkins-infra/pipeline-library/commit/48fc69bdd3f7e3adbebea76b8bf68edfe5ed3e32
> causes {{mvn test}} to not do anything:
> {code:none}
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {code}
> In 3.0.0-M3, or for that matter 3.0.0-M4, this runs a variety of tests as
> expected. {{git bisect}} points to the fix of SUREFIRE-1787 as the culprit:
> {code:none}
> d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041 is the first bad commit
> commit d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041
> Author: tibordigana
> Date: Sat May 2 13:08:16 2020 +0200
> [SUREFIRE-1787] Support multiple runners (JUnit4, TestNG, other) and
> their API in JUnit5 Provider
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
