[jira] [Commented] (SUREFIRE-2097) More configuration for surefire JPMS
[ https://issues.apache.org/jira/browse/SUREFIRE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748544#comment-17748544 ] Martin Desruisseaux commented on SUREFIRE-2097: --- Thanks for the reply! Does it means that MNG-7855 issue is actually a {{plexus-languages}} issue? In that case, do you know if there is anyway to tell plexus to put dependencies on the module-path rather than class-path? > More configuration for surefire JPMS > > > Key: SUREFIRE-2097 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2097 > Project: Maven Surefire > Issue Type: Improvement >Affects Versions: 3.0.0-M7 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > > Currently surefire manages the build of module path and classpath graph with > almost not configurable option. > Due to long time between M5 and M6 releases while in the meantime plexus-java > has incorporated a lot changes (for compiler, javadoc), those release has > created some backward incompatible changes which are affecting some users > such: > - https://issues.apache.org/jira/browse/SUREFIRE-2057 > - comments here [https://github.com/eclipse/jetty.project/pull/8129] > So we need few more options to be able to configure some of the assumptions > which has been made and changed in plexus-java. > Because the current configuration is hardcoded: > {code:java} > ResolvePathsRequest req = ResolvePathsRequest.ofStrings( > testClasspath.getClassPath() ) > .setIncludeAllProviders( true ) > .setJdkHome( javaHome ) > .setIncludeStatic( true ) > .setModuleDescriptor( javaModuleDescriptor ); > {code} > We must give users some options to override the black magic made by > plexus-java. > Options to configure: > - force all test/provided scope to be in classpath or not > - do not add automatically providers to the module path > - a possible list per groupId/artifactId to force module path or classpath > - etc... > The idea here is too collect what users need. > Remember we will try to avoid too much complicated options :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2097) More configuration for surefire JPMS
[ https://issues.apache.org/jira/browse/SUREFIRE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748510#comment-17748510 ] Olivier Lamy commented on SUREFIRE-2097: Well actually it's not exactly the same issue :) The MNG issue will have a more generic setup but currently it's done by https://github.com/codehaus-plexus/plexus-languages. > More configuration for surefire JPMS > > > Key: SUREFIRE-2097 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2097 > Project: Maven Surefire > Issue Type: Improvement >Affects Versions: 3.0.0-M7 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > > Currently surefire manages the build of module path and classpath graph with > almost not configurable option. > Due to long time between M5 and M6 releases while in the meantime plexus-java > has incorporated a lot changes (for compiler, javadoc), those release has > created some backward incompatible changes which are affecting some users > such: > - https://issues.apache.org/jira/browse/SUREFIRE-2057 > - comments here [https://github.com/eclipse/jetty.project/pull/8129] > So we need few more options to be able to configure some of the assumptions > which has been made and changed in plexus-java. > Because the current configuration is hardcoded: > {code:java} > ResolvePathsRequest req = ResolvePathsRequest.ofStrings( > testClasspath.getClassPath() ) > .setIncludeAllProviders( true ) > .setJdkHome( javaHome ) > .setIncludeStatic( true ) > .setModuleDescriptor( javaModuleDescriptor ); > {code} > We must give users some options to override the black magic made by > plexus-java. > Options to configure: > - force all test/provided scope to be in classpath or not > - do not add automatically providers to the module path > - a possible list per groupId/artifactId to force module path or classpath > - etc... > The idea here is too collect what users need. > Remember we will try to avoid too much complicated options :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2097) More configuration for surefire JPMS
[ https://issues.apache.org/jira/browse/SUREFIRE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748204#comment-17748204 ] Martin Desruisseaux commented on SUREFIRE-2097: --- This issue seems related to MNG-7855 (dependencies wrongly put on class-path rather than module-path). I think that in those two issues, the problem is that the developer has no way (as far as I know) to overwrite Maven black magic by the developer's intend. When the black magic is wrong, the developer is blocked from using JPMS in the context of a Maven project, unless "polluting" the libraries with a bit risky workaround. > More configuration for surefire JPMS > > > Key: SUREFIRE-2097 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2097 > Project: Maven Surefire > Issue Type: Improvement >Affects Versions: 3.0.0-M7 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > > Currently surefire manages the build of module path and classpath graph with > almost not configurable option. > Due to long time between M5 and M6 releases while in the meantime plexus-java > has incorporated a lot changes (for compiler, javadoc), those release has > created some backward incompatible changes which are affecting some users > such: > - https://issues.apache.org/jira/browse/SUREFIRE-2057 > - comments here [https://github.com/eclipse/jetty.project/pull/8129] > So we need few more options to be able to configure some of the assumptions > which has been made and changed in plexus-java. > Because the current configuration is hardcoded: > {code:java} > ResolvePathsRequest req = ResolvePathsRequest.ofStrings( > testClasspath.getClassPath() ) > .setIncludeAllProviders( true ) > .setJdkHome( javaHome ) > .setIncludeStatic( true ) > .setModuleDescriptor( javaModuleDescriptor ); > {code} > We must give users some options to override the black magic made by > plexus-java. > Options to configure: > - force all test/provided scope to be in classpath or not > - do not add automatically providers to the module path > - a possible list per groupId/artifactId to force module path or classpath > - etc... > The idea here is too collect what users need. > Remember we will try to avoid too much complicated options :) -- This message was sent by Atlassian Jira (v8.20.10#820010)