[jira] [Updated] (MENFORCER-247) Add a "require file checksum" rule
[ https://issues.apache.org/jira/browse/MENFORCER-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Connolly updated MENFORCER-247: --- Fix Version/s: 3.0.0 > Add a "require file checksum" rule > -- > > Key: MENFORCER-247 > URL: https://issues.apache.org/jira/browse/MENFORCER-247 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Reporter: Lyubomyr Shaydariv >Assignee: Guillaume Boué > Fix For: 1.4.2, 3.0.0 > > Attachments: require.file.checksum.patch > > > Hi. > Sometimes there is a need to have a rule to check a file against a predefined > checksum. Let's say, a result of a generated file in the build output > directory is expected to result in a required checksum, or some source/test > files must result in predefined checksums. I've came across such a rule on > GitHub https://github.com/esamson/checksum-enforcer-rule and I think it would > be nice to have this one as a standard rule. > What I've done already: > * Adapted the original source to the source code base in > http://svn.apache.org/repos/asf/maven/enforcer/trunk (1.4.2-SNAPSHOT) > * Added Apache Commons Codec 1.6 dependency thus adding support for MD5, > SHA-1, SHA-256, SHA-384, SHA-512 > * Added some tests > * Added an example for all hashing functions to the generated site. > What I'm not sure about: > * Would you accept this feature as one that's worth be a part of standard > rules. > * If so, I'm not sure if https://github.com/apache/maven-enforcer accepts > pull requests as I've noticed probably automatically generated `git-svn-id` > field in `git log` output. So probably the patch might be committed to the > Subversion repository first. > Here is the patch diff on GitHub: > https://github.com/lyubomyr-shaydariv/maven-enforcer/commit/86ed97423b5c64625f700c3afe555c02d6c619df -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (MENFORCER-247) Add a "require file checksum" rule
[ https://issues.apache.org/jira/browse/MENFORCER-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyubomyr Shaydariv updated MENFORCER-247: - Attachment: require.file.checksum.patch [~khmarbaise] hi, thank you for the feedback. I've just fixed the tests following your suggestion on GitHub. Please see the attached `require.file.checksum.patch` generated with `git diff HEAD~2` in my repo including both initial `86ed97423b5c64625f700c3afe555c02d6c619df` and `2723f8c2add0e832f9304720bae82d7cce0c4b76` commits. Not sure if git-generated patches are fine for Subversion. > Add a "require file checksum" rule > -- > > Key: MENFORCER-247 > URL: https://issues.apache.org/jira/browse/MENFORCER-247 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Reporter: Lyubomyr Shaydariv > Attachments: require.file.checksum.patch > > > Hi. > Sometimes there is a need to have a rule to check a file against a predefined > checksum. Let's say, a result of a generated file in the build output > directory is expected to result in a required checksum, or some source/test > files must result in predefined checksums. I've came across such a rule on > GitHub https://github.com/esamson/checksum-enforcer-rule and I think it would > be nice to have this one as a standard rule. > What I've done already: > * Adapted the original source to the source code base in > http://svn.apache.org/repos/asf/maven/enforcer/trunk (1.4.2-SNAPSHOT) > * Added Apache Commons Codec 1.6 dependency thus adding support for MD5, > SHA-1, SHA-256, SHA-384, SHA-512 > * Added some tests > * Added an example for all hashing functions to the generated site. > What I'm not sure about: > * Would you accept this feature as one that's worth be a part of standard > rules. > * If so, I'm not sure if https://github.com/apache/maven-enforcer accepts > pull requests as I've noticed probably automatically generated `git-svn-id` > field in `git log` output. So probably the patch might be committed to the > Subversion repository first. > Here is the patch diff on GitHub: > https://github.com/lyubomyr-shaydariv/maven-enforcer/commit/86ed97423b5c64625f700c3afe555c02d6c619df -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MENFORCER-247) Add a "require file checksum" rule
[ https://issues.apache.org/jira/browse/MENFORCER-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyubomyr Shaydariv updated MENFORCER-247: - Description: Hi. Sometimes there is a need to have a rule to check a file against a predefined checksum. Let's say, a result of a generated file in the build output directory is expected to result in a required checksum, or some source/test files must result in predefined checksums. I've came across such a rule on GitHub https://github.com/esamson/checksum-enforcer-rule and I think it would be nice to have this one as a standard rule. What I've done already: * Adapted the original source to the source code base in http://svn.apache.org/repos/asf/maven/enforcer/trunk (1.4.2-SNAPSHOT) * Added Apache Commons Codec 1.6 dependency thus adding support for MD5, SHA-1, SHA-256, SHA-384, SHA-512 * Added some tests * Added an example for all hashing functions to the generated site. What I'm not sure about: * Would you accept this feature as one that's worth be a part of standard rules. * If so, I'm not sure if https://github.com/apache/maven-enforcer accepts pull requests as I've noticed probably automatically generated `git-svn-id` field in `git log` output. So probably the patch might be committed to the Subversion repository first. Here is the patch diff on GitHub: https://github.com/lyubomyr-shaydariv/maven-enforcer/commit/86ed97423b5c64625f700c3afe555c02d6c619df was: Hi. Sometimes there is a need to have a rule to check a file against a predefined checksum. Let's say, a result of a generated file in the build output directory is expected to result in a required checksum, or some source/test files must result in predefined checksums. I've came across such a rule on GitHub https://github.com/esamson/checksum-enforcer-rule and I think it would be nice to have this one as a standard rule. What I've done already: * Adapted the original source to the source code base in http://svn.apache.org/repos/asf/maven/enforcer/trunk * Added Apache Commons Codec 1.6 dependency thus adding support for MD5, SHA-1, SHA-256, SHA-384, SHA-512 * Added some tests * Added an example for all hashing functions to the generated site. What I'm not sure about: * Would you accept this feature as one that's worth be a part of standard rules. * If so, I'm not sure if https://github.com/apache/maven-enforcer accepts pull requests as I've noticed probably automatically generated `git-svn-id` field in `git log` output. So probably the patch might be committed to the Subversion repository first. Here is the patch diff on GitHub: https://github.com/lyubomyr-shaydariv/maven-enforcer/commit/86ed97423b5c64625f700c3afe555c02d6c619df > Add a "require file checksum" rule > -- > > Key: MENFORCER-247 > URL: https://issues.apache.org/jira/browse/MENFORCER-247 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Reporter: Lyubomyr Shaydariv > > Hi. > Sometimes there is a need to have a rule to check a file against a predefined > checksum. Let's say, a result of a generated file in the build output > directory is expected to result in a required checksum, or some source/test > files must result in predefined checksums. I've came across such a rule on > GitHub https://github.com/esamson/checksum-enforcer-rule and I think it would > be nice to have this one as a standard rule. > What I've done already: > * Adapted the original source to the source code base in > http://svn.apache.org/repos/asf/maven/enforcer/trunk (1.4.2-SNAPSHOT) > * Added Apache Commons Codec 1.6 dependency thus adding support for MD5, > SHA-1, SHA-256, SHA-384, SHA-512 > * Added some tests > * Added an example for all hashing functions to the generated site. > What I'm not sure about: > * Would you accept this feature as one that's worth be a part of standard > rules. > * If so, I'm not sure if https://github.com/apache/maven-enforcer accepts > pull requests as I've noticed probably automatically generated `git-svn-id` > field in `git log` output. So probably the patch might be committed to the > Subversion repository first. > Here is the patch diff on GitHub: > https://github.com/lyubomyr-shaydariv/maven-enforcer/commit/86ed97423b5c64625f700c3afe555c02d6c619df -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MENFORCER-247) Add a "require file checksum" rule
[ https://issues.apache.org/jira/browse/MENFORCER-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyubomyr Shaydariv updated MENFORCER-247: - Affects Version/s: (was: 1.4.2) > Add a "require file checksum" rule > -- > > Key: MENFORCER-247 > URL: https://issues.apache.org/jira/browse/MENFORCER-247 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Reporter: Lyubomyr Shaydariv > > Hi. > Sometimes there is a need to have a rule to check a file against a predefined > checksum. Let's say, a result of a generated file in the build output > directory is expected to result in a required checksum, or some source/test > files must result in predefined checksums. I've came across such a rule on > GitHub https://github.com/esamson/checksum-enforcer-rule and I think it would > be nice to have this one as a standard rule. > What I've done already: > * Adapted the original source to the source code base in > http://svn.apache.org/repos/asf/maven/enforcer/trunk > * Added Apache Commons Codec 1.6 dependency thus adding support for MD5, > SHA-1, SHA-256, SHA-384, SHA-512 > * Added some tests > * Added an example for all hashing functions to the generated site. > What I'm not sure about: > * Would you accept this feature as one that's worth be a part of standard > rules. > * If so, I'm not sure if https://github.com/apache/maven-enforcer accepts > pull requests as I've noticed probably automatically generated `git-svn-id` > field in `git log` output. So probably the patch might be committed to the > Subversion repository first. > Here is the patch diff on GitHub: > https://github.com/lyubomyr-shaydariv/maven-enforcer/commit/86ed97423b5c64625f700c3afe555c02d6c619df -- This message was sent by Atlassian JIRA (v6.3.4#6332)