[jira] [Updated] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML

2021-01-24 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6435:

Fix Version/s: (was: 4.0.x-candidate)
   Issues to be reviewed for 4.x

> DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
> ---
>
> Key: MNG-6435
> URL: https://issues.apache.org/jira/browse/MNG-6435
> Project: Maven
>  Issue Type: Improvement
>  Components: Settings
>Affects Versions: 3.5.3
>Reporter: Laird Nelson
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Issues to be reviewed for 4.x
>
>
> On or around line 234, interpolation of settings assumes XML:
> {code}
> interpolator.addPostProcessor( new InterpolationPostProcessor()
> {
>   @Override
>   public Object execute( String expression, Object value )
>   {
> if ( value != null )
> {
>   // we're going to parse this back in as XML so we need to escape XML 
> markup
>   value = value.toString().replace( "&", "" ).replace( "<", "" 
> ).replace( ">", "" );
>   return value;
> }
> return null;
>   }
> } );
> {code}
> The value being interpolated here is the result of a {{SettingsWriter}}'s 
> output.  Obviously this kind of escaping doesn't make any sense if the 
> {{SettingsWriter}} in question is not XML-based.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML

2020-12-26 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6435:

Fix Version/s: 4.0.x-candidate

> DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
> ---
>
> Key: MNG-6435
> URL: https://issues.apache.org/jira/browse/MNG-6435
> Project: Maven
>  Issue Type: Improvement
>  Components: Settings
>Affects Versions: 3.5.3
>Reporter: Laird Nelson
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> On or around line 234, interpolation of settings assumes XML:
> {code}
> interpolator.addPostProcessor( new InterpolationPostProcessor()
> {
>   @Override
>   public Object execute( String expression, Object value )
>   {
> if ( value != null )
> {
>   // we're going to parse this back in as XML so we need to escape XML 
> markup
>   value = value.toString().replace( "&", "" ).replace( "<", "" 
> ).replace( ">", "" );
>   return value;
> }
> return null;
>   }
> } );
> {code}
> The value being interpolated here is the result of a {{SettingsWriter}}'s 
> output.  Obviously this kind of escaping doesn't make any sense if the 
> {{SettingsWriter}} in question is not XML-based.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML

2018-07-31 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MNG-6435:
-
Priority: Minor  (was: Major)

> DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
> ---
>
> Key: MNG-6435
> URL: https://issues.apache.org/jira/browse/MNG-6435
> Project: Maven
>  Issue Type: Improvement
>  Components: Settings
>Affects Versions: 3.5.3
>Reporter: Laird Nelson
>Priority: Minor
>
> On or around line 234, interpolation of settings assumes XML:
> {code}
> interpolator.addPostProcessor( new InterpolationPostProcessor()
> {
>   @Override
>   public Object execute( String expression, Object value )
>   {
> if ( value != null )
> {
>   // we're going to parse this back in as XML so we need to escape XML 
> markup
>   value = value.toString().replace( "&", "" ).replace( "<", "" 
> ).replace( ">", "" );
>   return value;
> }
> return null;
>   }
> } );
> {code}
> The value being interpolated here is the result of a {{SettingsWriter}}'s 
> output.  Obviously this kind of escaping doesn't make any sense if the 
> {{SettingsWriter}} in question is not XML-based.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML

2018-07-31 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MNG-6435:
-
Issue Type: Improvement  (was: Bug)

> DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
> ---
>
> Key: MNG-6435
> URL: https://issues.apache.org/jira/browse/MNG-6435
> Project: Maven
>  Issue Type: Improvement
>  Components: Settings
>Affects Versions: 3.5.3
>Reporter: Laird Nelson
>Priority: Major
>
> On or around line 234, interpolation of settings assumes XML:
> {code}
> interpolator.addPostProcessor( new InterpolationPostProcessor()
> {
>   @Override
>   public Object execute( String expression, Object value )
>   {
> if ( value != null )
> {
>   // we're going to parse this back in as XML so we need to escape XML 
> markup
>   value = value.toString().replace( "&", "" ).replace( "<", "" 
> ).replace( ">", "" );
>   return value;
> }
> return null;
>   }
> } );
> {code}
> The value being interpolated here is the result of a {{SettingsWriter}}'s 
> output.  Obviously this kind of escaping doesn't make any sense if the 
> {{SettingsWriter}} in question is not XML-based.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML

2018-06-27 Thread Laird Nelson (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laird Nelson updated MNG-6435:
--
Description: 
On or around line 234, interpolation of settings assumes XML:
{code}
interpolator.addPostProcessor( new InterpolationPostProcessor()
{
  @Override
  public Object execute( String expression, Object value )
  {
if ( value != null )
{
  // we're going to parse this back in as XML so we need to escape XML 
markup
  value = value.toString().replace( "&", "" ).replace( "<", "" 
).replace( ">", "" );
  return value;
}
return null;
  }
} );
{code}

The value being interpolated here is the result of a {{SettingsWriter}}'s 
output.  Obviously this kind of escaping doesn't make any sense if the 
{{SettingsWriter}} in question is not XML-based.

  was:
On or around line 234, interpolation of settings assumes XML:
{code}
interpolator.addPostProcessor( new InterpolationPostProcessor()
{
  @Override
  public Object execute( String expression, Object value )
  {
if ( value != null )
{
  // we're going to parse this back in as XML so we need to escape XML 
markup
  value = value.toString().replace( "&", "" ).replace( "<", "" 
).replace( ">", "" );
  return value;
}
return null;
  }
} );
{code}

The expression being interpolated here is the result of a {{SettingsWriter}}'s 
output.  Obviously this kind of escaping doesn't make any sense if the 
{{SettingsWriter}} in question is not XML-based.


> DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
> ---
>
> Key: MNG-6435
> URL: https://issues.apache.org/jira/browse/MNG-6435
> Project: Maven
>  Issue Type: Bug
>  Components: Settings
>Affects Versions: 3.5.3
>Reporter: Laird Nelson
>Priority: Major
>
> On or around line 234, interpolation of settings assumes XML:
> {code}
> interpolator.addPostProcessor( new InterpolationPostProcessor()
> {
>   @Override
>   public Object execute( String expression, Object value )
>   {
> if ( value != null )
> {
>   // we're going to parse this back in as XML so we need to escape XML 
> markup
>   value = value.toString().replace( "&", "" ).replace( "<", "" 
> ).replace( ">", "" );
>   return value;
> }
> return null;
>   }
> } );
> {code}
> The value being interpolated here is the result of a {{SettingsWriter}}'s 
> output.  Obviously this kind of escaping doesn't make any sense if the 
> {{SettingsWriter}} in question is not XML-based.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)