[jira] [Commented] (DOXIA-203) Add support for level 6 sections and generalize Sink API for sections
[ https://issues.apache.org/jira/browse/DOXIA-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114561#comment-15114561 ] Hudson commented on DOXIA-203: -- SUCCESS: Integrated in doxia-all #229 (See [https://builds.apache.org/job/doxia-all/229/]) [DOXIA-203] Add support for level 6 sections (rfscholte: [http://svn.apache.org/viewvc/?view=rev&rev=1726565]) * ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/RandomAccessSink.java * ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/SinkAdapter.java * ./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/SinkEventTestingSink.java * ./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/TextSink.java * ./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/WellformednessCheckingSink.java * ./doxia/doxia-sink-api/src/main/java/org/apache/maven/doxia/sink/Sink.java > Add support for level 6 sections and generalize Sink API for sections > - > > Key: DOXIA-203 > URL: https://issues.apache.org/jira/browse/DOXIA-203 > Project: Maven Doxia > Issue Type: Improvement > Components: Sink API >Affects Versions: 1.0-alpha-10 >Reporter: Vincent Massol >Assignee: Robert Scholte > Fix For: 1.7 > > > XWiki supports 6 levels (see > http://platform.xwiki.org/xwiki/bin/view/Main/XWikiSyntax) and thus I cannot > write a valid parser if the Sink API doesn't support a level 6. > I'd even suggest to unify all sink method for sections into a single method > with a level parameter passed instead of having sectionTitle1(), etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] Commented: (DOXIA-203) Add support for level 6 sections and generalize Sink API for sections
[ http://jira.codehaus.org/browse/DOXIA-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126712 ] Lukas Theussl commented on DOXIA-203: - There is an issue (don't know if it's an inconsistency) with the xhtml-based parsers and sinks: eg sectionTitle1() in XhtmlBaseSink emits a tag, sectionTitle2() a etc, sectionTitle5() emits a but there is no method that emits a . > Add support for level 6 sections and generalize Sink API for sections > - > > Key: DOXIA-203 > URL: http://jira.codehaus.org/browse/DOXIA-203 > Project: Maven Doxia > Issue Type: Improvement > Components: Sink API >Affects Versions: 1.0-alpha-10 >Reporter: Vincent Massol > > XWiki supports 6 levels (see > http://platform.xwiki.org/xwiki/bin/view/Main/XWikiSyntax) and thus I cannot > write a valid parser if the Sink API doesn't support a level 6. > I'd even suggest to unify all sink method for sections into a single method > with a level parameter passed instead of having sectionTitle1(), etc. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-203) Add support for level 6 sections and generalize Sink API for sections
[ http://jira.codehaus.org/browse/DOXIA-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_120888 ] Vincent Massol commented on DOXIA-203: -- well if we say that 1.0 is not released yet then we should remove the old cruft and not deprecate them. If OTOH we think that 1.0 has already been released in practice (if not de facto) then let's create a 1.0 branch, and make trunk be 1.1 or 2.0 and remove the cruft there. WDYT? > Add support for level 6 sections and generalize Sink API for sections > - > > Key: DOXIA-203 > URL: http://jira.codehaus.org/browse/DOXIA-203 > Project: Maven Doxia > Issue Type: Improvement > Components: Sink API >Affects Versions: 1.0-alpha-10 >Reporter: Vincent Massol > > XWiki supports 6 levels (see > http://platform.xwiki.org/xwiki/bin/view/Main/XWikiSyntax) and thus I cannot > write a valid parser if the Sink API doesn't support a level 6. > I'd even suggest to unify all sink method for sections into a single method > with a level parameter passed instead of having sectionTitle1(), etc. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-203) Add support for level 6 sections and generalize Sink API for sections
[ http://jira.codehaus.org/browse/DOXIA-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_120885 ] Vincent Siveton commented on DOXIA-203: --- I already thought about this and I am generally in favour on this general approach, but we dont want to remove these methods, more now on beta. > Add support for level 6 sections and generalize Sink API for sections > - > > Key: DOXIA-203 > URL: http://jira.codehaus.org/browse/DOXIA-203 > Project: Maven Doxia > Issue Type: Improvement > Components: Sink API >Affects Versions: 1.0-alpha-10 >Reporter: Vincent Massol > > XWiki supports 6 levels (see > http://platform.xwiki.org/xwiki/bin/view/Main/XWikiSyntax) and thus I cannot > write a valid parser if the Sink API doesn't support a level 6. > I'd even suggest to unify all sink method for sections into a single method > with a level parameter passed instead of having sectionTitle1(), etc. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
