[jira] Commented: (DOXIA-50) Improve the AptParser class
[ http://jira.codehaus.org/browse/DOXIA-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102037 ] Lukas Theussl commented on DOXIA-50: I think this should be closed won't fix. * aptconvert doesn't recognize a physical ^L as a pagebreak, so it shouldn't be allowed * the order where a table caption is emitted is irrelevant for the parser (as long as it's the same for all parsers), it's the corresponding sinks that have to put the caption in the right place. We need to think to install a testing mechanism to ensure that all parsers emit events in the same order. * there is still something fishy about apt table parsing, but the above patch doesn't solve that for me, I will open a separate issue. > Improve the AptParser class > --- > > Key: DOXIA-50 > URL: http://jira.codehaus.org/browse/DOXIA-50 > Project: doxia > Issue Type: Improvement > Components: Core >Affects Versions: 1.0-alpha-8 >Reporter: Vincent Siveton > Attachments: AptParser.diff > > > This patch provides some improvements for the AptParser: > * support of the pagebreak, ie ^L > * support of tableHeaderCell() call > * improve the tableCaption() call -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-50) Improve the AptParser class
[ http://jira.codehaus.org/browse/DOXIA-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_90362 ] Brett Porter commented on DOXIA-50: --- I don't think the patch has been updated after the feedback, so it can be unscheduled. > Improve the AptParser class > --- > > Key: DOXIA-50 > URL: http://jira.codehaus.org/browse/DOXIA-50 > Project: doxia > Issue Type: Improvement > Components: Core >Affects Versions: 1.0-alpha-8 >Reporter: Vincent Siveton > Fix For: 1.0 > > Attachments: AptParser.diff > > > This patch provides some improvements for the AptParser: > * support of the pagebreak, ie ^L > * support of tableHeaderCell() call > * improve the tableCaption() call -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-50) Improve the AptParser class
[ http://jira.codehaus.org/browse/DOXIA-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_90361 ] Jason van Zyl commented on DOXIA-50: You guys figure this out or shall we unschedule it for 1.0? > Improve the AptParser class > --- > > Key: DOXIA-50 > URL: http://jira.codehaus.org/browse/DOXIA-50 > Project: doxia > Issue Type: Improvement > Components: Core >Affects Versions: 1.0-alpha-8 >Reporter: Vincent Siveton > Fix For: 1.0 > > Attachments: AptParser.diff > > > This patch provides some improvements for the AptParser: > * support of the pagebreak, ie ^L > * support of tableHeaderCell() call > * improve the tableCaption() call -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-50) Improve the AptParser class
[ http://jira.codehaus.org/browse/DOXIA-50?page=comments#action_63217 ] Vincent Siveton commented on DOXIA-50: -- Brett, > - \f should continue to be supported, as that's the real CTRL-L. We can > support a physical ^L as well, but that's not normally how it should worl. Agree > - I don't understand what was wrong with table header cells - they worked for > me in APT in the past. With APT, no table header cell will be rendered (like Xdoc). See the differences on the tables: XDOC http://maven.apache.org/development-process.html (Best-Practice Documents part) APT http://maven.apache.org/download.html (Download Maven 2.0.3 part) With this patch, some pages should be reviewed. For instance, http://maven.apache.org/ant-tasks.html (Task Reference part) > - I don't understand why the caption is placed outside of the table instead > of inside? The caption is recognised as a line. I had got a java.lang.ClassCastException when using DOXIA-53. > Improve the AptParser class > --- > > Key: DOXIA-50 > URL: http://jira.codehaus.org/browse/DOXIA-50 > Project: doxia > Type: Improvement > Components: Core > Versions: 1.0-alpha-8 > Reporter: Vincent Siveton > Fix For: 1.0 > Attachments: AptParser.diff > > > This patch provides some improvements for the AptParser: > * support of the pagebreak, ie ^L > * support of tableHeaderCell() call > * improve the tableCaption() call -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-50) Improve the AptParser class
[ http://jira.codehaus.org/browse/DOXIA-50?page=comments#action_63033 ] Brett Porter commented on DOXIA-50: --- Vincent, I don't understand this patch. - \f should continue to be supported, as that's the real CTRL-L. We can support a physical ^L as well, but that's not normally how it should worl. - I don't understand what was wrong with table header cells - they worked for me in APT in the past. - I don't understand why the caption is placed outside of the table instead of inside? > Improve the AptParser class > --- > > Key: DOXIA-50 > URL: http://jira.codehaus.org/browse/DOXIA-50 > Project: doxia > Type: Improvement > Components: Core > Versions: 1.0-alpha-8 > Reporter: Vincent Siveton > Fix For: 1.0-alpha-8 > Attachments: AptParser.diff > > > This patch provides some improvements for the AptParser: > * support of the pagebreak, ie ^L > * support of tableHeaderCell() call > * improve the tableCaption() call -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
