[jira] Commented: (MASSEMBLY-510) leading period ('.') added to directory names
[
http://jira.codehaus.org/browse/MASSEMBLY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=257513#action_257513
]
John Casey commented on MASSEMBLY-510:
--
working on it right now. Hopefully, it's fixed, but the ITs will tell... :-)
> leading period ('.') added to directory names
> -
>
> Key: MASSEMBLY-510
> URL: http://jira.codehaus.org/browse/MASSEMBLY-510
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
>Affects Versions: 2.2
> Environment: Windows XP, SP3
> Maven 2.2.1
> Maven Assembly 2.2
>Reporter: KP
>Assignee: John Casey
> Fix For: 2.2.1
>
> Attachments: dist.xml, pom.xml
>
>
> $ cat dist.xml
> xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0
> http://maven.apache.org/xsd/assembly-1.1.0.xsd";>
> dist
>
> zip
>
>
>
>
>
> ${project.basedir}/../paper
>
>
> ${project.basedir}/../boots
>
>
>
>
> $ mvn clean assembly:assembly
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]task-segment: [clean]
> [INFO]
>
> [INFO] [clean:clean {execution: default-clean}]
> [INFO] Deleting directory F:\test-assembly\target
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]task-segment: [assembly:assembly] (aggregator-style)
> [INFO]
>
> [INFO] Preparing assembly:assembly
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]
>
> [INFO] [site:attach-descriptor {execution: default-attach-descriptor}]
> [INFO] [assembly:assembly {execution: default-cli}]
> [INFO] Reading assembly descriptor: src/main/assembly/dist.xml
> [INFO] Building zip:
> F:\test-assembly\target\test-assembly-3.1-SNAPSHOT-dist.zip
> [INFO]
>
> [INFO] BUILD SUCCESSFUL
> [INFO]
>
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Mon Oct 11 15:34:37 EDT 2010
> [INFO] Final Memory: 18M/45M
> [INFO]
>
> $ unzip -l target/test-assembly-dist.zip
> Archive: target/test-assembly-dist.zip
> Length DateTimeName
> - -- -
> 0 10-11-2010 15:34 test-assembly/
> 0 10-11-2010 15:27 test-assembly/.paper/
> 0 10-11-2010 15:27 test-assembly/.paper/random.txt
> 0 10-11-2010 15:27 test-assembly/.boots/
> 0 10-11-2010 15:27 test-assembly/.boots/boots.txt
> - ---
> 0 5 files
> Do you notice the '.paper' and '.boots' directories? It should just be
> 'paper' and 'boots', if I'm understanding it correctly.
> I tried other versions of the plugin (e.g., beta-4), I tried removing
> "${project.basedir}/".
> No go. :(
> P.S. If someone points me in the right direction, like a class name, I'll
> write a test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-510) leading period ('.') added to directory names
[
http://jira.codehaus.org/browse/MASSEMBLY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=257497#action_257497
]
Dennis Lundberg commented on MASSEMBLY-510:
---
John, do you think you have time to fix this?
It's the last issue left in the 2.2.1 release.
If you don't have time right now, I'll just push it to the next release.
> leading period ('.') added to directory names
> -
>
> Key: MASSEMBLY-510
> URL: http://jira.codehaus.org/browse/MASSEMBLY-510
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
>Affects Versions: 2.2
> Environment: Windows XP, SP3
> Maven 2.2.1
> Maven Assembly 2.2
>Reporter: KP
>Assignee: John Casey
> Fix For: 2.2.1
>
> Attachments: dist.xml, pom.xml
>
>
> $ cat dist.xml
> xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0
> http://maven.apache.org/xsd/assembly-1.1.0.xsd";>
> dist
>
> zip
>
>
>
>
>
> ${project.basedir}/../paper
>
>
> ${project.basedir}/../boots
>
>
>
>
> $ mvn clean assembly:assembly
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]task-segment: [clean]
> [INFO]
>
> [INFO] [clean:clean {execution: default-clean}]
> [INFO] Deleting directory F:\test-assembly\target
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]task-segment: [assembly:assembly] (aggregator-style)
> [INFO]
>
> [INFO] Preparing assembly:assembly
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]
>
> [INFO] [site:attach-descriptor {execution: default-attach-descriptor}]
> [INFO] [assembly:assembly {execution: default-cli}]
> [INFO] Reading assembly descriptor: src/main/assembly/dist.xml
> [INFO] Building zip:
> F:\test-assembly\target\test-assembly-3.1-SNAPSHOT-dist.zip
> [INFO]
>
> [INFO] BUILD SUCCESSFUL
> [INFO]
>
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Mon Oct 11 15:34:37 EDT 2010
> [INFO] Final Memory: 18M/45M
> [INFO]
>
> $ unzip -l target/test-assembly-dist.zip
> Archive: target/test-assembly-dist.zip
> Length DateTimeName
> - -- -
> 0 10-11-2010 15:34 test-assembly/
> 0 10-11-2010 15:27 test-assembly/.paper/
> 0 10-11-2010 15:27 test-assembly/.paper/random.txt
> 0 10-11-2010 15:27 test-assembly/.boots/
> 0 10-11-2010 15:27 test-assembly/.boots/boots.txt
> - ---
> 0 5 files
> Do you notice the '.paper' and '.boots' directories? It should just be
> 'paper' and 'boots', if I'm understanding it correctly.
> I tried other versions of the plugin (e.g., beta-4), I tried removing
> "${project.basedir}/".
> No go. :(
> P.S. If someone points me in the right direction, like a class name, I'll
> write a test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-510) leading period ('.') added to directory names
[
http://jira.codehaus.org/browse/MASSEMBLY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=239446#action_239446
]
KP commented on MASSEMBLY-510:
--
@John Casey: Yup, I just tried beta-4 and beta-5 and the result is the same.
> leading period ('.') added to directory names
> -
>
> Key: MASSEMBLY-510
> URL: http://jira.codehaus.org/browse/MASSEMBLY-510
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
>Affects Versions: 2.2
> Environment: Windows XP, SP3
> Maven 2.2.1
> Maven Assembly 2.2
>Reporter: KP
> Attachments: dist.xml, pom.xml
>
>
> $ cat dist.xml
> xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0
> http://maven.apache.org/xsd/assembly-1.1.0.xsd";>
> dist
>
> zip
>
>
>
>
>
> ${project.basedir}/../paper
>
>
> ${project.basedir}/../boots
>
>
>
>
> $ mvn clean assembly:assembly
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]task-segment: [clean]
> [INFO]
>
> [INFO] [clean:clean {execution: default-clean}]
> [INFO] Deleting directory F:\test-assembly\target
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]task-segment: [assembly:assembly] (aggregator-style)
> [INFO]
>
> [INFO] Preparing assembly:assembly
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]
>
> [INFO] [site:attach-descriptor {execution: default-attach-descriptor}]
> [INFO] [assembly:assembly {execution: default-cli}]
> [INFO] Reading assembly descriptor: src/main/assembly/dist.xml
> [INFO] Building zip:
> F:\test-assembly\target\test-assembly-3.1-SNAPSHOT-dist.zip
> [INFO]
>
> [INFO] BUILD SUCCESSFUL
> [INFO]
>
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Mon Oct 11 15:34:37 EDT 2010
> [INFO] Final Memory: 18M/45M
> [INFO]
>
> $ unzip -l target/test-assembly-dist.zip
> Archive: target/test-assembly-dist.zip
> Length DateTimeName
> - -- -
> 0 10-11-2010 15:34 test-assembly/
> 0 10-11-2010 15:27 test-assembly/.paper/
> 0 10-11-2010 15:27 test-assembly/.paper/random.txt
> 0 10-11-2010 15:27 test-assembly/.boots/
> 0 10-11-2010 15:27 test-assembly/.boots/boots.txt
> - ---
> 0 5 files
> Do you notice the '.paper' and '.boots' directories? It should just be
> 'paper' and 'boots', if I'm understanding it correctly.
> I tried other versions of the plugin (e.g., beta-4), I tried removing
> "${project.basedir}/".
> No go. :(
> P.S. If someone points me in the right direction, like a class name, I'll
> write a test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-510) leading period ('.') added to directory names
[
http://jira.codehaus.org/browse/MASSEMBLY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=239369#action_239369
]
John Casey commented on MASSEMBLY-510:
--
to be clear, you've tried this with 2.2-beta-* (beta-4 or beta-5), and it
doesn't work there, either?
> leading period ('.') added to directory names
> -
>
> Key: MASSEMBLY-510
> URL: http://jira.codehaus.org/browse/MASSEMBLY-510
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
>Affects Versions: 2.2
> Environment: Windows XP, SP3
> Maven 2.2.1
> Maven Assembly 2.2
>Reporter: KP
> Attachments: dist.xml, pom.xml
>
>
> $ cat dist.xml
> xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0
> http://maven.apache.org/xsd/assembly-1.1.0.xsd";>
> dist
>
> zip
>
>
>
>
>
> ${project.basedir}/../paper
>
>
> ${project.basedir}/../boots
>
>
>
>
> $ mvn clean assembly:assembly
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]task-segment: [clean]
> [INFO]
>
> [INFO] [clean:clean {execution: default-clean}]
> [INFO] Deleting directory F:\test-assembly\target
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]task-segment: [assembly:assembly] (aggregator-style)
> [INFO]
>
> [INFO] Preparing assembly:assembly
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]
>
> [INFO] [site:attach-descriptor {execution: default-attach-descriptor}]
> [INFO] [assembly:assembly {execution: default-cli}]
> [INFO] Reading assembly descriptor: src/main/assembly/dist.xml
> [INFO] Building zip:
> F:\test-assembly\target\test-assembly-3.1-SNAPSHOT-dist.zip
> [INFO]
>
> [INFO] BUILD SUCCESSFUL
> [INFO]
>
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Mon Oct 11 15:34:37 EDT 2010
> [INFO] Final Memory: 18M/45M
> [INFO]
>
> $ unzip -l target/test-assembly-dist.zip
> Archive: target/test-assembly-dist.zip
> Length DateTimeName
> - -- -
> 0 10-11-2010 15:34 test-assembly/
> 0 10-11-2010 15:27 test-assembly/.paper/
> 0 10-11-2010 15:27 test-assembly/.paper/random.txt
> 0 10-11-2010 15:27 test-assembly/.boots/
> 0 10-11-2010 15:27 test-assembly/.boots/boots.txt
> - ---
> 0 5 files
> Do you notice the '.paper' and '.boots' directories? It should just be
> 'paper' and 'boots', if I'm understanding it correctly.
> I tried other versions of the plugin (e.g., beta-4), I tried removing
> "${project.basedir}/".
> No go. :(
> P.S. If someone points me in the right direction, like a class name, I'll
> write a test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-510) leading period ('.') added to directory names
[
http://jira.codehaus.org/browse/MASSEMBLY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=239319#action_239319
]
KP commented on MASSEMBLY-510:
--
I think I found the issue. In {{AssemblyFormatUtils.java}}, around line 263:
{code}
value = StringUtils.replace( value, "./", "" );
{code}
This means that file sets in the assembly descriptor that the '../' entry will
break.
The quick workaround is to use '..' instead, as this will not trigger the
calls to {{StringUtils.replace()}}.
I will create a unit test for this when I get the chance.
> leading period ('.') added to directory names
> -
>
> Key: MASSEMBLY-510
> URL: http://jira.codehaus.org/browse/MASSEMBLY-510
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
>Affects Versions: 2.2
> Environment: Windows XP, SP3
> Maven 2.2.1
> Maven Assembly 2.2
>Reporter: KP
> Attachments: dist.xml, pom.xml
>
>
> $ cat dist.xml
> xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0
> http://maven.apache.org/xsd/assembly-1.1.0.xsd";>
> dist
>
> zip
>
>
>
>
>
> ${project.basedir}/../paper
>
>
> ${project.basedir}/../boots
>
>
>
>
> $ mvn clean assembly:assembly
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]task-segment: [clean]
> [INFO]
>
> [INFO] [clean:clean {execution: default-clean}]
> [INFO] Deleting directory F:\test-assembly\target
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]task-segment: [assembly:assembly] (aggregator-style)
> [INFO]
>
> [INFO] Preparing assembly:assembly
> [INFO]
>
> [INFO] Building oracle-sql-assembly
> [INFO]
>
> [INFO] [site:attach-descriptor {execution: default-attach-descriptor}]
> [INFO] [assembly:assembly {execution: default-cli}]
> [INFO] Reading assembly descriptor: src/main/assembly/dist.xml
> [INFO] Building zip:
> F:\test-assembly\target\test-assembly-3.1-SNAPSHOT-dist.zip
> [INFO]
>
> [INFO] BUILD SUCCESSFUL
> [INFO]
>
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Mon Oct 11 15:34:37 EDT 2010
> [INFO] Final Memory: 18M/45M
> [INFO]
>
> $ unzip -l target/test-assembly-dist.zip
> Archive: target/test-assembly-dist.zip
> Length DateTimeName
> - -- -
> 0 10-11-2010 15:34 test-assembly/
> 0 10-11-2010 15:27 test-assembly/.paper/
> 0 10-11-2010 15:27 test-assembly/.paper/random.txt
> 0 10-11-2010 15:27 test-assembly/.boots/
> 0 10-11-2010 15:27 test-assembly/.boots/boots.txt
> - ---
> 0 5 files
> Do you notice the '.paper' and '.boots' directories? It should just be
> 'paper' and 'boots', if I'm understanding it correctly.
> I tried other versions of the plugin (e.g., beta-4), I tried removing
> "${project.basedir}/".
> No go. :(
> P.S. If someone points me in the right direction, like a class name, I'll
> write a test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
