[jira] Commented: (MCHECKSTYLE-101) Skip should skip everything including the Velocity initialization
[
http://jira.codehaus.org/browse/MCHECKSTYLE-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=176306#action_176306
]
Steve Gilbert commented on MCHECKSTYLE-101:
---
The logs are not the problem. It's time. The point of skipping checkstyle is
to save individual developer build time. When Velocity initializes, it takes a
lot of time, as much time as it does for checkstyle to do the checking. In our
environment we have checkstyle hooked into the install goal so the time lost
accumulates over many iterations and is significant.
> Skip should skip everything including the Velocity initialization
> -
>
> Key: MCHECKSTYLE-101
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-101
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
>Affects Versions: 2.2
>Reporter: Steve Gilbert
>Assignee: nicolas de loof
> Fix For: 2.3
>
>
> The "skip" configuration property prevents the check from happening, however,
> Velocity still gets initialized. For a small project, this takes the build
> time from 5 seconds without checkstyle in the pom to 13 seconds with it in
> and skip=true. While 8 seconds does not seem like much, it adds up over the
> course of days and weeks. Note that we have checkstyle hooked in at the
> verify/check phase/goal to cause the build to fail on a checkstyle violation
> during a typical developer's compilation they do all the time.
> Build output with skip=true:
> [INFO] Preparing checkstyle:check
> [INFO] Setting property: classpath.resource.loader.class =>
> 'org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader'.
> [INFO] Setting property: velocimacro.messages.on => 'false'.
> [INFO] Setting property: resource.loader => 'classpath'.
> [INFO] Setting property: resource.manager.logwhenfound => 'false'.
> [INFO] **
> [INFO] Starting Jakarta Velocity v1.4
> [INFO] RuntimeInstance initializing.
> [INFO] Default Properties File:
> org\apache\velocity\runtime\defaults\velocity.properties
> [INFO] Default ResourceManager initializing. (class
> org.apache.velocity.runtime.resource.ResourceManagerImpl)
> [INFO] Resource Loader Instantiated:
> org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader
> [INFO] ClasspathResourceLoader : initialization starting.
> [INFO] ClasspathResourceLoader : initialization complete.
> [INFO] ResourceCache : initialized. (class
> org.apache.velocity.runtime.resource.ResourceCacheImpl)
> [INFO] Default ResourceManager initialization complete.
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Literal
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Macro
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Parse
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Include
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Foreach
> [INFO] Created: 20 parsers.
> [INFO] Velocimacro : initialization starting.
> [INFO] Velocimacro : adding VMs from VM library template :
> VM_global_library.vm
> [ERROR] ResourceManager : unable to find resource 'VM_global_library.vm' in
> any resource loader.
> [INFO] Velocimacro : error using VM library template VM_global_library.vm :
> org.apache.velocity.exception.ResourceNotFoundException: Unable to find
> resource 'VM_global_library.vm'
> [INFO] Velocimacro : VM library template macro registration complete.
> [INFO] Velocimacro : allowInline = true : VMs can be defined inline in
> templates
> [INFO] Velocimacro : allowInlineToOverride = false : VMs defined inline may
> NOT replace previous VM definitions
> [INFO] Velocimacro : allowInlineLocal = false : VMs defined inline will be
> global in scope if allowed.
> [INFO] Velocimacro : initialization complete.
> [INFO] Velocity successfully started.
> [INFO] [checkstyle:checkstyle]
> [INFO] [checkstyle:check {execution: default}]
> See also MCHECKSTYLE-71.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-101) Skip should skip everything including the Velocity initialization
[
http://jira.codehaus.org/browse/MCHECKSTYLE-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=176305#action_176305
]
nicolas de loof commented on MCHECKSTYLE-101:
-
we use a shared plexus component that is dependency-injected by plexus
container.
What's wrong with this component beeing initialized ? only some undesirable
logs ?
> Skip should skip everything including the Velocity initialization
> -
>
> Key: MCHECKSTYLE-101
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-101
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
>Affects Versions: 2.2
>Reporter: Steve Gilbert
>Assignee: nicolas de loof
> Fix For: 2.3
>
>
> The "skip" configuration property prevents the check from happening, however,
> Velocity still gets initialized. For a small project, this takes the build
> time from 5 seconds without checkstyle in the pom to 13 seconds with it in
> and skip=true. While 8 seconds does not seem like much, it adds up over the
> course of days and weeks. Note that we have checkstyle hooked in at the
> verify/check phase/goal to cause the build to fail on a checkstyle violation
> during a typical developer's compilation they do all the time.
> Build output with skip=true:
> [INFO] Preparing checkstyle:check
> [INFO] Setting property: classpath.resource.loader.class =>
> 'org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader'.
> [INFO] Setting property: velocimacro.messages.on => 'false'.
> [INFO] Setting property: resource.loader => 'classpath'.
> [INFO] Setting property: resource.manager.logwhenfound => 'false'.
> [INFO] **
> [INFO] Starting Jakarta Velocity v1.4
> [INFO] RuntimeInstance initializing.
> [INFO] Default Properties File:
> org\apache\velocity\runtime\defaults\velocity.properties
> [INFO] Default ResourceManager initializing. (class
> org.apache.velocity.runtime.resource.ResourceManagerImpl)
> [INFO] Resource Loader Instantiated:
> org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader
> [INFO] ClasspathResourceLoader : initialization starting.
> [INFO] ClasspathResourceLoader : initialization complete.
> [INFO] ResourceCache : initialized. (class
> org.apache.velocity.runtime.resource.ResourceCacheImpl)
> [INFO] Default ResourceManager initialization complete.
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Literal
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Macro
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Parse
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Include
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Foreach
> [INFO] Created: 20 parsers.
> [INFO] Velocimacro : initialization starting.
> [INFO] Velocimacro : adding VMs from VM library template :
> VM_global_library.vm
> [ERROR] ResourceManager : unable to find resource 'VM_global_library.vm' in
> any resource loader.
> [INFO] Velocimacro : error using VM library template VM_global_library.vm :
> org.apache.velocity.exception.ResourceNotFoundException: Unable to find
> resource 'VM_global_library.vm'
> [INFO] Velocimacro : VM library template macro registration complete.
> [INFO] Velocimacro : allowInline = true : VMs can be defined inline in
> templates
> [INFO] Velocimacro : allowInlineToOverride = false : VMs defined inline may
> NOT replace previous VM definitions
> [INFO] Velocimacro : allowInlineLocal = false : VMs defined inline will be
> global in scope if allowed.
> [INFO] Velocimacro : initialization complete.
> [INFO] Velocity successfully started.
> [INFO] [checkstyle:checkstyle]
> [INFO] [checkstyle:check {execution: default}]
> See also MCHECKSTYLE-71.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-101) Skip should skip everything including the Velocity initialization
[
http://jira.codehaus.org/browse/MCHECKSTYLE-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=176301#action_176301
]
Steve Gilbert commented on MCHECKSTYLE-101:
---
Perhaps not using an annotation can be considered.
> Skip should skip everything including the Velocity initialization
> -
>
> Key: MCHECKSTYLE-101
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-101
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
>Affects Versions: 2.2
>Reporter: Steve Gilbert
>Assignee: nicolas de loof
> Fix For: 2.3
>
>
> The "skip" configuration property prevents the check from happening, however,
> Velocity still gets initialized. For a small project, this takes the build
> time from 5 seconds without checkstyle in the pom to 13 seconds with it in
> and skip=true. While 8 seconds does not seem like much, it adds up over the
> course of days and weeks. Note that we have checkstyle hooked in at the
> verify/check phase/goal to cause the build to fail on a checkstyle violation
> during a typical developer's compilation they do all the time.
> Build output with skip=true:
> [INFO] Preparing checkstyle:check
> [INFO] Setting property: classpath.resource.loader.class =>
> 'org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader'.
> [INFO] Setting property: velocimacro.messages.on => 'false'.
> [INFO] Setting property: resource.loader => 'classpath'.
> [INFO] Setting property: resource.manager.logwhenfound => 'false'.
> [INFO] **
> [INFO] Starting Jakarta Velocity v1.4
> [INFO] RuntimeInstance initializing.
> [INFO] Default Properties File:
> org\apache\velocity\runtime\defaults\velocity.properties
> [INFO] Default ResourceManager initializing. (class
> org.apache.velocity.runtime.resource.ResourceManagerImpl)
> [INFO] Resource Loader Instantiated:
> org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader
> [INFO] ClasspathResourceLoader : initialization starting.
> [INFO] ClasspathResourceLoader : initialization complete.
> [INFO] ResourceCache : initialized. (class
> org.apache.velocity.runtime.resource.ResourceCacheImpl)
> [INFO] Default ResourceManager initialization complete.
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Literal
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Macro
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Parse
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Include
> [INFO] Loaded System Directive: org.apache.velocity.runtime.directive.Foreach
> [INFO] Created: 20 parsers.
> [INFO] Velocimacro : initialization starting.
> [INFO] Velocimacro : adding VMs from VM library template :
> VM_global_library.vm
> [ERROR] ResourceManager : unable to find resource 'VM_global_library.vm' in
> any resource loader.
> [INFO] Velocimacro : error using VM library template VM_global_library.vm :
> org.apache.velocity.exception.ResourceNotFoundException: Unable to find
> resource 'VM_global_library.vm'
> [INFO] Velocimacro : VM library template macro registration complete.
> [INFO] Velocimacro : allowInline = true : VMs can be defined inline in
> templates
> [INFO] Velocimacro : allowInlineToOverride = false : VMs defined inline may
> NOT replace previous VM definitions
> [INFO] Velocimacro : allowInlineLocal = false : VMs defined inline will be
> global in scope if allowed.
> [INFO] Velocimacro : initialization complete.
> [INFO] Velocity successfully started.
> [INFO] [checkstyle:checkstyle]
> [INFO] [checkstyle:check {execution: default}]
> See also MCHECKSTYLE-71.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
