[jira] Commented: (MNG-2254) the encoding parameter in xml declaration of POM is ignored
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_109706 ] Brian Fox commented on MNG-2254: Thanks Herve, the test looks good. I wasn't able to get the patches applied cleanly. Can you update them and then I'll apply and test? (i'm going to add the test to the core suite) the encoding parameter in xml declaration of POM is ignored Key: MNG-2254 URL: http://jira.codehaus.org/browse/MNG-2254 Project: Maven 2 Issue Type: Bug Components: POM::Encoding Reporter: Naoki Nose Assignee: Jason van Zyl Fix For: 2.0.8 Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, mng-2254-PomEncoding.tgz, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored. to fix this problem, We should - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly - regenerate maven-model using fixed modello-plugin-xpp3 - fix DefaultMavenProjectBuilder to use regenerated maven-model properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml declaration of POM is ignored
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_109597 ] Brian Fox commented on MNG-2254: Can someone make an IT for this? See the instructions here: http://docs.codehaus.org/display/MAVEN/Creating+a+Maven+Integration+Test the encoding parameter in xml declaration of POM is ignored Key: MNG-2254 URL: http://jira.codehaus.org/browse/MNG-2254 Project: Maven 2 Issue Type: Bug Components: POM::Encoding Reporter: Naoki Nose Assignee: Jason van Zyl Fix For: 2.0.8 Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored. to fix this problem, We should - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly - regenerate maven-model using fixed modello-plugin-xpp3 - fix DefaultMavenProjectBuilder to use regenerated maven-model properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml declaration of POM is ignored
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105369 ] Andrew Williams commented on MNG-2254: -- Can you please clarify which patches apply and which do not the encoding parameter in xml declaration of POM is ignored Key: MNG-2254 URL: http://jira.codehaus.org/browse/MNG-2254 Project: Maven 2 Issue Type: Bug Components: POM::Encoding Reporter: Naoki Nose Assignee: Jason van Zyl Fix For: 2.0.8 Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored. to fix this problem, We should - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly - regenerate maven-model using fixed modello-plugin-xpp3 - fix DefaultMavenProjectBuilder to use regenerated maven-model properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml declaration of POM is ignored
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105371 ] Herve Boutemy commented on MNG-2254: the 2 latest only are to be applied: - MNG-2254_artifact.diff for maven/artifact/trunk and maven/components/branches/maven-2.0.x/maven-artifact - MNG-2254_components.diff for maven/components/trunk and maven/components/branches/maven-2.0.x the encoding parameter in xml declaration of POM is ignored Key: MNG-2254 URL: http://jira.codehaus.org/browse/MNG-2254 Project: Maven 2 Issue Type: Bug Components: POM::Encoding Reporter: Naoki Nose Assignee: Jason van Zyl Fix For: 2.0.8 Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored. to fix this problem, We should - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly - regenerate maven-model using fixed modello-plugin-xpp3 - fix DefaultMavenProjectBuilder to use regenerated maven-model properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml declaration of POM is ignored
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102856 ] Jason van Zyl commented on MNG-2254: I will take a look, I have walked through everything else this week: plexus and modello, so now I can push in the changes into Maven's core. the encoding parameter in xml declaration of POM is ignored Key: MNG-2254 URL: http://jira.codehaus.org/browse/MNG-2254 Project: Maven 2 Issue Type: Bug Components: POM::Encoding Reporter: Naoki Nose Assignee: Jason van Zyl Fix For: 2.0.8 Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, modello-plugin-xpp3.diff DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored. to fix this problem, We should - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly - regenerate maven-model using fixed modello-plugin-xpp3 - fix DefaultMavenProjectBuilder to use regenerated maven-model properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml declaration of POM is ignored
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_100267 ] Herve Boutemy commented on MNG-2254: for problems about encodings, there are ways to write a Reader that automagically detects the encoding of a XML stream: see https://rome.dev.java.net/apidocs/0_5/com/sun/syndication/io/XmlReader.html this permits to use a reader as a source for an XML parser without loosing any information: the magic is done by the reader, not by the parser. Such a solution would be an easy fix: the actual MavenXpp3Reader signature could be sufficient (even if using an InputStream would be more classical) the encoding parameter in xml declaration of POM is ignored Key: MNG-2254 URL: http://jira.codehaus.org/browse/MNG-2254 Project: Maven 2 Issue Type: Bug Components: POM::Encoding Reporter: Naoki Nose Assignee: Jason van Zyl Fix For: 2.1.x Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored. to fix this problem, We should - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly - regenerate maven-model using fixed modello-plugin-xpp3 - fix DefaultMavenProjectBuilder to use regenerated maven-model properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml declaration of POM is ignored
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_100268 ] Jason van Zyl commented on MNG-2254: Herve, if you want take a crack at this I would certainly incorporate this into Modello. the encoding parameter in xml declaration of POM is ignored Key: MNG-2254 URL: http://jira.codehaus.org/browse/MNG-2254 Project: Maven 2 Issue Type: Bug Components: POM::Encoding Reporter: Naoki Nose Assignee: Jason van Zyl Fix For: 2.1.x Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored. to fix this problem, We should - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly - regenerate maven-model using fixed modello-plugin-xpp3 - fix DefaultMavenProjectBuilder to use regenerated maven-model properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml declaration of POM is ignored
[ http://jira.codehaus.org/browse/MNG-2254?page=comments#action_65078 ] Stefan Hübner commented on MNG-2254: As I just stated in MNG-2255 I think, that ??...the parser used to read in maven's model isn't the problem really. It's more likely the way the POM is handed to the parser.?? See MNG-2255 for full discussion of the issue. the encoding parameter in xml declaration of POM is ignored Key: MNG-2254 URL: http://jira.codehaus.org/browse/MNG-2254 Project: Maven 2 Type: Bug Reporter: Naoki Nose Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored. to fix this problem, We should - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly - regenerate maven-model using fixed modello-plugin-xpp3 - fix DefaultMavenProjectBuilder to use regenerated maven-model properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml declaration of POM is ignored
[ http://jira.codehaus.org/browse/MNG-2254?page=comments#action_64670 ] Carlos Sanchez commented on MNG-2254: - it'd be better to swith to a external xml parser, see MNG-2255 the encoding parameter in xml declaration of POM is ignored Key: MNG-2254 URL: http://jira.codehaus.org/browse/MNG-2254 Project: Maven 2 Type: Bug Reporter: Naoki Nose Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored. to fix this problem, We should - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly - regenerate maven-model using fixed modello-plugin-xpp3 - fix DefaultMavenProjectBuilder to use regenerated maven-model properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml declaration of POM is ignored
[ http://jira.codehaus.org/browse/MNG-2254?page=comments#action_64373 ] Naoki Nose commented on MNG-2254: - Attached files are the patch to fix this issue. These files depend on the patch of MXParser which I attached to the following issue. http://jira.codehaus.org/browse/MNG-2148 using a external standard xml pull parser may be better solution, as discussed in the following issue. http://jira.codehaus.org/browse/DOXIA-60 the encoding parameter in xml declaration of POM is ignored Key: MNG-2254 URL: http://jira.codehaus.org/browse/MNG-2254 Project: Maven 2 Type: Bug Reporter: Naoki Nose Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored. to fix this problem, We should - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly - regenerate maven-model using fixed modello-plugin-xpp3 - fix DefaultMavenProjectBuilder to use regenerated maven-model properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
