[jira] Commented: (MNG-3461) Mirrors should not apply to file:// repositories
[ http://jira.codehaus.org/browse/MNG-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127534 ] John Casey commented on MNG-3461: - I've reviewed the patch, and all looks good with it. I think even UNC paths will work out alright here, since you have to provide a protocol for the repository to work. In UNC cases, this would be 'file://' which would mean that the \\server\path\to\repo UNC path should render 'server' as the host name, which is != localhost, and therefore matches external:*. > Mirrors should not apply to file:// repositories > > > Key: MNG-3461 > URL: http://jira.codehaus.org/browse/MNG-3461 > Project: Maven 2 > Issue Type: Improvement > Components: Artifacts and Repositories >Affects Versions: 2.0.8 >Reporter: Brian Fox >Assignee: John Casey > Fix For: 2.0.9 > > Attachments: mng-3461.diff > > > I ran into some issues recently with the IT tests. I use a mirrorof * to > redirect everything to a repo manager but this is also redirecting the file > based repositories. I can't think of any good reason this should apply to > anything other than remote repos. I have two proposals: > > 1. Change maven so that file based repos ignore all mirror settings > 2. Change maven so that file based repos ignore the wildcard but > will respond if the mirror specifically names it. > > I can't think of any reason why a mirror should override a local repo so I > suggest we go with #1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3461) Mirrors should not apply to file:// repositories
[ http://jira.codehaus.org/browse/MNG-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127306 ] John Casey commented on MNG-3461: - Link to proposal: http://docs.codehaus.org/display/MAVEN/Mirror+Settings+and+File+repositories > Mirrors should not apply to file:// repositories > > > Key: MNG-3461 > URL: http://jira.codehaus.org/browse/MNG-3461 > Project: Maven 2 > Issue Type: Improvement > Components: Artifacts and Repositories >Affects Versions: 2.0.8 >Reporter: Brian Fox > Fix For: 2.0.9 > > > I ran into some issues recently with the IT tests. I use a mirrorof * to > redirect everything to a repo manager but this is also redirecting the file > based repositories. I can't think of any good reason this should apply to > anything other than remote repos. I have two proposals: > > 1. Change maven so that file based repos ignore all mirror settings > 2. Change maven so that file based repos ignore the wildcard but > will respond if the mirror specifically names it. > > I can't think of any reason why a mirror should override a local repo so I > suggest we go with #1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3461) Mirrors should not apply to file:// repositories
[ http://jira.codehaus.org/browse/MNG-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127305 ] John Casey commented on MNG-3461: - IMO it's really unfortunate that we started using regex-like syntax for mirrorOf in the first place. Having reserve words instead, like 'all' or 'external', would be better since it would allow flexibility to expand in precisely this way. I'd be in favor of an 'external:*' syntax to mean anything not on this machine (using file:// or localhost as the host would be "this machine" IMO). Maybe we can start introducing these reserved words now? > Mirrors should not apply to file:// repositories > > > Key: MNG-3461 > URL: http://jira.codehaus.org/browse/MNG-3461 > Project: Maven 2 > Issue Type: Improvement > Components: Artifacts and Repositories >Affects Versions: 2.0.8 >Reporter: Brian Fox > Fix For: 2.0.9 > > > I ran into some issues recently with the IT tests. I use a mirrorof * to > redirect everything to a repo manager but this is also redirecting the file > based repositories. I can't think of any good reason this should apply to > anything other than remote repos. I have two proposals: > > 1. Change maven so that file based repos ignore all mirror settings > 2. Change maven so that file based repos ignore the wildcard but > will respond if the mirror specifically names it. > > I can't think of any reason why a mirror should override a local repo so I > suggest we go with #1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3461) Mirrors should not apply to file:// repositories
[ http://jira.codehaus.org/browse/MNG-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127165 ] Brian Fox commented on MNG-3461: I guess I can live with that. The reason I was thinking of still skipping the file ones is that you may have a name conflict and you didn't mean the one with the file, but the one with the http. > Mirrors should not apply to file:// repositories > > > Key: MNG-3461 > URL: http://jira.codehaus.org/browse/MNG-3461 > Project: Maven 2 > Issue Type: Improvement > Components: Artifacts and Repositories >Affects Versions: 2.0.8 >Reporter: Brian Fox > > I ran into some issues recently with the IT tests. I use a mirrorof * to > redirect everything to a repo manager but this is also redirecting the file > based repositories. I can't think of any good reason this should apply to > anything other than remote repos. I have two proposals: > > 1. Change maven so that file based repos ignore all mirror settings > 2. Change maven so that file based repos ignore the wildcard but > will respond if the mirror specifically names it. > > I can't think of any reason why a mirror should override a local repo so I > suggest we go with #1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3461) Mirrors should not apply to file:// repositories
[ http://jira.codehaus.org/browse/MNG-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127158 ] Carlos Sanchez commented on MNG-3461: - #2 if I explicitly want to mirror a file repo I should be able to > Mirrors should not apply to file:// repositories > > > Key: MNG-3461 > URL: http://jira.codehaus.org/browse/MNG-3461 > Project: Maven 2 > Issue Type: Improvement > Components: Artifacts and Repositories >Affects Versions: 2.0.8 >Reporter: Brian Fox > > I ran into some issues recently with the IT tests. I use a mirrorof * to > redirect everything to a repo manager but this is also redirecting the file > based repositories. I can't think of any good reason this should apply to > anything other than remote repos. I have two proposals: > > 1. Change maven so that file based repos ignore all mirror settings > 2. Change maven so that file based repos ignore the wildcard but > will respond if the mirror specifically names it. > > I can't think of any reason why a mirror should override a local repo so I > suggest we go with #1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
