[jira] Commented: (MNG-3719) [regression] plugin execution ordering no longer POM ordered in 2.0.9
[
http://jira.codehaus.org/browse/MNG-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=179886#action_179886
]
Brett Porter commented on MNG-3719:
---
more details please - the IT passes. I would prefer we re-close this based on
the successful IT and open a new issue if there is a variant use case that
fails.
[regression] plugin execution ordering no longer POM ordered in 2.0.9
-
Key: MNG-3719
URL: http://jira.codehaus.org/browse/MNG-3719
Project: Maven 2
Issue Type: Bug
Components: POM
Affects Versions: 2.0.9, 2.0.10, 2.1.0-M1
Environment: Maven 2.0.9, java version 1.5.0_13 Java(TM) 2 Runtime
Environment, Standard Edition (build 1.5.0_13-b05-241) Java HotSpot(TM)
Client VM (build 1.5.0_13-120, mixed mode, sharing), OS X 10.4
Reporter: Gary S. Weaver
Assignee: John Casey
Priority: Critical
Fix For: 2.0.11, 2.1.0
Attachments: MNG-3719-maven-project.patch,
plugin-execution-order-cant-be-defined-maven-2.0.9.tar.gz
I extend my sincere apologies if there is a much easier way of doing this,
but so far I haven't found any.
There should be some way to ensure order of plugin executions through
dependencies on other executions. See attached project for example, or see
below for the applicable example in a pom.xml. When plugins are defined in
pom.xml in the following manner to ensure correct execution order, they are
not executed sequentially and there is no way to indicate dependencies, as
would be expected (note- I'm not expecting that it interpret the step 1...,
..., step 5... IDs, I'm only suggesting that either the plugins be executed
in order that they are found in the XML (most intuitive) or that there be
some concept of priority/ordinal added, or even perhaps (this would be most
ant-like) that plugin executions (and maybe even plugin goal executions) be
allowed to define prequisite execution IDs to be run (even if they are IDs
not defined in the pom, but maybe a parent pom, even though I don't need that
right now).
I know that this could be problematic if a plugin execution from one
lifecycle phase depends on another from another lifecycle phase (and you
could get into circular references that way that would have to be recognized
during pom validation after loading/merging pom.xmls). However, not being
able to at the very least define order of execution of different (or the
same) plugin executions as noted below and in attached project makes it
difficult to chain plugin executions that depend on each other, thereby
reducing the practicality of the pom.xml and Maven 2.
For example, these plugin executions cannot be ordered properly in Maven
2.0.9, since there appears to be no way to indicate dependencies of one
execution on another:
{code}
build
plugins
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-compiler-plugin/artifactId
configuration
source1.5/source
target1.5/target
/configuration
/plugin
plugin
!-- backup original source web.xml in preparation for
chaining of plugin modifications to it --
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-antrun-plugin/artifactId
executions
execution
idstep 1 - backup-original-web.xml-from-src/id
phasegenerate-resources/phase
goals
goalrun/goal
/goals
configuration
tasks
mkdir dir=${pom.basedir}/target/
mkdir dir=${pom.basedir}/target/tmpwebxml/
copy
file=${pom.basedir}/src/main/webapp/WEB-INF/web.xml
todir=${pom.basedir}/target/tmpwebxml//
/tasks
/configuration
/execution
/executions
/plugin
plugin
!-- this plugin converts to
${basedir}/src/main/webapp/WEB-INF/web.xml to ${basedir}/target/jspweb.xml --
groupIdorg.codehaus.mojo/groupId
artifactIdjspc-maven-plugin/artifactId
executions
execution
idstep 2 - jspc/id
phasegenerate-resources/phase
goals
goalcompile/goal
/goals
/execution
/executions
[jira] Commented: (MNG-3719) [regression] plugin execution ordering no longer POM ordered in 2.0.9
[
http://jira.codehaus.org/browse/MNG-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=164377#action_164377
]
Brett Porter commented on MNG-3719:
---
Yep, I already updated the docs :)
[regression] plugin execution ordering no longer POM ordered in 2.0.9
-
Key: MNG-3719
URL: http://jira.codehaus.org/browse/MNG-3719
Project: Maven 2
Issue Type: Bug
Components: POM
Affects Versions: 2.0.9, 2.0.10, 2.1.0-M1
Environment: Maven 2.0.9, java version 1.5.0_13 Java(TM) 2 Runtime
Environment, Standard Edition (build 1.5.0_13-b05-241) Java HotSpot(TM)
Client VM (build 1.5.0_13-120, mixed mode, sharing), OS X 10.4
Reporter: Gary S. Weaver
Assignee: Brett Porter
Priority: Critical
Fix For: 2.0.11, 2.1.0-M2
Attachments: MNG-3719-maven-project.patch,
plugin-execution-order-cant-be-defined-maven-2.0.9.tar.gz
I extend my sincere apologies if there is a much easier way of doing this,
but so far I haven't found any.
There should be some way to ensure order of plugin executions through
dependencies on other executions. See attached project for example, or see
below for the applicable example in a pom.xml. When plugins are defined in
pom.xml in the following manner to ensure correct execution order, they are
not executed sequentially and there is no way to indicate dependencies, as
would be expected (note- I'm not expecting that it interpret the step 1...,
..., step 5... IDs, I'm only suggesting that either the plugins be executed
in order that they are found in the XML (most intuitive) or that there be
some concept of priority/ordinal added, or even perhaps (this would be most
ant-like) that plugin executions (and maybe even plugin goal executions) be
allowed to define prequisite execution IDs to be run (even if they are IDs
not defined in the pom, but maybe a parent pom, even though I don't need that
right now).
I know that this could be problematic if a plugin execution from one
lifecycle phase depends on another from another lifecycle phase (and you
could get into circular references that way that would have to be recognized
during pom validation after loading/merging pom.xmls). However, not being
able to at the very least define order of execution of different (or the
same) plugin executions as noted below and in attached project makes it
difficult to chain plugin executions that depend on each other, thereby
reducing the practicality of the pom.xml and Maven 2.
For example, these plugin executions cannot be ordered properly in Maven
2.0.9, since there appears to be no way to indicate dependencies of one
execution on another:
{code}
build
plugins
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-compiler-plugin/artifactId
configuration
source1.5/source
target1.5/target
/configuration
/plugin
plugin
!-- backup original source web.xml in preparation for
chaining of plugin modifications to it --
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-antrun-plugin/artifactId
executions
execution
idstep 1 - backup-original-web.xml-from-src/id
phasegenerate-resources/phase
goals
goalrun/goal
/goals
configuration
tasks
mkdir dir=${pom.basedir}/target/
mkdir dir=${pom.basedir}/target/tmpwebxml/
copy
file=${pom.basedir}/src/main/webapp/WEB-INF/web.xml
todir=${pom.basedir}/target/tmpwebxml//
/tasks
/configuration
/execution
/executions
/plugin
plugin
!-- this plugin converts to
${basedir}/src/main/webapp/WEB-INF/web.xml to ${basedir}/target/jspweb.xml --
groupIdorg.codehaus.mojo/groupId
artifactIdjspc-maven-plugin/artifactId
executions
execution
idstep 2 - jspc/id
phasegenerate-resources/phase
goals
goalcompile/goal
/goals
/execution
/executions
configuration
injectStringlt;!-- [INSERT JSPC FRAGMENT HERE]
--gt;/injectString
[jira] Commented: (MNG-3719) [regression] plugin execution ordering no longer POM ordered in 2.0.9
[
http://jira.codehaus.org/browse/MNG-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=164221#action_164221
]
Brett Porter commented on MNG-3719:
---
I noted that this is only an issue when there is more than one declaration of a
particular plugin.
Since MNG-2145, multiple declarations are grouped together as if there were
executions in one plugin. This patch simply sorts those executions correctly.
I think the original poster wanted the old functionality back where plugins
could be declared multiple times and run in order - however I'm not prepared to
undo that on 2.0.x.
I've applied the patch to resolve the issue.
[regression] plugin execution ordering no longer POM ordered in 2.0.9
-
Key: MNG-3719
URL: http://jira.codehaus.org/browse/MNG-3719
Project: Maven 2
Issue Type: Bug
Components: POM
Affects Versions: 2.0.9, 2.0.10, 2.1.0-M1
Environment: Maven 2.0.9, java version 1.5.0_13 Java(TM) 2 Runtime
Environment, Standard Edition (build 1.5.0_13-b05-241) Java HotSpot(TM)
Client VM (build 1.5.0_13-120, mixed mode, sharing), OS X 10.4
Reporter: Gary S. Weaver
Priority: Critical
Fix For: 2.0.11, 2.1.0-M2
Attachments: MNG-3719-maven-project.patch,
plugin-execution-order-cant-be-defined-maven-2.0.9.tar.gz
I extend my sincere apologies if there is a much easier way of doing this,
but so far I haven't found any.
There should be some way to ensure order of plugin executions through
dependencies on other executions. See attached project for example, or see
below for the applicable example in a pom.xml. When plugins are defined in
pom.xml in the following manner to ensure correct execution order, they are
not executed sequentially and there is no way to indicate dependencies, as
would be expected (note- I'm not expecting that it interpret the step 1...,
..., step 5... IDs, I'm only suggesting that either the plugins be executed
in order that they are found in the XML (most intuitive) or that there be
some concept of priority/ordinal added, or even perhaps (this would be most
ant-like) that plugin executions (and maybe even plugin goal executions) be
allowed to define prequisite execution IDs to be run (even if they are IDs
not defined in the pom, but maybe a parent pom, even though I don't need that
right now).
I know that this could be problematic if a plugin execution from one
lifecycle phase depends on another from another lifecycle phase (and you
could get into circular references that way that would have to be recognized
during pom validation after loading/merging pom.xmls). However, not being
able to at the very least define order of execution of different (or the
same) plugin executions as noted below and in attached project makes it
difficult to chain plugin executions that depend on each other, thereby
reducing the practicality of the pom.xml and Maven 2.
For example, these plugin executions cannot be ordered properly in Maven
2.0.9, since there appears to be no way to indicate dependencies of one
execution on another:
{code}
build
plugins
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-compiler-plugin/artifactId
configuration
source1.5/source
target1.5/target
/configuration
/plugin
plugin
!-- backup original source web.xml in preparation for
chaining of plugin modifications to it --
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-antrun-plugin/artifactId
executions
execution
idstep 1 - backup-original-web.xml-from-src/id
phasegenerate-resources/phase
goals
goalrun/goal
/goals
configuration
tasks
mkdir dir=${pom.basedir}/target/
mkdir dir=${pom.basedir}/target/tmpwebxml/
copy
file=${pom.basedir}/src/main/webapp/WEB-INF/web.xml
todir=${pom.basedir}/target/tmpwebxml//
/tasks
/configuration
/execution
/executions
/plugin
plugin
!-- this plugin converts to
${basedir}/src/main/webapp/WEB-INF/web.xml to ${basedir}/target/jspweb.xml --
groupIdorg.codehaus.mojo/groupId
artifactIdjspc-maven-plugin/artifactId
executions
[jira] Commented: (MNG-3719) [regression] plugin execution ordering no longer POM ordered in 2.0.9
[
http://jira.codehaus.org/browse/MNG-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=164239#action_164239
]
Torben S. Giesselmann commented on MNG-3719:
Exactly, the problem came from from merging multiple plugin declarations into
one. I still think the docs should be updated, though.
[regression] plugin execution ordering no longer POM ordered in 2.0.9
-
Key: MNG-3719
URL: http://jira.codehaus.org/browse/MNG-3719
Project: Maven 2
Issue Type: Bug
Components: POM
Affects Versions: 2.0.9, 2.0.10, 2.1.0-M1
Environment: Maven 2.0.9, java version 1.5.0_13 Java(TM) 2 Runtime
Environment, Standard Edition (build 1.5.0_13-b05-241) Java HotSpot(TM)
Client VM (build 1.5.0_13-120, mixed mode, sharing), OS X 10.4
Reporter: Gary S. Weaver
Assignee: Brett Porter
Priority: Critical
Fix For: 2.0.11, 2.1.0-M2
Attachments: MNG-3719-maven-project.patch,
plugin-execution-order-cant-be-defined-maven-2.0.9.tar.gz
I extend my sincere apologies if there is a much easier way of doing this,
but so far I haven't found any.
There should be some way to ensure order of plugin executions through
dependencies on other executions. See attached project for example, or see
below for the applicable example in a pom.xml. When plugins are defined in
pom.xml in the following manner to ensure correct execution order, they are
not executed sequentially and there is no way to indicate dependencies, as
would be expected (note- I'm not expecting that it interpret the step 1...,
..., step 5... IDs, I'm only suggesting that either the plugins be executed
in order that they are found in the XML (most intuitive) or that there be
some concept of priority/ordinal added, or even perhaps (this would be most
ant-like) that plugin executions (and maybe even plugin goal executions) be
allowed to define prequisite execution IDs to be run (even if they are IDs
not defined in the pom, but maybe a parent pom, even though I don't need that
right now).
I know that this could be problematic if a plugin execution from one
lifecycle phase depends on another from another lifecycle phase (and you
could get into circular references that way that would have to be recognized
during pom validation after loading/merging pom.xmls). However, not being
able to at the very least define order of execution of different (or the
same) plugin executions as noted below and in attached project makes it
difficult to chain plugin executions that depend on each other, thereby
reducing the practicality of the pom.xml and Maven 2.
For example, these plugin executions cannot be ordered properly in Maven
2.0.9, since there appears to be no way to indicate dependencies of one
execution on another:
{code}
build
plugins
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-compiler-plugin/artifactId
configuration
source1.5/source
target1.5/target
/configuration
/plugin
plugin
!-- backup original source web.xml in preparation for
chaining of plugin modifications to it --
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-antrun-plugin/artifactId
executions
execution
idstep 1 - backup-original-web.xml-from-src/id
phasegenerate-resources/phase
goals
goalrun/goal
/goals
configuration
tasks
mkdir dir=${pom.basedir}/target/
mkdir dir=${pom.basedir}/target/tmpwebxml/
copy
file=${pom.basedir}/src/main/webapp/WEB-INF/web.xml
todir=${pom.basedir}/target/tmpwebxml//
/tasks
/configuration
/execution
/executions
/plugin
plugin
!-- this plugin converts to
${basedir}/src/main/webapp/WEB-INF/web.xml to ${basedir}/target/jspweb.xml --
groupIdorg.codehaus.mojo/groupId
artifactIdjspc-maven-plugin/artifactId
executions
execution
idstep 2 - jspc/id
phasegenerate-resources/phase
goals
goalcompile/goal
/goals
/execution
/executions
[jira] Commented: (MNG-3719) [regression] plugin execution ordering no longer POM ordered in 2.0.9
[
http://jira.codehaus.org/browse/MNG-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=163906#action_163906
]
Torben S. Giesselmann commented on MNG-3719:
Since the patch won't make it into 2.0.10, the documentation at
http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
should be updated in the meantime. To avoid any confusion, it should be
mentioned that there's a problem. Or remove the comment altogether or change it
to As of 2.0.11.
[regression] plugin execution ordering no longer POM ordered in 2.0.9
-
Key: MNG-3719
URL: http://jira.codehaus.org/browse/MNG-3719
Project: Maven 2
Issue Type: Bug
Components: POM
Affects Versions: 2.0.9, 2.0.10, 2.1.0-M1
Environment: Maven 2.0.9, java version 1.5.0_13 Java(TM) 2 Runtime
Environment, Standard Edition (build 1.5.0_13-b05-241) Java HotSpot(TM)
Client VM (build 1.5.0_13-120, mixed mode, sharing), OS X 10.4
Reporter: Gary S. Weaver
Priority: Critical
Fix For: 2.0.11, 2.1.0-M2
Attachments: MNG-3719-maven-project.patch,
plugin-execution-order-cant-be-defined-maven-2.0.9.tar.gz
I extend my sincere apologies if there is a much easier way of doing this,
but so far I haven't found any.
There should be some way to ensure order of plugin executions through
dependencies on other executions. See attached project for example, or see
below for the applicable example in a pom.xml. When plugins are defined in
pom.xml in the following manner to ensure correct execution order, they are
not executed sequentially and there is no way to indicate dependencies, as
would be expected (note- I'm not expecting that it interpret the step 1...,
..., step 5... IDs, I'm only suggesting that either the plugins be executed
in order that they are found in the XML (most intuitive) or that there be
some concept of priority/ordinal added, or even perhaps (this would be most
ant-like) that plugin executions (and maybe even plugin goal executions) be
allowed to define prequisite execution IDs to be run (even if they are IDs
not defined in the pom, but maybe a parent pom, even though I don't need that
right now).
I know that this could be problematic if a plugin execution from one
lifecycle phase depends on another from another lifecycle phase (and you
could get into circular references that way that would have to be recognized
during pom validation after loading/merging pom.xmls). However, not being
able to at the very least define order of execution of different (or the
same) plugin executions as noted below and in attached project makes it
difficult to chain plugin executions that depend on each other, thereby
reducing the practicality of the pom.xml and Maven 2.
For example, these plugin executions cannot be ordered properly in Maven
2.0.9, since there appears to be no way to indicate dependencies of one
execution on another:
{code}
build
plugins
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-compiler-plugin/artifactId
configuration
source1.5/source
target1.5/target
/configuration
/plugin
plugin
!-- backup original source web.xml in preparation for
chaining of plugin modifications to it --
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-antrun-plugin/artifactId
executions
execution
idstep 1 - backup-original-web.xml-from-src/id
phasegenerate-resources/phase
goals
goalrun/goal
/goals
configuration
tasks
mkdir dir=${pom.basedir}/target/
mkdir dir=${pom.basedir}/target/tmpwebxml/
copy
file=${pom.basedir}/src/main/webapp/WEB-INF/web.xml
todir=${pom.basedir}/target/tmpwebxml//
/tasks
/configuration
/execution
/executions
/plugin
plugin
!-- this plugin converts to
${basedir}/src/main/webapp/WEB-INF/web.xml to ${basedir}/target/jspweb.xml --
groupIdorg.codehaus.mojo/groupId
artifactIdjspc-maven-plugin/artifactId
executions
execution
idstep 2 - jspc/id
phasegenerate-resources/phase
goals
