[jira] Commented: (MNG-4830) Add helper component to build MavenExecutionRequest from cli args (String[] args)
[ http://jira.codehaus.org/browse/MNG-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=235934#action_235934 ] Jason van Zyl commented on MNG-4830: You should also then think about the invoker plugin, the release plugin and the verifier. If we're going to fix this we might as well fix it all. > Add helper component to build MavenExecutionRequest from cli args (String[] > args) > - > > Key: MNG-4830 > URL: http://jira.codehaus.org/browse/MNG-4830 > Project: Maven 2 & 3 > Issue Type: Improvement > Components: Bootstrap & Build, Command Line >Affects Versions: 3.0-beta-3 >Reporter: Olivier Lamy > > currently executing maven programmatically is quite difficult because > building easily a MavenExecutionRequest needs a lot of parameters, some > methods to call etc... > Here a simple component which build MavenExecutionRequest from String[] args > (cli arguments). > Source code is here : > [http://github.com/olamy/hudson-maven3-support/blob/master/maven3-listener/src/main/java/org/apache/maven/cli/MavenExecutionRequestBuilder.java]. > Any objection I commit this in ASF ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-4830) Add helper component to build MavenExecutionRequest from cli args (String[] args)
[ http://jira.codehaus.org/browse/MNG-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=235933#action_235933 ] Olivier Lamy commented on MNG-4830: --- that's exactly the goals : * get component to work in MavenCli * not having a -1 :-) > Add helper component to build MavenExecutionRequest from cli args (String[] > args) > - > > Key: MNG-4830 > URL: http://jira.codehaus.org/browse/MNG-4830 > Project: Maven 2 & 3 > Issue Type: Improvement > Components: Bootstrap & Build, Command Line >Affects Versions: 3.0-beta-3 >Reporter: Olivier Lamy > > currently executing maven programmatically is quite difficult because > building easily a MavenExecutionRequest needs a lot of parameters, some > methods to call etc... > Here a simple component which build MavenExecutionRequest from String[] args > (cli arguments). > Source code is here : > [http://github.com/olamy/hudson-maven3-support/blob/master/maven3-listener/src/main/java/org/apache/maven/cli/MavenExecutionRequestBuilder.java]. > Any objection I commit this in ASF ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-4830) Add helper component to build MavenExecutionRequest from cli args (String[] args)
[ http://jira.codehaus.org/browse/MNG-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=235931#action_235931 ] Jason van Zyl commented on MNG-4830: I'll try to glean what you mean here ... Have you basically extracted: http://github.com/olamy/hudson-maven3-support/blob/master/maven3-listener/src/main/java/org/apache/maven/cli/DefaultMavenExecutionRequestBuilder.java out of https://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java If so this would only be useful if we didn't have to duplicate code. So you need to figure out how to use this in the MavenCli in a way that reuses the code. Right now the components that are required are looked up directly by the container. So dropping your code right now in that form would just make a bunch of duplicate code. So until you find a way to make the same component work in both places I'm -1. If you can get your component to work in MavenCli I'm +1. > Add helper component to build MavenExecutionRequest from cli args (String[] > args) > - > > Key: MNG-4830 > URL: http://jira.codehaus.org/browse/MNG-4830 > Project: Maven 2 & 3 > Issue Type: Improvement > Components: Bootstrap & Build, Command Line >Affects Versions: 3.0-beta-3 >Reporter: Olivier Lamy > > currently executing maven programmatically is quite difficult because > building easily a MavenExecutionRequest needs a lot of parameters, some > methods to call etc... > Here a simple component which build MavenExecutionRequest from String[] args > (cli arguments). > Source code is here : > [http://github.com/olamy/hudson-maven3-support/blob/master/maven3-listener/src/main/java/org/apache/maven/cli/MavenExecutionRequestBuilder.java]. > Any objection I commit this in ASF ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-4830) Add helper component to build MavenExecutionRequest from cli args (String[] args)
[ http://jira.codehaus.org/browse/MNG-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=235925#action_235925 ] Olivier Lamy commented on MNG-4830: --- The goal is here to help people using maven programmaticaly. String array is just cli args and PrintStream is for logging. Sure it's not perfect but building manually MavenExecutionRequest and/or ProjectBuildingRequest is a little bit complicated and not really documented (ie what are necessary objects and/or components etc...). > Add helper component to build MavenExecutionRequest from cli args (String[] > args) > - > > Key: MNG-4830 > URL: http://jira.codehaus.org/browse/MNG-4830 > Project: Maven 2 & 3 > Issue Type: Improvement > Components: Bootstrap & Build, Command Line >Affects Versions: 3.0-beta-3 >Reporter: Olivier Lamy > > currently executing maven programmatically is quite difficult because > building easily a MavenExecutionRequest needs a lot of parameters, some > methods to call etc... > Here a simple component which build MavenExecutionRequest from String[] args > (cli arguments). > Source code is here : > [http://github.com/olamy/hudson-maven3-support/blob/master/maven3-listener/src/main/java/org/apache/maven/cli/MavenExecutionRequestBuilder.java]. > Any objection I commit this in ASF ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-4830) Add helper component to build MavenExecutionRequest from cli args (String[] args)
[ http://jira.codehaus.org/browse/MNG-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=235922#action_235922 ] Jason van Zyl commented on MNG-4830: Please keep this out of the core. I don't see how this method call helps anyone. An untype String array that accepts a PrintStream? Once stuff like this goes in that we haven't thought about very much has to be supported forever. I would prefer it not go in. > Add helper component to build MavenExecutionRequest from cli args (String[] > args) > - > > Key: MNG-4830 > URL: http://jira.codehaus.org/browse/MNG-4830 > Project: Maven 2 & 3 > Issue Type: Improvement > Components: Bootstrap & Build, Command Line >Affects Versions: 3.0-beta-3 >Reporter: Olivier Lamy > > currently executing maven programmatically is quite difficult because > building easily a MavenExecutionRequest needs a lot of parameters, some > methods to call etc... > Here a simple component which build MavenExecutionRequest from String[] args > (cli arguments). > Source code is here : > [http://github.com/olamy/hudson-maven3-support/blob/master/maven3-listener/src/main/java/org/apache/maven/cli/MavenExecutionRequestBuilder.java]. > Any objection I commit this in ASF ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
