[jira] Commented: (MPIR-85) Refactoring of dependency and dependency management report
[ http://jira.codehaus.org/browse/MPIR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=140735#action_140735 ] Vincent Siveton commented on MPIR-85: - Hi Nick, I am working to prepare the release of the MPIR. Could you send us a one-in-one patch? Tx Refactoring of dependency and dependency management report -- Key: MPIR-85 URL: http://jira.codehaus.org/browse/MPIR-85 Project: Maven 2.x Project Info Reports Plugin Issue Type: Improvement Components: dependencies, dependency-management Affects Versions: 2.1 Reporter: Nick Stolwijk Attachments: comparators.patch, refactor.patch, refactor.patch I've tried to refactor the code from MPIR-83 a bit, because it used a lot of copied code. Important improvements: - Created a AbstractProjectInfoRenderer and AbstractDependencyRenderer. If this patch is accepted, I want to write all the renderers out of the inforeports in separate classes, with more code sharing. This is a start of that. - I changed the unit tests, because the expected and actual were reversed. This is the case in many of the info report unit tests. Please tell me what you think of it. I know it is only a start. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPIR-85) Refactoring of dependency and dependency management report
[ http://jira.codehaus.org/browse/MPIR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=130185#action_130185 ] Dennis Lundberg commented on MPIR-85: - Nick, which of the three patch files is it that should be applied? I'm a bit confused... Refactoring of dependency and dependency management report -- Key: MPIR-85 URL: http://jira.codehaus.org/browse/MPIR-85 Project: Maven 2.x Project Info Reports Plugin Issue Type: Improvement Affects Versions: 2.1 Reporter: Nick Stolwijk Attachments: comparators.patch, refactor.patch, refactor.patch I've tried to refactor the code from MPIR-83 a bit, because it used a lot of copied code. Important improvements: - Created a AbstractProjectInfoRenderer and AbstractDependencyRenderer. If this patch is accepted, I want to write all the renderers out of the inforeports in separate classes, with more code sharing. This is a start of that. - I changed the unit tests, because the expected and actual were reversed. This is the case in many of the info report unit tests. Please tell me what you think of it. I know it is only a start. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPIR-85) Refactoring of dependency and dependency management report
[ http://jira.codehaus.org/browse/MPIR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126065 ] Vincent Siveton commented on MPIR-85: - IMHO it is a good work. Thanks! I have some comments on the code: * I dont like AbstractDependencies#getScope(Object) Why not using getScope() directly ? * could you provide some test cases for new comparator classes? Some comments on the Maven code convention: * we don't use final at all, specially in methods definition/signature * could you separated public/protected/private in each class to make the code more readingness? * could you comment a minimum with javadoc, specially abstract classes? Btw it is $Id: $ (with colon) for the @version tag I think you could go ahead. Refactoring of dependency and dependency management report -- Key: MPIR-85 URL: http://jira.codehaus.org/browse/MPIR-85 Project: Maven 2.x Project Info Reports Plugin Issue Type: Improvement Affects Versions: 2.1 Reporter: Nick Stolwijk Attachments: refactor.patch I've tried to refactor the code from MPIR-83 a bit, because it used a lot of copied code. Important improvements: - Created a AbstractProjectInfoRenderer and AbstractDependencyRenderer. If this patch is accepted, I want to write all the renderers out of the inforeports in separate classes, with more code sharing. This is a start of that. - I changed the unit tests, because the expected and actual were reversed. This is the case in many of the info report unit tests. Please tell me what you think of it. I know it is only a start. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPIR-85) Refactoring of dependency and dependency management report
[ http://jira.codehaus.org/browse/MPIR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126067 ] Vincent Siveton commented on MPIR-85: - Another thought for the getScope() issue: you could also create a wrapper for Artifact and Dependency Refactoring of dependency and dependency management report -- Key: MPIR-85 URL: http://jira.codehaus.org/browse/MPIR-85 Project: Maven 2.x Project Info Reports Plugin Issue Type: Improvement Affects Versions: 2.1 Reporter: Nick Stolwijk Attachments: refactor.patch I've tried to refactor the code from MPIR-83 a bit, because it used a lot of copied code. Important improvements: - Created a AbstractProjectInfoRenderer and AbstractDependencyRenderer. If this patch is accepted, I want to write all the renderers out of the inforeports in separate classes, with more code sharing. This is a start of that. - I changed the unit tests, because the expected and actual were reversed. This is the case in many of the info report unit tests. Please tell me what you think of it. I know it is only a start. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
