[jira] Commented: (MRELEASE-239) release:perform and release:prepare should accept multi-line goals/preparationGoals configurations

2011-11-10 Thread Stephen Connolly (JIRA)

[ 
https://jira.codehaus.org/browse/MRELEASE-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=283192#comment-283192
 ] 

Stephen Connolly commented on MRELEASE-239:
---

Actually, just I'll re-open this bug rather than open a new one

> release:perform and release:prepare should accept multi-line 
> goals/preparationGoals configurations
> --
>
> Key: MRELEASE-239
> URL: https://jira.codehaus.org/browse/MRELEASE-239
> Project: Maven 2.x Release Plugin
>  Issue Type: Improvement
>  Components: prepare
>Affects Versions: 2.0-beta-6
>Reporter: Steve Rowe
>Assignee: Stephen Connolly
>Priority: Minor
> Fix For: 2.2.1
>
> Attachments: ForkedMavenExecutor.patch
>
>
> When I specify a list of goals in my POM that span multiple lines (see an 
> example below), only those goals before the newline are executed when I run 
> "mvn release:perform". 
> I have only noticed this for release:perform, but given what the code looks 
> like, I assume it's an issue for release:prepare too.
> This is a minor problem, but an irritating one, because release:peform claims 
> to successfully complete without actually executing all specified goals.
> I attach a patch to ForkedMavenExecutor.java that splits the goals list on 
> newlines and carriage returns, in addition to the comma and space split 
> characters that were there already.
> Here's an example configuration that will trigger the problem:
>   
> maven-release-plugin
> 
>   ...
>   
> package group:first-goal group:second-goal group:third-goal
> site-deploy changes:announcement-generate 
> changes:announcement-mail
>   
> 
>   

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MRELEASE-239) release:perform and release:prepare should accept multi-line goals/preparationGoals configurations

2011-11-10 Thread Stephen Connolly (JIRA)

[ 
https://jira.codehaus.org/browse/MRELEASE-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=283191#comment-283191
 ] 

Stephen Connolly commented on MRELEASE-239:
---

One solution would be to create a profile that executes your required plugins 
and change the preparation goals to

-Pprepare-release

where the profile would look something like


  prepare-release
  
initialize 

  
org.codehaus.mojo
buildnumber-maven-plugin

  
prepare-release
validate

  create

  

   
  
fm.last.maven
changelog-maven-plugin

  
prepare-release
validate

  verify 
  update

  

   
  
maven-scm-plugin

  
prepare-release
initialize

  checkin

  

   

But you should create a separate bug for the line separator issue anyway

> release:perform and release:prepare should accept multi-line 
> goals/preparationGoals configurations
> --
>
> Key: MRELEASE-239
> URL: https://jira.codehaus.org/browse/MRELEASE-239
> Project: Maven 2.x Release Plugin
>  Issue Type: Improvement
>  Components: prepare
>Affects Versions: 2.0-beta-6
>Reporter: Steve Rowe
>Assignee: Stephen Connolly
>Priority: Minor
> Fix For: 2.2.1
>
> Attachments: ForkedMavenExecutor.patch
>
>
> When I specify a list of goals in my POM that span multiple lines (see an 
> example below), only those goals before the newline are executed when I run 
> "mvn release:perform". 
> I have only noticed this for release:perform, but given what the code looks 
> like, I assume it's an issue for release:prepare too.
> This is a minor problem, but an irritating one, because release:peform claims 
> to successfully complete without actually executing all specified goals.
> I attach a patch to ForkedMavenExecutor.java that splits the goals list on 
> newlines and carriage returns, in addition to the comma and space split 
> characters that were there already.
> Here's an example configuration that will trigger the problem:
>   
> maven-release-plugin
> 
>   ...
>   
> package group:first-goal group:second-goal group:third-goal
> site-deploy changes:announcement-generate 
> changes:announcement-mail
>   
> 
>   

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MRELEASE-239) release:perform and release:prepare should accept multi-line goals/preparationGoals configurations

2011-11-10 Thread Mass Dosage (JIRA)

[ 
https://jira.codehaus.org/browse/MRELEASE-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=283190#comment-283190
 ] 

Mass Dosage commented on MRELEASE-239:
--

I'm running version 2.2.1 of the maven-release-plugin and Maven 3. If we have a 
preparationGoals element that spans more than one line like so:
{code}

  fm.last.maven:changelog-maven-plugin:verify
org.codehaus.mojo:buildnumber-maven-plugin:create 
fm.last.maven:changelog-maven-plugin:update scm:checkin

{code}

The build fails with the following stack trace:

{code}
[INFO] /bin/sh: org.codehaus.mojo:buildnumber-maven-plugin:create: not found
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Last.fm parent POM  FAILURE [15.067s]
[INFO] Last.fm Parent project with legacy project layout . SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 16.816s
[INFO] Finished at: Thu Nov 10 09:46:25 GMT 2011
[INFO] Final Memory: 7M/89M
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-release-plugin:2.2.1:prepare (default-cli) on 
project parent: Maven execution failed, exit code: '127' -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-release-plugin:2.2.1:prepare (default-cli) on 
project parent: Maven execution failed, exit code: '127'
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: org.apache.maven.plugin.MojoExecutionException: Maven execution 
failed, exit code: '127'
at 
org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease(PrepareReleaseMojo.java:306)
at 
org.apache.maven.plugins.release.PrepareReleaseMojo.execute(PrepareReleaseMojo.java:258)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more
Caused by: org.apache.maven.shared.release.ReleaseExecutionException: Maven 
execution failed, exit code: '127'
at 
org.apache.maven.shared.release.phase.AbstractRunGoalsPhase.execute(AbstractRunGoalsPhase.java:89)
at 
org.apache.maven.shared.release.phase.RunPrepareGoalsPhase.execute(RunPrepareGoalsPhase.java:44)
at 
org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:206)
at 
org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:142)
at 
org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:104)
at 
org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease(PrepareReleaseMojo.java:302)
... 22 more
Caused by: org.apache.maven.shared.release.exec.MavenExecutorException: Maven 
execution failed, exit code: '127'
at 
org.apache.maven.shared.release.exec.InvokerMavenExecutor.execut