[jira] Commented: (MRELEASE-383) svn inconsistent line ending style
[
http://jira.codehaus.org/browse/MRELEASE-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209607#action_209607
]
Brett Porter commented on MRELEASE-383:
---
I believe I've fixed the test. Since the code always goes to to the platform's
LS, the test relies on the input files being in the platform's LS. However,
that wouldn't effectively test this problem on Linux machines, and would cause
the build to fail on Linux if you download a source distro with CRLF input
files.
I changed it so the input files are always CRLF just for this test, and that
the code runs with CRLF as the LS instead of the platform one, achieving
consistent results.
> svn inconsistent line ending style
> --
>
> Key: MRELEASE-383
> URL: http://jira.codehaus.org/browse/MRELEASE-383
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Barrie Treloar
>Assignee: nicolas de loof
> Fix For: 2.0
>
>
> The problem occurs in the CDATA section of the maven-eclipse-plugin -
> when setting the contents of the .checkstyle file.
> {code:xml}
> pom.xml
> ...
>
> org.apache.maven.plugins
> maven-eclipse-plugin
>
>true
>
>
> com.atlassw.tools.eclipse.checkstyle.CheckstyleBuilder
>
>
>
> com.atlassw.tools.eclipse.checkstyle.CheckstyleNature
>
>
>
>.checkstyle
>
>
>
>
>
>
>
>
> {code}
> When this file is transformed the CDATA section has LF only.
> On windows it should have CR LF.
> I suspect because it uses \n instead of System.getProperty( line.separator );
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-383) svn inconsistent line ending style
[
http://jira.codehaus.org/browse/MRELEASE-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194750#action_194750
]
nicolas de loof commented on MRELEASE-383:
--
svn:eol-style has been set to ensure reproductibility.
Can you please check the "expected" pom layout ?
test pass on CI server :-/
> svn inconsistent line ending style
> --
>
> Key: MRELEASE-383
> URL: http://jira.codehaus.org/browse/MRELEASE-383
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Barrie Treloar
>Assignee: nicolas de loof
> Fix For: 2.0-beta-10
>
>
> The problem occurs in the CDATA section of the maven-eclipse-plugin -
> when setting the contents of the .checkstyle file.
> {code:xml}
> pom.xml
> ...
>
> org.apache.maven.plugins
> maven-eclipse-plugin
>
>true
>
>
> com.atlassw.tools.eclipse.checkstyle.CheckstyleBuilder
>
>
>
> com.atlassw.tools.eclipse.checkstyle.CheckstyleNature
>
>
>
>.checkstyle
>
>
>
>
>
>
>
>
> {code}
> When this file is transformed the CDATA section has LF only.
> On windows it should have CR LF.
> I suspect because it uses \n instead of System.getProperty( line.separator );
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-383) svn inconsistent line ending style
[
http://jira.codehaus.org/browse/MRELEASE-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194734#action_194734
]
Holger Schinzel commented on MRELEASE-383:
--
RewritePomsForReleasePhaseTest.testRewritePomWithCDATASection() is failing on
my Linux box, too - Windows is running fine.
> svn inconsistent line ending style
> --
>
> Key: MRELEASE-383
> URL: http://jira.codehaus.org/browse/MRELEASE-383
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Barrie Treloar
>Assignee: nicolas de loof
> Fix For: 2.0-beta-10
>
>
> The problem occurs in the CDATA section of the maven-eclipse-plugin -
> when setting the contents of the .checkstyle file.
> {code:xml}
> pom.xml
> ...
>
> org.apache.maven.plugins
> maven-eclipse-plugin
>
>true
>
>
> com.atlassw.tools.eclipse.checkstyle.CheckstyleBuilder
>
>
>
> com.atlassw.tools.eclipse.checkstyle.CheckstyleNature
>
>
>
>.checkstyle
>
>
>
>
>
>
>
>
> {code}
> When this file is transformed the CDATA section has LF only.
> On windows it should have CR LF.
> I suspect because it uses \n instead of System.getProperty( line.separator );
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-383) svn inconsistent line ending style
[
http://jira.codehaus.org/browse/MRELEASE-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=190546#action_190546
]
Mike Dillon commented on MRELEASE-383:
--
I'm seeing a failure of this test on trunk now under Linux. It looks like the
only difference between the expected and received values is the line ending.
> svn inconsistent line ending style
> --
>
> Key: MRELEASE-383
> URL: http://jira.codehaus.org/browse/MRELEASE-383
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Barrie Treloar
>Assignee: nicolas de loof
> Fix For: 2.0-beta-10
>
>
> The problem occurs in the CDATA section of the maven-eclipse-plugin -
> when setting the contents of the .checkstyle file.
> {code:xml}
> pom.xml
> ...
>
> org.apache.maven.plugins
> maven-eclipse-plugin
>
>true
>
>
> com.atlassw.tools.eclipse.checkstyle.CheckstyleBuilder
>
>
>
> com.atlassw.tools.eclipse.checkstyle.CheckstyleNature
>
>
>
>.checkstyle
>
>
>
>
>
>
>
>
> {code}
> When this file is transformed the CDATA section has LF only.
> On windows it should have CR LF.
> I suspect because it uses \n instead of System.getProperty( line.separator );
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-383) svn inconsistent line ending style
[
http://jira.codehaus.org/browse/MRELEASE-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=153944#action_153944
]
Paul Benedict commented on MRELEASE-383:
This issue has bitten me too. I am unable to use the plugin with CDATA sections.
> svn inconsistent line ending style
> --
>
> Key: MRELEASE-383
> URL: http://jira.codehaus.org/browse/MRELEASE-383
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
>Reporter: Barrie Treloar
>
> The problem occurs in the CDATA section of the maven-eclipse-plugin -
> when setting the contents of the .checkstyle file.
> {code:xml}
> pom.xml
> ...
>
> org.apache.maven.plugins
> maven-eclipse-plugin
>
>true
>
>
> com.atlassw.tools.eclipse.checkstyle.CheckstyleBuilder
>
>
>
> com.atlassw.tools.eclipse.checkstyle.CheckstyleNature
>
>
>
>.checkstyle
>
>
>
>
>
>
>
>
> {code}
> When this file is transformed the CDATA section has LF only.
> On windows it should have CR LF.
> I suspect because it uses \n instead of System.getProperty( line.separator );
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
