[jira] Commented: (SCM-292) Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in memory clientspec names
[ http://jira.codehaus.org/browse/SCM-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_94674 ] Raphael PETIT commented on SCM-292: --- Currently, each client spec has - a root with the unique number at the end - a view defined by one line Maybe, it can be changed to a unique client spec - a root (global definition) - a view defined by several line the unique number at the end So things seems to be manageable without continnum concept in the scm... > Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in > memory clientspec names > > > Key: SCM-292 > URL: http://jira.codehaus.org/browse/SCM-292 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-perforce >Affects Versions: 1.0-beta-4 >Reporter: Emmanuel Venisse >Assignee: Patrick Schneider >Priority: Critical > Fix For: 1.0 > > > With a Map instead of a system property, we'll can support more that one > clientspec in the jvm. It's necessary for Continuum because it access to more > than one project in Perforce. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-292) Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in memory clientspec names
[ http://jira.codehaus.org/browse/SCM-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92506 ] Emmanuel Venisse commented on SCM-292: -- Mike, ping. > Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in > memory clientspec names > > > Key: SCM-292 > URL: http://jira.codehaus.org/browse/SCM-292 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-perforce >Affects Versions: 1.0-beta-4 >Reporter: Emmanuel Venisse >Assignee: Patrick Schneider >Priority: Critical > Fix For: 1.0-beta-5 > > > With a Map instead of a system property, we'll can support more that one > clientspec in the jvm. It's necessary for Continuum because it access to more > than one project in Perforce. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-292) Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in memory clientspec names
[
http://jira.codehaus.org/browse/SCM-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92132
]
Emmanuel Venisse commented on SCM-292:
--
Possible solution without modification in continuum:
instead of system property, we can store the clientspec in
${user.home}/.scm/perforce.xml (other providers use a xml file to configure the
provider too)
In this file we store a mapping between the scmurl and the clientspec
{noformat}
scm:perforce:[EMAIL
PROTECTED]:port:path_to_repository1
username-host-MavenSCM-path-to-repo1
scm:perforce:[EMAIL
PROTECTED]:port:path_to_repository2
username-host-MavenSCM-path-to-repo2
{noformat}
and in PerforceScmProvider.getClientspecName(...) we return the clientSpecName
from the xml file. If if doesn't exist, we generate a default name and we store
it in the xml file.
WDYT?
> Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in
> memory clientspec names
>
>
> Key: SCM-292
> URL: http://jira.codehaus.org/browse/SCM-292
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
>Affects Versions: 1.0-beta-4
>Reporter: Emmanuel Venisse
> Assigned To: Patrick Schneider
>Priority: Critical
> Fix For: 1.0
>
>
> With a Map instead of a system property, we'll can support more that one
> clientspec in the jvm. It's necessary for Continuum because it access to more
> than one project in Perforce.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-292) Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in memory clientspec names
[ http://jira.codehaus.org/browse/SCM-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92112 ] Mike Perham commented on SCM-292: - I don't see any way to support multiple clientspecs without explicit support in Continuum and SCM. We need support for ad hoc variables associated with a build which can be passed to the provider. The system property is a hack which obviously doesn't scale. > Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in > memory clientspec names > > > Key: SCM-292 > URL: http://jira.codehaus.org/browse/SCM-292 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-perforce >Affects Versions: 1.0-beta-4 >Reporter: Emmanuel Venisse > Assigned To: Patrick Schneider >Priority: Critical > Fix For: 1.0 > > > With a Map instead of a system property, we'll can support more that one > clientspec in the jvm. It's necessary for Continuum because it access to more > than one project in Perforce. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-292) Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in memory clientspec names
[ http://jira.codehaus.org/browse/SCM-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_91833 ] Mike Perham commented on SCM-292: - I might be able to get the existing clientspec name using 'p4 where pom.xml' and examining the output but this doesn't help in the case where I want to checkout a new project using an existing clientspec. Let me think about this more. > Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in > memory clientspec names > > > Key: SCM-292 > URL: http://jira.codehaus.org/browse/SCM-292 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-perforce >Affects Versions: 1.0-beta-4 >Reporter: Emmanuel Venisse > Assigned To: Patrick Schneider >Priority: Critical > Fix For: 1.0 > > > With a Map instead of a system property, we'll can support more that one > clientspec in the jvm. It's necessary for Continuum because it access to more > than one project in Perforce. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-292) Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in memory clientspec names
[ http://jira.codehaus.org/browse/SCM-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_91832 ] Mike Perham commented on SCM-292: - But where does this map come from? Who creates it? No, the clientspec is completely independent from the checkout and in most cases is not created by the provider. > Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in > memory clientspec names > > > Key: SCM-292 > URL: http://jira.codehaus.org/browse/SCM-292 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-perforce >Affects Versions: 1.0-beta-4 >Reporter: Emmanuel Venisse > Assigned To: Patrick Schneider >Priority: Critical > Fix For: 1.0 > > > With a Map instead of a system property, we'll can support more that one > clientspec in the jvm. It's necessary for Continuum because it access to more > than one project in Perforce. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-292) Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in memory clientspec names
[ http://jira.codehaus.org/browse/SCM-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_91830 ] Patrick Schneider commented on SCM-292: --- I am pretty busy, but I can take a look. > Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in > memory clientspec names > > > Key: SCM-292 > URL: http://jira.codehaus.org/browse/SCM-292 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-perforce >Affects Versions: 1.0-beta-4 >Reporter: Emmanuel Venisse > Assigned To: Patrick Schneider >Priority: Critical > Fix For: 1.0 > > > With a Map instead of a system property, we'll can support more that one > clientspec in the jvm. It's necessary for Continuum because it access to more > than one project in Perforce. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-292) Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in memory clientspec names
[ http://jira.codehaus.org/browse/SCM-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_91825 ] Emmanuel Venisse commented on SCM-292: -- Continuum know only the scm url.and the working directory. The actual DEFAULT_CLIENTSPEC_PROPERTY system property can't be used because in a CI tool like continuum, we manage more that one project so more than one clientspec, and this system property allow only one. I thought to a map that will contain all client specs with the scm url in the key and the client spec in the value. Do you think it can work? The client spec is generated at the end of the checkout, right? > Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in > memory clientspec names > > > Key: SCM-292 > URL: http://jira.codehaus.org/browse/SCM-292 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-perforce >Affects Versions: 1.0-beta-4 >Reporter: Emmanuel Venisse > Assigned To: Patrick Schneider >Priority: Critical > Fix For: 1.0 > > > With a Map instead of a system property, we'll can support more that one > clientspec in the jvm. It's necessary for Continuum because it access to more > than one project in Perforce. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-292) Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in memory clientspec names
[
http://jira.codehaus.org/browse/SCM-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_91824
]
Mike Perham commented on SCM-292:
-
E, can you give more details about how you expect this to work? Am I supposed
to map { directory -> clientspec-name }? The SCM provider really only knows
the current directory it is working with. So how will Continuum pass me the
clientspec name to use?
> Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in
> memory clientspec names
>
>
> Key: SCM-292
> URL: http://jira.codehaus.org/browse/SCM-292
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
>Affects Versions: 1.0-beta-4
>Reporter: Emmanuel Venisse
> Assigned To: Patrick Schneider
>Priority: Critical
> Fix For: 1.0
>
>
> With a Map instead of a system property, we'll can support more that one
> clientspec in the jvm. It's necessary for Continuum because it access to more
> than one project in Perforce.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-292) Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in memory clientspec names
[ http://jira.codehaus.org/browse/SCM-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_91173 ] Mike Perham commented on SCM-292: - E, I'm on vacation for the next week. > Replace DEFAULT_CLIENTSPEC_PROPERTY system property by a map to store in > memory clientspec names > > > Key: SCM-292 > URL: http://jira.codehaus.org/browse/SCM-292 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-perforce >Affects Versions: 1.0-beta-4 >Reporter: Emmanuel Venisse >Priority: Critical > Fix For: 1.0 > > > With a Map instead of a system property, we'll can support more that one > clientspec in the jvm. It's necessary for Continuum because it access to more > than one project in Perforce. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
