[jira] [Commented] (SCM-494) Let providers indicate whether a commit is required before a tag
[ https://issues.apache.org/jira/browse/SCM-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731095#comment-16731095 ] Michael Osipov commented on SCM-494: Is this one still valid? > Let providers indicate whether a commit is required before a tag > > > Key: SCM-494 > URL: https://issues.apache.org/jira/browse/SCM-494 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-api >Reporter: Mike Dillon >Priority: Minor > Fix For: waiting-for-feedback > > Attachments: requiresCommitBeforeTag.diff > > > As part of looking into creating a patch for MRELEASE-477, I realized that > SCM providers would need to indicate whether they are able to create a "tag" > directly from a modified working copy. Subversion can do this, but not all > providers can. I'm providing a patch that adds a requiresCommitBeforeTag() > method to ScmProvider, similar to the requiresEditMode() method. It looks > like there is a request for a general "capabilities" API in SCM-23; this > would fit into such an API if it existed, but that issue doesn't have a patch > attached :) > I haven't provided a test of this since it's only a flag that is not used > inside maven-scm (I'm planning to provide a patch for maven-release to use it > there). I could see it being used in scm:tag to allow a generic check for a > dirty working copy in a local-to-remote tag operation, but it seems like > these things are better handled by the provider themselves. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] Commented: (SCM-494) Let providers indicate whether a commit is required before a tag
[ http://jira.codehaus.org/browse/SCM-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=195259#action_195259 ] Mike Dillon commented on SCM-494: - It there anything I can do to help expedite this ticket? I've provided a patch already, but please let me know if there is something else I can do that will get this patch applied. If there is a problem with the approach I've suggested, let's discuss so we can get the right solution implemented and released. Let providers indicate whether a commit is required before a tag Key: SCM-494 URL: http://jira.codehaus.org/browse/SCM-494 Project: Maven SCM Issue Type: Improvement Components: maven-scm-api Reporter: Mike Dillon Priority: Minor Attachments: requiresCommitBeforeTag.diff As part of looking into creating a patch for MRELEASE-477, I realized that SCM providers would need to indicate whether they are able to create a tag directly from a modified working copy. Subversion can do this, but not all providers can. I'm providing a patch that adds a requiresCommitBeforeTag() method to ScmProvider, similar to the requiresEditMode() method. It looks like there is a request for a general capabilities API in SCM-23; this would fit into such an API if it existed, but that issue doesn't have a patch attached :) I haven't provided a test of this since it's only a flag that is not used inside maven-scm (I'm planning to provide a patch for maven-release to use it there). I could see it being used in scm:tag to allow a generic check for a dirty working copy in a local-to-remote tag operation, but it seems like these things are better handled by the provider themselves. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-494) Let providers indicate whether a commit is required before a tag
[ http://jira.codehaus.org/browse/SCM-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=188851#action_188851 ] Mike Dillon commented on SCM-494: - Note: I've defaulted this flag to true in AbstractScmProvider. The only provider where it is overridden to be false is in AbstractSvnScmProvider. It should probably be false for some of the other providers as well, but I'm not sure which ones. Let providers indicate whether a commit is required before a tag Key: SCM-494 URL: http://jira.codehaus.org/browse/SCM-494 Project: Maven SCM Issue Type: Improvement Components: maven-scm-api Reporter: Mike Dillon Priority: Minor Attachments: requiresCommitBeforeTag.diff As part of looking into creating a patch for MRELEASE-477, I realized that SCM providers would need to indicate whether they are able to create a tag directly from a modified working copy. Subversion can do this, but not all providers can. I'm providing a patch that adds a requiresCommitBeforeTag() method to ScmProvider, similar to the requiresEditMode() method. It looks like there is a request for a general capabilities API in SCM-23; this would fit into such an API if it existed, but that issue doesn't have a patch attached :) I haven't provided a test of this since it's only a flag that is not used inside maven-scm (I'm planning to provide a patch for maven-release to use it there). I could see it being used in scm:tag to allow a generic check for a dirty working copy in a local-to-remote tag operation, but it seems like these things are better handled by the provider themselves. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
