Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]
gnodet closed pull request #242: [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 URL: https://github.com/apache/maven-plugin-tools/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]
gnodet commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2126521901 Closed in favour of https://github.com/apache/maven-plugin-tools/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]
slawekjaranowski commented on code in PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#discussion_r1610706745 ## pom.xml: ## @@ -333,6 +333,21 @@ + + + +true +never +fail + + +false + + maven-2126 + https://repository.apache.org/content/repositories/maven-2126/ Review Comment: should be a PR as draft -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]
hboutemy commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2027872569 IIUC, discussion means this PR is not ready for merge and release: I'll release 3.12.0 without -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]
hboutemy commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2026933356 too complex answer, I'm not sure what to do to release plugin-tools 3.12.0 this WE regarding this PR associated to MPLUGIN-508: 1. release now without the PR? 2. push to finalize to PR before releasing? (need to define the acceptance criteria) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]
gnodet commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2016909806 > I extracted from this huge PR updates that were not really related to Maven 4 alpha but cleanup that caused it hard to get the intent of the PR you'll need to rebase to get a more focused PR, that we'll be able to describe: from what I see, the upgrade adds some very new approach like DI that would be useful to describe > > I'd like to do a release next week: we'll need to define if we can get this update in or not The support for 4.x plugins cannot really be finalised before the API is, given this target is moving. However, we need to keep up to date so that we can work on plugins more easily. I think the plugin could be trimmed down (just the actual plugin, we don't need other modules) and moved to maven-core to support v4 plugins... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]
hboutemy commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2016844928 I extracted from this huge PR updates that were not really related to Maven 4 alpha but cleanup that caused it hard to get the intent of the PR you'll need to rebase to get a more focused PR, that we'll be able to describe: from what I see, the upgrade adds some very new approach like DI that would be useful to describe I'd like to do a release next week: we'll need to define if we can get this update in or not -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]
gnodet commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2012198247 > > > The plugin currently supports building either a Maven 3 or a Maven 4 plugin. > > > > > > sorry, I still need some explanations because I can't guess from this PR touching 75 files described as "Upgrade to Maven 4.0.0-alpha-12" > > Most of the 75 files are just a renaming of the `mavenVersion` to `maven3Version` to make it more intuitive which one is used. > > > is this PR about adding support for Maven 4 specific plugins in addition to classical Maven 3 plugins? or just upgrading such a support added before that I overlooked? > > The support was added quite some time ago ([50482ba](https://github.com/apache/maven-plugin-tools/commit/50482ba4695f2e3efe710a583a639fa53dbabb64)). This PR is just to upgrade to alpha-13 (and needs to be adjusted with the release) > > > Is there a Maven 4 plugin IT to look at such a Maven 4 plugin? > > Yes, there's one at https://github.com/apache/maven-plugin-tools/tree/5297a91a8f8b4df54c96566b0629bb72944c2047/maven-plugin-plugin/src/it/v4api > > > and key question: is this PR intended for 3.12.0 release, as noted in Jira? > > Yes FWIW, I think the plugin supporting Maven 4 would be better located inside maven-core colocated with the API (and maybe soon the implementation extracted with https://github.com/apache/maven/pull/1441). Same for the plugin-testing framework also contains support for both Maven 3 and Maven 4 in the same library, which is not really clean imho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
