[jira] [Commented] (SUREFIRE-1402) I have an issue with maven surefire which uses Junit and Jmockit
[ https://issues.apache.org/jira/browse/SUREFIRE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116330#comment-16116330 ] Tibor Digana commented on SUREFIRE-1402: Arvin, you have old version of surefire. Upgrade it! I cannot help you with old version. [~dantran] There's JMock 2.x and JMockit 0.999.19. What a mixture is it? Surefire must not rely on JMock and thus Surefire must not start it in advance. JMock must start itself in ordinal way within JUnit runner when creating the instance. > I have an issue with maven surefire which uses Junit and Jmockit > > > Key: SUREFIRE-1402 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1402 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.7+ (parallel) support, Maven Surefire Report > Plugin >Affects Versions: 2.8 > Environment: Windows 7 eclipse Java 1.8 >Reporter: Arvind >Assignee: Tibor Digana >Priority: Critical > Labels: build, test > > When i try to build the maven project i get the following error. > --- > Test set: > --- > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.469 sec <<< > FAILURE! > java.lang.IllegalArgumentException > at > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103) > at > org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150) > at > org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:74) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
Tibor Digana created SUREFIRE-1403:
--
Summary: [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to
forked CLI argument
Key: SUREFIRE-1403
URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
Project: Maven Surefire
Issue Type: Bug
Components: Maven Failsafe Plugin, Maven Surefire Plugin
Reporter: Tibor Digana
Assignee: Tibor Digana
Fix For: 2.20.1
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules ALL-SYSTEM}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Description:
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules ALL-SYSTEM}}
The fix would be to add {{\\--add-modules ALL-SYSTEM }} if {{--add-modules}} is
not specified by user at Java 9+.
was:
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules ALL-SYSTEM}}
The fix would be to add {{ --add-modules ALL-SYSTEM }} if {{--add-modules}} is
not specified by user at Java 9+.
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add {{\\--add-modules ALL-SYSTEM }} if {{--add-modules}}
> is not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Description:
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules ALL-SYSTEM}}
The fix would be to add {{ --add-modules ALL-SYSTEM }} if {{--add-modules}} is
not specified by user at Java 9+.
was:
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules ALL-SYSTEM}}
The fix would be to add {{--add-modules ALL-SYSTEM}} if {{--add-modules}} is
not specified by user at Java 9+.
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add {{ --add-modules ALL-SYSTEM }} if {{--add-modules}}
> is not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Description:
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules ALL-SYSTEM}}
The fix would be to add {{--add-modules ALL-SYSTEM}} if {{--add-modules}} is
not specified by user at Java 9+.
was:
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules ALL-SYSTEM}}
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add {{--add-modules ALL-SYSTEM}} if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Description:
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules ALL-SYSTEM}}
The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is not
specified by user at Java 9+.
was:
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules ALL-SYSTEM}}
The fix would be to add {{\\--add-modules ALL-SYSTEM }} if {{--add-modules}} is
not specified by user at Java 9+.
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (SUREFIRE-1404) Package of ServiceLoader was changed in version 2.20 and documentation uses package providerapi
Tibor Digana created SUREFIRE-1404:
--
Summary: Package of ServiceLoader was changed in version 2.20 and
documentation uses package providerapi
Key: SUREFIRE-1404
URL: https://issues.apache.org/jira/browse/SUREFIRE-1404
Project: Maven Surefire
Issue Type: Bug
Affects Versions: 2.20
Reporter: Tibor Digana
Assignee: Tibor Digana
Fix For: 2.20.1
Version 2.20 uses package {{spi}}. According to documentation which did not
change the package must be {{providerapi}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1404) Package of ServiceLoader was changed in version 2.20 and documentation uses package providerapi
[
https://issues.apache.org/jira/browse/SUREFIRE-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1404.
--
Resolution: Fixed
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=1a65d61dd18147e905bbba1911534a07bfa03eed
> Package of ServiceLoader was changed in version 2.20 and documentation uses
> package providerapi
> ---
>
> Key: SUREFIRE-1404
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1404
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Version 2.20 uses package {{spi}}. According to documentation which did not
> change the package must be {{providerapi}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116416#comment-16116416
]
Tibor Digana commented on SUREFIRE-1403:
[~eolivelli]
[~rfscholte]
I have pushed a branch for Java 9 on Surefire.
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1403
I am missing IT that I need to have time to write however I tested on separate
project.
Can you meanwhile test it and have a look?
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116421#comment-16116421
]
Tibor Digana commented on SUREFIRE-1403:
For the given JDK via Toolchain or {{jvm}} argument of Surefire plugin
configuration, I will discover JDK version from JDK/release which is properties
file and has entry e.g. {{JAVA_VERSION="9"}}.
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116423#comment-16116423 ] Tibor Digana commented on SUREFIRE-1265: [~eolivelli] [~rfscholte] I have created SUREFIRE-1403. Made a fix and the test passed. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (SUREFIRE-1392) Running Failsafe results in crash on java 9-ea, missing class JAXBException
[
https://issues.apache.org/jira/browse/SUREFIRE-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-1392:
--
Assignee: Tibor Digana
> Running Failsafe results in crash on java 9-ea, missing class JAXBException
> ---
>
> Key: SUREFIRE-1392
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1392
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.20
> Environment: Maven 3.5.0
> Build 9-ea+173
> OS: Solus, 4.9.32-31.lts
>Reporter: Daniel Nilsson
>Assignee: Tibor Digana
>Priority: Minor
>
> When running maven-failsafe-plugin 2.20 with Java 9 on one of my projects, it
> results in the following error:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.20:integration-test (integration-test) @
> scb-java-client ---
> [WARNING] Error injecting:
> org.apache.maven.plugin.failsafe.IntegrationTestMojo
> java.lang.NoClassDefFoundError: javax/xml/bind/JAXBException
> at java.base/java.lang.Class.getDeclaredConstructors0(Native Method)
> at
> java.base/java.lang.Class.privateGetDeclaredConstructors(Class.java:3105)
> at java.base/java.lang.Class.getDeclaredConstructors(Class.java:2333)
> at
> com.google.inject.spi.InjectionPoint.forConstructorOf(InjectionPoint.java:245)
> at
> com.google.inject.internal.ConstructorBindingImpl.create(ConstructorBindingImpl.java:99)
> at
> com.google.inject.internal.InjectorImpl.createUninitializedBinding(InjectorImpl.java:658)
> at
> com.google.inject.internal.InjectorImpl.createJustInTimeBinding(InjectorImpl.java:882)
> at
> com.google.inject.internal.InjectorImpl.createJustInTimeBindingRecursive(InjectorImpl.java:805)
> at
> com.google.inject.internal.InjectorImpl.getJustInTimeBinding(InjectorImpl.java:282)
> at
> com.google.inject.internal.InjectorImpl.getBindingOrThrow(InjectorImpl.java:214)
> at
> com.google.inject.internal.InjectorImpl.getProviderOrThrow(InjectorImpl.java:1006)
> at
> com.google.inject.internal.InjectorImpl.getProvider(InjectorImpl.java:1038)
> at
> com.google.inject.internal.InjectorImpl.getProvider(InjectorImpl.java:1001)
> at
> com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1051)
> at
> org.eclipse.sisu.space.AbstractDeferredClass.get(AbstractDeferredClass.java:48)
> at
> com.google.inject.internal.ProviderInternalFactory.provision(ProviderInternalFactory.java:81)
> at
> com.google.inject.internal.InternalFactoryToInitializableAdapter.provision(InternalFactoryToInitializableAdapter.java:53)
> at
> com.google.inject.internal.ProviderInternalFactory$1.call(ProviderInternalFactory.java:65)
> at
> com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:115)
> at
> com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:133)
> at
> com.google.inject.internal.ProvisionListenerStackCallback.provision(ProvisionListenerStackCallback.java:68)
> at
> com.google.inject.internal.ProviderInternalFactory.circularGet(ProviderInternalFactory.java:63)
> at
> com.google.inject.internal.InternalFactoryToInitializableAdapter.get(InternalFactoryToInitializableAdapter.java:45)
> at
> com.google.inject.internal.InjectorImpl$2$1.call(InjectorImpl.java:1016)
> at
> com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1092)
> at com.google.inject.internal.InjectorImpl$2.get(InjectorImpl.java:1012)
> at org.eclipse.sisu.inject.Guice4$1.get(Guice4.java:162)
> at org.eclipse.sisu.inject.LazyBeanEntry.getValue(LazyBeanEntry.java:81)
> at
> org.eclipse.sisu.plexus.LazyPlexusBean.getValue(LazyPlexusBean.java:51)
> at
> org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:263)
> at
> org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:255)
> at
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.getConfiguredMojo(DefaultMavenPluginManager.java:519)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:121)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildPr
[jira] [Closed] (SUREFIRE-1392) Running Failsafe results in crash on java 9-ea, missing class JAXBException
[
https://issues.apache.org/jira/browse/SUREFIRE-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1392.
--
Resolution: Duplicate
> Running Failsafe results in crash on java 9-ea, missing class JAXBException
> ---
>
> Key: SUREFIRE-1392
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1392
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.20
> Environment: Maven 3.5.0
> Build 9-ea+173
> OS: Solus, 4.9.32-31.lts
>Reporter: Daniel Nilsson
>Assignee: Tibor Digana
>Priority: Minor
>
> When running maven-failsafe-plugin 2.20 with Java 9 on one of my projects, it
> results in the following error:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.20:integration-test (integration-test) @
> scb-java-client ---
> [WARNING] Error injecting:
> org.apache.maven.plugin.failsafe.IntegrationTestMojo
> java.lang.NoClassDefFoundError: javax/xml/bind/JAXBException
> at java.base/java.lang.Class.getDeclaredConstructors0(Native Method)
> at
> java.base/java.lang.Class.privateGetDeclaredConstructors(Class.java:3105)
> at java.base/java.lang.Class.getDeclaredConstructors(Class.java:2333)
> at
> com.google.inject.spi.InjectionPoint.forConstructorOf(InjectionPoint.java:245)
> at
> com.google.inject.internal.ConstructorBindingImpl.create(ConstructorBindingImpl.java:99)
> at
> com.google.inject.internal.InjectorImpl.createUninitializedBinding(InjectorImpl.java:658)
> at
> com.google.inject.internal.InjectorImpl.createJustInTimeBinding(InjectorImpl.java:882)
> at
> com.google.inject.internal.InjectorImpl.createJustInTimeBindingRecursive(InjectorImpl.java:805)
> at
> com.google.inject.internal.InjectorImpl.getJustInTimeBinding(InjectorImpl.java:282)
> at
> com.google.inject.internal.InjectorImpl.getBindingOrThrow(InjectorImpl.java:214)
> at
> com.google.inject.internal.InjectorImpl.getProviderOrThrow(InjectorImpl.java:1006)
> at
> com.google.inject.internal.InjectorImpl.getProvider(InjectorImpl.java:1038)
> at
> com.google.inject.internal.InjectorImpl.getProvider(InjectorImpl.java:1001)
> at
> com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1051)
> at
> org.eclipse.sisu.space.AbstractDeferredClass.get(AbstractDeferredClass.java:48)
> at
> com.google.inject.internal.ProviderInternalFactory.provision(ProviderInternalFactory.java:81)
> at
> com.google.inject.internal.InternalFactoryToInitializableAdapter.provision(InternalFactoryToInitializableAdapter.java:53)
> at
> com.google.inject.internal.ProviderInternalFactory$1.call(ProviderInternalFactory.java:65)
> at
> com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:115)
> at
> com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:133)
> at
> com.google.inject.internal.ProvisionListenerStackCallback.provision(ProvisionListenerStackCallback.java:68)
> at
> com.google.inject.internal.ProviderInternalFactory.circularGet(ProviderInternalFactory.java:63)
> at
> com.google.inject.internal.InternalFactoryToInitializableAdapter.get(InternalFactoryToInitializableAdapter.java:45)
> at
> com.google.inject.internal.InjectorImpl$2$1.call(InjectorImpl.java:1016)
> at
> com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1092)
> at com.google.inject.internal.InjectorImpl$2.get(InjectorImpl.java:1012)
> at org.eclipse.sisu.inject.Guice4$1.get(Guice4.java:162)
> at org.eclipse.sisu.inject.LazyBeanEntry.getValue(LazyBeanEntry.java:81)
> at
> org.eclipse.sisu.plexus.LazyPlexusBean.getValue(LazyPlexusBean.java:51)
> at
> org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:263)
> at
> org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:255)
> at
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.getConfiguredMojo(DefaultMavenPluginManager.java:519)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:121)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(Life
[jira] [Commented] (SUREFIRE-1402) I have an issue with maven surefire which uses Junit and Jmockit
[ https://issues.apache.org/jira/browse/SUREFIRE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116596#comment-16116596 ] Tibor Digana commented on SUREFIRE-1402: Arvin, Again the help-plugin is not about success or failure. It is about generating another POM the Maven will see. That POM contains for any *surefire* artifact. There might be many. Second, I have to close this since you did not provide the project to reproduce this issue. Attach it to Jira. > I have an issue with maven surefire which uses Junit and Jmockit > > > Key: SUREFIRE-1402 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1402 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.7+ (parallel) support, Maven Surefire Report > Plugin >Affects Versions: 2.8 > Environment: Windows 7 eclipse Java 1.8 >Reporter: Arvind >Assignee: Tibor Digana >Priority: Critical > Labels: build, test > > When i try to build the maven project i get the following error. > --- > Test set: > --- > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.469 sec <<< > FAILURE! > java.lang.IllegalArgumentException > at > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103) > at > org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150) > at > org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:74) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1402) I have an issue with maven surefire which uses Junit and Jmockit
[ https://issues.apache.org/jira/browse/SUREFIRE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116623#comment-16116623 ] Tibor Digana commented on SUREFIRE-1402: What is the stack trance like with Surefire version 2.20? > I have an issue with maven surefire which uses Junit and Jmockit > > > Key: SUREFIRE-1402 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1402 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.7+ (parallel) support, Maven Surefire Report > Plugin >Affects Versions: 2.8 > Environment: Windows 7 eclipse Java 1.8 >Reporter: Arvind >Assignee: Tibor Digana >Priority: Critical > Labels: build, test > > When i try to build the maven project i get the following error. > --- > Test set: > --- > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.469 sec <<< > FAILURE! > java.lang.IllegalArgumentException > at > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103) > at > org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150) > at > org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:74) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1402) I have an issue with maven surefire which uses Junit and Jmockit
[
https://issues.apache.org/jira/browse/SUREFIRE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116635#comment-16116635
]
Tibor Digana commented on SUREFIRE-1402:
I do no mean help-plugin.
Now run ordinal build, something like {{mvn test}}.
> I have an issue with maven surefire which uses Junit and Jmockit
>
>
> Key: SUREFIRE-1402
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1402
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.7+ (parallel) support, Maven Surefire Report
> Plugin
>Affects Versions: 2.8
> Environment: Windows 7 eclipse Java 1.8
>Reporter: Arvind
>Assignee: Tibor Digana
>Priority: Critical
> Labels: build, test
> Attachments: log.txt
>
>
> When i try to build the maven project i get the following error.
> ---
> Test set:
> ---
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.469 sec <<<
> FAILURE!
> java.lang.IllegalArgumentException
> at
> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
> at
> org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150)
> at
> org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:74)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1402) I have an issue with maven surefire which uses Junit and Jmockit
[ https://issues.apache.org/jira/browse/SUREFIRE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116663#comment-16116663 ] Tibor Digana commented on SUREFIRE-1402: ok, post the error to Jira and we will see. > I have an issue with maven surefire which uses Junit and Jmockit > > > Key: SUREFIRE-1402 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1402 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.7+ (parallel) support, Maven Surefire Report > Plugin >Affects Versions: 2.8 > Environment: Windows 7 eclipse Java 1.8 >Reporter: Arvind >Assignee: Tibor Digana >Priority: Critical > Labels: build, test > Attachments: log.txt > > > When i try to build the maven project i get the following error. > --- > Test set: > --- > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.469 sec <<< > FAILURE! > java.lang.IllegalArgumentException > at > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103) > at > org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150) > at > org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:74) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1402) I have an issue with maven surefire which uses Junit and Jmockit
[ https://issues.apache.org/jira/browse/SUREFIRE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116710#comment-16116710 ] Tibor Digana commented on SUREFIRE-1402: Sorry but I cannot help you because this stack trace still does not match version 2.20. One your module use 2.16. Please change it to 2.20 as well. This module: com.hp.it.111467 sbs-obligation-service-orchestration 1.1.50-SNAPSHOT sbs-obligation-service-orchestration SBS Obligation Service (parent project) > I have an issue with maven surefire which uses Junit and Jmockit > > > Key: SUREFIRE-1402 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1402 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.7+ (parallel) support, Maven Surefire Report > Plugin >Affects Versions: 2.8 > Environment: Windows 7 eclipse Java 1.8 >Reporter: Arvind >Assignee: Tibor Digana >Priority: Critical > Labels: build, test > Attachments: log.txt > > > When i try to build the maven project i get the following error. > --- > Test set: > --- > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.469 sec <<< > FAILURE! > java.lang.IllegalArgumentException > at > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103) > at > org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150) > at > org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:74) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1402) ......................................
[ https://issues.apache.org/jira/browse/SUREFIRE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1402: --- Comment: was deleted (was: Sorry but I cannot help you because this stack trace still does not match version 2.20. One your module use 2.16. Please change it to 2.20 as well. This module: com.hp.it.111467 sbs-obligation-service-orchestration 1.1.50-SNAPSHOT sbs-obligation-service-orchestration SBS Obligation Service (parent project) ) > .. > -- > > Key: SUREFIRE-1402 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1402 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.7+ (parallel) support, Maven Surefire Report > Plugin >Affects Versions: 2.8 > Environment: Windows 7 eclipse Java 1.8 >Reporter: Arvind >Assignee: Tibor Digana >Priority: Critical > Labels: build, test > > When i try to build the maven project i get the following error. > --- > Test set: > --- > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.469 sec <<< > FAILURE! > java.lang.IllegalArgumentException > at > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103) > at > org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150) > at > org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:74) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120425#comment-16120425
]
Tibor Digana commented on SUREFIRE-1403:
I have made a new update.
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: SUCCESS: Integrated in Jenkins build maven-surefire-dev #36 (See
[https://builds.apache.org/job/maven-surefire-dev/36/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=395c68dc117f595c119094ce30605f9dd8dc019d])
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (edit) maven-surefire-common/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit) surefire-api/pom.xml
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit) surefire-integration-tests/pom.xml
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit) pom.xml
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit) surefire-booter/pom.xml
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: UNSTABLE: Integrated in Jenkins build maven-surefire-dev #38 (See
[https://builds.apache.org/job/maven-surefire-dev/38/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=c199052db0f5eef4ee5ccd885df7f0425fd87a0f])
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit) pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit) surefire-api/pom.xml
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (edit) maven-surefire-common/pom.xml
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (edit) surefire-booter/pom.xml
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (edit) surefire-integration-tests/pom.xml
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: UNSTABLE: Integrated in Jenkins build maven-surefire-dev #35 (See
[https://builds.apache.org/job/maven-surefire-dev/35/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=ecda11ea1884b14a26f01e5403a76bb78f14010e])
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (edit) maven-surefire-common/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit) surefire-api/pom.xml
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (edit) surefire-booter/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit) pom.xml
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (edit) surefire-integration-tests/pom.xml
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: SUCCESS: Integrated in Jenkins build maven-surefire-dev #39 (See
[https://builds.apache.org/job/maven-surefire-dev/39/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=fcfe5daef5704360d5b9bd009647758e63a287dd])
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (edit) surefire-booter/pom.xml
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit) pom.xml
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit) surefire-api/pom.xml
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit) surefire-integration-tests/pom.xml
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (edit) maven-surefire-common/pom.xml
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124618#comment-16124618
]
Tibor Digana commented on SUREFIRE-1403:
[~eolivelli]
Can you test {{2.21-SNAPSHOT}} ?
Configure plugin repository in your POM with
URL=http://repository.apache.org/snapshots/
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124651#comment-16124651
]
Tibor Digana commented on SUREFIRE-1403:
I launched the build with command:
{{mvn install "-Djdk.home=e:\Program Files\Java\jdk9" -P run-its}}
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124893#comment-16124893
]
Tibor Digana commented on SUREFIRE-1403:
Robert, you are talking about running surefire build of another project?
I did test on another project using Surefire and not Failsafe without
{{MAVEN_OPTS=--add-modules ALL-SYSTEM}} with success.
On Sun, Aug 13, 2017 at 1:25 PM, Robert Scholte (JIRA)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124913#comment-16124913
]
Tibor Digana commented on SUREFIRE-1403:
Robert, so failsafe:verify needs to use javax.xml.
This is not nice on Java 9 that they broke backwards compatibility and
force the world to use the switch to use --add-modules ALL-SYSTEM instead
of providing all modules installed in JRE. For instance, small JRE having
{{java.base}} has advantage on embedded systems and the only should be
propagated. Big scope JRE should propagate all installed modules.
But for me it does not make security sense and common sense to force JRE to
provide modules. It should be opposite and the admin/Jenkins should
configure big scope JRE with selected modules propagated to Java runtime
applications.
If this admin does not do that then all modules should be available by
default which is backwards compatibility for me and we do not have to to
implement these stupid tricks.
On Sun, Aug 13, 2017 at 1:36 PM, Robert Scholte (JIRA)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125063#comment-16125063
]
Tibor Digana commented on SUREFIRE-1403:
[~rfscholte]
Hi Robert, now everything works. I removed JAXB and included Failsafe to IT.
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: SUCCESS: Integrated in Jenkins build maven-surefire-dev #43 (See
[https://builds.apache.org/job/maven-surefire-dev/43/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=e490b265b6e9a908f2a83a887657c4f3456b4bcc])
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (edit) maven-surefire-common/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit) surefire-api/pom.xml
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit) surefire-integration-tests/pom.xml
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (edit) pom.xml
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (edit)
maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (edit) maven-surefire-plugin/pom.xml
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
* (edit) maven-failsafe-plugin/pom.xml
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
* (edit) surefire-booter/pom.xml
* (edit) surefire-setup-integration-tests/pom.xml
* (delete)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: SUCCESS: Integrated in Jenkins build maven-surefire-dev #42 (See
[https://builds.apache.org/job/maven-surefire-dev/42/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=a8e24ad96b0967dda1593ac733e15675493fe406])
* (edit) surefire-api/pom.xml
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit) pom.xml
* (edit) maven-surefire-common/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (edit) surefire-setup-integration-tests/pom.xml
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (edit) surefire-booter/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (edit) surefire-integration-tests/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: SUCCESS: Integrated in Jenkins build maven-surefire-dev #44 (See
[https://builds.apache.org/job/maven-surefire-dev/44/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=14f588a7c87ecafe79de54227080385b283f6af4])
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit)
maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit) surefire-api/pom.xml
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (edit) surefire-setup-integration-tests/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (edit) maven-surefire-plugin/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit) maven-failsafe-plugin/pom.xml
* (edit) surefire-booter/pom.xml
* (edit) pom.xml
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (delete)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit) maven-surefire-common/pom.xml
* (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (edit) surefire-integration-tests/pom.xml
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: SUCCESS: Integrated in Jenkins build maven-surefire-dev #45 (See
[https://builds.apache.org/job/maven-surefire-dev/45/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=9c52386083318d9b6d37af1b25d2f5f13f0f9565])
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (edit) surefire-setup-integration-tests/pom.xml
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (edit) maven-surefire-common/pom.xml
* (delete)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (edit) surefire-booter/pom.xml
* (edit) pom.xml
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (edit) maven-failsafe-plugin/pom.xml
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
* (edit) surefire-integration-tests/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit) README.md
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (edit)
maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit) maven-surefire-plugin/pom.xml
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit) surefire-api/pom.xml
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
* (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (add) surefire-booter/src/test/resources/jdk/bin/java
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1302) Surefire does not wait long enough for the forked VM and assumes it to be dead
[
https://issues.apache.org/jira/browse/SUREFIRE-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125488#comment-16125488
]
Tibor Digana commented on SUREFIRE-1302:
There are 4 pending issues to fix.
One of them has to be fixed now because the issue has been introduced
recently. It is a bug regarding @Parameterized in JUnit when tests fail.
This is very important because this was fine in 2.20 and I do not want to
deliver 2.20.1 with such issue for junit provider.
If you have time please look at it. See the last comment in
https://issues.apache.org/jira/browse/SUREFIRE-1264. There is the last
comment saying which commit introduced the issue. This tells you what
change caused this and should be kept but fixed. Of course IT tests are
needed.
On Mon, Aug 14, 2017 at 11:31 AM, Valentin Baranov (JIRA)
> Surefire does not wait long enough for the forked VM and assumes it to be dead
> --
>
> Key: SUREFIRE-1302
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1302
> Project: Maven Surefire
> Issue Type: Request
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Yuriy Zaplavnov
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: 2017-05-18T05-48-08_685-jvmRun1.dumpstream,
> surefire-gclog.log, surefire-logs,
> surefire-tests-terminated-master-aa9330316038f6b46316ce36ff40714ffc7cf299.zip,
> tests_log_01.txt, tests_log_02.txt
>
>
> This issue happens because surefire kills the forked container if it times
> out waiting for the 'ping'.
> In org.apache.maven.surefire.booter.ForkedBooter class there is hardcoded
> constant PING_TIMEOUT_IN_SECONDS = 20 which is used in the following method:
> {code}
> private static ScheduledFuture listenToShutdownCommands( CommandReader
> reader )
> {
> reader.addShutdownListener( createExitHandler( reader ) );
> AtomicBoolean pingDone = new AtomicBoolean( true );
> reader.addNoopListener( createPingHandler( pingDone ) );
> return JVM_TERMINATOR.scheduleAtFixedRate( createPingJob( pingDone,
> reader ),
>0,PING_TIMEOUT_IN_SECONDS,
> SECONDS );
> }
> {code}
> to create ScheduledFuture.
> In some of the cases the forked container might respond a bit later than it's
> expected and surefire kills it
> {code}
> private static Runnable createPingJob( final AtomicBoolean pingDone, final
> CommandReader reader )
> {
> return new Runnable()
> {
> public void run()
> {
> boolean hasPing = pingDone.getAndSet( false );
> if ( !hasPing )
> {
> exit( 1, KILL, reader, true );
> }
> }
> };
> }
> {code}
> As long as we need to terminate it anyway, It would be really helpful if the
> problem could be solved making the PING_TIMEOUT_IN_SECONDS configurable with
> the ability to specify the value from maven-surefire-plugin.
> It would help to configure this timeout based on needs and factors of the
> projects where surefire runs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1265. -- Resolution: Fixed There were two issues regarding Java 9 in Surefire. This issue fixed hidden exception thrown in reflection but the most important issue SUREFIRE-1403 which is fixed now is another topic regarding Java 9 and is waiting for approval to push to master. Thx. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1302) Surefire does not wait long enough for the forked VM and assumes it to be dead
[
https://issues.apache.org/jira/browse/SUREFIRE-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125531#comment-16125531
]
Tibor Digana commented on SUREFIRE-1302:
Exactly, the regression was found in SUREFIRE-1264 regarding failed test
and not passed tests as the initial fix in 1264 was proposed to fix.
We have two options.
I can reopen 1264 or create a new one.
Maybe reopening it is better. WDYT?
On Mon, Aug 14, 2017 at 12:40 PM, Valentin Baranov (JIRA)
> Surefire does not wait long enough for the forked VM and assumes it to be dead
> --
>
> Key: SUREFIRE-1302
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1302
> Project: Maven Surefire
> Issue Type: Request
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Yuriy Zaplavnov
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: 2017-05-18T05-48-08_685-jvmRun1.dumpstream,
> surefire-gclog.log, surefire-logs,
> surefire-tests-terminated-master-aa9330316038f6b46316ce36ff40714ffc7cf299.zip,
> tests_log_01.txt, tests_log_02.txt
>
>
> This issue happens because surefire kills the forked container if it times
> out waiting for the 'ping'.
> In org.apache.maven.surefire.booter.ForkedBooter class there is hardcoded
> constant PING_TIMEOUT_IN_SECONDS = 20 which is used in the following method:
> {code}
> private static ScheduledFuture listenToShutdownCommands( CommandReader
> reader )
> {
> reader.addShutdownListener( createExitHandler( reader ) );
> AtomicBoolean pingDone = new AtomicBoolean( true );
> reader.addNoopListener( createPingHandler( pingDone ) );
> return JVM_TERMINATOR.scheduleAtFixedRate( createPingJob( pingDone,
> reader ),
>0,PING_TIMEOUT_IN_SECONDS,
> SECONDS );
> }
> {code}
> to create ScheduledFuture.
> In some of the cases the forked container might respond a bit later than it's
> expected and surefire kills it
> {code}
> private static Runnable createPingJob( final AtomicBoolean pingDone, final
> CommandReader reader )
> {
> return new Runnable()
> {
> public void run()
> {
> boolean hasPing = pingDone.getAndSet( false );
> if ( !hasPing )
> {
> exit( 1, KILL, reader, true );
> }
> }
> };
> }
> {code}
> As long as we need to terminate it anyway, It would be really helpful if the
> problem could be solved making the PING_TIMEOUT_IN_SECONDS configurable with
> the ability to specify the value from maven-surefire-plugin.
> It would help to configure this timeout based on needs and factors of the
> projects where surefire runs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Reopened] (SUREFIRE-1264) Some tests can be lost when running in parallel with parameterized tests
[
https://issues.apache.org/jira/browse/SUREFIRE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reopened SUREFIRE-1264:
Additional bug should be fixed.
That means a situation when parameterized methods fail. See attachments.
> Some tests can be lost when running in parallel with parameterized tests
>
>
> Key: SUREFIRE-1264
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1264
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.7+ (parallel) support
>Affects Versions: 2.19.1
> Environment: Maven 3.3.9
> Java 1.8.0_45 (Oracle)
> System: OS X
> Reproduced on Linux too, with both OpenJDK 7 and Java 7 from Oracle.
>Reporter: Jean-Luc Derrien
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: failure-2.21-snapshot-SUREFIRE-1264.zip, pom.xml
>
>
> Hello,
> It appears some tests can be lost when using the parallel mode with
> parameterized tests. Here is a [small
> project|https://github.com/jderrien/surefire-junit-tests/tree/simple-1] I've
> used to try to reproduce the issue we have seen.
> This is not something that happens on every run, but it's quite frequent.
> With this loop, the problem should appear in less than 2 minutes, maybe on
> the first run when (un)lucky:
> {code}
> time while true; do mvn clean test > last.log ; tail -25 last.log ; if [
> "$(grep -c 'Tests run: 12' last.log)" == "0" ]; then break; fi ; done
> {code}
> Normal run:
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => stop
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.006 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec -
> in [p2]
> Results :
> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> When tests have been lost (here one test lost according to the output):
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec -
> in [p2]
> Results :
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> Note: there are 3 test classes and 18 tests on the [master
> branch|https://github.com/jderrien/surefire-junit-tests/tree/master] and it's
> even more frequent/easy to reproduce.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1302) Surefire does not wait long enough for the forked VM and assumes it to be dead
[
https://issues.apache.org/jira/browse/SUREFIRE-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125636#comment-16125636
]
Tibor Digana commented on SUREFIRE-1302:
Thx Valentin. The issue SUREFIRE-1264 is reopened.
On Mon, Aug 14, 2017 at 1:00 PM, Valentin Baranov (JIRA)
> Surefire does not wait long enough for the forked VM and assumes it to be dead
> --
>
> Key: SUREFIRE-1302
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1302
> Project: Maven Surefire
> Issue Type: Request
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Yuriy Zaplavnov
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: 2017-05-18T05-48-08_685-jvmRun1.dumpstream,
> surefire-gclog.log, surefire-logs,
> surefire-tests-terminated-master-aa9330316038f6b46316ce36ff40714ffc7cf299.zip,
> tests_log_01.txt, tests_log_02.txt
>
>
> This issue happens because surefire kills the forked container if it times
> out waiting for the 'ping'.
> In org.apache.maven.surefire.booter.ForkedBooter class there is hardcoded
> constant PING_TIMEOUT_IN_SECONDS = 20 which is used in the following method:
> {code}
> private static ScheduledFuture listenToShutdownCommands( CommandReader
> reader )
> {
> reader.addShutdownListener( createExitHandler( reader ) );
> AtomicBoolean pingDone = new AtomicBoolean( true );
> reader.addNoopListener( createPingHandler( pingDone ) );
> return JVM_TERMINATOR.scheduleAtFixedRate( createPingJob( pingDone,
> reader ),
>0,PING_TIMEOUT_IN_SECONDS,
> SECONDS );
> }
> {code}
> to create ScheduledFuture.
> In some of the cases the forked container might respond a bit later than it's
> expected and surefire kills it
> {code}
> private static Runnable createPingJob( final AtomicBoolean pingDone, final
> CommandReader reader )
> {
> return new Runnable()
> {
> public void run()
> {
> boolean hasPing = pingDone.getAndSet( false );
> if ( !hasPing )
> {
> exit( 1, KILL, reader, true );
> }
> }
> };
> }
> {code}
> As long as we need to terminate it anyway, It would be really helpful if the
> problem could be solved making the PING_TIMEOUT_IN_SECONDS configurable with
> the ability to specify the value from maven-surefire-plugin.
> It would help to configure this timeout based on needs and factors of the
> projects where surefire runs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: SUCCESS: Integrated in Jenkins build maven-surefire-dev #46 (See
[https://builds.apache.org/job/maven-surefire-dev/46/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=622185be8b495c9f0d8ac0c9b628be4a92e1438c])
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit) maven-surefire-plugin/src/site/site.xml
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (add) maven-surefire-plugin/src/site/markdown/java9.md
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit) surefire-integration-tests/pom.xml
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit) surefire-api/pom.xml
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (delete)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit) pom.xml
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (edit) maven-failsafe-plugin/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (edit) surefire-setup-integration-tests/pom.xml
* (edit) maven-surefire-plugin/pom.xml
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (edit) surefire-booter/pom.xml
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (edit)
maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (edit) README.md
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit) maven-surefire-common/pom.xml
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1403.
--
Resolution: Fixed
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=578ada73b724151f0cbce3b6ae39e55d242ef430
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: FAILURE: Integrated in Jenkins build maven-surefire-dev #48 (See
[https://builds.apache.org/job/maven-surefire-dev/48/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=cdc7b64c3dc295c92d4bbc3a150ad0d6de31a764])
* (edit) maven-failsafe-plugin/pom.xml
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (edit) surefire-integration-tests/pom.xml
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb
* (edit) pom.xml
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (edit) README.md
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (delete)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (edit) maven-surefire-plugin/src/site/site.xml
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (edit) maven-surefire-common/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit) surefire-booter/pom.xml
* (edit)
maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (add) maven-surefire-plugin/src/site/markdown/java9.md
* (edit) surefire-setup-integration-tests/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit) surefire-api/pom.xml
* (edit) maven-surefire-plugin/pom.xml
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: FAILURE: Integrated in Jenkins build maven-surefire #1752 (See
[https://builds.apache.org/job/maven-surefire/1752/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=578ada73b724151f0cbce3b6ae39e55d242ef430])
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (delete)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (edit) maven-failsafe-plugin/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit) surefire-booter/pom.xml
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (add) maven-surefire-plugin/src/site/markdown/java9.md
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (edit) maven-surefire-common/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit) pom.xml
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (edit)
maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (edit) surefire-api/pom.xml
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
* (edit) README.md
* (edit) maven-surefire-plugin/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (edit) surefire-setup-integration-tests/pom.xml
* (edit) surefire-integration-tests/pom.xml
* (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit) maven-surefire-plugin/src/site/site.xml
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: SUCCESS: Integrated in Jenkins build maven-surefire-dev #47 (See
[https://builds.apache.org/job/maven-surefire-dev/47/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=578ada73b724151f0cbce3b6ae39e55d242ef430])
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (edit) maven-surefire-plugin/src/site/site.xml
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit) pom.xml
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit) surefire-integration-tests/pom.xml
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (edit) README.md
* (edit) maven-failsafe-plugin/pom.xml
* (delete)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (edit) surefire-booter/pom.xml
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (edit)
maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit) maven-surefire-common/pom.xml
* (edit) surefire-api/pom.xml
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (add) maven-surefire-plugin/src/site/markdown/java9.md
* (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
* (edit) surefire-setup-integration-tests/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit) maven-surefire-plugin/pom.xml
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134862#comment-16134862
]
Tibor Digana commented on SUREFIRE-1403:
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=0635d25e9d273c48196c1c9cb40eefc38393daba
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1264) Some tests can be lost when running in parallel with parameterized tests
[
https://issues.apache.org/jira/browse/SUREFIRE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137273#comment-16137273
]
Tibor Digana commented on SUREFIRE-1264:
[~Prifiz]
[~valyok]
Did you have time to have a look at this issue?
If you remember we spoke about it in the chat of SUREFIRE-1302.
> Some tests can be lost when running in parallel with parameterized tests
>
>
> Key: SUREFIRE-1264
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1264
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.7+ (parallel) support
>Affects Versions: 2.19.1
> Environment: Maven 3.3.9
> Java 1.8.0_45 (Oracle)
> System: OS X
> Reproduced on Linux too, with both OpenJDK 7 and Java 7 from Oracle.
>Reporter: Jean-Luc Derrien
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: failure-2.21-snapshot-SUREFIRE-1264.zip, pom.xml
>
>
> Hello,
> It appears some tests can be lost when using the parallel mode with
> parameterized tests. Here is a [small
> project|https://github.com/jderrien/surefire-junit-tests/tree/simple-1] I've
> used to try to reproduce the issue we have seen.
> This is not something that happens on every run, but it's quite frequent.
> With this loop, the problem should appear in less than 2 minutes, maybe on
> the first run when (un)lucky:
> {code}
> time while true; do mvn clean test > last.log ; tail -25 last.log ; if [
> "$(grep -c 'Tests run: 12' last.log)" == "0" ]; then break; fi ; done
> {code}
> Normal run:
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => stop
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.006 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec -
> in [p2]
> Results :
> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> When tests have been lost (here one test lost according to the output):
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec -
> in [p2]
> Results :
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> Note: there are 3 test classes and 18 tests on the [master
> branch|https://github.com/jderrien/surefire-junit-tests/tree/master] and it's
> even more frequent/easy to reproduce.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1264) Some tests can be lost when running in parallel with parameterized tests
[
https://issues.apache.org/jira/browse/SUREFIRE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139612#comment-16139612
]
Tibor Digana commented on SUREFIRE-1264:
[~Prifiz]
Definitely the root cause is in {{JUnitCoreRunListener}} . After I removed
{{isParameterizedRunner( testDesc ) ? testDesc.getClassName() :}} your test
summary became stable.
There is an issue {{TestClassMethodNameUtils}} with howeve but this is not a
root cause. We should fix the statement {{return m.matches() ? m.group( 1 ) :
null}} to {{return m.matches() ? m.group( 1 ) : displayName}}.
> Some tests can be lost when running in parallel with parameterized tests
>
>
> Key: SUREFIRE-1264
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1264
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.7+ (parallel) support
>Affects Versions: 2.19.1
> Environment: Maven 3.3.9
> Java 1.8.0_45 (Oracle)
> System: OS X
> Reproduced on Linux too, with both OpenJDK 7 and Java 7 from Oracle.
>Reporter: Jean-Luc Derrien
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: failure-2.21-snapshot-SUREFIRE-1264.zip, pom.xml
>
>
> Hello,
> It appears some tests can be lost when using the parallel mode with
> parameterized tests. Here is a [small
> project|https://github.com/jderrien/surefire-junit-tests/tree/simple-1] I've
> used to try to reproduce the issue we have seen.
> This is not something that happens on every run, but it's quite frequent.
> With this loop, the problem should appear in less than 2 minutes, maybe on
> the first run when (un)lucky:
> {code}
> time while true; do mvn clean test > last.log ; tail -25 last.log ; if [
> "$(grep -c 'Tests run: 12' last.log)" == "0" ]; then break; fi ; done
> {code}
> Normal run:
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => stop
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.006 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec -
> in [p2]
> Results :
> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> When tests have been lost (here one test lost according to the output):
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec -
> in [p2]
> Results :
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> Note: there are 3 test classes and 18 tests on the [master
> branch|https://github.com/jderrien/surefire-junit-tests/tree/master] and it's
> even more frequent/easy to reproduce.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1264) Some tests can be lost when running in parallel with parameterized tests
[
https://issues.apache.org/jira/browse/SUREFIRE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142679#comment-16142679
]
Tibor Digana commented on SUREFIRE-1264:
[~Prifiz]
[~valyok]
I am currently working on {{JUnitCoreRunListener}}, the method
{{fillTestCountMap}}. It fills out a Map with test classes and TestSet but it
is not so well written. It should be developed from new beginning and
{{TestSet#createReportEntry()}} should be changed due to the existence of local
variable {{isJunit3}} and then I hope this issue will be fixed.
> Some tests can be lost when running in parallel with parameterized tests
>
>
> Key: SUREFIRE-1264
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1264
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.7+ (parallel) support
>Affects Versions: 2.19.1
> Environment: Maven 3.3.9
> Java 1.8.0_45 (Oracle)
> System: OS X
> Reproduced on Linux too, with both OpenJDK 7 and Java 7 from Oracle.
>Reporter: Jean-Luc Derrien
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: failure-2.21-snapshot-SUREFIRE-1264.zip, pom.xml
>
>
> Hello,
> It appears some tests can be lost when using the parallel mode with
> parameterized tests. Here is a [small
> project|https://github.com/jderrien/surefire-junit-tests/tree/simple-1] I've
> used to try to reproduce the issue we have seen.
> This is not something that happens on every run, but it's quite frequent.
> With this loop, the problem should appear in less than 2 minutes, maybe on
> the first run when (un)lucky:
> {code}
> time while true; do mvn clean test > last.log ; tail -25 last.log ; if [
> "$(grep -c 'Tests run: 12' last.log)" == "0" ]; then break; fi ; done
> {code}
> Normal run:
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => stop
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.006 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec -
> in [p2]
> Results :
> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> When tests have been lost (here one test lost according to the output):
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec -
> in [p2]
> Results :
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> Note: there are 3 test classes and 18 tests on the [master
> branch|https://github.com/jderrien/surefire-junit-tests/tree/master] and it's
> even more frequent/easy to reproduce.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1264) Some tests can be lost when running in parallel with parameterized tests
[
https://issues.apache.org/jira/browse/SUREFIRE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144246#comment-16144246
]
Tibor Digana commented on SUREFIRE-1264:
[~Prifiz]
[~valyok]
I have pushed a branch {{SUREFIRE-1264_2}} with a fix.
Can you please build the project on your side and use the version
{{2.21-SNAPSHOT}} in your project and give me a feedback with your test result.
Please build Surefire project like this:
{{mvn install -DskipTests}}
> Some tests can be lost when running in parallel with parameterized tests
>
>
> Key: SUREFIRE-1264
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1264
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.7+ (parallel) support
>Affects Versions: 2.19.1
> Environment: Maven 3.3.9
> Java 1.8.0_45 (Oracle)
> System: OS X
> Reproduced on Linux too, with both OpenJDK 7 and Java 7 from Oracle.
>Reporter: Jean-Luc Derrien
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: failure-2.21-snapshot-SUREFIRE-1264.zip, pom.xml
>
>
> Hello,
> It appears some tests can be lost when using the parallel mode with
> parameterized tests. Here is a [small
> project|https://github.com/jderrien/surefire-junit-tests/tree/simple-1] I've
> used to try to reproduce the issue we have seen.
> This is not something that happens on every run, but it's quite frequent.
> With this loop, the problem should appear in less than 2 minutes, maybe on
> the first run when (un)lucky:
> {code}
> time while true; do mvn clean test > last.log ; tail -25 last.log ; if [
> "$(grep -c 'Tests run: 12' last.log)" == "0" ]; then break; fi ; done
> {code}
> Normal run:
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => stop
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.006 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec -
> in [p2]
> Results :
> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> When tests have been lost (here one test lost according to the output):
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec -
> in [p2]
> Results :
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> Note: there are 3 test classes and 18 tests on the [master
> branch|https://github.com/jderrien/surefire-junit-tests/tree/master] and it's
> even more frequent/easy to reproduce.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1264) Some tests can be lost when running in parallel with parameterized tests
[
https://issues.apache.org/jira/browse/SUREFIRE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144406#comment-16144406
]
Tibor Digana commented on SUREFIRE-1264:
Flaky tests fail in the build which must be fixed.
> Some tests can be lost when running in parallel with parameterized tests
>
>
> Key: SUREFIRE-1264
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1264
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.7+ (parallel) support
>Affects Versions: 2.19.1
> Environment: Maven 3.3.9
> Java 1.8.0_45 (Oracle)
> System: OS X
> Reproduced on Linux too, with both OpenJDK 7 and Java 7 from Oracle.
>Reporter: Jean-Luc Derrien
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: failure-2.21-snapshot-SUREFIRE-1264.zip, pom.xml
>
>
> Hello,
> It appears some tests can be lost when using the parallel mode with
> parameterized tests. Here is a [small
> project|https://github.com/jderrien/surefire-junit-tests/tree/simple-1] I've
> used to try to reproduce the issue we have seen.
> This is not something that happens on every run, but it's quite frequent.
> With this loop, the problem should appear in less than 2 minutes, maybe on
> the first run when (un)lucky:
> {code}
> time while true; do mvn clean test > last.log ; tail -25 last.log ; if [
> "$(grep -c 'Tests run: 12' last.log)" == "0" ]; then break; fi ; done
> {code}
> Normal run:
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => stop
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.006 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec -
> in [p2]
> Results :
> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> When tests have been lost (here one test lost according to the output):
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec -
> in [p2]
> Results :
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> Note: there are 3 test classes and 18 tests on the [master
> branch|https://github.com/jderrien/surefire-junit-tests/tree/master] and it's
> even more frequent/easy to reproduce.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1396) Provider class path is incorrect for custom provider in Failsafe
[ https://issues.apache.org/jira/browse/SUREFIRE-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1396: --- Fix Version/s: 2.20.1 > Provider class path is incorrect for custom provider in Failsafe > > > Key: SUREFIRE-1396 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1396 > Project: Maven Surefire > Issue Type: Bug >Reporter: Jonathan Bell >Assignee: Tibor Digana > Fix For: 2.20.1 > > > Hi, > When using a custom Surefire provider with Surefire (not Failsafe), the > "provider classpath" contains only the provider and surefire-api. However, > when using a custom provider with Failsafe, the provider class path ends up > including a lot more... it seems like perhaps all plugins that are loaded? > This has caused some mayhem for me when using a custom provider in projects > that use a specific version of SLF4J... because then failsafe forces 1.5.6 to > be loaded (from this process of incorrectly finding the custom provider), > causing a crash. > It is a simple fix (3 lines in AbstractSurefireMojo - it had the name of the > Surefire plugin hardcoded, which isn't correct when it's actually Failsafe). > I've got a patched fork of master on GitHub > (https://github.com/jon-bell/maven-surefire/commit/04f66cdd828d131a028eb400d1ed26fe104fe3f2) > that fixes it and an integration test that demonstrates the flaw. I am not > 100% sure on the formatting of the integration test (i.e., I am opening a > JIRA ticket so that I suppose I can name it under the JIRA issue? How should > I specify the current version of surefire in the integration test package?) - > if the fix is welcome against master I'd be happy to open a PR on GitHub. I > am also happy to merge against a different branch if it's more helpful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (SUREFIRE-1396) Provider class path is incorrect for custom provider in Failsafe
[ https://issues.apache.org/jira/browse/SUREFIRE-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1396: -- Assignee: Tibor Digana > Provider class path is incorrect for custom provider in Failsafe > > > Key: SUREFIRE-1396 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1396 > Project: Maven Surefire > Issue Type: Bug >Reporter: Jonathan Bell >Assignee: Tibor Digana > Fix For: 2.20.1 > > > Hi, > When using a custom Surefire provider with Surefire (not Failsafe), the > "provider classpath" contains only the provider and surefire-api. However, > when using a custom provider with Failsafe, the provider class path ends up > including a lot more... it seems like perhaps all plugins that are loaded? > This has caused some mayhem for me when using a custom provider in projects > that use a specific version of SLF4J... because then failsafe forces 1.5.6 to > be loaded (from this process of incorrectly finding the custom provider), > causing a crash. > It is a simple fix (3 lines in AbstractSurefireMojo - it had the name of the > Surefire plugin hardcoded, which isn't correct when it's actually Failsafe). > I've got a patched fork of master on GitHub > (https://github.com/jon-bell/maven-surefire/commit/04f66cdd828d131a028eb400d1ed26fe104fe3f2) > that fixes it and an integration test that demonstrates the flaw. I am not > 100% sure on the formatting of the integration test (i.e., I am opening a > JIRA ticket so that I suppose I can name it under the JIRA issue? How should > I specify the current version of surefire in the integration test package?) - > if the fix is welcome against master I'd be happy to open a PR on GitHub. I > am also happy to merge against a different branch if it's more helpful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1396) Provider class path is incorrect for custom provider in Failsafe
[ https://issues.apache.org/jira/browse/SUREFIRE-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1396. -- Resolution: Fixed https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=99cd4f65f5f04ed8c98f446850f5f8bd7b98fc64 > Provider class path is incorrect for custom provider in Failsafe > > > Key: SUREFIRE-1396 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1396 > Project: Maven Surefire > Issue Type: Bug >Reporter: Jonathan Bell >Assignee: Tibor Digana > Fix For: 2.20.1 > > > Hi, > When using a custom Surefire provider with Surefire (not Failsafe), the > "provider classpath" contains only the provider and surefire-api. However, > when using a custom provider with Failsafe, the provider class path ends up > including a lot more... it seems like perhaps all plugins that are loaded? > This has caused some mayhem for me when using a custom provider in projects > that use a specific version of SLF4J... because then failsafe forces 1.5.6 to > be loaded (from this process of incorrectly finding the custom provider), > causing a crash. > It is a simple fix (3 lines in AbstractSurefireMojo - it had the name of the > Surefire plugin hardcoded, which isn't correct when it's actually Failsafe). > I've got a patched fork of master on GitHub > (https://github.com/jon-bell/maven-surefire/commit/04f66cdd828d131a028eb400d1ed26fe104fe3f2) > that fixes it and an integration test that demonstrates the flaw. I am not > 100% sure on the formatting of the integration test (i.e., I am opening a > JIRA ticket so that I suppose I can name it under the JIRA issue? How should > I specify the current version of surefire in the integration test package?) - > if the fix is welcome against master I'd be happy to open a PR on GitHub. I > am also happy to merge against a different branch if it's more helpful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (SUREFIRE-1383) dependenciesToScan Does Not Leverage Classpath Elements
[ https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1383: -- Assignee: Tibor Digana > dependenciesToScan Does Not Leverage Classpath Elements > > > Key: SUREFIRE-1383 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1383 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20 >Reporter: Owen Farrell >Assignee: Tibor Digana > Fix For: Backlog > > Attachments: scanned-dependencies-sample.zip > > > The configuration attribute relies solely on installed > artifacts. This is an issue when the targeted dependencies were built as part > of the current session. The net result is that stale artifacts are used (i.e. > if the dependency has changed since it was last installed) or the tests are > not executed at all (if the dependency has not been previously installed. > Attached is a sample project that illustrates this issue: > Given I have a multi-module project >And the first module built includes test classes as part of the project > artifact >And subsequent modules scan the first for unit tests to execute > When I execute the _*test*_ goal (prior to any install) > Then the build should succeed >And tests should be executed with each module -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1383) dependenciesToScan Does Not Leverage Classpath Elements
[ https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1383: --- Fix Version/s: (was: Backlog) 2.20.1 > dependenciesToScan Does Not Leverage Classpath Elements > > > Key: SUREFIRE-1383 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1383 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20 >Reporter: Owen Farrell >Assignee: Tibor Digana > Fix For: 2.20.1 > > Attachments: scanned-dependencies-sample.zip > > > The configuration attribute relies solely on installed > artifacts. This is an issue when the targeted dependencies were built as part > of the current session. The net result is that stale artifacts are used (i.e. > if the dependency has changed since it was last installed) or the tests are > not executed at all (if the dependency has not been previously installed. > Attached is a sample project that illustrates this issue: > Given I have a multi-module project >And the first module built includes test classes as part of the project > artifact >And subsequent modules scan the first for unit tests to execute > When I execute the _*test*_ goal (prior to any install) > Then the build should succeed >And tests should be executed with each module -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1264) Some tests can be lost when running in parallel with parameterized tests
[
https://issues.apache.org/jira/browse/SUREFIRE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145982#comment-16145982
]
Tibor Digana commented on SUREFIRE-1264:
CI passed all tests successfully:
https://builds.apache.org/job/maven-surefire-pipeline/job/SUREFIRE-1264_2/
> Some tests can be lost when running in parallel with parameterized tests
>
>
> Key: SUREFIRE-1264
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1264
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.7+ (parallel) support
>Affects Versions: 2.19.1
> Environment: Maven 3.3.9
> Java 1.8.0_45 (Oracle)
> System: OS X
> Reproduced on Linux too, with both OpenJDK 7 and Java 7 from Oracle.
>Reporter: Jean-Luc Derrien
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: failure-2.21-snapshot-SUREFIRE-1264.zip, pom.xml
>
>
> Hello,
> It appears some tests can be lost when using the parallel mode with
> parameterized tests. Here is a [small
> project|https://github.com/jderrien/surefire-junit-tests/tree/simple-1] I've
> used to try to reproduce the issue we have seen.
> This is not something that happens on every run, but it's quite frequent.
> With this loop, the problem should appear in less than 2 minutes, maybe on
> the first run when (un)lucky:
> {code}
> time while true; do mvn clean test > last.log ; tail -25 last.log ; if [
> "$(grep -c 'Tests run: 12' last.log)" == "0" ]; then break; fi ; done
> {code}
> Normal run:
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => stop
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.006 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec -
> in [p2]
> Results :
> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> When tests have been lost (here one test lost according to the output):
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec -
> in [p2]
> Results :
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> Note: there are 3 test classes and 18 tests on the [master
> branch|https://github.com/jderrien/surefire-junit-tests/tree/master] and it's
> even more frequent/easy to reproduce.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (SUREFIRE-1371) Plugin should fail if argLine is set when forkCount = 0
[
https://issues.apache.org/jira/browse/SUREFIRE-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-1371:
--
Assignee: Tibor Digana
> Plugin should fail if argLine is set when forkCount = 0
>
>
> Key: SUREFIRE-1371
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1371
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Failsafe Plugin, Maven Surefire Plugin, process
> forking
>Reporter: Gili
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> Following up on SUREFIRE-1369: The plugin should fail with a verbose error if
> {{forkCount=0}} and {{}} is set.
> Per [~tibor17], this sanity check should happen in {{AbstractSurefireMojo}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1373) Tests annotated with @NotThreadSafe are not executed in isolation
[ https://issues.apache.org/jira/browse/SUREFIRE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1373: --- Remaining Estimate: 48h Original Estimate: 48h > Tests annotated with @NotThreadSafe are not executed in isolation > - > > Key: SUREFIRE-1373 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1373 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20 >Reporter: Sebastian Kirsch >Assignee: Tibor Digana > Fix For: 2.20.1 > > Original Estimate: 48h > Remaining Estimate: 48h > > The [surefire > documentation|http://maven.apache.org/components/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html] > states that > bq. you can apply the JCIP annotation @net.jcip.annotations.NotThreadSafe on > the Java class of JUnit test (pure test class, Suite, Parameterized, etc.) in > order to execute it in single Thread instance. The Thread has name > maven-surefire-plugin@NotThreadSafe and it is executed at the end of the test > run. > However, the thread is run in parallel to the other tests being executed, > which contradicts the documentation and defeats the purpose of running tests > sequentially in a single thread. > See https://github.com/sebastiankirsch/surefire-nonthreadsafe for a test case. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1371) Plugin should fail if argLine is set when forkCount = 0
[
https://issues.apache.org/jira/browse/SUREFIRE-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1371:
---
Remaining Estimate: 48h
Original Estimate: 48h
> Plugin should fail if argLine is set when forkCount = 0
>
>
> Key: SUREFIRE-1371
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1371
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Failsafe Plugin, Maven Surefire Plugin, process
> forking
>Reporter: Gili
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Following up on SUREFIRE-1369: The plugin should fail with a verbose error if
> {{forkCount=0}} and {{}} is set.
> Per [~tibor17], this sanity check should happen in {{AbstractSurefireMojo}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1264) Some tests can be lost when running in parallel with parameterized tests
[
https://issues.apache.org/jira/browse/SUREFIRE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1264.
--
Resolution: Fixed
[~Prifiz]
[~valyok]
[~jderrien]
I fixed this issue. If you do not want to wait for the official release (cca 2
weeks) feel free to build and install it from master branch and use SNAPSHOT
version.
https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=c8724dd2f992625c355e4817a6b7995d3e88fdb4
> Some tests can be lost when running in parallel with parameterized tests
>
>
> Key: SUREFIRE-1264
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1264
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.7+ (parallel) support
>Affects Versions: 2.19.1
> Environment: Maven 3.3.9
> Java 1.8.0_45 (Oracle)
> System: OS X
> Reproduced on Linux too, with both OpenJDK 7 and Java 7 from Oracle.
>Reporter: Jean-Luc Derrien
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: failure-2.21-snapshot-SUREFIRE-1264.zip, pom.xml
>
> Time Spent: 144h
> Remaining Estimate: 24h
>
> Hello,
> It appears some tests can be lost when using the parallel mode with
> parameterized tests. Here is a [small
> project|https://github.com/jderrien/surefire-junit-tests/tree/simple-1] I've
> used to try to reproduce the issue we have seen.
> This is not something that happens on every run, but it's quite frequent.
> With this loop, the problem should appear in less than 2 minutes, maybe on
> the first run when (un)lucky:
> {code}
> time while true; do mvn clean test > last.log ; tail -25 last.log ; if [
> "$(grep -c 'Tests run: 12' last.log)" == "0" ]; then break; fi ; done
> {code}
> Normal run:
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => stop
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => stop
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.006 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec -
> in [p2]
> Results :
> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> When tests have been lost (here one test lost according to the output):
> {noformat}
> ---
> T E S T S
> ---
> Running [p2]
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 -
> sleeptime = 5 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 -
> sleeptime = 1 => start
> com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 -
> sleeptime = 2 => start
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec -
> in [p2]
> Running [p2]
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec -
> in [p2]
> Results :
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> Note: there are 3 test classes and 18 tests on the [master
> branch|https://github.com/jderrien/surefire-junit-tests/tree/master] and it's
> even more frequent/easy to reproduce.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1372:
---
Fix Version/s: 2.20.1
> Rerunning failing tests fails in combination with
> Description#createSuiteDescription
>
>
> Key: SUREFIRE-1372
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1372
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: M.P. Korstanje
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> When using surefire to rerun failing tests created by a Runner that uses
> {noformat}Description#createSuiteDescription{noformat} with a human readable
> name rather then a class name the following stack trace occurs:
> {code}
> org.apache.maven.surefire.testset.TestSetFailedException: Unable to create
> test class 'Scenario: Fail when running'
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:385)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> Caused by: java.lang.ClassNotFoundException: Scenario: Fail when running
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:379)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-1408:
--
Assignee: Tibor Digana
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 2.20.1
>
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter8706425108380679609.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3030080908304903958tmp
> surefire_5025412729838224505067tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] org.
[jira] [Updated] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1408:
---
Fix Version/s: (was: 2.20.1)
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter8706425108380679609.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3030080908304903958tmp
> surefire_5025412729838224505067tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] org.apache.maven.surefire.booter.
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156009#comment-16156009
]
Tibor Digana commented on SUREFIRE-1408:
[~aonishuk]
I think you touched the issue when GC is quite long, cca 10 seconds at least.
Could it be?
We have it fixed in {{2.20.1}}. You can check it out with current snapshot
Version {{2.21-SNAPSHOT}} if you build Surefire project from GitHub and install
it in you local repo via {{mvn install -DskipTests}} and use plugin Version
{{2.21-SNAPSHOT}} in your project.
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156014#comment-16156014
]
Tibor Digana commented on SUREFIRE-1408:
[~aonishuk]
I was talking about fixed issue {{SUREFIRE-1302}}.
I hope it is really gone; otherwise it's a big problem then.
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter8706425108380679609.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3030080908304903958tmp
> surefire_502541272983822450
[jira] [Commented] (SUREFIRE-1382) OutOfMemoryError occurs when JUnit 5 test fails
[
https://issues.apache.org/jira/browse/SUREFIRE-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157288#comment-16157288
]
Tibor Digana commented on SUREFIRE-1382:
Surefire will be released soon.
On Thu, Sep 7, 2017 at 3:00 PM, Mark Lagendijk (JIRA)
> OutOfMemoryError occurs when JUnit 5 test fails
> ---
>
> Key: SUREFIRE-1382
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1382
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Maven home: C:\prg\apache-maven-3.3.9\bin\..
> Java version: 1.8.0_102, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_102\jre
> Default locale: en_US, platform encoding: Cp1251
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos"
>Reporter: Oleksij Lupandin
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
>
> h4. Steps to reproduce
> # Check out project "maven-surefire2_20-junit5" from
> https://wissenst...@gitlab.com/wissenstein/maven-surefire2_20-junit5.git.
> # Go to the project root (where pom.xml is).
> # Run the following command: {code}mvn -Psurefire2_19_1 clean test{code}
> The project is tested using Surefire Maven plugin version 2.19.1. At the end
> of the output you can see:
> {code}---
> T E S T S
> ---
> Running com.wissenstein.mavensurefirejunit.SimplisticTest
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.073 sec <<<
> FAILURE! - in com.wissenstein.mavensurefirejunit.SimplisticTest
> shouldDeliberatelyFail() Time elapsed: 0.021 sec <<< FAILURE!
> org.opentest4j.AssertionFailedError: Test deliberately failed
> at
> com.wissenstein.mavensurefirejunit.SimplisticTest.shouldDeliberatelyFail(SimplisticTest.java:11)
> Results :
> Failed tests:
> SimplisticTest.shouldDeliberatelyFail:11 Test deliberately failed
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 4.583 s
> [INFO] Finished at: 2017-06-06T16:57:35+02:00
> [INFO] Final Memory: 16M/264M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire2_20-junit5: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> C:\projects\surefire\maven-surefire2_20-junit5\target\surefire-reports for
> the individual test results.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException{code}
> # Run the following command: {code}mvn -Psurefire2_20 clean test{code}
> The project is tested using Surefire Maven plugin version 2.20.
> h4. Actual result
> At the end of the output you can see: {code}[INFO]
> ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running com.wissenstein.mavensurefirejunit.SimplisticTest
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 6.061 s
> [INFO] Finished at: 2017-06-06T17:03:52+02:00
> [INFO] Final Memory: 17M/3028M
> [INFO]
>
> [ERROR] Java heap space -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/OutOfMemoryError{code}
> The stack trace is as follows: {code}java.lang.OutOfMemoryError: Java heap
> space
> at java.util.Arrays.copyOf(Arrays.java:3332)
> at
> java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124)
> at
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157315#comment-16157315
]
Tibor Digana commented on SUREFIRE-1408:
[~aonishuk]
Attach current dump files and logs as files, but not in the Jira as comments.
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter8706425108380679609.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3030080908304903958tmp
> surefire_5025412729838224505067tmp
> [ERROR] Error occurred i
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157373#comment-16157373
]
Tibor Digana commented on SUREFIRE-1408:
[~aonishuk]
I guess this is OOM.
You have quite a lot tests and I guess the JVM exited. The logs tells me that
two test classes were aborted. The abort means that JVM finished abruptly and
did not finish test set. It's quite hard to confirm this but you can lookup
files generated by JVM {{java.hprof.txt}} or after segmentation fault
{{hs_err_pid*}}. If these are not found on the disk then configure JVM to write
dump file on OOM to disk. Printing GC with {{verbose:gc}} may help whats is
going on with Heap and PermGen. Please remove {{-X -e}} in commandline.
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye.
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157422#comment-16157422
]
Tibor Digana commented on SUREFIRE-1408:
[~jonathan.hurley]
Java Heap might not be enough. Did you tune {{MaxPermSize}} on Java 6 or 7 and
{{MaxMetaSpace}} on Java 8.
Maybe you should use {{jconsole}}.
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter8706425108380679609.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire303008090830490
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157434#comment-16157434
]
Tibor Digana commented on SUREFIRE-1408:
What happens if you do not use groups?
${testcase.groups}
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter8706425108380679609.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3030080908304903958tmp
> surefire_5025412729838224505067tmp
> [ERROR] Error occurred in starting fork, check output i
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157513#comment-16157513
]
Tibor Digana commented on SUREFIRE-1408:
Do you use {{System.exit}} or {{Runtime.halt}} or {{FileDescriptor.out}} ?
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter8706425108380679609.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3030080908304903958tmp
> surefire_5025412729838224505067tmp
> [ERROR] Error occurred in starting fork
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157628#comment-16157628
]
Tibor Digana commented on SUREFIRE-1408:
[~aonishuk]
[~jonathan.hurley]
I have observed different result. I use Maven 3.5.0, JDK 1.8.0_144 and 16 GRAM.
This summary is from second run. The first run was without {{clean}} and {{-X}}
and {{-e}} but the summary was different and first two modules failed.
I did not see error in your tests.
I checked out the branch you told me as written in your post.
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Web . FAILURE [ 52.635 s]
[INFO] Ambari Views ... SUCCESS [ 6.327 s]
[INFO] utility SUCCESS [ 2.318 s]
[INFO] Ambari Metrics Common .. SUCCESS [ 8.940 s]
[INFO] Ambari Server .. FAILURE [04:42 min]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 05:53 min
[INFO] Finished at: 2017-09-07T22:44:53+02:00
[INFO] Final Memory: 53M/371M
[INFO]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec
(ambari-web unit tests) on project ambari-web: Command execution failed.
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (ambari-web unit tests)
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, chec
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157630#comment-16157630
]
Tibor Digana commented on SUREFIRE-1408:
This is my mvn options which includes memory setting for Maven process:
echo %MAVEN_OPTS%
-Dhttps.protocols="TLSv1" -server -Xmx768m -XX:MaxMetaspaceSize=864m
-Dmaven.repo.local=D:\.m2\repository
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter8706425108380679609.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_
[jira] [Updated] (SUREFIRE-1383) dependenciesToScan Does Not Leverage Classpath Elements
[ https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1383: --- Fix Version/s: (was: 2.20.1) 2.20.2 > dependenciesToScan Does Not Leverage Classpath Elements > > > Key: SUREFIRE-1383 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1383 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20 >Reporter: Owen Farrell >Assignee: Tibor Digana > Fix For: 2.20.2 > > Attachments: scanned-dependencies-sample.zip > > Time Spent: 48h > Remaining Estimate: 24h > > The configuration attribute relies solely on installed > artifacts. This is an issue when the targeted dependencies were built as part > of the current session. The net result is that stale artifacts are used (i.e. > if the dependency has changed since it was last installed) or the tests are > not executed at all (if the dependency has not been previously installed. > Attached is a sample project that illustrates this issue: > Given I have a multi-module project >And the first module built includes test classes as part of the project > artifact >And subsequent modules scan the first for unit tests to execute > When I execute the _*test*_ goal (prior to any install) > Then the build should succeed >And tests should be executed with each module -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1372:
---
Fix Version/s: (was: 2.20.1)
2.20.2
> Rerunning failing tests fails in combination with
> Description#createSuiteDescription
>
>
> Key: SUREFIRE-1372
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1372
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: M.P. Korstanje
>Assignee: Tibor Digana
> Fix For: 2.20.2
>
>
> When using surefire to rerun failing tests created by a Runner that uses
> {noformat}Description#createSuiteDescription{noformat} with a human readable
> name rather then a class name the following stack trace occurs:
> {code}
> org.apache.maven.surefire.testset.TestSetFailedException: Unable to create
> test class 'Scenario: Fail when running'
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:385)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> Caused by: java.lang.ClassNotFoundException: Scenario: Fail when running
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:379)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1373) Tests annotated with @NotThreadSafe are not executed in isolation
[ https://issues.apache.org/jira/browse/SUREFIRE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1373: --- Fix Version/s: (was: 2.20.1) 2.20.2 > Tests annotated with @NotThreadSafe are not executed in isolation > - > > Key: SUREFIRE-1373 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1373 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20 >Reporter: Sebastian Kirsch >Assignee: Tibor Digana > Fix For: 2.20.2 > > Original Estimate: 48h > Remaining Estimate: 48h > > The [surefire > documentation|http://maven.apache.org/components/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html] > states that > bq. you can apply the JCIP annotation @net.jcip.annotations.NotThreadSafe on > the Java class of JUnit test (pure test class, Suite, Parameterized, etc.) in > order to execute it in single Thread instance. The Thread has name > maven-surefire-plugin@NotThreadSafe and it is executed at the end of the test > run. > However, the thread is run in parallel to the other tests being executed, > which contradicts the documentation and defeats the purpose of running tests > sequentially in a single thread. > See https://github.com/sebastiankirsch/surefire-nonthreadsafe for a test case. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1371) Plugin should fail if argLine is set when forkCount = 0
[
https://issues.apache.org/jira/browse/SUREFIRE-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1371:
---
Fix Version/s: (was: 2.20.1)
2.20.2
> Plugin should fail if argLine is set when forkCount = 0
>
>
> Key: SUREFIRE-1371
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1371
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Failsafe Plugin, Maven Surefire Plugin, process
> forking
>Reporter: Gili
>Assignee: Tibor Digana
> Fix For: 2.20.2
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Following up on SUREFIRE-1369: The plugin should fail with a verbose error if
> {{forkCount=0}} and {{}} is set.
> Per [~tibor17], this sanity check should happen in {{AbstractSurefireMojo}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (SUREFIRE-1409) Parallel runner should not drop away runners that have zero children.
Tibor Digana created SUREFIRE-1409: -- Summary: Parallel runner should not drop away runners that have zero children. Key: SUREFIRE-1409 URL: https://issues.apache.org/jira/browse/SUREFIRE-1409 Project: Maven Surefire Issue Type: Bug Components: Junit 4.7+ (parallel) support Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 2.20.2 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1409) Parallel runner should not drop away runners that have zero children.
[ https://issues.apache.org/jira/browse/SUREFIRE-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1409: --- Issue Type: Improvement (was: Bug) > Parallel runner should not drop away runners that have zero children. > - > > Key: SUREFIRE-1409 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1409 > Project: Maven Surefire > Issue Type: Improvement > Components: Junit 4.7+ (parallel) support >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.2 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Description:
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules java.se.ee}}
The fix would be to add "--add-modules java.se.ee" if {{--add-modules}} is not
specified by user at Java 9+.
was:
Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help
and does not do anything because the module is ignored in Java 9.
In-plugin provider does not have any problem to load classes from entire JDK.
Forked JVM would work only after added
{{--add-modules ALL-SYSTEM}}
The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is not
specified by user at Java 9+.
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules java.se.ee}}
> The fix would be to add "--add-modules java.se.ee" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Summary: [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI
argument (was: [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI
argument)
> [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules java.se.ee}}
> The fix would be to add "--add-modules java.se.ee" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1409) Parallel runner should not drop away runners that have zero children.
[ https://issues.apache.org/jira/browse/SUREFIRE-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1409: --- Description: JUnit does not force runners to include all child tests in Description. Therefore Parallel Runner should not throw such tests away. For example Spock does not report parametrized tests. [https://github.com/spockframework/spock/pull/558] > Parallel runner should not drop away runners that have zero children. > - > > Key: SUREFIRE-1409 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1409 > Project: Maven Surefire > Issue Type: Improvement > Components: Junit 4.7+ (parallel) support >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.2 > > > JUnit does not force runners to include all child tests in Description. > Therefore Parallel Runner should not throw such tests away. > For example Spock does not report parametrized tests. > [https://github.com/spockframework/spock/pull/558] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159299#comment-16159299
]
Tibor Digana commented on SUREFIRE-1408:
[~aonishuk]
This is my result:
{{
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ... SUCCESS [ 7.566 s]
[INFO] utility SUCCESS [ 2.017 s]
[INFO] Ambari Metrics Common .. SUCCESS [ 12.307 s]
[INFO] Ambari Server .. FAILURE [ 6.704 s]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 29.626 s
[INFO] Finished at: 2017-09-08T22:40:25+02:00
[INFO] Final Memory: 43M/313M
[INFO]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec
(azuredb-gen) on project ambari-server: Command execution failed.: Cannot run
program
"E:\tmp\zmaz12\ambari\ambari-server\src\main\sh\azuredb_create_generator.sh"
(in directory "E:\tmp\zmaz12\ambari\ambari-server"): CreateProcess error=193,
%1 is not a valid Win32 application -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
}}
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ER
[jira] [Comment Edited] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159299#comment-16159299
]
Tibor Digana edited comment on SUREFIRE-1408 at 9/8/17 8:44 PM:
[~aonishuk]
This is my result:
{panel}
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ... SUCCESS [ 7.566 s]
[INFO] utility SUCCESS [ 2.017 s]
[INFO] Ambari Metrics Common .. SUCCESS [ 12.307 s]
[INFO] Ambari Server .. FAILURE [ 6.704 s]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 29.626 s
[INFO] Finished at: 2017-09-08T22:40:25+02:00
[INFO] Final Memory: 43M/313M
[INFO]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec
(azuredb-gen) on project ambari-server: Command execution failed.: Cannot run
program
"E:\tmp\zmaz12\ambari\ambari-server\src\main\sh\azuredb_create_generator.sh"
(in directory "E:\tmp\zmaz12\ambari\ambari-server"): CreateProcess error=193,
%1 is not a valid Win32 application -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
{panel}
was (Author: tibor17):
[~aonishuk]
This is my result:
{{
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ... SUCCESS [ 7.566 s]
[INFO] utility SUCCESS [ 2.017 s]
[INFO] Ambari Metrics Common .. SUCCESS [ 12.307 s]
[INFO] Ambari Server .. FAILURE [ 6.704 s]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 29.626 s
[INFO] Finished at: 2017-09-08T22:40:25+02:00
[INFO] Final Memory: 43M/313M
[INFO]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec
(azuredb-gen) on project ambari-server: Command execution failed.: Cannot run
program
"E:\tmp\zmaz12\ambari\ambari-server\src\main\sh\azuredb_create_generator.sh"
(in directory "E:\tmp\zmaz12\ambari\ambari-server"): CreateProcess error=193,
%1 is not a valid Win32 application -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
}}
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
>
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159306#comment-16159306
]
Tibor Digana commented on SUREFIRE-1408:
[~aonishuk]
Should I use Ubuntu or Fedora?
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter8706425108380679609.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3030080908304903958tmp
> surefire_5025412729838224505067tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR]
[jira] [Updated] (SUREFIRE-1409) Parallel runner should not drop away runners that have zero children.
[ https://issues.apache.org/jira/browse/SUREFIRE-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1409: --- Fix Version/s: (was: 2.20.2) 2.20.1 > Parallel runner should not drop away runners that have zero children. > - > > Key: SUREFIRE-1409 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1409 > Project: Maven Surefire > Issue Type: Improvement > Components: Junit 4.7+ (parallel) support >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.1 > > > JUnit does not force runners to include all child tests in Description. > Therefore Parallel Runner should not throw such tests away. > For example Spock does not report parametrized tests. > [https://github.com/spockframework/spock/pull/558] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1409) Parallel runner should not drop away runners that have zero children.
[ https://issues.apache.org/jira/browse/SUREFIRE-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1409. -- Resolution: Fixed https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=67c06d5876dcabc037de9b5f4cc226beeedcb379 > Parallel runner should not drop away runners that have zero children. > - > > Key: SUREFIRE-1409 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1409 > Project: Maven Surefire > Issue Type: Improvement > Components: Junit 4.7+ (parallel) support >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.1 > > > JUnit does not force runners to include all child tests in Description. > Therefore Parallel Runner should not throw such tests away. > For example Spock does not report parametrized tests. > [https://github.com/spockframework/spock/pull/558] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1373) Tests annotated with @NotThreadSafe are not executed in isolation
[
https://issues.apache.org/jira/browse/SUREFIRE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159838#comment-16159838
]
Tibor Digana commented on SUREFIRE-1373:
[~apache-bugzi...@sebastian-kirsch.org]
[~sebastiankirsch]
[~tuk]
I checked the code again and it is correct. I want to say that now I do not see
error in the code.
Therefore I would like to ask you to do one of these two things or both:
* write a {{pom.xml}} and simple sources to reproduce this issue
* write unit test in our existing test class
[ParallelComputerBuilderTest|https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java]
and print in console expected test is being run after {{sleep()}} with
different delays in each method.
> Tests annotated with @NotThreadSafe are not executed in isolation
> -
>
> Key: SUREFIRE-1373
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1373
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: Sebastian Kirsch
>Assignee: Tibor Digana
> Fix For: 2.20.2
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The [surefire
> documentation|http://maven.apache.org/components/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html]
> states that
> bq. you can apply the JCIP annotation @net.jcip.annotations.NotThreadSafe on
> the Java class of JUnit test (pure test class, Suite, Parameterized, etc.) in
> order to execute it in single Thread instance. The Thread has name
> maven-surefire-plugin@NotThreadSafe and it is executed at the end of the test
> run.
> However, the thread is run in parallel to the other tests being executed,
> which contradicts the documentation and defeats the purpose of running tests
> sequentially in a single thread.
> See https://github.com/sebastiankirsch/surefire-nonthreadsafe for a test case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1373) Tests annotated with @NotThreadSafe are not executed in isolation
[ https://issues.apache.org/jira/browse/SUREFIRE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1373: --- Fix Version/s: (was: 2.20.2) Backlog > Tests annotated with @NotThreadSafe are not executed in isolation > - > > Key: SUREFIRE-1373 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1373 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20 >Reporter: Sebastian Kirsch >Assignee: Tibor Digana > Fix For: Backlog > > Original Estimate: 48h > Remaining Estimate: 48h > > The [surefire > documentation|http://maven.apache.org/components/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html] > states that > bq. you can apply the JCIP annotation @net.jcip.annotations.NotThreadSafe on > the Java class of JUnit test (pure test class, Suite, Parameterized, etc.) in > order to execute it in single Thread instance. The Thread has name > maven-surefire-plugin@NotThreadSafe and it is executed at the end of the test > run. > However, the thread is run in parallel to the other tests being executed, > which contradicts the documentation and defeats the purpose of running tests > sequentially in a single thread. > See https://github.com/sebastiankirsch/surefire-nonthreadsafe for a test case. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SUREFIRE-1410) Add FAQ and improve Warning message when native stream in forked JVM is corrupted
Tibor Digana created SUREFIRE-1410: -- Summary: Add FAQ and improve Warning message when native stream in forked JVM is corrupted Key: SUREFIRE-1410 URL: https://issues.apache.org/jira/browse/SUREFIRE-1410 Project: Maven Surefire Issue Type: Improvement Components: Maven Failsafe Plugin, Maven Surefire Plugin Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 2.20.1 Related to the discussion with contributors in SUREFIRE-1359. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1410) Add FAQ and improve Warning message when native stream in forked JVM is corrupted
[
https://issues.apache.org/jira/browse/SUREFIRE-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1410:
---
Docs Text: (was: The message {{Corrupted stdin stream in forked JVM}}
would become more specific {{Corrupted STDOUT by directly writing to native
stream in forked JVM}}.
Then {{See the dump file}} would be extended to {{See FAQ web page and the dump
file}}.
These messages would appear just once in the console and not per fork as it was
in prior versions.)
> Add FAQ and improve Warning message when native stream in forked JVM is
> corrupted
> -
>
> Key: SUREFIRE-1410
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1410
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Labels: documentation
> Fix For: 2.20.1
>
>
> Related to the discussion with contributors in SUREFIRE-1359.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1410) Add FAQ and improve Warning message when native stream in forked JVM is corrupted
[
https://issues.apache.org/jira/browse/SUREFIRE-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1410:
---
Description:
Related to the discussion with contributors in SUREFIRE-1359.
The message {{Corrupted stdin stream in forked JVM}} would become more specific
{{Corrupted STDOUT by directly writing to native stream in forked JVM}}.
Then {{See the dump file}} would be extended to {{See FAQ web page and the dump
file}}.
These messages would appear just once in the console and not per fork as it was
in prior versions.
was:
Related to the discussion with contributors in SUREFIRE-1359.
> Add FAQ and improve Warning message when native stream in forked JVM is
> corrupted
> -
>
> Key: SUREFIRE-1410
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1410
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Labels: documentation
> Fix For: 2.20.1
>
>
> Related to the discussion with contributors in SUREFIRE-1359.
> The message {{Corrupted stdin stream in forked JVM}} would become more
> specific {{Corrupted STDOUT by directly writing to native stream in forked
> JVM}}.
> Then {{See the dump file}} would be extended to {{See FAQ web page and the
> dump file}}.
> These messages would appear just once in the console and not per fork as it
> was in prior versions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (SUREFIRE-1411) Improve calls String.length == 0 to Java 1.6 call String.isEmpty
Tibor Digana created SUREFIRE-1411: -- Summary: Improve calls String.length == 0 to Java 1.6 call String.isEmpty Key: SUREFIRE-1411 URL: https://issues.apache.org/jira/browse/SUREFIRE-1411 Project: Maven Surefire Issue Type: Improvement Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 2.20.1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1411) Improve calls String.length == 0 to Java 1.6 call String.isEmpty
[ https://issues.apache.org/jira/browse/SUREFIRE-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1411. -- Resolution: Fixed https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=8a63486f8efc721d0003cb5685e590a98369704a > Improve calls String.length == 0 to Java 1.6 call String.isEmpty > > > Key: SUREFIRE-1411 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1411 > Project: Maven Surefire > Issue Type: Improvement >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.1 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1410) Add FAQ and improve Warning message when native stream in forked JVM is corrupted
[
https://issues.apache.org/jira/browse/SUREFIRE-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1410.
--
Resolution: Fixed
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=ead22a3d399a5fd608ebae90a079644ab786eae8
> Add FAQ and improve Warning message when native stream in forked JVM is
> corrupted
> -
>
> Key: SUREFIRE-1410
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1410
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Labels: documentation
> Fix For: 2.20.1
>
>
> Related to the discussion with contributors in SUREFIRE-1359.
> The message {{Corrupted stdin stream in forked JVM}} would become more
> specific {{Corrupted STDOUT by directly writing to native stream in forked
> JVM}}.
> Then {{See the dump file}} would be extended to {{See FAQ web page and the
> dump file}}.
> These messages would appear just once in the console and not per fork as it
> was in prior versions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (SUREFIRE-1412) Findbugs plugin fails - Update maven-parent to Version 30 and downgrade maven-site-plugin
Tibor Digana created SUREFIRE-1412: -- Summary: Findbugs plugin fails - Update maven-parent to Version 30 and downgrade maven-site-plugin Key: SUREFIRE-1412 URL: https://issues.apache.org/jira/browse/SUREFIRE-1412 Project: Maven Surefire Issue Type: Bug Affects Versions: 2.20 Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 2.20.1 The solution is to Update :maven-parent:26 to Version 30. Consequently after the update Fluido 1.3.0 fails [1] and the solution is to downgrage maven-site-plugin:3.5.1 to 3.4. [1]: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.6:site (default-site) on project surefire: Velocity parsing error while reading the site decoration template from org.apache.maven.skins:maven-fluido-skin:jar:1.4 skin: Encountered "source" at META-INF/maven/site.vm[line 1162, column 52] [ERROR] Was expecting one of: [ERROR] "," ... [ERROR] ")" ... [ERROR] ... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1412) Findbugs plugin fails - Update maven-parent to Version 30 and downgrade maven-site-plugin
[ https://issues.apache.org/jira/browse/SUREFIRE-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1412. -- Resolution: Fixed https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=b8eb673627e5d73d0e3d0dfdd639f257e10536ea > Findbugs plugin fails - Update maven-parent to Version 30 and downgrade > maven-site-plugin > - > > Key: SUREFIRE-1412 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1412 > Project: Maven Surefire > Issue Type: Bug >Affects Versions: 2.20 >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.1 > > > The solution is to Update :maven-parent:26 to Version 30. > Consequently after the update Fluido 1.3.0 fails [1] and the solution is to > downgrage maven-site-plugin:3.5.1 to 3.4. > [1]: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.6:site (default-site) on project > surefire: Velocity parsing error while reading the site decoration template > from org.apache.maven.skins:maven-fluido-skin:jar:1.4 skin: Encountered > "source" at META-INF/maven/site.vm[line 1162, column 52] > [ERROR] Was expecting one of: > [ERROR] "," ... > [ERROR] ")" ... > [ERROR] ... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SUREFIRE-1413) Javadoc - unknown TAG @noinspection
Tibor Digana created SUREFIRE-1413:
--
Summary: Javadoc - unknown TAG @noinspection
Key: SUREFIRE-1413
URL: https://issues.apache.org/jira/browse/SUREFIRE-1413
Project: Maven Surefire
Issue Type: Bug
Reporter: Tibor Digana
Assignee: Tibor Digana
Fix For: 2.20.1
After updated {{maven-parent}} Version to 30 this issue became a blocker to
release {{2.20.1}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1413) Javadoc - unknown TAG @noinspection
[
https://issues.apache.org/jira/browse/SUREFIRE-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1413.
--
Resolution: Fixed
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=c8e42d05c8fb0a5b3ac8b14d33cac7ac196bbd60
> Javadoc - unknown TAG @noinspection
> ---
>
> Key: SUREFIRE-1413
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1413
> Project: Maven Surefire
> Issue Type: Bug
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Labels: javadoc
> Fix For: 2.20.1
>
>
> After updated {{maven-parent}} Version to 30 this issue became a blocker to
> release {{2.20.1}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1413) Javadoc - unknown TAG @noinspection
[
https://issues.apache.org/jira/browse/SUREFIRE-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1413:
---
Labels: javadoc (was: )
> Javadoc - unknown TAG @noinspection
> ---
>
> Key: SUREFIRE-1413
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1413
> Project: Maven Surefire
> Issue Type: Bug
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Labels: javadoc
> Fix For: 2.20.1
>
>
> After updated {{maven-parent}} Version to 30 this issue became a blocker to
> release {{2.20.1}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1408) Surefire tests constantly fail due to fork issue.
[
https://issues.apache.org/jira/browse/SUREFIRE-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167058#comment-16167058
]
Tibor Digana commented on SUREFIRE-1408:
Pls do not put the log in comment. There is better way - attached files.
Do you use {{SecurityManager}}? Due to I see
{{checkExit(AmbariException.java:30)}.
What is not granted in your security manager?
> Surefire tests constantly fail due to fork issue.
> -
>
> Key: SUREFIRE-1408
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1408
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20
>Reporter: Andrew Onischuk
>Assignee: Tibor Digana
>Priority: Blocker
>
> Our project cannot run the tests for some reason we have this error. This is
> blocking 100% of test runs. A big blocker for our project.
> The tests which fail with this are always random.
> {noformat}
> [WARNING] Tests run: 4830, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [4.001s]
> [INFO] utility ... SUCCESS [1.057s]
> [INFO] Ambari Metrics Common . SUCCESS [14.892s]
> [INFO] Ambari Server . FAILURE
> [28:40.637s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 29:01.548s
> [INFO] Finished at: Wed Sep 06 13:53:46 EEST 2017
> [INFO] Final Memory: 49M/583M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on
> project ambari-server: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /tmp/ambari_test_java/ambari-server/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter7964123771295668464.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun4 surefire3196986160626902066tmp
> surefire_494835328994998108571tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.controller.AmbariServerTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter5127210523160415183.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun1 surefire5729106817171066937tmp
> surefire_5004808314434139002513tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter3901662057959462367.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13-25-37_978-jvmRun2 surefire1724459552574953042tmp
> surefire_5012934123283689072947tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR]
> org.apache.ambari.server.controller.metrics.ganglia.GangliaPropertyProviderTest
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd /tmp/ambari_test_java/ambari-server &&
> /usr/local/java/jdk1.8.0_25/jre/bin/java -Xmx2048m -XX:MaxPermSize=1024m
> -Xms1024m -jar
> /tmp/ambari_test_java/ambari-server/target/surefire/surefirebooter8706425108380679609.jar
> /tmp/ambari_test_java/ambari-server/target/surefire
> 2017-09-06T13
