[jira] [Commented] (MESOS-2216) The "configure" phase breaks with the IBM JVM.
[ https://issues.apache.org/jira/browse/MESOS-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607576#comment-14607576 ] Jihun Kang commented on MESOS-2216: --- Does anyone work on this issue? If not, can I start to work on this issue? > The "configure" phase breaks with the IBM JVM. > -- > > Key: MESOS-2216 > URL: https://issues.apache.org/jira/browse/MESOS-2216 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.20.1, 1.0.0 > Environment: Ubuntu / x86_64 >Reporter: Tony Reix > > ./configure does not work with IBM JVM, since it looks for a directory: >/usr/lib/jvm/ibm-java-x86_64-71/jre/lib/amd64/server x86_64 >/usr/lib/jvm/ibm-java-ppc64le-71/jre/lib/ppc64le/serverPPC64 LE > that does not exist for the IBM JVM. > Though this directory does exist for Oracle JVM and Open JDK: >/usr/lib/jvm/jdk1.7.0_71/jre/lib/amd64/server Oracle JVM >/usr/lib/jvm/java-1.7.0-openjdk-amd64/jre/lib/amd64/server OpenJDK > However, the files: > libjsig.so > libjvm.so (3 versions) > do exist for IBM JVM. > Anyway, creating the server directory and copying the files (tried with the 3 > versions of libjvm.so) does not fix the issue: > checking whether or not we can build with JNI... > /usr/lib/jvm/ibm-java-x86_64-71/jre/lib/amd64/server/libjvm.so: undefined > reference to `dlopen' > /usr/lib/jvm/ibm-java-x86_64-71/jre/lib/amd64/server/libjvm.so: undefined > reference to `dlclose' > /usr/lib/jvm/ibm-java-x86_64-71/jre/lib/amd64/server/libjvm.so: undefined > reference to `dlerror' > /usr/lib/jvm/ibm-java-x86_64-71/jre/lib/amd64/server/libjvm.so: undefined > reference to `dlsym' > /usr/lib/jvm/ibm-java-x86_64-71/jre/lib/amd64/server/libjvm.so: undefined > reference to `dladdr' > Something (dlopen, dlclose, dlerror, dlsym, dladdr) is missing in IBM JVM. > So, either the configure step relies on a feature that is not in the Java > standard but only in the Oracle JVM and OpenJDK, or the IBM JVM lacks part of > the Java standard. > I'm not an expert about this. So, I'd like Mesos people to experiment with > IBM JVM. Maybe there is another solution for this step of the Mesos configure > that would work with all 3 JVMs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-2959) Mesos website deploy script should include Javadoc for generated code.
Connor Doyle created MESOS-2959: --- Summary: Mesos website deploy script should include Javadoc for generated code. Key: MESOS-2959 URL: https://issues.apache.org/jira/browse/MESOS-2959 Project: Mesos Issue Type: Improvement Components: project website Reporter: Connor Doyle cc [~adam-mesos] and [~BenWhitehead] Now that the Javadoc HTML includes the generated (protobuf and autoconf-templated) classes, they should be included on the web site. The rake file currently rolls its own call to the javadoc tool. See: https://reviews.apache.org/r/35961 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2957) Add version to MasterInfo
[ https://issues.apache.org/jira/browse/MESOS-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam B updated MESOS-2957: -- Assignee: Marco Massenzio > Add version to MasterInfo > - > > Key: MESOS-2957 > URL: https://issues.apache.org/jira/browse/MESOS-2957 > Project: Mesos > Issue Type: Improvement >Reporter: Vinod Kone >Assignee: Marco Massenzio > > This will help schedulers figure out the version of the master that they are > interacting with. See MESOS-2736 for additional context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2939) Testing the new workflow
[ https://issues.apache.org/jira/browse/MESOS-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Massenzio updated MESOS-2939: --- Labels: mesosphere test (was: test) > Testing the new workflow > > > Key: MESOS-2939 > URL: https://issues.apache.org/jira/browse/MESOS-2939 > Project: Mesos > Issue Type: Story >Affects Versions: 0.23.0 >Reporter: Marco Massenzio >Assignee: Marco Massenzio > Labels: mesosphere, test > Fix For: 0.24.0 > > > This is a simple test story to try out the new workflow. > Unfortunately, testing and getting it to work seems to be something that > actually does take up time, so I'm tracking this here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2294) Implement the Events stream on master for Call endpoint
[ https://issues.apache.org/jira/browse/MESOS-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anand Mazumdar updated MESOS-2294: -- Labels: mesosphere twitter (was: twitter) > Implement the Events stream on master for Call endpoint > --- > > Key: MESOS-2294 > URL: https://issues.apache.org/jira/browse/MESOS-2294 > Project: Mesos > Issue Type: Task >Reporter: Vinod Kone >Assignee: Anand Mazumdar > Labels: mesosphere, twitter > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2924) Allow simple construction via initializer list on hashset.
[
https://issues.apache.org/jira/browse/MESOS-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam B updated MESOS-2924:
--
Labels: mesosphere (was: )
> Allow simple construction via initializer list on hashset.
> --
>
> Key: MESOS-2924
> URL: https://issues.apache.org/jira/browse/MESOS-2924
> Project: Mesos
> Issue Type: Improvement
>Reporter: Till Toenshoff
>Assignee: Alexander Rojas
>Priority: Minor
> Labels: mesosphere
>
> {{hashmap}} already has a initializer-list constructor, {{hashset}} should
> offer the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MESOS-2552) C++ Scheduler library should send HTTP Calls to master
[ https://issues.apache.org/jira/browse/MESOS-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anand Mazumdar updated MESOS-2552: -- Sprint: Mesosphere Sprint 13 Labels: mesosphere (was: ) > C++ Scheduler library should send HTTP Calls to master > -- > > Key: MESOS-2552 > URL: https://issues.apache.org/jira/browse/MESOS-2552 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Anand Mazumdar > Labels: mesosphere > > Once the scheduler library sends Call messages, we should update it to send > Calls as HTTP requests to "/call" endpoint on master. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2939) IGNORE - Tests the new workflow
[ https://issues.apache.org/jira/browse/MESOS-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606312#comment-14606312 ] Marco Massenzio commented on MESOS-2939: Workflow is correct; the 'issue view buttons' appear to be correct; however, the actions taken are not the expected ones. Still following up in INFRA-9846 > IGNORE - Tests the new workflow > --- > > Key: MESOS-2939 > URL: https://issues.apache.org/jira/browse/MESOS-2939 > Project: Mesos > Issue Type: Story >Affects Versions: 0.23.0 >Reporter: Marco Massenzio >Assignee: Marco Massenzio > Labels: test > Fix For: 0.24.0 > > > This is a simple test story to try out the new workflow. > Please ignore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2951) Inefficient container usage collection
[ https://issues.apache.org/jira/browse/MESOS-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jojy Varghese updated MESOS-2951: - Story Points: 3 > Inefficient container usage collection > -- > > Key: MESOS-2951 > URL: https://issues.apache.org/jira/browse/MESOS-2951 > Project: Mesos > Issue Type: Improvement > Components: containerization, docker > Environment: linux >Reporter: Jojy Varghese >Assignee: Jojy Varghese > Labels: containerizer, docker > > docker containerizer currently collects usage statistics by calling os's > process statistics (eg ps ). There is scope for making this efficient, say by > querying cgroups file system. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2936) Create a design document for Quota support in Master
[ https://issues.apache.org/jira/browse/MESOS-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606299#comment-14606299 ] Marco Massenzio commented on MESOS-2936: hey, [~alex-mesos] - how many points should this task have? can you please make sure to add them, please? > Create a design document for Quota support in Master > > > Key: MESOS-2936 > URL: https://issues.apache.org/jira/browse/MESOS-2936 > Project: Mesos > Issue Type: Documentation > Components: documentation >Reporter: Alexander Rukletsov >Assignee: Alexander Rukletsov > Labels: mesosphere > > Create a design document for the Quota feature support in Mesos Master > (excluding allocator) to be shared with the Mesos community. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-2958) Update Call protobuf to move top level FrameworkInfo inside Subscribe
Vinod Kone created MESOS-2958: - Summary: Update Call protobuf to move top level FrameworkInfo inside Subscribe Key: MESOS-2958 URL: https://issues.apache.org/jira/browse/MESOS-2958 Project: Mesos Issue Type: Improvement Reporter: Vinod Kone It is better for FrameworkInfo to be only included in 'Subscribe' message (that needs to be added) instead of for every call. Instead the top level Call should contain a FrameworkID to identify the framework making the call. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-2957) Add version to MasterInfo
Vinod Kone created MESOS-2957: - Summary: Add version to MasterInfo Key: MESOS-2957 URL: https://issues.apache.org/jira/browse/MESOS-2957 Project: Mesos Issue Type: Improvement Reporter: Vinod Kone This will help schedulers figure out the version of the master that they are interacting with. See MESOS-2736 for additional context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2768) SIGPIPE in process::run_in_event_loop()
[
https://issues.apache.org/jira/browse/MESOS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606180#comment-14606180
]
Benjamin Mahler commented on MESOS-2768:
Sounds like we're accidentally closing libev's pipe..? Likely need an audit of
{{close}} and {{os::close}} calls.
One suggestion, if everything goes through {{os::close}}, we can provide
patches for folks to deploy that exposes libev's pipe fd's and if {{os::close}}
encounters a call against these fd's, then it can stack trace so we can find
the call site in the logs. Thoughts?
> SIGPIPE in process::run_in_event_loop()
> ---
>
> Key: MESOS-2768
> URL: https://issues.apache.org/jira/browse/MESOS-2768
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Yan Xu
>Priority: Critical
>
> Observed in production.
> {noformat:title=slave log}
> I0526 12:17:48.027257 51633 slave.cpp:4077] Received a new estimation of the
> oversubscribable resources
> W0526 12:17:48.027257 51636 logging.cpp:91] RAW: Received signal SIGPIPE;
> escalating to SIGABRT
> *** Aborted at 1432642668 (unix time) try "date -d @1432642668" if you are
> using GNU date ***
> PC: @ 0x7fa58c23eb6d raise
> *** SIGABRT (@0xc9a5) received by PID 51621 (TID 0x7fa58224c940) from PID
> 51621; stack trace: ***
> @ 0x7fa58c23eca0 (unknown)
> @ 0x7fa58c23eb6d raise
> @ 0x7fa58cc19ba7 mesos::internal::logging::handler()
> @ 0x7fa58c23eca0 (unknown)
> @ 0x7fa58c23da2b __libc_write
> @ 0x7fa58cb57b6f evpipe_write.part.5
> @ 0x7fa58d245070 process::run_in_event_loop<>()
> @ 0x7fa58d2441ba process::EventLoop::delay()
> @ 0x7fa58d1c3c9c process::clock::scheduleTick()
> @ 0x7fa58d1c65b1 process::Clock::timer()
> @ 0x7fa58d23915a process::delay<>()
> @ 0x7fa58d23a740 process::ReaperProcess::wait()
> @ 0x7fa58d21261a process::ProcessManager::resume()
> @ 0x7fa58d2128dc process::schedule()
> @ 0x7fa58c23683d start_thread
> @ 0x7fa58ba28fcd clone
> {noformat}
> {noformat:title=gdb}
> (gdb) bt
> #0 0x7fa58c23eb6d in raise () from /lib64/libpthread.so.0
> #1 0x7fa58cc19ba7 in mesos::internal::logging::handler (signal=Unhandled
> dwarf expression opcode 0xf3
> ) at logging/logging.cpp:92
> #2
> #3 0x7fa58c23da2b in write () from /lib64/libpthread.so.0
> #4 0x7fa58cb57b6f in evpipe_write (loop=0x7fa58e1e79c0, flag=Unhandled
> dwarf expression opcode 0xfa
> ) at ev.c:2172
> #5 0x7fa58d245070 in process::run_in_event_loop(const
> std::function()> &) (f=Unhandled dwarf expression
> opcode 0xf3
> ) at src/libev.hpp:80
> #6 0x7fa58d2441ba in process::EventLoop::delay(const Duration &, const
> std::function &) (duration=Unhandled dwarf expression opcode 0xf3
> ) at src/libev.cpp:106
> #7 0x7fa58d1c3c9c in process::clock::scheduleTick (timers=Unhandled
> dwarf expression opcode 0xf3
> ) at src/clock.cpp:119
> #8 0x7fa58d1c65b1 in process::Clock::timer(const Duration &, const
> std::function &) (duration=Unhandled dwarf expression opcode 0xf3
> ) at src/clock.cpp:254
> #9 0x7fa58d23915a in process::delay
> (duration=..., pid=Unhandled dwarf expression opcode 0xf3
> ) at ./include/process/delay.hpp:25
> #10 0x7fa58d23a740 in process::ReaperProcess::wait (this=0x2056920) at
> src/reap.cpp:93
> #11 0x7fa58d21261a in process::ProcessManager::resume (this=0x1db8d20,
> process=0x2056958) at src/process.cpp:2172
> #12 0x7fa58d2128dc in process::schedule (arg=Unhandled dwarf expression
> opcode 0xf3
> ) at src/process.cpp:602
> #13 0x7fa58c23683d in start_thread () from /lib64/libpthread.so.0
> #14 0x7fa58ba28fcd in clone () from /lib64/libc.so.6
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-2552) C++ Scheduler library should send HTTP Calls to master
[ https://issues.apache.org/jira/browse/MESOS-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606163#comment-14606163 ] Anand Mazumdar commented on MESOS-2552: --- This was needed for testing the call HTTP endpoint on master. Submitted a diff up for review : https://reviews.apache.org/r/36013 ( is still a work in progress ) > C++ Scheduler library should send HTTP Calls to master > -- > > Key: MESOS-2552 > URL: https://issues.apache.org/jira/browse/MESOS-2552 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone > > Once the scheduler library sends Call messages, we should update it to send > Calls as HTTP requests to "/call" endpoint on master. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-2552) C++ Scheduler library should send HTTP Calls to master
[ https://issues.apache.org/jira/browse/MESOS-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anand Mazumdar reassigned MESOS-2552: - Assignee: Anand Mazumdar > C++ Scheduler library should send HTTP Calls to master > -- > > Key: MESOS-2552 > URL: https://issues.apache.org/jira/browse/MESOS-2552 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Anand Mazumdar > > Once the scheduler library sends Call messages, we should update it to send > Calls as HTTP requests to "/call" endpoint on master. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2942) Create documentation for using SSL
[ https://issues.apache.org/jira/browse/MESOS-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606132#comment-14606132 ] Joris Van Remoortere commented on MESOS-2942: - https://reviews.apache.org/r/36003 > Create documentation for using SSL > -- > > Key: MESOS-2942 > URL: https://issues.apache.org/jira/browse/MESOS-2942 > Project: Mesos > Issue Type: Documentation > Components: libprocess >Reporter: Joris Van Remoortere >Assignee: Joris Van Remoortere >Priority: Blocker > Labels: documentation, libprocess, mesosphere, ssl > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2956) Stack trace in isolator tests on Linux VM
[
https://issues.apache.org/jira/browse/MESOS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606156#comment-14606156
]
Paul Brett commented on MESOS-2956:
---
https://reviews.apache.org/r/36014/
> Stack trace in isolator tests on Linux VM
> -
>
> Key: MESOS-2956
> URL: https://issues.apache.org/jira/browse/MESOS-2956
> Project: Mesos
> Issue Type: Bug
>Reporter: Paul Brett
>Assignee: Paul Brett
>
> PerfEventIsolatorTest fails with stack trace when run in Linux VM
> [--] 1 test from PerfEventIsolatorTest
> [ RUN ] PerfEventIsolatorTest.ROOT_CGROUPS_Sample
> F0629 11:38:17.088412 14114 isolator_tests.cpp:837] CHECK_SOME(isolator):
> Failed to create PerfEvent isolator, invalid events: { cycles, task-clock }
> *** Check failure stack trace: ***
> @ 0x2ab5e5aeeb1a google::LogMessage::Fail()
> @ 0x2ab5e5aeea66 google::LogMessage::SendToLog()
> @ 0x2ab5e5aee468 google::LogMessage::Flush()
> @ 0x2ab5e5af137c google::LogMessageFatal::~LogMessageFatal()
> @ 0x864b0c _CheckFatal::~_CheckFatal()
> @ 0xc458ed
> mesos::internal::tests::PerfEventIsolatorTest_ROOT_CGROUPS_Sample_Test::TestBody()
> @ 0x119fb17
> testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> @ 0x119ac9e
> testing::internal::HandleExceptionsInMethodIfSupported<>()
> @ 0x118305f testing::Test::Run()
> @ 0x1183782 testing::TestInfo::Run()
> @ 0x1183d0a testing::TestCase::Run()
> @ 0x11889d4 testing::internal::UnitTestImpl::RunAllTests()
> @ 0x11a09ae
> testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> @ 0x119b9c3
> testing::internal::HandleExceptionsInMethodIfSupported<>()
> @ 0x11878e0 testing::UnitTest::Run()
> @ 0xcdc8c7 main
> @ 0x2ab5e7fdbec5 (unknown)
> @ 0x861a89 (unknown)
> make[3]: *** [check-local] Aborted (core dumped)
> [ RUN ] UserCgroupIsolatorTest/2.ROOT_CGROUPS_UserCgroup
> F0629 11:49:38.763434 18836 isolator_tests.cpp:1200] CHECK_SOME(isolator):
> Failed to create PerfEvent isolator, invalid events: { cpu-cycles }
> *** Check failure stack trace: ***
> @ 0x2ba40eb2db1a google::LogMessage::Fail()
> @ 0x2ba40eb2da66 google::LogMessage::SendToLog()
> @ 0x2ba40eb2d468 google::LogMessage::Flush()
> @ 0x2ba40eb3037c google::LogMessageFatal::~LogMessageFatal()
> @ 0x864b0c _CheckFatal::~_CheckFatal()
> @ 0xc5ddb1
> mesos::internal::tests::UserCgroupIsolatorTest_ROOT_CGROUPS_UserCgroup_Test<>::TestBody()
> @ 0x119fc43
> testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> @ 0x119adca
> testing::internal::HandleExceptionsInMethodIfSupported<>()
> @ 0x118318b testing::Test::Run()
> @ 0x11838ae testing::TestInfo::Run()
> @ 0x1183e36 testing::TestCase::Run()
> @ 0x1188b00 testing::internal::UnitTestImpl::RunAllTests()
> @ 0x11a0ada
> testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> @ 0x119baef
> testing::internal::HandleExceptionsInMethodIfSupported<>()
> @ 0x1187a0c testing::UnitTest::Run()
> @ 0xcdc9f3 main
> @ 0x2ba41101aec5 (unknown)
> @ 0x861a89 (unknown)
> make[3]: *** [check-local] Aborted (core dumped)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MESOS-2890) Sandbox URL doesn't work in web-ui when using SSL
[ https://issues.apache.org/jira/browse/MESOS-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joris Van Remoortere updated MESOS-2890: Sprint: Mesosphere Sprint 13 > Sandbox URL doesn't work in web-ui when using SSL > - > > Key: MESOS-2890 > URL: https://issues.apache.org/jira/browse/MESOS-2890 > Project: Mesos > Issue Type: Bug > Components: webui >Reporter: Joris Van Remoortere >Assignee: Joris Van Remoortere >Priority: Critical > Labels: mesosphere, sandbox, ssl, webui > > The links to the sandbox in the web ui don't work when ssl is enabled. This > is likely an 'http' -> 'https' issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2119) Add Socket tests
[ https://issues.apache.org/jira/browse/MESOS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joris Van Remoortere updated MESOS-2119: Sprint: Mesosphere Q4 Sprint 3 - 12/7, Mesosphere Q1 Sprint 1 - 1/23, Mesosphere Q1 Sprint 2 - 2/6, Mesosphere Q1 Sprint 3 - 2/20, Mesosphere Q1 Sprint 4 - 3/6, Mesosphere Q1 Sprint 5 - 3/20, Mesosphere Q1 Sprint 6 - 4/3, Mesosphere Q1 Sprint 7 - 4/17, Mesosphere Q2 Sprint 8 - 5/1, Mesosphere Sprint 10, Mesosphere Sprint 11 (was: Mesosphere Q4 Sprint 3 - 12/7, Mesosphere Q1 Sprint 1 - 1/23, Mesosphere Q1 Sprint 2 - 2/6, Mesosphere Q1 Sprint 3 - 2/20, Mesosphere Q1 Sprint 4 - 3/6, Mesosphere Q1 Sprint 5 - 3/20, Mesosphere Q1 Sprint 6 - 4/3, Mesosphere Q1 Sprint 7 - 4/17, Mesosphere Q2 Sprint 8 - 5/1, Mesosphere Sprint 10, Mesosphere Sprint 11, Mesosphere Sprint 13) > Add Socket tests > > > Key: MESOS-2119 > URL: https://issues.apache.org/jira/browse/MESOS-2119 > Project: Mesos > Issue Type: Task > Components: libprocess >Reporter: Niklas Quarfot Nielsen >Assignee: Joris Van Remoortere > Labels: mesosphere > > Add more Socket specific tests to get coverage while doing libev to libevent > (w and wo SSL) move -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2956) Stack trace in isolator tests on Linux VM
[
https://issues.apache.org/jira/browse/MESOS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Brett updated MESOS-2956:
--
Description:
PerfEventIsolatorTest fails with stack trace when run in Linux VM
[--] 1 test from PerfEventIsolatorTest
[ RUN ] PerfEventIsolatorTest.ROOT_CGROUPS_Sample
F0629 11:38:17.088412 14114 isolator_tests.cpp:837] CHECK_SOME(isolator):
Failed to create PerfEvent isolator, invalid events: { cycles, task-clock }
*** Check failure stack trace: ***
@ 0x2ab5e5aeeb1a google::LogMessage::Fail()
@ 0x2ab5e5aeea66 google::LogMessage::SendToLog()
@ 0x2ab5e5aee468 google::LogMessage::Flush()
@ 0x2ab5e5af137c google::LogMessageFatal::~LogMessageFatal()
@ 0x864b0c _CheckFatal::~_CheckFatal()
@ 0xc458ed
mesos::internal::tests::PerfEventIsolatorTest_ROOT_CGROUPS_Sample_Test::TestBody()
@ 0x119fb17
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x119ac9e
testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x118305f testing::Test::Run()
@ 0x1183782 testing::TestInfo::Run()
@ 0x1183d0a testing::TestCase::Run()
@ 0x11889d4 testing::internal::UnitTestImpl::RunAllTests()
@ 0x11a09ae
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x119b9c3
testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x11878e0 testing::UnitTest::Run()
@ 0xcdc8c7 main
@ 0x2ab5e7fdbec5 (unknown)
@ 0x861a89 (unknown)
make[3]: *** [check-local] Aborted (core dumped)
[ RUN ] UserCgroupIsolatorTest/2.ROOT_CGROUPS_UserCgroup
F0629 11:49:38.763434 18836 isolator_tests.cpp:1200] CHECK_SOME(isolator):
Failed to create PerfEvent isolator, invalid events: { cpu-cycles }
*** Check failure stack trace: ***
@ 0x2ba40eb2db1a google::LogMessage::Fail()
@ 0x2ba40eb2da66 google::LogMessage::SendToLog()
@ 0x2ba40eb2d468 google::LogMessage::Flush()
@ 0x2ba40eb3037c google::LogMessageFatal::~LogMessageFatal()
@ 0x864b0c _CheckFatal::~_CheckFatal()
@ 0xc5ddb1
mesos::internal::tests::UserCgroupIsolatorTest_ROOT_CGROUPS_UserCgroup_Test<>::TestBody()
@ 0x119fc43
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x119adca
testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x118318b testing::Test::Run()
@ 0x11838ae testing::TestInfo::Run()
@ 0x1183e36 testing::TestCase::Run()
@ 0x1188b00 testing::internal::UnitTestImpl::RunAllTests()
@ 0x11a0ada
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x119baef
testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x1187a0c testing::UnitTest::Run()
@ 0xcdc9f3 main
@ 0x2ba41101aec5 (unknown)
@ 0x861a89 (unknown)
make[3]: *** [check-local] Aborted (core dumped)
was:
PerfEventIsolatorTest fails with stack trace when run in Linux VM
[--] 1 test from PerfEventIsolatorTest
[ RUN ] PerfEventIsolatorTest.ROOT_CGROUPS_Sample
F0629 11:38:17.088412 14114 isolator_tests.cpp:837] CHECK_SOME(isolator):
Failed to create PerfEvent isolator, invalid events: { cycles, task-clock }
*** Check failure stack trace: ***
@ 0x2ab5e5aeeb1a google::LogMessage::Fail()
@ 0x2ab5e5aeea66 google::LogMessage::SendToLog()
@ 0x2ab5e5aee468 google::LogMessage::Flush()
@ 0x2ab5e5af137c google::LogMessageFatal::~LogMessageFatal()
@ 0x864b0c _CheckFatal::~_CheckFatal()
@ 0xc458ed
mesos::internal::tests::PerfEventIsolatorTest_ROOT_CGROUPS_Sample_Test::TestBody()
@ 0x119fb17
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x119ac9e
testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x118305f testing::Test::Run()
@ 0x1183782 testing::TestInfo::Run()
@ 0x1183d0a testing::TestCase::Run()
@ 0x11889d4 testing::internal::UnitTestImpl::RunAllTests()
@ 0x11a09ae
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x119b9c3
testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x11878e0 testing::UnitTest::Run()
@ 0xcdc8c7 main
@ 0x2ab5e7fdbec5 (unknown)
@ 0x861a89 (unknown)
make[3]: *** [check-local] Aborted (core dumped)
> Stack trace in isolator tests on Linux VM
> -
>
> Key: MESOS-2956
> URL: https://issues.apache.org/jira/browse/MESOS-2956
> Project: Mesos
> Issue Type: Bug
>Reporter: Paul Brett
>
[jira] [Created] (MESOS-2956) Stack trace in isolator tests on Linux VM
Paul Brett created MESOS-2956:
-
Summary: Stack trace in isolator tests on Linux VM
Key: MESOS-2956
URL: https://issues.apache.org/jira/browse/MESOS-2956
Project: Mesos
Issue Type: Bug
Reporter: Paul Brett
Assignee: Paul Brett
PerfEventIsolatorTest fails with stack trace when run in Linux VM
[--] 1 test from PerfEventIsolatorTest
[ RUN ] PerfEventIsolatorTest.ROOT_CGROUPS_Sample
F0629 11:38:17.088412 14114 isolator_tests.cpp:837] CHECK_SOME(isolator):
Failed to create PerfEvent isolator, invalid events: { cycles, task-clock }
*** Check failure stack trace: ***
@ 0x2ab5e5aeeb1a google::LogMessage::Fail()
@ 0x2ab5e5aeea66 google::LogMessage::SendToLog()
@ 0x2ab5e5aee468 google::LogMessage::Flush()
@ 0x2ab5e5af137c google::LogMessageFatal::~LogMessageFatal()
@ 0x864b0c _CheckFatal::~_CheckFatal()
@ 0xc458ed
mesos::internal::tests::PerfEventIsolatorTest_ROOT_CGROUPS_Sample_Test::TestBody()
@ 0x119fb17
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x119ac9e
testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x118305f testing::Test::Run()
@ 0x1183782 testing::TestInfo::Run()
@ 0x1183d0a testing::TestCase::Run()
@ 0x11889d4 testing::internal::UnitTestImpl::RunAllTests()
@ 0x11a09ae
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x119b9c3
testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x11878e0 testing::UnitTest::Run()
@ 0xcdc8c7 main
@ 0x2ab5e7fdbec5 (unknown)
@ 0x861a89 (unknown)
make[3]: *** [check-local] Aborted (core dumped)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-2123) Document changes in C++ Resources API in CHANGELOG.
[ https://issues.apache.org/jira/browse/MESOS-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606055#comment-14606055 ] Jie Yu commented on MESOS-2123: --- https://reviews.apache.org/r/36010 https://reviews.apache.org/r/36011 > Document changes in C++ Resources API in CHANGELOG. > --- > > Key: MESOS-2123 > URL: https://issues.apache.org/jira/browse/MESOS-2123 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: Jie Yu > Labels: twitter > > With the refactor introduced in MESOS-1974, we need to document those API > changes in CHANGELOG. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2640) Remove old frameworks and ec2 scripts from core Mesos repository
[ https://issues.apache.org/jira/browse/MESOS-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606034#comment-14606034 ] Yan Xu commented on MESOS-2640: --- https://reviews.apache.org/r/33090/ https://reviews.apache.org/r/36005/ > Remove old frameworks and ec2 scripts from core Mesos repository > > > Key: MESOS-2640 > URL: https://issues.apache.org/jira/browse/MESOS-2640 > Project: Mesos > Issue Type: Task >Reporter: Yan Xu >Assignee: Yan Xu > > As per discussion [on the dev > list|http://www.mail-archive.com/dev@mesos.apache.org/msg31587.html] we'll > remove the old and unmaintained frameworks code from the repo and move them > to https://github.com/mesos/. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-2481) Update CHANGELOG and upgrades doc about the new acceptOffers API.
[ https://issues.apache.org/jira/browse/MESOS-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606009#comment-14606009 ] Jie Yu edited comment on MESOS-2481 at 6/29/15 5:59 PM: https://reviews.apache.org/r/36008/ https://reviews.apache.org/r/36009/ was (Author: jieyu): https://reviews.apache.org/r/36008/ > Update CHANGELOG and upgrades doc about the new acceptOffers API. > - > > Key: MESOS-2481 > URL: https://issues.apache.org/jira/browse/MESOS-2481 > Project: Mesos > Issue Type: Bug >Reporter: Jie Yu >Assignee: Jie Yu >Priority: Critical > > We added a new scheduler driver API called 'acceptOffers'. This is a more > generic version of 'launchTasks'. It allows us to do more about the accepted > offers (e.g., reservation, create/destroy volumes). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2481) Update CHANGELOG and upgrades doc about the new acceptOffers API.
[ https://issues.apache.org/jira/browse/MESOS-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606009#comment-14606009 ] Jie Yu commented on MESOS-2481: --- https://reviews.apache.org/r/36008/ > Update CHANGELOG and upgrades doc about the new acceptOffers API. > - > > Key: MESOS-2481 > URL: https://issues.apache.org/jira/browse/MESOS-2481 > Project: Mesos > Issue Type: Bug >Reporter: Jie Yu >Assignee: Jie Yu >Priority: Critical > > We added a new scheduler driver API called 'acceptOffers'. This is a more > generic version of 'launchTasks'. It allows us to do more about the accepted > offers (e.g., reservation, create/destroy volumes). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2955) Introduce acceptOffers scheduler driver API for performing operations on Offers
[ https://issues.apache.org/jira/browse/MESOS-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jie Yu updated MESOS-2955: -- Description: This is a more general version of the `launchTasks` API, which allows the scheduler to accept an offer and specify a list of operations (Offer.Operation) to perform using the resources in the offer. Currently, the supported operations include LAUNCH (launching tasks), RESERVE (making dynamic reservations), UNRESERVE (releasing dynamic reservations), CREATE (creating persistent volumes) and DESTROY (releasing persistent volumes). > Introduce acceptOffers scheduler driver API for performing operations on > Offers > --- > > Key: MESOS-2955 > URL: https://issues.apache.org/jira/browse/MESOS-2955 > Project: Mesos > Issue Type: Improvement >Reporter: Jie Yu > Fix For: 0.23.0 > > > This is a more general version of the `launchTasks` API, which allows the > scheduler to accept an offer and specify a list of operations > (Offer.Operation) to perform using the resources in the offer. Currently, the > supported operations include LAUNCH (launching tasks), RESERVE (making > dynamic reservations), UNRESERVE (releasing dynamic reservations), CREATE > (creating persistent volumes) and DESTROY (releasing persistent volumes). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2640) Remove old frameworks and ec2 scripts from core Mesos repository
[ https://issues.apache.org/jira/browse/MESOS-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Xu updated MESOS-2640: -- Summary: Remove old frameworks and ec2 scripts from core Mesos repository (was: Remove old frameworks from core Mesos repository) > Remove old frameworks and ec2 scripts from core Mesos repository > > > Key: MESOS-2640 > URL: https://issues.apache.org/jira/browse/MESOS-2640 > Project: Mesos > Issue Type: Task >Reporter: Yan Xu >Assignee: Yan Xu > > As per discussion [on the dev > list|http://www.mail-archive.com/dev@mesos.apache.org/msg31587.html] we'll > remove the old and unmaintained frameworks code from the repo and move them > to https://github.com/mesos/. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2955) Introduce an Accept Call for performing operations on Offers
[ https://issues.apache.org/jira/browse/MESOS-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606000#comment-14606000 ] Jie Yu commented on MESOS-2955: --- https://reviews.apache.org/r/29785 > Introduce an Accept Call for performing operations on Offers > > > Key: MESOS-2955 > URL: https://issues.apache.org/jira/browse/MESOS-2955 > Project: Mesos > Issue Type: Improvement >Reporter: Jie Yu > Fix For: 0.23.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2955) Introduce acceptOffers scheduler driver API for performing operations on Offers
[ https://issues.apache.org/jira/browse/MESOS-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jie Yu updated MESOS-2955: -- Summary: Introduce acceptOffers scheduler driver API for performing operations on Offers (was: Introduce an Accept Call for performing operations on Offers) > Introduce acceptOffers scheduler driver API for performing operations on > Offers > --- > > Key: MESOS-2955 > URL: https://issues.apache.org/jira/browse/MESOS-2955 > Project: Mesos > Issue Type: Improvement >Reporter: Jie Yu > Fix For: 0.23.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-2955) Introduce an Accept Call for performing operations on Offers
[ https://issues.apache.org/jira/browse/MESOS-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606000#comment-14606000 ] Jie Yu edited comment on MESOS-2955 at 6/29/15 5:54 PM: https://reviews.apache.org/r/29785 https://reviews.apache.org/r/29823 was (Author: jieyu): https://reviews.apache.org/r/29785 > Introduce an Accept Call for performing operations on Offers > > > Key: MESOS-2955 > URL: https://issues.apache.org/jira/browse/MESOS-2955 > Project: Mesos > Issue Type: Improvement >Reporter: Jie Yu > Fix For: 0.23.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-2955) Introduce an Accept Call for performing operations on Offers
Jie Yu created MESOS-2955: - Summary: Introduce an Accept Call for performing operations on Offers Key: MESOS-2955 URL: https://issues.apache.org/jira/browse/MESOS-2955 Project: Mesos Issue Type: Improvement Reporter: Jie Yu Fix For: 0.23.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1806) Substituting etcd or ReplicatedLog for Zookeeper
[ https://issues.apache.org/jira/browse/MESOS-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605926#comment-14605926 ] Jeff Mitchell commented on MESOS-1806: -- Just wanted to add a comment to please keep the implementation abstract. I'm also quite interested in the ability to run this on top of Consul (too many bad experiences with etcd), so it'd be nice if doing so was just a matter of writing implementations of interface functions. > Substituting etcd or ReplicatedLog for Zookeeper > > > Key: MESOS-1806 > URL: https://issues.apache.org/jira/browse/MESOS-1806 > Project: Mesos > Issue Type: Task >Reporter: Ed Ropple >Assignee: Shuai Lin >Priority: Minor > >eropple: Could you also file a new JIRA for Mesos to drop ZK > in favor of etcd or ReplicatedLog? Would love to get some momentum going on > that one. > -- > Consider it filed. =) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-1552) Mesos javadoc should include .proto javadoc
[ https://issues.apache.org/jira/browse/MESOS-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Connor Doyle reassigned MESOS-1552: --- Assignee: Connor Doyle > Mesos javadoc should include .proto javadoc > --- > > Key: MESOS-1552 > URL: https://issues.apache.org/jira/browse/MESOS-1552 > Project: Mesos > Issue Type: Story > Components: documentation, java api >Reporter: Kevin Sweeney >Assignee: Connor Doyle > Labels: newbie > > The Java API documentation on the website > (http://mesos.apache.org/api/latest/java/) should include protobuf > documentation. protoc automatically generates javadoc based on comments in > the .proto so this should be a matter of wiring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2742) Architecture doc on global resources
[ https://issues.apache.org/jira/browse/MESOS-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam B updated MESOS-2742: -- Shepherd: Adam B > Architecture doc on global resources > > > Key: MESOS-2742 > URL: https://issues.apache.org/jira/browse/MESOS-2742 > Project: Mesos > Issue Type: Task >Reporter: Niklas Quarfot Nielsen >Assignee: Joerg Schad > Labels: mesosphere > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2210) Disallow special characters in role.
[ https://issues.apache.org/jira/browse/MESOS-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605476#comment-14605476 ] Adam B commented on MESOS-2210: --- Patch is almost ready, but it's not a blocker for 0.23, so I retargeted it for now. We'll include it in 0.23 if it lands soon enough. > Disallow special characters in role. > > > Key: MESOS-2210 > URL: https://issues.apache.org/jira/browse/MESOS-2210 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: haosdent > Labels: newbie > > As we introduce persistent volumes in MESOS-1524, we will use roles as > directory names on the slave (https://reviews.apache.org/r/28562/). As a > result, the master should disallow special characters (like space and slash) > in role. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2210) Disallow special characters in role.
[ https://issues.apache.org/jira/browse/MESOS-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam B updated MESOS-2210: -- Target Version/s: 0.24.0 (was: 0.23.0) > Disallow special characters in role. > > > Key: MESOS-2210 > URL: https://issues.apache.org/jira/browse/MESOS-2210 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: haosdent > Labels: newbie > > As we introduce persistent volumes in MESOS-1524, we will use roles as > directory names on the slave (https://reviews.apache.org/r/28562/). As a > result, the master should disallow special characters (like space and slash) > in role. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2110) Configurable Ping Timeouts
[ https://issues.apache.org/jira/browse/MESOS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605408#comment-14605408 ] Adam B commented on MESOS-2110: --- Committed the feature. There's still a pending review to update the tests: https://reviews.apache.org/r/35958/ commit 6cd28dd9154a1a28ff0756078cb776c221d025d1 Author: Adam B Date: Mon Jun 29 02:59:59 2015 -0700 Added Configurable Slave Ping Timeouts Added new --slave_ping_timeout and --max_slave_ping_timeouts flags to mesos-master to supplement the DEFAULT_SLAVE_PING_TIMEOUT (15secs) and DEFAULT_MAX_SLAVE_PING_TIMEOUTS (5). These can be extended if slaves are expected/allowed to be down for longer than a minute or two. Slave will receive master's ping timeout in SlaveRe[re]gisteredMessage. Beware that this affects recovery from network timeouts as well as actual slave node/process failover. Also fixed the log message in recoveredSlavesTimeout() to correctly reference flags.slave_reregister_timeout instead of the unrelated ping timeouts. Review: https://reviews.apache.org/r/29507 > Configurable Ping Timeouts > -- > > Key: MESOS-2110 > URL: https://issues.apache.org/jira/browse/MESOS-2110 > Project: Mesos > Issue Type: Improvement > Components: master, slave >Reporter: Adam B >Assignee: Adam B > Labels: master, mesosphere, network, slave, timeout > > After a series of ping-failures, the master considers the slave lost and > calls shutdownSlave, requiring such a slave that reconnects to kill its tasks > and re-register as a new slaveId. On the other side, after a similar timeout, > the slave will consider the master lost and try to detect a new master. These > timeouts are currently hardcoded constants (5 * 15s), which may not be > well-suited for all scenarios. > - Some clusters may tolerate a longer slave process restart period, and > wouldn't want tasks to be killed upon reconnect. > - Some clusters may have higher-latency networks (e.g. cross-datacenter, or > for volunteer computing efforts), and would like to tolerate longer periods > without communication. > We should provide flags/mechanisms on the master to control its tolerance for > non-communicative slaves, and (less importantly?) on the slave to tolerate > missing masters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2610) Add a Java example framework to test persistent volumes.
[ https://issues.apache.org/jira/browse/MESOS-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam B updated MESOS-2610: -- Target Version/s: 0.24.0 (was: 0.23.0) > Add a Java example framework to test persistent volumes. > > > Key: MESOS-2610 > URL: https://issues.apache.org/jira/browse/MESOS-2610 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: haosdent > > We already have a C++ framework for testing persistent volumes. Since many of > the frameworks are written in Java, so probably we should add an example > framework for Java too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2784) Added constexpr to C++11 whitelist.
[ https://issues.apache.org/jira/browse/MESOS-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605360#comment-14605360 ] Bernd Mathiske commented on MESOS-2784: --- commit b8007aaa9329479e993ded4b7b1ceab7c6c27966 Author: Paul Brett Date: Mon Jun 29 11:49:04 2015 +0200 Add constexpr to C++ whitelist Review: https://reviews.apache.org/r/34835 (Sorry for not correcting the summary before committing! Should have been: "Added constexpr to C++ whitelist."). > Added constexpr to C++11 whitelist. > --- > > Key: MESOS-2784 > URL: https://issues.apache.org/jira/browse/MESOS-2784 > Project: Mesos > Issue Type: Improvement > Components: documentation >Reporter: Paul Brett >Assignee: Paul Brett > Labels: twitter > > constexpr is currently used to eliminate initialization dependency issues for > non-POD objects. We should add it to the whitelist of acceptable c++11 > features in the style guide. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2784) Added constexpr to C++11 whitelist.
[ https://issues.apache.org/jira/browse/MESOS-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Mathiske updated MESOS-2784: -- Summary: Added constexpr to C++11 whitelist. (was: Add constexpr to C++11 whitelist) > Added constexpr to C++11 whitelist. > --- > > Key: MESOS-2784 > URL: https://issues.apache.org/jira/browse/MESOS-2784 > Project: Mesos > Issue Type: Improvement > Components: documentation >Reporter: Paul Brett >Assignee: Paul Brett > Labels: twitter > > constexpr is currently used to eliminate initialization dependency issues for > non-POD objects. We should add it to the whitelist of acceptable c++11 > features in the style guide. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-2745) Add 'Path' to stout's user guide
[ https://issues.apache.org/jira/browse/MESOS-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Toenshoff updated MESOS-2745: -- Assignee: haosdent > Add 'Path' to stout's user guide > - > > Key: MESOS-2745 > URL: https://issues.apache.org/jira/browse/MESOS-2745 > Project: Mesos > Issue Type: Improvement >Reporter: Till Toenshoff >Assignee: haosdent > Labels: newbie > > stout's README does not yet include 'Path', we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2756) Update style guide: Avoid object slicing
[
https://issues.apache.org/jira/browse/MESOS-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605356#comment-14605356
]
Bernd Mathiske commented on MESOS-2756:
---
[~benjaminhindman]] The class Base in the example code directly above does have
a public default copy constructor. Just protecting the argument-less default
constructor is insufficient. Writing the class this way avoids all object
slicing problems:
{code}
class Base {
public:
virtual int get() const { return v; }
protected:
Base(const Base& other) : v(base.v) {}
Base(int _v) : v(_v) {}
int v;
private:
Base() {}
};
{code}
See also the discussion between [~jvanremoortere] and me above. So, copy
constructors need to be addressed in the solution to this ticket, one way or
another!
> Update style guide: Avoid object slicing
>
>
> Key: MESOS-2756
> URL: https://issues.apache.org/jira/browse/MESOS-2756
> Project: Mesos
> Issue Type: Improvement
>Reporter: Joris Van Remoortere
>Assignee: Joris Van Remoortere
> Labels: c++, mesosphere
>
> In order to improve the safety of our code base, let's augment the style
> guide to:
> "Disallow public construction of base classes"
> so that we can avoid the object slicing problem. This is a good pattern to
> follow in general as it prevents subtle semantic bugs like the following:
> {code:title=ObjectSlicing.cpp|borderStyle=solid}
> #include
> #include
> class Base {
> public:
> Base(int _v) : v(_v) {}
> virtual int get() const { return v; }
> protected:
> int v;
> };
> class Derived : public Base {
> public:
> Derived(int _v) : Base(_v) {}
> virtual int get() const { return v + 1; }
> };
> int main() {
> Base b(5);
> Derived d(5);
> std::vector vec;
> vec.push_back(b);
> vec.push_back(d);
> for (const auto& v : vec) {
> printf("[%d]\n", v.get());
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-2119) Add Socket tests
[ https://issues.apache.org/jira/browse/MESOS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605290#comment-14605290 ] Adam B commented on MESOS-2119: --- [~jvanremoortere] Does this patch need to be revisited/discarded? Is it obviated by the tests for MESOS-2888? Should this ticket be resolved/retargeted? > Add Socket tests > > > Key: MESOS-2119 > URL: https://issues.apache.org/jira/browse/MESOS-2119 > Project: Mesos > Issue Type: Task > Components: libprocess >Reporter: Niklas Quarfot Nielsen >Assignee: Joris Van Remoortere > Labels: mesosphere > > Add more Socket specific tests to get coverage while doing libev to libevent > (w and wo SSL) move -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2944) Use of EXPECT in test and relying on the checked condition afterwards.
[
https://issues.apache.org/jira/browse/MESOS-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605277#comment-14605277
]
Bernd Mathiske commented on MESOS-2944:
---
commit b62517792205babad7b11b3fae665024a3d5b3d5
Author: Joerg Schad
Date: Mon Jun 29 10:27:03 2015 +0200
Change EXPECT to ASSERT in docker containerizer tests that rely on assertion
Review: https://reviews.apache.org/r/35920
> Use of EXPECT in test and relying on the checked condition afterwards.
> --
>
> Key: MESOS-2944
> URL: https://issues.apache.org/jira/browse/MESOS-2944
> Project: Mesos
> Issue Type: Bug
> Components: test
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>Priority: Minor
> Labels: mesosphere
>
> In docker_containerizer_test we have the following pattern.
> {code}
> EXPECT_NE(0u, offers.get().size());
> const Offer& offer = offers.get()[0];
> {code}
> As we rely on the value afterwards we should use ASSERT_NE instead. In that
> case the test will fail immediately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
