[jira] [Deleted] (MESOS-8494) test issue

2018-01-25 Thread Gavin (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gavin deleted MESOS-8494:
-


> test issue
> --
>
> Key: MESOS-8494
> URL: https://issues.apache.org/jira/browse/MESOS-8494
> Project: Mesos
>  Issue Type: Choose from below ...
>Reporter: Gavin
>Priority: Major
>
> ignore please



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MESOS-8494) test issue

2018-01-25 Thread Gavin (JIRA)
Gavin created MESOS-8494:


 Summary: test issue
 Key: MESOS-8494
 URL: https://issues.apache.org/jira/browse/MESOS-8494
 Project: Mesos
  Issue Type: Choose from below ...
Reporter: Gavin


ignore please



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8492) Checkpoint profiles in storage local resource provider.

2018-01-25 Thread Chun-Hung Hsiao (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chun-Hung Hsiao updated MESOS-8492:
---
Summary: Checkpoint profiles in storage local resource provider.  (was: 
Support missing profiles from the disk profile module)

> Checkpoint profiles in storage local resource provider.
> ---
>
> Key: MESOS-8492
> URL: https://issues.apache.org/jira/browse/MESOS-8492
> Project: Mesos
>  Issue Type: Task
>  Components: storage
>Reporter: Chun-Hung Hsiao
>Assignee: Chun-Hung Hsiao
>Priority: Major
>  Labels: mesosphere, storage
>
> SLRP should be able to handle missing profiles from an arbitrary disk profile 
> module, and probably need to checkpoint them for recovery.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8492) Support missing profiles from the disk profile module

2018-01-25 Thread Chun-Hung Hsiao (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chun-Hung Hsiao updated MESOS-8492:
---
Summary: Support missing profiles from the disk profile module  (was: 
Support profile activation / deactivation)

> Support missing profiles from the disk profile module
> -
>
> Key: MESOS-8492
> URL: https://issues.apache.org/jira/browse/MESOS-8492
> Project: Mesos
>  Issue Type: Task
>  Components: storage
>Reporter: Chun-Hung Hsiao
>Assignee: Chun-Hung Hsiao
>Priority: Major
>  Labels: mesosphere, storage
>
> SLRP should be able to handle missing profiles from an arbitrary disk profile 
> module, and probably need to checkpoint them for recovery.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MESOS-8477) Make clean fails without Python artifacts.

2018-01-25 Thread Till Toenshoff (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-8477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340403#comment-16340403
 ] 

Till Toenshoff commented on MESOS-8477:
---

{noformat}
commit 46ebb84b80298f64f1fb97b75f2ecc2c68ba20ea (HEAD -> master, origin/master, 
origin/HEAD)
Author: Till Toenshoff 
Date:   Fri Jan 26 02:25:03 2018 +0100

Fixed make clean without Python.

Review: https://reviews.apache.org/r/65280/
{noformat}

> Make clean fails without Python artifacts.
> --
>
> Key: MESOS-8477
> URL: https://issues.apache.org/jira/browse/MESOS-8477
> Project: Mesos
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.5.0
>Reporter: Till Toenshoff
>Assignee: Till Toenshoff
>Priority: Major
> Fix For: 1.6.0
>
>
> Make clean may fail if there are no Python artifacts created by previous 
> builds.  
> {noformat}
> $ make clean{noformat}
> {noformat}
> [...]
> rm -rf java/target
> rm -f examples/java/*.class
> rm -f java/jni/org_apache_mesos*.h
> find python \( -name "build" -o -name "dist" -o -name "*.pyc" \
>   -o -name "*.egg-info" \) -exec rm -rf '{}' \+
> find: ‘python’: No such file or directory
> make[1]: *** [clean-python] Error 1
> make[1]: Leaving directory `/home/centos/workspace/mesos/build/src'
> make: *** [clean-recursive] Error 1{noformat}
>  
> Triggered by 
> [https://github.com/apache/mesos/blob/62d392704c499e06da0323e50dfd016cdac06f33/src/Makefile.am#L2218-L2219]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8493) Master task state metrics discrepancy

2018-01-25 Thread Ilya Pronin (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Pronin updated MESOS-8493:
---
Description: 
Currently if the task status update has no reason we don't increment 
{{master///}} metric. Because of that 
{{master/task_/*}} counters may not sum up to {{master/tasks_}} 
counter, if for example a custom executor doesn't set the reason in its status 
updates.

Since the zero value in {{Reason}} enum is already taken it is possible to just 
count status updates with no reason an under artificial {{reason_unknown}} name.

  was:
Currently if the task status update has no reason we don't increment 
{{master///}} metric. Because of that 
{{master/task_/*}} counters may not sum up to {{master/tasks_}} 
counter, if for example a custom executor doesn't set a reason to its status 
updates.

Since the zero value in {{Reason}} enum is already taken it is possible to just 
count status updates with no reason an under artificial {{reason_unknown}} name.


> Master task state metrics discrepancy
> -
>
> Key: MESOS-8493
> URL: https://issues.apache.org/jira/browse/MESOS-8493
> Project: Mesos
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 1.2.0
>Reporter: Ilya Pronin
>Priority: Trivial
>
> Currently if the task status update has no reason we don't increment 
> {{master///}} metric. Because of that 
> {{master/task_/*}} counters may not sum up to {{master/tasks_}} 
> counter, if for example a custom executor doesn't set the reason in its 
> status updates.
> Since the zero value in {{Reason}} enum is already taken it is possible to 
> just count status updates with no reason an under artificial 
> {{reason_unknown}} name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8493) Master task state metrics discrepancy

2018-01-25 Thread Ilya Pronin (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Pronin updated MESOS-8493:
---
Component/s: master

> Master task state metrics discrepancy
> -
>
> Key: MESOS-8493
> URL: https://issues.apache.org/jira/browse/MESOS-8493
> Project: Mesos
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 1.2.0
>Reporter: Ilya Pronin
>Priority: Trivial
>
> Currently if the task status update has no reason we don't increment 
> {{master///}} metric. Because of that 
> {{master/task_/*}} counters may not sum up to 
> {{master/tasks_}} counter, if for example a custom executor doesn't 
> set a reason to its status updates.
> Since the zero value in {{Reason}} enum is already taken it is possible to 
> just count status updates with no reason an under artificial 
> {{reason_unknown}} name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MESOS-8493) Master task state metrics discrepancy

2018-01-25 Thread Ilya Pronin (JIRA)
Ilya Pronin created MESOS-8493:
--

 Summary: Master task state metrics discrepancy
 Key: MESOS-8493
 URL: https://issues.apache.org/jira/browse/MESOS-8493
 Project: Mesos
  Issue Type: Improvement
Affects Versions: 1.2.0
Reporter: Ilya Pronin


Currently if the task status update has no reason we don't increment 
{{master///}} metric. Because of that 
{{master/task_/*}} counters may not sum up to {{master/tasks_}} 
counter, if for example a custom executor doesn't set a reason to its status 
updates.

Since the zero value in {{Reason}} enum is already taken it is possible to just 
count status updates with no reason an under artificial {{reason_unknown}} name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MESOS-8458) Response from /help includes broken links.

2018-01-25 Thread Benjamin Mahler (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340303#comment-16340303
 ] 

Benjamin Mahler commented on MESOS-8458:


Hm.. all the links look ok to me when I test on a cluster. Am I missing 
something obvious?

> Response from /help includes broken links.
> --
>
> Key: MESOS-8458
> URL: https://issues.apache.org/jira/browse/MESOS-8458
> Project: Mesos
>  Issue Type: Bug
>  Components: libprocess
>Affects Versions: 1.5.0
>Reporter: Alexander Rukletsov
>Priority: Major
>  Labels: mesosphere
>
> Links in response from {{http:///help/}} contain duplicated 
> "/help" prefix, e.g., {{http:///help/help/version}}.
> Links in response from {{http:///help/master/}} contain 
> duplicated "/master" prefix, e.g., 
> {{http:///help/master/master/flags}}.
> Without trailing slash all links are fine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MESOS-2852) Remove now that C++11 is required.

2018-01-25 Thread Benjamin Mahler (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340301#comment-16340301
 ] 

Benjamin Mahler commented on MESOS-2852:


[~mcypark] looks like we should close this now that other stuff has crept into 
lambda?

> Remove  now that C++11 is required.
> -
>
> Key: MESOS-2852
> URL: https://issues.apache.org/jira/browse/MESOS-2852
> Project: Mesos
>  Issue Type: Task
>Reporter: Benjamin Mahler
>Priority: Major
>  Labels: tech-debt
>
> Now that we no longer need to pull in tr1, let's remove . 
> It looks like std::function has already crept its way into the libprocess 
> source, but the mesos source still uses {{lambda::}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8492) Support profile activation / deactivation

2018-01-25 Thread Chun-Hung Hsiao (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chun-Hung Hsiao updated MESOS-8492:
---
Description: SLRP should be able to handle missing profiles from an 
arbitrary disk profile module, and probably need to checkpoint them for 
recovery.  (was: We need support for activating/deactivating profiles in SLRP. 
For deactivated profiles, we probably need to checkpoint them for recovery.)

> Support profile activation / deactivation
> -
>
> Key: MESOS-8492
> URL: https://issues.apache.org/jira/browse/MESOS-8492
> Project: Mesos
>  Issue Type: Task
>  Components: storage
>Reporter: Chun-Hung Hsiao
>Assignee: Chun-Hung Hsiao
>Priority: Major
>  Labels: mesosphere, storage
>
> SLRP should be able to handle missing profiles from an arbitrary disk profile 
> module, and probably need to checkpoint them for recovery.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MESOS-8492) Support profile activation / deactivation

2018-01-25 Thread Chun-Hung Hsiao (JIRA)
Chun-Hung Hsiao created MESOS-8492:
--

 Summary: Support profile activation / deactivation
 Key: MESOS-8492
 URL: https://issues.apache.org/jira/browse/MESOS-8492
 Project: Mesos
  Issue Type: Task
  Components: storage
Reporter: Chun-Hung Hsiao
Assignee: Chun-Hung Hsiao


We need support for activating/deactivating profiles in SLRP. For deactivated 
profiles, we probably need to checkpoint them for recovery.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (MESOS-8490) UpdateSlaveMessageWithPendingOffers is flaky.

2018-01-25 Thread Benjamin Bannier (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Bannier reassigned MESOS-8490:
---

Assignee: Benjamin Bannier

> UpdateSlaveMessageWithPendingOffers is flaky.
> -
>
> Key: MESOS-8490
> URL: https://issues.apache.org/jira/browse/MESOS-8490
> Project: Mesos
>  Issue Type: Bug
>  Components: test
> Environment: CentOS 6 with SSL
> Ubuntu 16.04
>Reporter: Alexander Rukletsov
>Assignee: Benjamin Bannier
>Priority: Major
>  Labels: flaky-test
> Attachments: UpdateSlaveMessageWithPendingOffers-badrun1.txt, 
> UpdateSlaveMessageWithPendingOffers-badrun2.txt
>
>
> {noformat}
> ../../src/tests/master_tests.cpp:8728
> Failed to wait 15secs for offers
> {noformat}
> Full logs attached. Log output from two failures looks different, might be an 
> indicator of multiple issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (MESOS-8458) Response from /help includes broken links.

2018-01-25 Thread Alexander Rukletsov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rukletsov reassigned MESOS-8458:
--

Assignee: (was: Alexander Rukletsov)

> Response from /help includes broken links.
> --
>
> Key: MESOS-8458
> URL: https://issues.apache.org/jira/browse/MESOS-8458
> Project: Mesos
>  Issue Type: Bug
>  Components: libprocess
>Affects Versions: 1.5.0
>Reporter: Alexander Rukletsov
>Priority: Major
>  Labels: mesosphere
>
> Links in response from {{http:///help/}} contain duplicated 
> "/help" prefix, e.g., {{http:///help/help/version}}.
> Links in response from {{http:///help/master/}} contain 
> duplicated "/master" prefix, e.g., 
> {{http:///help/master/master/flags}}.
> Without trailing slash all links are fine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8458) Response from /help includes broken links.

2018-01-25 Thread Alexander Rukletsov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rukletsov updated MESOS-8458:
---
Story Points: 3  (was: 2)

> Response from /help includes broken links.
> --
>
> Key: MESOS-8458
> URL: https://issues.apache.org/jira/browse/MESOS-8458
> Project: Mesos
>  Issue Type: Bug
>  Components: libprocess
>Affects Versions: 1.5.0
>Reporter: Alexander Rukletsov
>Priority: Major
>  Labels: mesosphere
>
> Links in response from {{http:///help/}} contain duplicated 
> "/help" prefix, e.g., {{http:///help/help/version}}.
> Links in response from {{http:///help/master/}} contain 
> duplicated "/master" prefix, e.g., 
> {{http:///help/master/master/flags}}.
> Without trailing slash all links are fine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8458) Response from /help includes broken links.

2018-01-25 Thread Alexander Rukletsov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rukletsov updated MESOS-8458:
---
Description: 
Links in response from {{http:///help/}} contain duplicated 
"/help" prefix, e.g., {{http:///help/help/version}}.

Links in response from {{http:///help/master/}} contain 
duplicated "/master" prefix, e.g., 
{{http:///help/master/master/flags}}.

Without trailing slash all links are fine.

  was:Links in response from {{http:///help/}} contain 
duplicated "/help" prefix, e.g., {{http:///help/help/version}}.


> Response from /help includes broken links.
> --
>
> Key: MESOS-8458
> URL: https://issues.apache.org/jira/browse/MESOS-8458
> Project: Mesos
>  Issue Type: Bug
>  Components: libprocess
>Affects Versions: 1.5.0
>Reporter: Alexander Rukletsov
>Assignee: Alexander Rukletsov
>Priority: Major
>  Labels: mesosphere
>
> Links in response from {{http:///help/}} contain duplicated 
> "/help" prefix, e.g., {{http:///help/help/version}}.
> Links in response from {{http:///help/master/}} contain 
> duplicated "/master" prefix, e.g., 
> {{http:///help/master/master/flags}}.
> Without trailing slash all links are fine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8458) Response from /help includes broken links.

2018-01-25 Thread Alexander Rukletsov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rukletsov updated MESOS-8458:
---
Shepherd: Benjamin Bannier  (was: Benjamin Mahler)

> Response from /help includes broken links.
> --
>
> Key: MESOS-8458
> URL: https://issues.apache.org/jira/browse/MESOS-8458
> Project: Mesos
>  Issue Type: Bug
>  Components: libprocess
>Affects Versions: 1.5.0
>Reporter: Alexander Rukletsov
>Assignee: Alexander Rukletsov
>Priority: Major
>  Labels: mesosphere
>
> Links in response from "http:///help" contain duplicated 
> "/help" prefix, e.g., "http:///help/help/version".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8458) Response from /help includes broken links.

2018-01-25 Thread Alexander Rukletsov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rukletsov updated MESOS-8458:
---
Description: Links in response from {{http:///help/}} 
contain duplicated "/help" prefix, e.g., 
{{http:///help/help/version}}.  (was: Links in response from 
"http:///help" contain duplicated "/help" prefix, e.g., 
"http:///help/help/version".)

> Response from /help includes broken links.
> --
>
> Key: MESOS-8458
> URL: https://issues.apache.org/jira/browse/MESOS-8458
> Project: Mesos
>  Issue Type: Bug
>  Components: libprocess
>Affects Versions: 1.5.0
>Reporter: Alexander Rukletsov
>Assignee: Alexander Rukletsov
>Priority: Major
>  Labels: mesosphere
>
> Links in response from {{http:///help/}} contain duplicated 
> "/help" prefix, e.g., {{http:///help/help/version}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8458) Response from /help includes broken links.

2018-01-25 Thread Alexander Rukletsov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rukletsov updated MESOS-8458:
---
Sprint:   (was: Mesosphere Sprint 73)

> Response from /help includes broken links.
> --
>
> Key: MESOS-8458
> URL: https://issues.apache.org/jira/browse/MESOS-8458
> Project: Mesos
>  Issue Type: Bug
>  Components: libprocess
>Affects Versions: 1.5.0
>Reporter: Alexander Rukletsov
>Assignee: Alexander Rukletsov
>Priority: Major
>  Labels: mesosphere
>
> Links in response from "http:///help" contain duplicated 
> "/help" prefix, e.g., "http:///help/help/version".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-5333) GET /master/maintenance/schedule/ produces 404.

2018-01-25 Thread Alexander Rukletsov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rukletsov updated MESOS-5333:
---
Story Points: 3  (was: 1)

> GET /master/maintenance/schedule/ produces 404.
> ---
>
> Key: MESOS-5333
> URL: https://issues.apache.org/jira/browse/MESOS-5333
> Project: Mesos
>  Issue Type: Bug
>  Components: HTTP API, libprocess
>Reporter: Nathan Handler
>Assignee: Alexander Rukletsov
>Priority: Minor
>  Labels: mesosphere
> Fix For: 1.6.0
>
>
> Attempts to make a GET request to /master/maintenance/schedule/ result in a 
> 404. However, if I make a GET request to /master/maintenance/schedule 
> (without the trailing /), it works. My current (untested) theory is that this 
> might be related to the fact that there is also a 
> /master/maintenance/schedule/status endpoint (an endpoint built on top of a 
> functioning endpoint), as requests to /help and /help/ (with and without the 
> trailing slash) produce the same functioning result.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8491) SchedulerHttpApiTest.Subscribe is flaky.

2018-01-25 Thread Alexander Rukletsov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rukletsov updated MESOS-8491:
---
Attachment: SchedulerHttpApiTest.Subscribe-badrun1.txt

> SchedulerHttpApiTest.Subscribe is flaky.
> 
>
> Key: MESOS-8491
> URL: https://issues.apache.org/jira/browse/MESOS-8491
> Project: Mesos
>  Issue Type: Bug
>  Components: test
> Environment: Ubuntu 14.04 with SSL.
>Reporter: Alexander Rukletsov
>Priority: Major
>  Labels: flaky-test
> Attachments: SchedulerHttpApiTest.Subscribe-badrun1.txt
>
>
> {noformat}
> ../../src/tests/scheduler_http_api_tests.cpp:307
> Failed to wait 15secs for event
> {noformat}
> Full log attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MESOS-8491) SchedulerHttpApiTest.Subscribe is flaky.

2018-01-25 Thread Alexander Rukletsov (JIRA)
Alexander Rukletsov created MESOS-8491:
--

 Summary: SchedulerHttpApiTest.Subscribe is flaky.
 Key: MESOS-8491
 URL: https://issues.apache.org/jira/browse/MESOS-8491
 Project: Mesos
  Issue Type: Bug
  Components: test
 Environment: Ubuntu 14.04 with SSL.
Reporter: Alexander Rukletsov
 Attachments: SchedulerHttpApiTest.Subscribe-badrun1.txt

{noformat}
../../src/tests/scheduler_http_api_tests.cpp:307
Failed to wait 15secs for event
{noformat}
Full log attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8490) UpdateSlaveMessageWithPendingOffers is flaky.

2018-01-25 Thread Alexander Rukletsov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rukletsov updated MESOS-8490:
---
Attachment: UpdateSlaveMessageWithPendingOffers-badrun1.txt

> UpdateSlaveMessageWithPendingOffers is flaky.
> -
>
> Key: MESOS-8490
> URL: https://issues.apache.org/jira/browse/MESOS-8490
> Project: Mesos
>  Issue Type: Bug
>  Components: test
> Environment: CentOS 6 with SSL
> Ubuntu 16.04
>Reporter: Alexander Rukletsov
>Priority: Major
>  Labels: flaky-test
> Attachments: UpdateSlaveMessageWithPendingOffers-badrun1.txt, 
> UpdateSlaveMessageWithPendingOffers-badrun2.txt
>
>
> {noformat}
> ../../src/tests/master_tests.cpp:8728
> Failed to wait 15secs for offers
> {noformat}
> Full logs attached. Log output from two failures looks different, might be an 
> indicator of multiple issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8490) UpdateSlaveMessageWithPendingOffers is flaky.

2018-01-25 Thread Alexander Rukletsov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rukletsov updated MESOS-8490:
---
Attachment: UpdateSlaveMessageWithPendingOffers-badrun2.txt

> UpdateSlaveMessageWithPendingOffers is flaky.
> -
>
> Key: MESOS-8490
> URL: https://issues.apache.org/jira/browse/MESOS-8490
> Project: Mesos
>  Issue Type: Bug
>  Components: test
> Environment: CentOS 6 with SSL
> Ubuntu 16.04
>Reporter: Alexander Rukletsov
>Priority: Major
>  Labels: flaky-test
> Attachments: UpdateSlaveMessageWithPendingOffers-badrun1.txt, 
> UpdateSlaveMessageWithPendingOffers-badrun2.txt
>
>
> {noformat}
> ../../src/tests/master_tests.cpp:8728
> Failed to wait 15secs for offers
> {noformat}
> Full logs attached. Log output from two failures looks different, might be an 
> indicator of multiple issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MESOS-8490) UpdateSlaveMessageWithPendingOffers is flaky.

2018-01-25 Thread Alexander Rukletsov (JIRA)
Alexander Rukletsov created MESOS-8490:
--

 Summary: UpdateSlaveMessageWithPendingOffers is flaky.
 Key: MESOS-8490
 URL: https://issues.apache.org/jira/browse/MESOS-8490
 Project: Mesos
  Issue Type: Bug
  Components: test
 Environment: CentOS 6 with SSL
Ubuntu 16.04
Reporter: Alexander Rukletsov
 Attachments: UpdateSlaveMessageWithPendingOffers-badrun1.txt, 
UpdateSlaveMessageWithPendingOffers-badrun2.txt

{noformat}
../../src/tests/master_tests.cpp:8728
Failed to wait 15secs for offers
{noformat}
Full logs attached. Log output from two failures looks different, might be an 
indicator of multiple issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (MESOS-7699) "stdlib.h: No such file or directory" when building with GCC 6 (Debian stable freshly released)

2018-01-25 Thread Benno Evers (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339357#comment-16339357
 ] 

Benno Evers edited comment on MESOS-7699 at 1/25/18 3:25 PM:
-

Updated review chain after fixing a bunch of other issues blocking this:

 

[https://reviews.apache.org/r/62447/]

[https://reviews.apache.org/r/65289/]

[https://reviews.apache.org/r/65290/]

 


was (Author: bennoe):
Updated review chain after fixing a bunch of other issues blocking this: 
https://reviews.apache.org/r/62447/

> "stdlib.h: No such file or directory" when building with GCC 6 (Debian stable 
> freshly released)
> ---
>
> Key: MESOS-7699
> URL: https://issues.apache.org/jira/browse/MESOS-7699
> Project: Mesos
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.2.0
>Reporter: Adam Cecile
>Assignee: Benno Evers
>Priority: Major
>  Labels: autotools
>
> Hi,
> It seems the issue comes from a workaround added a while ago:
> https://reviews.apache.org/r/40326/
> https://reviews.apache.org/r/40327/
> When building with external libraries it turns out creating build commands 
> line with -isystem /usr/include which is clearly stated as being wrong, 
> according to GCC guys:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
> I'll do some testing by reverting all -isystem to -I and I'll let it know if 
> it gets built.
> Regards, Adam.
> {noformat}
> configure:21642: result: no
> configure:21642: checking glog/logging.h presence
> configure:21642: g++ -E -I/usr/include -I/usr/include/apr-1 
> -I/usr/include/apr-1.0 -Wdate-time -D_FORTIFY_SOURCE=2 -isystem /usr/include 
> -I/usr/include conftest.cpp
> In file included from /usr/include/c++/6/ext/string_conversions.h:41:0,
>  from /usr/include/c++/6/bits/basic_string.h:5417,
>  from /usr/include/c++/6/string:52,
>  from /usr/include/c++/6/bits/locale_classes.h:40,
>  from /usr/include/c++/6/bits/ios_base.h:41,
>  from /usr/include/c++/6/ios:42,
>  from /usr/include/c++/6/ostream:38,
>  from /usr/include/glog/logging.h:43,
>  from conftest.cpp:32:
> /usr/include/c++/6/cstdlib:75:25: fatal error: stdlib.h: No such file or 
> directory
>  #include_next 
>  ^
> compilation terminated.
> configure:21642: $? = 1
> configure: failed program was:
> | /* confdefs.h */
> | #define PACKAGE_NAME "mesos"
> | #define PACKAGE_TARNAME "mesos"
> | #define PACKAGE_VERSION "1.2.0"
> | #define PACKAGE_STRING "mesos 1.2.0"
> | #define PACKAGE_BUGREPORT ""
> | #define PACKAGE_URL ""
> | #define PACKAGE "mesos"
> | #define VERSION "1.2.0"
> | #define STDC_HEADERS 1
> | #define HAVE_SYS_TYPES_H 1
> | #define HAVE_SYS_STAT_H 1
> | #define HAVE_STDLIB_H 1
> | #define HAVE_STRING_H 1
> | #define HAVE_MEMORY_H 1
> | #define HAVE_STRINGS_H 1
> | #define HAVE_INTTYPES_H 1
> | #define HAVE_STDINT_H 1
> | #define HAVE_UNISTD_H 1
> | #define HAVE_DLFCN_H 1
> | #define LT_OBJDIR ".libs/"
> | #define HAVE_CXX11 1
> | #define HAVE_PTHREAD_PRIO_INHERIT 1
> | #define HAVE_PTHREAD 1
> | #define HAVE_LIBZ 1
> | #define HAVE_FTS_H 1
> | #define HAVE_APR_POOLS_H 1
> | #define HAVE_LIBAPR_1 1
> | #define HAVE_BOOST_VERSION_HPP 1
> | #define HAVE_LIBCURL 1
> | /* end confdefs.h.  */
> | #include 
> configure:21642: result: no
> configure:21642: checking for glog/logging.h
> configure:21642: result: no
> configure:21674: error: cannot find glog
> ---
> You have requested the use of a non-bundled glog but no suitable
> glog could be found.
> You may want specify the location of glog by providing a prefix
> path via --with-glog=DIR, or check that the path you provided is
> correct if you're already doing this.
> ---
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MESOS-7699) "stdlib.h: No such file or directory" when building with GCC 6 (Debian stable freshly released)

2018-01-25 Thread Benno Evers (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339357#comment-16339357
 ] 

Benno Evers commented on MESOS-7699:


Updated review chain after fixing a bunch of other issues blocking this: 
https://reviews.apache.org/r/62447/

> "stdlib.h: No such file or directory" when building with GCC 6 (Debian stable 
> freshly released)
> ---
>
> Key: MESOS-7699
> URL: https://issues.apache.org/jira/browse/MESOS-7699
> Project: Mesos
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.2.0
>Reporter: Adam Cecile
>Assignee: Benno Evers
>Priority: Major
>  Labels: autotools
>
> Hi,
> It seems the issue comes from a workaround added a while ago:
> https://reviews.apache.org/r/40326/
> https://reviews.apache.org/r/40327/
> When building with external libraries it turns out creating build commands 
> line with -isystem /usr/include which is clearly stated as being wrong, 
> according to GCC guys:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
> I'll do some testing by reverting all -isystem to -I and I'll let it know if 
> it gets built.
> Regards, Adam.
> {noformat}
> configure:21642: result: no
> configure:21642: checking glog/logging.h presence
> configure:21642: g++ -E -I/usr/include -I/usr/include/apr-1 
> -I/usr/include/apr-1.0 -Wdate-time -D_FORTIFY_SOURCE=2 -isystem /usr/include 
> -I/usr/include conftest.cpp
> In file included from /usr/include/c++/6/ext/string_conversions.h:41:0,
>  from /usr/include/c++/6/bits/basic_string.h:5417,
>  from /usr/include/c++/6/string:52,
>  from /usr/include/c++/6/bits/locale_classes.h:40,
>  from /usr/include/c++/6/bits/ios_base.h:41,
>  from /usr/include/c++/6/ios:42,
>  from /usr/include/c++/6/ostream:38,
>  from /usr/include/glog/logging.h:43,
>  from conftest.cpp:32:
> /usr/include/c++/6/cstdlib:75:25: fatal error: stdlib.h: No such file or 
> directory
>  #include_next 
>  ^
> compilation terminated.
> configure:21642: $? = 1
> configure: failed program was:
> | /* confdefs.h */
> | #define PACKAGE_NAME "mesos"
> | #define PACKAGE_TARNAME "mesos"
> | #define PACKAGE_VERSION "1.2.0"
> | #define PACKAGE_STRING "mesos 1.2.0"
> | #define PACKAGE_BUGREPORT ""
> | #define PACKAGE_URL ""
> | #define PACKAGE "mesos"
> | #define VERSION "1.2.0"
> | #define STDC_HEADERS 1
> | #define HAVE_SYS_TYPES_H 1
> | #define HAVE_SYS_STAT_H 1
> | #define HAVE_STDLIB_H 1
> | #define HAVE_STRING_H 1
> | #define HAVE_MEMORY_H 1
> | #define HAVE_STRINGS_H 1
> | #define HAVE_INTTYPES_H 1
> | #define HAVE_STDINT_H 1
> | #define HAVE_UNISTD_H 1
> | #define HAVE_DLFCN_H 1
> | #define LT_OBJDIR ".libs/"
> | #define HAVE_CXX11 1
> | #define HAVE_PTHREAD_PRIO_INHERIT 1
> | #define HAVE_PTHREAD 1
> | #define HAVE_LIBZ 1
> | #define HAVE_FTS_H 1
> | #define HAVE_APR_POOLS_H 1
> | #define HAVE_LIBAPR_1 1
> | #define HAVE_BOOST_VERSION_HPP 1
> | #define HAVE_LIBCURL 1
> | /* end confdefs.h.  */
> | #include 
> configure:21642: result: no
> configure:21642: checking for glog/logging.h
> configure:21642: result: no
> configure:21674: error: cannot find glog
> ---
> You have requested the use of a non-bundled glog but no suitable
> glog could be found.
> You may want specify the location of glog by providing a prefix
> path via --with-glog=DIR, or check that the path you provided is
> correct if you're already doing this.
> ---
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8482) Signed/Unsigned comparisons in tests

2018-01-25 Thread Benjamin Bannier (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Bannier updated MESOS-8482:

Story Points: 1
  Sprint: Mesosphere Sprint 73

> Signed/Unsigned comparisons in tests
> 
>
> Key: MESOS-8482
> URL: https://issues.apache.org/jira/browse/MESOS-8482
> Project: Mesos
>  Issue Type: Bug
>  Components: test
>Reporter: Benno Evers
>Assignee: Benno Evers
>Priority: Major
>  Labels: mesosphere, newbie, tech-debt
> Fix For: 1.6.0
>
>
> Many tests in mesos currently have comparisons between signed and unsigned 
> integers, eg
> {noformat}
>     ASSERT_EQ(4, v1Response->read_file().size());
> {noformat}
> or comparisons between values of different enums, e.g. TaskState and 
> v1::TaskState:
> {noformat}
>   ASSERT_EQ(TASK_STARTING, startingUpdate->status().state());
> {noformat}
> Usually, the compiler would catch these and emit a warning, but these are 
> currently silenced because gtest headers are included using the {{-isystem}} 
> command line flag.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (MESOS-8489) LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags is flaky

2018-01-25 Thread Andrei Budnik (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Budnik reassigned MESOS-8489:


Assignee: Andrei Budnik

> LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags is flaky
> --
>
> Key: MESOS-8489
> URL: https://issues.apache.org/jira/browse/MESOS-8489
> Project: Mesos
>  Issue Type: Bug
>  Components: containerization
>Reporter: Andrei Budnik
>Assignee: Andrei Budnik
>Priority: Major
>  Labels: containerizer, flaky-test, mesosphere
> Attachments: ROOT_IsolatorFlags-badrun3.txt
>
>
> Observed this on internal Mesosphere CI.
> {code:java}
> ../../src/tests/cluster.cpp:662: Failure
> Value of: containers->empty()
>   Actual: false
> Expected: true
> Failed to destroy containers: { test }
> {code}
> h2. Steps to reproduce
>  # Add {{::sleep(1);}} before 
> [removing|https://github.com/apache/mesos/blob/e91ce42ed56c5ab65220fbba740a8a50c7f835ae/src/linux/cgroups.cpp#L483]
>  "test" cgroup
>  # recompile
>  # run `GLOG_v=2 sudo GLOG_v=2 ./src/mesos-tests 
> --gtest_filter=LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags 
> --gtest_break_on_failure --gtest_repeat=10 --verbose`
> h2. Race description
> While recovery is in progress for [the first 
> slave|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/tests/containerizer/linux_capabilities_isolator_tests.cpp#L733],
>  calling 
> [`StartSlave()`|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/tests/containerizer/linux_capabilities_isolator_tests.cpp#L738]
>  leads to calling 
> [`slave::Containerizer::create()`|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/tests/cluster.cpp#L431]
>  to create a containerizer. An attempt to create a mesos c'zer, leads to 
> calling 
> [`cgroups::prepare`|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/slave/containerizer/mesos/linux_launcher.cpp#L124].
>  Finally, we get to the point, where we try to create a ["test" 
> container|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/linux/cgroups.cpp#L476].
>  So, the recovery process for the first slave [might 
> detect|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/slave/containerizer/mesos/linux_launcher.cpp#L268-L301]
>  this "test" container as an orphaned container.
> Thus, there is the race between recovery process for the first slave and an 
> attempt to create a c'zer for the second agent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MESOS-7506) Multiple tests leave orphan containers.

2018-01-25 Thread Andrei Budnik (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339151#comment-16339151
 ] 

Andrei Budnik commented on MESOS-7506:
--

Created a separate MESOS-8489 ticket for this ^^

> Multiple tests leave orphan containers.
> ---
>
> Key: MESOS-7506
> URL: https://issues.apache.org/jira/browse/MESOS-7506
> Project: Mesos
>  Issue Type: Bug
>  Components: containerization
> Environment: Ubuntu 16.04
> Fedora 23
> other Linux distros
>Reporter: Alexander Rukletsov
>Assignee: Andrei Budnik
>Priority: Major
>  Labels: containerizer, flaky-test, mesosphere
> Attachments: KillMultipleTasks-badrun.txt, 
> ROOT_IsolatorFlags-badrun.txt, ROOT_IsolatorFlags-badrun2.txt, 
> ROOT_IsolatorFlags-badrun3.txt, ReconcileTasksMissingFromSlave-badrun.txt, 
> ResourceLimitation-badrun.txt, ResourceLimitation-badrun2.txt, 
> RestartSlaveRequireExecutorAuthentication-badrun.txt, 
> TaskWithFileURI-badrun.txt
>
>
> I've observed a number of flaky tests that leave orphan containers upon 
> cleanup. A typical log looks like this:
> {noformat}
> ../../src/tests/cluster.cpp:580: Failure
> Value of: containers->empty()
>   Actual: false
> Expected: true
> Failed to destroy containers: { da3e8aa8-98e7-4e72-a8fd-5d0bae960014 }
> {noformat}
> All currently affected tests:
> {noformat}
> SlaveTest.RestartSlaveRequireExecutorAuthentication // cannot reproduce any 
> more
> ROOT_IsolatorFlags
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MESOS-8489) LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags is flaky

2018-01-25 Thread Andrei Budnik (JIRA)
Andrei Budnik created MESOS-8489:


 Summary: LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags is 
flaky
 Key: MESOS-8489
 URL: https://issues.apache.org/jira/browse/MESOS-8489
 Project: Mesos
  Issue Type: Bug
  Components: containerization
Reporter: Andrei Budnik
 Attachments: ROOT_IsolatorFlags-badrun3.txt

Observed this on internal Mesosphere CI.
{code:java}
../../src/tests/cluster.cpp:662: Failure
Value of: containers->empty()
  Actual: false
Expected: true
Failed to destroy containers: { test }
{code}
h2. Steps to reproduce
 # Add {{::sleep(1);}} before 
[removing|https://github.com/apache/mesos/blob/e91ce42ed56c5ab65220fbba740a8a50c7f835ae/src/linux/cgroups.cpp#L483]
 "test" cgroup
 # recompile
 # run `GLOG_v=2 sudo GLOG_v=2 ./src/mesos-tests 
--gtest_filter=LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags 
--gtest_break_on_failure --gtest_repeat=10 --verbose`

h2. Race description

While recovery is in progress for [the first 
slave|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/tests/containerizer/linux_capabilities_isolator_tests.cpp#L733],
 calling 
[`StartSlave()`|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/tests/containerizer/linux_capabilities_isolator_tests.cpp#L738]
 leads to calling 
[`slave::Containerizer::create()`|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/tests/cluster.cpp#L431]
 to create a containerizer. An attempt to create a mesos c'zer, leads to 
calling 
[`cgroups::prepare`|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/slave/containerizer/mesos/linux_launcher.cpp#L124].
 Finally, we get to the point, where we try to create a ["test" 
container|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/linux/cgroups.cpp#L476].
 So, the recovery process for the first slave [might 
detect|https://github.com/apache/mesos/blob/ce0905fcb31a10ade0962a89235fa90b01edf01a/src/slave/containerizer/mesos/linux_launcher.cpp#L268-L301]
 this "test" container as an orphaned container.

Thus, there is the race between recovery process for the first slave and an 
attempt to create a c'zer for the second agent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (MESOS-8454) Add a download link for master and agent logs in WebUI

2018-01-25 Thread Armand Grillet (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333246#comment-16333246
 ] 

Armand Grillet edited comment on MESOS-8454 at 1/25/18 11:48 AM:
-

[https://reviews.apache.org/r/65246/]

 


was (Author: armandgrillet):
[https://reviews.apache.org/r/65245/]

[https://reviews.apache.org/r/65246/]

 

> Add a download link for master and agent logs in WebUI
> --
>
> Key: MESOS-8454
> URL: https://issues.apache.org/jira/browse/MESOS-8454
> Project: Mesos
>  Issue Type: Improvement
>  Components: webui
>Reporter: Vinod Kone
>Assignee: Armand Grillet
>Priority: Major
>
> Just like task sandboxes, it would be great for us to provide a download link 
> for mesos and agent logs in the WebUI. Right now the the log link opens up 
> the pailer, which is not really convenient to do `grep` and such while 
> debugging.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (MESOS-8486) Webui should display role limits.

2018-01-25 Thread Armand Grillet (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Armand Grillet reassigned MESOS-8486:
-

Assignee: Armand Grillet

> Webui should display role limits.
> -
>
> Key: MESOS-8486
> URL: https://issues.apache.org/jira/browse/MESOS-8486
> Project: Mesos
>  Issue Type: Task
>  Components: webui
>Reporter: Benjamin Mahler
>Assignee: Armand Grillet
>Priority: Major
>
> With the addition of quota limits (see MESOS-8068), the UI should be updated 
> to display the per role limit information. Specifically, the 'Roles' tab 
> needs to be updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MESOS-8413) Zookeeper configuration passwords are shown in clear text

2018-01-25 Thread Alexander Rojas (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339073#comment-16339073
 ] 

Alexander Rojas commented on MESOS-8413:


Backport commits.

{noformat}
commit af082dc8e31be696dc857374d13359d98b4f4359
Author: Alexander Rojas 
AuthorDate: Thu Jan 18 16:20:18 2018 +0100
Commit: Alexander Rojas 
CommitDate: Thu Jan 25 11:04:57 2018 +0100

Added SecurePathOrValue for file flags which need not to leak contents.

The default behavior when serializing a flag, if its value comes from
a file (by using the prefix `file://`) is to show the contents of
the file instead of the path to the file.

A common pattern for flags containing sensitive information is to
store the values in a secure file, however the default behavior
of serializing flags causes these values to be leaked when
serializing a subclass of `FlagsBase`.

This patch introduces the structure `SecurePathOrValue` so that
the default behavior is overriden and the path of the flag will
be shown instead of the flag value itself.

Review: https://reviews.apache.org/r/65226
{noformat}
{noformat}
commit e6269bea534dfc512291e7762e34cfdb216eb311
Author: Alexander Rojas 
AuthorDate: Thu Jan 11 10:47:04 2018 +0100
Commit: Alexander Rojas 
CommitDate: Thu Jan 25 11:05:09 2018 +0100

Mesos flags related to ZooKeeper use SecurePathOrValue.

Up until now the Mesos master flag `--zk` as well as the Mesos agent
flag `--master` would leak ZooKeeper authentication credentials in
both logs and results for the `/flags` endpoint, if the credentials
were part of the configuration url.

This patch prevents this leakage if a user decides to store the
ZooKeeper url in a file and pass the file as a value to the flags
mentioned above (using the preffix `file://`).

Review: https://reviews.apache.org/r/65090
{noformat}

{noformat}
commit b9b626c9b50e7c8ebd376990ab1f41fc5e1a36a7 (HEAD -> 1.5.x, upstream/1.5.x)
Author: Alexander Rojas 
AuthorDate: Thu Jan 25 11:49:47 2018 +0100
Commit: Alexander Rojas 
CommitDate: Thu Jan 25 11:49:47 2018 +0100

Added MESOS-8413 to CHANGELOG.
{noformat}


> Zookeeper configuration passwords are shown in clear text
> -
>
> Key: MESOS-8413
> URL: https://issues.apache.org/jira/browse/MESOS-8413
> Project: Mesos
>  Issue Type: Bug
>  Components: master
>Affects Versions: 1.4.1
>Reporter: Alexander Rojas
>Assignee: Alexander Rojas
>Priority: Major
>  Labels: mesosphere, security
> Fix For: 1.5.0, 1.6.0
>
>
> No matter how one configures mesos, either by passing the ZooKeeper flags in 
> the command line or using a file, as follows:
> {noformat}
> ./bin/mesos-master.sh --work_dir=/tmp/$USER/mesos/master 
> --log_dir=/tmp/$USER/mesos/master/log 
> --zk=zk://${zk_username}:${zk_password}@${zk_addr}/mesos --quorum=1
> {noformat}
> {noformat}
> echo "zk://${zk_username}:${zk_password}@${zk_addr}/mesos" > 
> /tmp/${USER}/mesos/zk_config.txt
> ./bin/mesos-master.sh --work_dir=/tmp/$USER/mesos/master 
> --log_dir=/tmp/$USER/mesos/master/log --zk=/tmp/${USER}/mesos/zk_config.txt
> {noformat}
> both the logs and the results of the {{/flags}} endpoint will resolve to the 
> contents of the flags, i.e.:
> {noformat}
> I0108 10:12:50.387522 28579 master.cpp:458] Flags at startup: 
> --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
> --allocation_interval="1secs" --allocator="HierarchicalDRF" 
> --authenticate_agents="false" --authenticate_frameworks="false" 
> --authenticate_http_frameworks="false" --authenticate_http_readonly="false" 
> --authenticate_http_readwrite="false" --authenticators="crammd5" 
> --authorizers="local" --filter_gpu_resources="true" --framework_sorter="drf" 
> --help="false" --hostname_lookup="true" --http_authenticators="basic" 
> --initialize_driver_logging="true" --log_auto_initialize="true" 
> --log_dir="/tmp/user/mesos/master/log" --logbufsecs="0" 
> --logging_level="INFO" --max_agent_ping_timeouts="5" 
> --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" 
> --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" 
> --quorum="1" --recovery_agent_removal_limit="100%" 
> --registry="replicated_log" --registry_fetch_timeout="1mins" 
> --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" 
> --registry_max_agent_count="102400" --registry_store_timeout="20secs" 
> --registry_strict="false" --require_agent_domain="false" 
> --root_submissions="true" --user_sorter="drf" --version="false" 
> 

[jira] [Updated] (MESOS-8447) Incomplete output of apply-reviews.py --dry-run

2018-01-25 Thread Benjamin Bannier (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Bannier updated MESOS-8447:

Summary: Incomplete output of apply-reviews.py --dry-run  (was: Incomplete 
output of apply-reviews.py --dru-run)

> Incomplete output of apply-reviews.py --dry-run
> ---
>
> Key: MESOS-8447
> URL: https://issues.apache.org/jira/browse/MESOS-8447
> Project: Mesos
>  Issue Type: Bug
>  Components: build
>Reporter: Benjamin Bannier
>Assignee: Benjamin Bannier
>Priority: Major
>
> The script {{support/apply-reviews.py}} has a flag {{--dry-run}} which should 
> dump the commands which would be performed. This flag is useful to e.g., 
> reorder patch chains or to manually resolve intermediate conflicts while 
> still being able to pull a full chain.
> The output looks like this
> {noformat}
> % ./support/apply-reviews.py -r 62447 -c -n -3 --dry-run
> wget --no-check-certificate --no-verbose -O 62160.patch 
> https://reviews.apache.org/r/62160/diff/raw/
> git apply --index 62160.patch --3way
> git commit --author "Benno Evers " -aF "62160.message"
> wget --no-check-certificate --no-verbose -O 62161.patch 
> https://reviews.apache.org/r/62161/diff/raw/
> git apply --index 62161.patch --3way
> git commit --author "Benno Evers " -aF "62161.message"
> wget --no-check-certificate --no-verbose -O 62444.patch 
> https://reviews.apache.org/r/62444/diff/raw/
> git apply --index 62444.patch --3way
> git commit --author "Benno Evers " -aF "62444.message"
> wget --no-check-certificate --no-verbose -O 62445.patch 
> https://reviews.apache.org/r/62445/diff/raw/
> git apply --index 62445.patch --3way
> git commit --author "Benno Evers " -aF "62445.message"
> wget --no-check-certificate --no-verbose -O 62447.patch 
> https://reviews.apache.org/r/62447/diff/raw/
> git apply --index 62447.patch --3way
> git commit --author "Benno Evers " -aF 
> "62447.message"{noformat}
> Trying to replay that dry run leads to an error since the commands to create 
> the commit message files are not printed.
> We should add these commands to the output.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8413) Zookeeper configuration passwords are shown in clear text

2018-01-25 Thread Alexander Rojas (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rojas updated MESOS-8413:
---
Fix Version/s: 1.5.0

> Zookeeper configuration passwords are shown in clear text
> -
>
> Key: MESOS-8413
> URL: https://issues.apache.org/jira/browse/MESOS-8413
> Project: Mesos
>  Issue Type: Bug
>  Components: master
>Affects Versions: 1.4.1
>Reporter: Alexander Rojas
>Assignee: Alexander Rojas
>Priority: Major
>  Labels: mesosphere, security
> Fix For: 1.5.0, 1.6.0
>
>
> No matter how one configures mesos, either by passing the ZooKeeper flags in 
> the command line or using a file, as follows:
> {noformat}
> ./bin/mesos-master.sh --work_dir=/tmp/$USER/mesos/master 
> --log_dir=/tmp/$USER/mesos/master/log 
> --zk=zk://${zk_username}:${zk_password}@${zk_addr}/mesos --quorum=1
> {noformat}
> {noformat}
> echo "zk://${zk_username}:${zk_password}@${zk_addr}/mesos" > 
> /tmp/${USER}/mesos/zk_config.txt
> ./bin/mesos-master.sh --work_dir=/tmp/$USER/mesos/master 
> --log_dir=/tmp/$USER/mesos/master/log --zk=/tmp/${USER}/mesos/zk_config.txt
> {noformat}
> both the logs and the results of the {{/flags}} endpoint will resolve to the 
> contents of the flags, i.e.:
> {noformat}
> I0108 10:12:50.387522 28579 master.cpp:458] Flags at startup: 
> --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
> --allocation_interval="1secs" --allocator="HierarchicalDRF" 
> --authenticate_agents="false" --authenticate_frameworks="false" 
> --authenticate_http_frameworks="false" --authenticate_http_readonly="false" 
> --authenticate_http_readwrite="false" --authenticators="crammd5" 
> --authorizers="local" --filter_gpu_resources="true" --framework_sorter="drf" 
> --help="false" --hostname_lookup="true" --http_authenticators="basic" 
> --initialize_driver_logging="true" --log_auto_initialize="true" 
> --log_dir="/tmp/user/mesos/master/log" --logbufsecs="0" 
> --logging_level="INFO" --max_agent_ping_timeouts="5" 
> --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" 
> --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" 
> --quorum="1" --recovery_agent_removal_limit="100%" 
> --registry="replicated_log" --registry_fetch_timeout="1mins" 
> --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" 
> --registry_max_agent_count="102400" --registry_store_timeout="20secs" 
> --registry_strict="false" --require_agent_domain="false" 
> --root_submissions="true" --user_sorter="drf" --version="false" 
> --webui_dir="/home/user/mesos/build/../src/webui" 
> --work_dir="/tmp/user/mesos/master" 
> --zk="zk://user@passwd:127.0.0.1:2181/mesos" --zk_session_timeout="10secs"
> {noformat}
> {noformat}
> HTTP/1.1 200 OK
> Content-Encoding: gzip
> Content-Length: 591
> Content-Type: application/json
> Date: Mon, 08 Jan 2018 15:12:53 GMT
> {
> "flags": {
> "agent_ping_timeout": "15secs",
> "agent_reregister_timeout": "10mins",
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate_agents": "false",
> "authenticate_frameworks": "false",
> "authenticate_http_frameworks": "false",
> "authenticate_http_readonly": "false",
> "authenticate_http_readwrite": "false",
> "authenticators": "crammd5",
> "authorizers": "local",
> "filter_gpu_resources": "true",
> "framework_sorter": "drf",
> "help": "false",
> "hostname_lookup": "true",
> "http_authenticators": "basic",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "log_dir": "/tmp/user/mesos/master/log",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_agent_ping_timeouts": "5",
> "max_completed_frameworks": "50",
> "max_completed_tasks_per_framework": "1000",
> "max_unreachable_tasks_per_framework": "1000",
> "port": "5050",
> "quiet": "false",
> "quorum": "1",
> "recovery_agent_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_gc_interval": "15mins",
> "registry_max_agent_age": "2weeks",
> "registry_max_agent_count": "102400",
> "registry_store_timeout": "20secs",
> "registry_strict": "false",
> "require_agent_domain": "false",
> "root_submissions": "true",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/user/mesos/build/../src/webui",
> "work_dir": "/tmp/user/mesos/master",
> "zk": "zk://user@passwd:127.0.0.1:2181/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> {noformat}
> 

[jira] [Assigned] (MESOS-8482) Signed/Unsigned comparisons in tests

2018-01-25 Thread Benjamin Bannier (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Bannier reassigned MESOS-8482:
---

   Shepherd: Benjamin Bannier
   Assignee: Benno Evers
Component/s: test

Review: https://reviews.apache.org/r/65308/

> Signed/Unsigned comparisons in tests
> 
>
> Key: MESOS-8482
> URL: https://issues.apache.org/jira/browse/MESOS-8482
> Project: Mesos
>  Issue Type: Bug
>  Components: test
>Reporter: Benno Evers
>Assignee: Benno Evers
>Priority: Major
>  Labels: mesosphere, newbie, tech-debt
>
> Many tests in mesos currently have comparisons between signed and unsigned 
> integers, eg
> {noformat}
>     ASSERT_EQ(4, v1Response->read_file().size());
> {noformat}
> or comparisons between values of different enums, e.g. TaskState and 
> v1::TaskState:
> {noformat}
>   ASSERT_EQ(TASK_STARTING, startingUpdate->status().state());
> {noformat}
> Usually, the compiler would catch these and emit a warning, but these are 
> currently silenced because gtest headers are included using the {{-isystem}} 
> command line flag.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8447) Incomplete output of apply-reviews.py --dru-run

2018-01-25 Thread Benjamin Bannier (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Bannier updated MESOS-8447:

Shepherd: Till Toenshoff

> Incomplete output of apply-reviews.py --dru-run
> ---
>
> Key: MESOS-8447
> URL: https://issues.apache.org/jira/browse/MESOS-8447
> Project: Mesos
>  Issue Type: Bug
>  Components: build
>Reporter: Benjamin Bannier
>Assignee: Benjamin Bannier
>Priority: Major
>
> The script {{support/apply-reviews.py}} has a flag {{--dry-run}} which should 
> dump the commands which would be performed. This flag is useful to e.g., 
> reorder patch chains or to manually resolve intermediate conflicts while 
> still being able to pull a full chain.
> The output looks like this
> {noformat}
> % ./support/apply-reviews.py -r 62447 -c -n -3 --dry-run
> wget --no-check-certificate --no-verbose -O 62160.patch 
> https://reviews.apache.org/r/62160/diff/raw/
> git apply --index 62160.patch --3way
> git commit --author "Benno Evers " -aF "62160.message"
> wget --no-check-certificate --no-verbose -O 62161.patch 
> https://reviews.apache.org/r/62161/diff/raw/
> git apply --index 62161.patch --3way
> git commit --author "Benno Evers " -aF "62161.message"
> wget --no-check-certificate --no-verbose -O 62444.patch 
> https://reviews.apache.org/r/62444/diff/raw/
> git apply --index 62444.patch --3way
> git commit --author "Benno Evers " -aF "62444.message"
> wget --no-check-certificate --no-verbose -O 62445.patch 
> https://reviews.apache.org/r/62445/diff/raw/
> git apply --index 62445.patch --3way
> git commit --author "Benno Evers " -aF "62445.message"
> wget --no-check-certificate --no-verbose -O 62447.patch 
> https://reviews.apache.org/r/62447/diff/raw/
> git apply --index 62447.patch --3way
> git commit --author "Benno Evers " -aF 
> "62447.message"{noformat}
> Trying to replay that dry run leads to an error since the commands to create 
> the commit message files are not printed.
> We should add these commands to the output.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MESOS-8413) Zookeeper configuration passwords are shown in clear text

2018-01-25 Thread Alexander Rojas (JIRA)

 [ 
https://issues.apache.org/jira/browse/MESOS-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Rojas updated MESOS-8413:
---
Fix Version/s: (was: 1.5.0)
   1.6.0

> Zookeeper configuration passwords are shown in clear text
> -
>
> Key: MESOS-8413
> URL: https://issues.apache.org/jira/browse/MESOS-8413
> Project: Mesos
>  Issue Type: Bug
>  Components: master
>Affects Versions: 1.4.1
>Reporter: Alexander Rojas
>Assignee: Alexander Rojas
>Priority: Major
>  Labels: mesosphere, security
> Fix For: 1.6.0
>
>
> No matter how one configures mesos, either by passing the ZooKeeper flags in 
> the command line or using a file, as follows:
> {noformat}
> ./bin/mesos-master.sh --work_dir=/tmp/$USER/mesos/master 
> --log_dir=/tmp/$USER/mesos/master/log 
> --zk=zk://${zk_username}:${zk_password}@${zk_addr}/mesos --quorum=1
> {noformat}
> {noformat}
> echo "zk://${zk_username}:${zk_password}@${zk_addr}/mesos" > 
> /tmp/${USER}/mesos/zk_config.txt
> ./bin/mesos-master.sh --work_dir=/tmp/$USER/mesos/master 
> --log_dir=/tmp/$USER/mesos/master/log --zk=/tmp/${USER}/mesos/zk_config.txt
> {noformat}
> both the logs and the results of the {{/flags}} endpoint will resolve to the 
> contents of the flags, i.e.:
> {noformat}
> I0108 10:12:50.387522 28579 master.cpp:458] Flags at startup: 
> --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
> --allocation_interval="1secs" --allocator="HierarchicalDRF" 
> --authenticate_agents="false" --authenticate_frameworks="false" 
> --authenticate_http_frameworks="false" --authenticate_http_readonly="false" 
> --authenticate_http_readwrite="false" --authenticators="crammd5" 
> --authorizers="local" --filter_gpu_resources="true" --framework_sorter="drf" 
> --help="false" --hostname_lookup="true" --http_authenticators="basic" 
> --initialize_driver_logging="true" --log_auto_initialize="true" 
> --log_dir="/tmp/user/mesos/master/log" --logbufsecs="0" 
> --logging_level="INFO" --max_agent_ping_timeouts="5" 
> --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" 
> --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" 
> --quorum="1" --recovery_agent_removal_limit="100%" 
> --registry="replicated_log" --registry_fetch_timeout="1mins" 
> --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" 
> --registry_max_agent_count="102400" --registry_store_timeout="20secs" 
> --registry_strict="false" --require_agent_domain="false" 
> --root_submissions="true" --user_sorter="drf" --version="false" 
> --webui_dir="/home/user/mesos/build/../src/webui" 
> --work_dir="/tmp/user/mesos/master" 
> --zk="zk://user@passwd:127.0.0.1:2181/mesos" --zk_session_timeout="10secs"
> {noformat}
> {noformat}
> HTTP/1.1 200 OK
> Content-Encoding: gzip
> Content-Length: 591
> Content-Type: application/json
> Date: Mon, 08 Jan 2018 15:12:53 GMT
> {
> "flags": {
> "agent_ping_timeout": "15secs",
> "agent_reregister_timeout": "10mins",
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate_agents": "false",
> "authenticate_frameworks": "false",
> "authenticate_http_frameworks": "false",
> "authenticate_http_readonly": "false",
> "authenticate_http_readwrite": "false",
> "authenticators": "crammd5",
> "authorizers": "local",
> "filter_gpu_resources": "true",
> "framework_sorter": "drf",
> "help": "false",
> "hostname_lookup": "true",
> "http_authenticators": "basic",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "log_dir": "/tmp/user/mesos/master/log",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_agent_ping_timeouts": "5",
> "max_completed_frameworks": "50",
> "max_completed_tasks_per_framework": "1000",
> "max_unreachable_tasks_per_framework": "1000",
> "port": "5050",
> "quiet": "false",
> "quorum": "1",
> "recovery_agent_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_gc_interval": "15mins",
> "registry_max_agent_age": "2weeks",
> "registry_max_agent_count": "102400",
> "registry_store_timeout": "20secs",
> "registry_strict": "false",
> "require_agent_domain": "false",
> "root_submissions": "true",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/user/mesos/build/../src/webui",
> "work_dir": "/tmp/user/mesos/master",
> "zk": "zk://user@passwd:127.0.0.1:2181/mesos",
> "zk_session_timeout":