[jira] [Commented] (MESOS-9818) Implement minimal agent-side draining handler

2019-06-28 Thread Greg Mann (JIRA)


[ 
https://issues.apache.org/jira/browse/MESOS-9818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875328#comment-16875328
 ] 

Greg Mann commented on MESOS-9818:
--

{code}
commit b2cfcecb34e76b9a5380bf27f8a2b650510ed158 (HEAD -> master, origin/master, 
origin/HEAD, merge)
Author: Greg Mann 
Date:   Fri Jun 28 13:13:58 2019 -0700

Added agent capability for agent draining.

This patch adds a new required agent capability, AGENT_DRAINING,
which indicates to the master that the agent is capable of
handling automatic task draining via the `DrainSlaveMessage`.

Review: https://reviews.apache.org/r/70839/
{code}

> Implement minimal agent-side draining handler
> -
>
> Key: MESOS-9818
> URL: https://issues.apache.org/jira/browse/MESOS-9818
> Project: Mesos
>  Issue Type: Task
>  Components: agent
>Reporter: Greg Mann
>Assignee: Greg Mann
>Priority: Major
>  Labels: foundations, mesosphere
>
> To unblock other work that can be done in parallel, this ticket captures the 
> implementation of a handler for the {{DrainSlaveMessage}} in the agent which 
> will:
> * Checkpoint the {{DrainInfo}}
> * Populate a new data member in the agent with the {{DrainInfo}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MESOS-9814) Implement DrainAgent master/operator call with associated registry actions

2019-06-28 Thread Greg Mann (JIRA)


[ 
https://issues.apache.org/jira/browse/MESOS-9814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875327#comment-16875327
 ] 

Greg Mann commented on MESOS-9814:
--

{code}
commit 8a85efb877f50c793954e06b2a6db3f4d3049050
Author: Joseph Wu 
Date:   Fri Jun 28 12:56:15 2019 -0700

Added master endpoints for agent draining.

This adds three master calls:
  * DRAIN_AGENT
  * DEACTIVATE_AGENT
  * REACTIVATE_AGENT

DRAIN_AGENT starts automated draining of tasks on the specified agent.
When marked for draining, the agent's resources will not be offered
and all the agent's tasks will be gracefully killed.

DEACTIVATE_AGENT stops offers for a specific agent.  This can be used
for manual draining of tasks, but is not limited to draining.
For example, the operator could deactivate an agent prior to
reserving resources.

REACTIVATE_AGENT restarts offers for a specific agent, that had been
drained or deactivated previously.

Review: https://reviews.apache.org/r/70911/
{code}
{code}
commit 497af42d422a7733b178c3f12b5c34c9328114c0
Author: Joseph Wu jos...@mesosphere.io
Date:   Fri Jun 28 12:56:11 2019 -0700


Added ACLs for agent draining APIs.

This adds three ACLs for the three endpoints added as part of the
agent draining feature:
  * DRAIN_AGENT
  * DEACTIVATE_AGENT
  * REACTIVATE_AGENT

All three ACLs are coarse-grained; a principal is either allowed to
perform the action, or unauthorized. However, there is scope to
restrict the action to particular subsets of agents in future.

Review: https://reviews.apache.org/r/70910/
{code}
{code}
commit cbb5694f00717f8d8a1b760622e9fe41b066be83
Author: Greg Mann 
Date:   Fri Jun 28 12:56:08 2019 -0700

Added common protobufs for agent draining.

This patch makes protobuf message updates which will be used
by both the master and the agent to facilitate automatic
draining of agents.

Review: https://reviews.apache.org/r/70822/
{code}

> Implement DrainAgent master/operator call with associated registry actions
> --
>
> Key: MESOS-9814
> URL: https://issues.apache.org/jira/browse/MESOS-9814
> Project: Mesos
>  Issue Type: Task
>  Components: master
>Reporter: Joseph Wu
>Assignee: Joseph Wu
>Priority: Major
>  Labels: foundations, mesosphere
>
> We want to add several calls associated with agent draining:
> {code}
> message Call {
>   enum Type {
> . . .
> DRAIN_AGENT = 37;
> DEACTIVATE_AGENT = 38;
> REACTIVATE_AGENT = 39;
>   }
>   . . .
>   message DrainAgents {
> message DrainConfig {
>   required AgentID agent = 1;
>   // The duration after which the agent should complete draining.
>   // If tasks are still running after this time, they will
>   // be forcefully terminated.
>   optional Duration max_grace_period = 2;
>   // Whether or not this agent will be removed permanently
>   // from the cluster when draining is complete.
>   optional bool destructive = 3 [default = false];
> }
> repeated DrainConfig drain_config = 1;
>   }
>   message DeactivateAgents {
> repeated AgentID agents = 1;
>   }
>   message ReactivateAgents {
> repeated AgentID agents = 1;
>   }
> }
> {code}
> Each field will be persisted in the registry:
> {code}
> message Registry {
>   . . .
>   message Slave {
> . . .
> optional DrainInfo drain_info = 2;
>   }
>   . . .
>   message UnreachableSlave {
> . . .
> optional DrainInfo drain_info = 3;
>   }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MESOS-9871) Expose quota consumption in /roles endpoint.

2019-06-28 Thread Benjamin Mahler (JIRA)
Benjamin Mahler created MESOS-9871:
--

 Summary: Expose quota consumption in /roles endpoint.
 Key: MESOS-9871
 URL: https://issues.apache.org/jira/browse/MESOS-9871
 Project: Mesos
  Issue Type: Task
  Components: master
Reporter: Benjamin Mahler
Assignee: Benjamin Mahler


As part of exposing quota consumption to users and displaying quota consumption 
in the ui, we will need to add it to the /roles endpoint (which is currently 
what the ui uses for the roles table).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)