[jira] [Commented] (MESOS-5037) foreachkey behaviour is not expected in multimap
[
https://issues.apache.org/jira/browse/MESOS-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883340#comment-16883340
]
Benjamin Mahler commented on MESOS-5037:
[~haosd...@gmail.com] foreachkey indeed sounds problematic for multimap.
I didn't follow the CPU load issue you found. Can you file a related ticket
explaining it? Be sure to show the code in question that is inducing the cpu
load, and attach perf data if possible.
> foreachkey behaviour is not expected in multimap
>
>
> Key: MESOS-5037
> URL: https://issues.apache.org/jira/browse/MESOS-5037
> Project: Mesos
> Issue Type: Bug
> Components: stout
>Reporter: haosdent
>Priority: Major
> Labels: foundations, stout
>
> Currently the {{foreachkey}} implementation is
> {code}
> #define foreachkey(VAR, COL)\
> foreachpair (VAR, __foreach__::ignore, COL)
> {code}
> This works in most structures. But in multimap, one key may map to multi
> values. This means there are multi pairs which have same key. So when call
> {{foreachkey}}, the {{key}} would duplicated when iteration. My idea to solve
> this is we prefer call {{foreach}} on {{(COL).keys()}} if {{keys()}} method
> exists in {{COL}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (MESOS-8789) Role-related endpoints should display distinct offered and allocated resources.
[
https://issues.apache.org/jira/browse/MESOS-8789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883290#comment-16883290
]
Benjamin Mahler commented on MESOS-8789:
{noformat}
commit d6738bcc86525e1ac661d2027a1934134426255f
Author: Benjamin Mahler
Date: Wed Jul 10 19:36:54 2019 -0400
Added Role::reserved, Role::allocated, Role::offered to master.
This provides a breakdown of resource quantities on a per-role
basis, that would aid debugging if shown in the endpoints and
roles table in the ui.
Review: https://reviews.apache.org/r/71050
{noformat}
{noformat}
commit 69c8feab6a62b1728872a367a8ed28f88eb029d3 (HEAD -> master, apache/master)
Author: Benjamin Mahler
Date: Wed Jul 10 20:09:31 2019 -0400
Added reserved, offered, allocated resources to the /roles endpoint.
This provides helpful information for debugging, as well as for the
webui to display in the roles table.
Review: https://reviews.apache.org/r/71053
{noformat}
> Role-related endpoints should display distinct offered and allocated
> resources.
> ---
>
> Key: MESOS-8789
> URL: https://issues.apache.org/jira/browse/MESOS-8789
> Project: Mesos
> Issue Type: Improvement
> Components: agent, HTTP API, master
>Affects Versions: 1.5.0
>Reporter: Till Toenshoff
>Assignee: Benjamin Mahler
>Priority: Major
> Labels: mesosphere, multitenancy, resource-management
>
> The role endpoints currently show accumulated values for resources
> (allocated), containing offered resources. For gaining an overview showing
> our allocated resources separately from the offered resources could improve
> the signal quality, depending on the use case.
> This also affects the UI display, for example the "Roles" tab.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (MESOS-9888) /roles and GET_ROLES do not expose roles with only static reservations
Benjamin Mahler created MESOS-9888: -- Summary: /roles and GET_ROLES do not expose roles with only static reservations Key: MESOS-9888 URL: https://issues.apache.org/jira/browse/MESOS-9888 Project: Mesos Issue Type: Bug Reporter: Benjamin Mahler If a role is only known to the master because of an agent with static reservations to that role, it will not be shown in the /roles and GET_ROLES APIs. This is because the roles are tracked based on frameworks primarily. We'll need to update the tracking to include when there are agents with reservations. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
