[jira] [Commented] (MESOS-6757) Consider using CMake to configure test scripts in the `bin/` diretory
[ https://issues.apache.org/jira/browse/MESOS-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832293#comment-15832293 ] Srinivas commented on MESOS-6757: - https://reviews.apache.org/r/55782/ Added this fix for complete parity. > Consider using CMake to configure test scripts in the `bin/` diretory > - > > Key: MESOS-6757 > URL: https://issues.apache.org/jira/browse/MESOS-6757 > Project: Mesos > Issue Type: Bug > Components: cmake >Reporter: Alex Clemmer >Assignee: Alex Clemmer > Labels: cmake, microsoft > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5433) Add 'distcheck' target to CMake build
[ https://issues.apache.org/jira/browse/MESOS-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srinivas reassigned MESOS-5433: --- Assignee: Srinivas (was: Alex Clemmer) > Add 'distcheck' target to CMake build > - > > Key: MESOS-5433 > URL: https://issues.apache.org/jira/browse/MESOS-5433 > Project: Mesos > Issue Type: Improvement > Components: cmake >Reporter: Juan Larriba >Assignee: Srinivas > Labels: microsoft > > We should add the "distcheck" option to the makefiles created by CMake > configuration. > This way, all the testing battery can be executed during CMake generation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5433) Add 'distcheck' target to CMake build
[ https://issues.apache.org/jira/browse/MESOS-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828748#comment-15828748 ] Srinivas commented on MESOS-5433: - https://reviews.apache.org/r/55686/ > Add 'distcheck' target to CMake build > - > > Key: MESOS-5433 > URL: https://issues.apache.org/jira/browse/MESOS-5433 > Project: Mesos > Issue Type: Improvement > Components: cmake >Reporter: Juan Larriba >Assignee: Alex Clemmer > Labels: microsoft > > We should add the "distcheck" option to the makefiles created by CMake > configuration. > This way, all the testing battery can be executed during CMake generation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4245) Add `dist` target to CMake solution
[ https://issues.apache.org/jira/browse/MESOS-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827182#comment-15827182 ] Srinivas commented on MESOS-4245: - https://reviews.apache.org/r/55657/ > Add `dist` target to CMake solution > --- > > Key: MESOS-4245 > URL: https://issues.apache.org/jira/browse/MESOS-4245 > Project: Mesos > Issue Type: Bug > Components: cmake >Reporter: Alex Clemmer >Assignee: Srinivas > Labels: cmake, mesosphere, microsoft, windows > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-4245) Add `dist` target to CMake solution
[ https://issues.apache.org/jira/browse/MESOS-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srinivas reassigned MESOS-4245: --- Assignee: Srinivas (was: Alex Clemmer) > Add `dist` target to CMake solution > --- > > Key: MESOS-4245 > URL: https://issues.apache.org/jira/browse/MESOS-4245 > Project: Mesos > Issue Type: Bug > Components: cmake >Reporter: Alex Clemmer >Assignee: Srinivas > Labels: cmake, mesosphere, microsoft, windows > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5902) CMake should generate protobuf definitions for Java
[ https://issues.apache.org/jira/browse/MESOS-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732977#comment-15732977 ] Srinivas commented on MESOS-5902: - Added 2 of 9 patches intended for review. https://reviews.apache.org/r/50414 https://reviews.apache.org/r/50415 > CMake should generate protobuf definitions for Java > --- > > Key: MESOS-5902 > URL: https://issues.apache.org/jira/browse/MESOS-5902 > Project: Mesos > Issue Type: Improvement > Components: build > Environment: CMake >Reporter: Srinivas >Assignee: Srinivas > Labels: microsoft > > Currently Java protobuf bindings require java protobuf library to generate > and compile the sources. We should build protobuf-java-2.6.1.jar from the > protobuf sources just like we build the mesos protobuf for C++. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5837) Document the Appc runtime isolator.
[ https://issues.apache.org/jira/browse/MESOS-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415548#comment-15415548 ] Srinivas commented on MESOS-5837: - Please Review. https://reviews.apache.org/r/50954 > Document the Appc runtime isolator. > --- > > Key: MESOS-5837 > URL: https://issues.apache.org/jira/browse/MESOS-5837 > Project: Mesos > Issue Type: Documentation > Components: containerization, isolation >Reporter: Gilbert Song >Assignee: Srinivas > Labels: containerizer, isolator, mesosphere > > Document the Appc runtime isolator and add the logic table for appc runtime > support in unified containerizer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5905) Zookeeper tests do not work on CMake builds as directory structure changed.
Srinivas created MESOS-5905: --- Summary: Zookeeper tests do not work on CMake builds as directory structure changed. Key: MESOS-5905 URL: https://issues.apache.org/jira/browse/MESOS-5905 Project: Mesos Issue Type: Bug Components: build Affects Versions: 1.1.0 Reporter: Srinivas Assignee: Srinivas Zookeeper tests load the class path at runtime. The zookeepers' SetUpTestCase uses the zookeeper build directory to extract the required jars into the java classpath for tests to work. This will break with cmake builds as there is extra build path generated when using cmake. The new make directory looks like "3rdparty/zookeeper-3.4.8/src/zookeeper-3.4.8" instead of "3rdparty/zookeeper-3.4.8". SetupTestCase should handle this. Although there is build setting to specify "ZOOKEEPER_VERSION" there is no build flag to specify zookeeper install directory and that information is deduced. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5902) CMake should generate protobuf definitions for Java
[ https://issues.apache.org/jira/browse/MESOS-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392704#comment-15392704 ] Srinivas commented on MESOS-5902: - Please review https://reviews.apache.org/r/50414 and https://reviews.apache.org/r/50415. > CMake should generate protobuf definitions for Java > --- > > Key: MESOS-5902 > URL: https://issues.apache.org/jira/browse/MESOS-5902 > Project: Mesos > Issue Type: Improvement > Components: build >Affects Versions: 1.1.0 > Environment: CMake >Reporter: Srinivas >Assignee: Srinivas > Fix For: 1.1.0 > > > Currently Java protobuf bindings require java protobuf library to generate > and compile the sources. We should build protobuf-java-2.6.1.jar from the > protobuf sources just like we build the mesos protobuf for C++. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-5902) CMake should generate protobuf definitions for Java
[ https://issues.apache.org/jira/browse/MESOS-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srinivas updated MESOS-5902: Description: Currently Java protobuf bindings require java protobuf library to generate and compile the sources. We should build protobuf-java-2.6.1.jar from the protobuf sources just like we build the mesos protobuf for C++. (was: Currently Java protobuf bindings require java protobuf library to generate and compile the sources. We should build protobuf-java-2.6.1.jar from the protobuf sources just like we build the ) > CMake should generate protobuf definitions for Java > --- > > Key: MESOS-5902 > URL: https://issues.apache.org/jira/browse/MESOS-5902 > Project: Mesos > Issue Type: Improvement > Components: build >Affects Versions: 1.1.0 > Environment: CMake >Reporter: Srinivas >Assignee: Srinivas > Fix For: 1.1.0 > > > Currently Java protobuf bindings require java protobuf library to generate > and compile the sources. We should build protobuf-java-2.6.1.jar from the > protobuf sources just like we build the mesos protobuf for C++. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5902) CMake should generate protobuf definitions for Java
Srinivas created MESOS-5902: --- Summary: CMake should generate protobuf definitions for Java Key: MESOS-5902 URL: https://issues.apache.org/jira/browse/MESOS-5902 Project: Mesos Issue Type: Improvement Components: build Affects Versions: 1.1.0 Environment: CMake Reporter: Srinivas Assignee: Srinivas Fix For: 1.1.0 Currently Java protobuf bindings require java protobuf library to generate and compile the sources. We should build protobuf-java-2.6.1.jar from the protobuf sources just like we build the -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5837) Document the Appc runtime isolator.
[ https://issues.apache.org/jira/browse/MESOS-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srinivas reassigned MESOS-5837: --- Assignee: Srinivas > Document the Appc runtime isolator. > --- > > Key: MESOS-5837 > URL: https://issues.apache.org/jira/browse/MESOS-5837 > Project: Mesos > Issue Type: Documentation > Components: containerization, isolation >Reporter: Gilbert Song >Assignee: Srinivas > Labels: containerizer, isolator, mesosphere > > Document the Appc runtime isolator and add the logic table for appc runtime > support in unified containerizer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-4288) Epic for implementing image discovery section of the appc spec.
[ https://issues.apache.org/jira/browse/MESOS-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srinivas reassigned MESOS-4288: --- Assignee: Srinivas > Epic for implementing image discovery section of the appc spec. > --- > > Key: MESOS-4288 > URL: https://issues.apache.org/jira/browse/MESOS-4288 > Project: Mesos > Issue Type: Epic > Components: containerization >Reporter: Jojy Varghese >Assignee: Srinivas > Labels: mesosphere > > Implement the image discovery mechanism described in > https://github.com/appc/spec/blob/master/spec/discovery.md. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4778) Add appc/runtime isolator for runtime isolation for appc images.
[ https://issues.apache.org/jira/browse/MESOS-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378132#comment-15378132 ] Srinivas commented on MESOS-4778: - Thank you [~jieyu]. Another set of patches are ready for review. https://reviews.apache.org/r/49232/ - Added appcManifest to ImageInfo and ProvisionInfo. This is to allow appcManifest information propagation. https://reviews.apache.org/r/49348/ - Added implementation to Appc Runtime Isolator. Runtime for running app containers using local file based images. https://reviews.apache.org/r/49689/ - Added Appc runtime isolator tests. > Add appc/runtime isolator for runtime isolation for appc images. > > > Key: MESOS-4778 > URL: https://issues.apache.org/jira/browse/MESOS-4778 > Project: Mesos > Issue Type: Task > Components: containerization >Reporter: Jie Yu >Assignee: Srinivas > Labels: containerizer, isolator > > Appc image also contains runtime information like 'exec', 'env', > 'workingDirectory' etc. > https://github.com/appc/spec/blob/master/spec/aci.md > Similar to docker images, we need to support a subset of them (mainly 'exec', > 'env' and 'workingDirectory'). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5756) Cmake build system needs to regenerate protobufs when they are updated.
[ https://issues.apache.org/jira/browse/MESOS-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371724#comment-15371724 ] Srinivas commented on MESOS-5756: - Please review https://reviews.apache.org/r/49928/ > Cmake build system needs to regenerate protobufs when they are updated. > --- > > Key: MESOS-5756 > URL: https://issues.apache.org/jira/browse/MESOS-5756 > Project: Mesos > Issue Type: Improvement > Components: build, cmake >Reporter: Joseph Wu >Assignee: Srinivas >Priority: Minor > Labels: cmake, mesosphere, newbie > > Generated header files, such as protobufs are currently generated all at once > in the CMake build system: > https://github.com/apache/mesos/blob/db8b0f16c1c8c6e683a4b788262f307a8bc218e0/cmake/MesosConfigure.cmake#L77-L80 > This means, if a protobuf is changed, the CMake build system will not > regenerate new protobufs unless you delete the generated {{/include}} > directory. > > Should be a trivial fix, as the CMake protobuf functions merely need to > depend on the input file: > * > https://github.com/apache/mesos/blob/db8b0f16c1c8c6e683a4b788262f307a8bc218e0/src/cmake/MesosProtobuf.cmake#L67 > * > https://github.com/apache/mesos/blob/db8b0f16c1c8c6e683a4b788262f307a8bc218e0/src/cmake/MesosProtobuf.cmake#L100 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5792) Add mesos tests to CMake (make check)
Srinivas created MESOS-5792: --- Summary: Add mesos tests to CMake (make check) Key: MESOS-5792 URL: https://issues.apache.org/jira/browse/MESOS-5792 Project: Mesos Issue Type: Improvement Components: build Reporter: Srinivas Assignee: Srinivas Provide CMakeLists.txt and configuration files to build mesos tests using CMake. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4135) Labels are not return in statusUpdate TaskStatus
[ https://issues.apache.org/jira/browse/MESOS-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291692#comment-15291692 ] Srinivas commented on MESOS-4135: - Hi, I need shepherd to understand the issue fully. But I do have a solution, https://reviews.apache.org/r/47608/ Please let me know your comments. > Labels are not return in statusUpdate TaskStatus > > > Key: MESOS-4135 > URL: https://issues.apache.org/jira/browse/MESOS-4135 > Project: Mesos > Issue Type: Bug > Components: framework, master >Affects Versions: 0.25.0 >Reporter: Felix Hupfeld >Assignee: Srinivas >Priority: Minor > > Labels that were set in the task's TaskInfo upon creation are not returned in > statusUpdate TaskStatus messages. > This restricts their usefulness. Use case would be maintaining the container > version of a running task. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4778) Add appc/runtime isolator for runtime isolation for appc images.
[ https://issues.apache.org/jira/browse/MESOS-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269061#comment-15269061 ] Srinivas commented on MESOS-4778: - Can you please review the patches above, I can make this a epic and open three separate sub tasks(issues) and associate to the patches above. I think of more subtasks we can add for pre and post command executors and may be volume mounts later. > Add appc/runtime isolator for runtime isolation for appc images. > > > Key: MESOS-4778 > URL: https://issues.apache.org/jira/browse/MESOS-4778 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: Srinivas > > Appc image also contains runtime information like 'exec', 'env', > 'workingDirectory' etc. > https://github.com/appc/spec/blob/master/spec/aci.md > Similar to docker images, we need to support a subset of them (mainly 'exec', > 'env' and 'workingDirectory'). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4778) Add appc/runtime isolator for runtime isolation for appc images.
[ https://issues.apache.org/jira/browse/MESOS-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269057#comment-15269057 ] Srinivas commented on MESOS-4778: - Sorry, I am referring to [~jojy] > Add appc/runtime isolator for runtime isolation for appc images. > > > Key: MESOS-4778 > URL: https://issues.apache.org/jira/browse/MESOS-4778 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: Srinivas > > Appc image also contains runtime information like 'exec', 'env', > 'workingDirectory' etc. > https://github.com/appc/spec/blob/master/spec/aci.md > Similar to docker images, we need to support a subset of them (mainly 'exec', > 'env' and 'workingDirectory'). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (MESOS-4778) Add appc/runtime isolator for runtime isolation for appc images.
[ https://issues.apache.org/jira/browse/MESOS-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srinivas updated MESOS-4778: Comment: was deleted (was: [~Joy] Can you please review the patches above, I can make this a epic and open three separate sub tasks(issues) and associate to the patches above. I think of more subtasks we can add for pre and post command executors and may be volume mounts later.) > Add appc/runtime isolator for runtime isolation for appc images. > > > Key: MESOS-4778 > URL: https://issues.apache.org/jira/browse/MESOS-4778 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: Srinivas > > Appc image also contains runtime information like 'exec', 'env', > 'workingDirectory' etc. > https://github.com/appc/spec/blob/master/spec/aci.md > Similar to docker images, we need to support a subset of them (mainly 'exec', > 'env' and 'workingDirectory'). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4778) Add appc/runtime isolator for runtime isolation for appc images.
[ https://issues.apache.org/jira/browse/MESOS-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269053#comment-15269053 ] Srinivas commented on MESOS-4778: - [~Joy] Can you please review the patches above, I can make this a epic and open three separate sub tasks(issues) and associate to the patches above. I think of more subtasks we can add for pre and post command executors and may be volume mounts later. > Add appc/runtime isolator for runtime isolation for appc images. > > > Key: MESOS-4778 > URL: https://issues.apache.org/jira/browse/MESOS-4778 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: Srinivas > > Appc image also contains runtime information like 'exec', 'env', > 'workingDirectory' etc. > https://github.com/appc/spec/blob/master/spec/aci.md > Similar to docker images, we need to support a subset of them (mainly 'exec', > 'env' and 'workingDirectory'). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4135) Labels are not return in statusUpdate TaskStatus
[ https://issues.apache.org/jira/browse/MESOS-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258983#comment-15258983 ] Srinivas commented on MESOS-4135: - Requesting Shepherd, I would like to work on it. > Labels are not return in statusUpdate TaskStatus > > > Key: MESOS-4135 > URL: https://issues.apache.org/jira/browse/MESOS-4135 > Project: Mesos > Issue Type: Bug > Components: framework, master >Affects Versions: 0.25.0 >Reporter: Felix Hupfeld >Assignee: Srinivas >Priority: Minor > > Labels that were set in the task's TaskInfo upon creation are not returned in > statusUpdate TaskStatus messages. > This restricts their usefulness. Use case would be maintaining the container > version of a running task. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4778) Add appc/runtime isolator for runtime isolation for appc images.
[ https://issues.apache.org/jira/browse/MESOS-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252197#comment-15252197 ] Srinivas commented on MESOS-4778: - 3. Isolator is added. https://reviews.apache.org/r/46498/ [~gilbert] [~jieyu] can you please shepherd and review these patches. > Add appc/runtime isolator for runtime isolation for appc images. > > > Key: MESOS-4778 > URL: https://issues.apache.org/jira/browse/MESOS-4778 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: Srinivas > > Appc image also contains runtime information like 'exec', 'env', > 'workingDirectory' etc. > https://github.com/appc/spec/blob/master/spec/aci.md > Similar to docker images, we need to support a subset of them (mainly 'exec', > 'env' and 'workingDirectory'). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4778) Add appc/runtime isolator for runtime isolation for appc images.
[ https://issues.apache.org/jira/browse/MESOS-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243361#comment-15243361 ] Srinivas commented on MESOS-4778: - I plan to add set up patches. 1. add runtime metadata "app" with ability to specify working directory, command and environment. https://reviews.apache.org/r/46107 2. add code to store and provisioner to propagate the metadata to the executor https://reviews.apache.org/r/46182 3. add runtime isolator to hook into containerizer. (WIP) > Add appc/runtime isolator for runtime isolation for appc images. > > > Key: MESOS-4778 > URL: https://issues.apache.org/jira/browse/MESOS-4778 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: Srinivas > > Appc image also contains runtime information like 'exec', 'env', > 'workingDirectory' etc. > https://github.com/appc/spec/blob/master/spec/aci.md > Similar to docker images, we need to support a subset of them (mainly 'exec', > 'env' and 'workingDirectory'). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-4778) Add appc/runtime isolator for runtime isolation for appc images.
[ https://issues.apache.org/jira/browse/MESOS-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srinivas reassigned MESOS-4778: --- Assignee: Srinivas > Add appc/runtime isolator for runtime isolation for appc images. > > > Key: MESOS-4778 > URL: https://issues.apache.org/jira/browse/MESOS-4778 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: Srinivas > > Appc image also contains runtime information like 'exec', 'env', > 'workingDirectory' etc. > https://github.com/appc/spec/blob/master/spec/aci.md > Similar to docker images, we need to support a subset of them (mainly 'exec', > 'env' and 'workingDirectory'). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4840) Remove ShutdownFramework from the ACLs messages and references
[ https://issues.apache.org/jira/browse/MESOS-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178214#comment-15178214 ] Srinivas commented on MESOS-4840: - [~adam-mesos] Can you please shepherd this issue. I have published this under https://reviews.apache.org/r/44345/ > Remove ShutdownFramework from the ACLs messages and references > -- > > Key: MESOS-4840 > URL: https://issues.apache.org/jira/browse/MESOS-4840 > Project: Mesos > Issue Type: Task > Components: master, security, technical debt >Affects Versions: 0.28.0 >Reporter: Alexander Rojas >Assignee: Alexander Rojas >Priority: Minor > Labels: deprecation, mesosphere > > {{ShutdownFramework}} acl was deprecated a couple of versions ago in favor of > the {{TeardownFramework}} message. Its deprecation cycle came with 0.27. That > means we should remove the message and its references in the code base. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-4135) Labels are not return in statusUpdate TaskStatus
[ https://issues.apache.org/jira/browse/MESOS-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srinivas reassigned MESOS-4135: --- Assignee: Srinivas > Labels are not return in statusUpdate TaskStatus > > > Key: MESOS-4135 > URL: https://issues.apache.org/jira/browse/MESOS-4135 > Project: Mesos > Issue Type: Bug > Components: framework, master >Affects Versions: 0.25.0 >Reporter: Felix Hupfeld >Assignee: Srinivas >Priority: Minor > > Labels that were set in the task's TaskInfo upon creation are not returned in > statusUpdate TaskStatus messages. > This restricts their usefulness. Use case would be maintaining the container > version of a running task. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4448) When returning HTTP code 403 a description should be given
[ https://issues.apache.org/jira/browse/MESOS-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115740#comment-15115740 ] Srinivas commented on MESOS-4448: - Please shepherd my changes. This is my first commit. > When returning HTTP code 403 a description should be given > -- > > Key: MESOS-4448 > URL: https://issues.apache.org/jira/browse/MESOS-4448 > Project: Mesos > Issue Type: Bug > Components: general >Affects Versions: 0.26.0 >Reporter: Alexander Rojas >Assignee: Srinivas >Priority: Trivial > > According with the HTTP Specification in [RFC-2616 Section > 10.4.4|http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.4]: > {quote} > If the request method was not HEAD and the server wishes to make public why > the request has not been fulfilled, it SHOULD describe the reason for the > refusal in the entity. If the server does not wish to make this information > available to the client, the status code 404 (Not Found) can be used instead. > {quote} > The definition of SHOULD in [RFC-2119|https://www.ietf.org/rfc/rfc2119.txt] > states: > {quote} > This word, or the adjective "RECOMMENDED", mean that there may exist valid > reasons in particular circumstances to ignore a particular item, but the full > implications must be understood and carefully weighed before choosing a > different course. > {quote} > That means that either each instance of returning {{http::Forbidden}} needs > to add a message in the body, or return 404 instead. If none of this apply, > it should be good to at least add a comment on why no body was added to the > reply. > The places in need of an update are: > {noformat} > src/master/http.cpp > 789:return Forbidden(); > 880:return Forbidden(); > 1209:return Forbidden(); > 1854:return Forbidden(); > 2482:return Forbidden(); > src/master/quota_handler.cpp > 344:return Forbidden(); > 453:return Forbidden(); > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-4448) When returning HTTP code 403 a description should be given
[ https://issues.apache.org/jira/browse/MESOS-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srinivas reassigned MESOS-4448: --- Assignee: Srinivas > When returning HTTP code 403 a description should be given > -- > > Key: MESOS-4448 > URL: https://issues.apache.org/jira/browse/MESOS-4448 > Project: Mesos > Issue Type: Bug > Components: general >Affects Versions: 0.26.0 >Reporter: Alexander Rojas >Assignee: Srinivas >Priority: Trivial > > According with the HTTP Specification in [RFC-2616 Section > 10.4.4|http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.4]: > {quote} > If the request method was not HEAD and the server wishes to make public why > the request has not been fulfilled, it SHOULD describe the reason for the > refusal in the entity. If the server does not wish to make this information > available to the client, the status code 404 (Not Found) can be used instead. > {quote} > The definition of SHOULD in [RFC-2119|https://www.ietf.org/rfc/rfc2119.txt] > states: > {quote} > This word, or the adjective "RECOMMENDED", mean that there may exist valid > reasons in particular circumstances to ignore a particular item, but the full > implications must be understood and carefully weighed before choosing a > different course. > {quote} > That means that either each instance of returning {{http::Forbidden}} needs > to add a message in the body, or return 404 instead. If none of this apply, > it should be good to at least add a comment on why no body was added to the > reply. > The places in need of an update are: > {noformat} > src/master/http.cpp > 789:return Forbidden(); > 880:return Forbidden(); > 1209:return Forbidden(); > 1854:return Forbidden(); > 2482:return Forbidden(); > src/master/quota_handler.cpp > 344:return Forbidden(); > 453:return Forbidden(); > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)