[jira] [Comment Edited] (MESOS-2537) AC_ARG_ENABLED checks are broken

2015-06-08 Thread James Peach (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573449#comment-14573449
 ] 

James Peach edited comment on MESOS-2537 at 6/9/15 12:10 AM:
-

Initial change: https://reviews.apache.org/r/33752/
Updating bundled dependency detection: https://reviews.apache.org/r/35084/
Update for libprocess: https://reviews.apache.org/r/35234/

After these changes,
  * --enable-bundled and --disable-bundled sets the default response for all 
bundled packages
  * --with-$PACKAGE=bundled or --without-package forces the use of a bundled 
package

FWIW --without-package should disable the use of a package, not revert to a 
bundled version, but this semantic is consistent with MESOS-1071.

There's a bunch of unusual behavior around gmock and gtest that doesn't make 
sense to me. If anyone can explain what the right behaviors is in this case, 
I'd be terribly grateful.


was (Author: jamespeach):
https://reviews.apache.org/r/33752/
https://reviews.apache.org/r/35084/

 AC_ARG_ENABLED checks are broken
 

 Key: MESOS-2537
 URL: https://issues.apache.org/jira/browse/MESOS-2537
 Project: Mesos
  Issue Type: Bug
  Components: build
Reporter: James Peach
Assignee: James Peach
Priority: Minor

 In a number of places, the Mesos configure script passes $foo=yes to the 
 2nd argument of {{AC_ARG_ENABLED}}. However, the 2nd argument is invoked when 
 the option is provided in any form, not just when the {{\--enable-foo}} form 
 is used. One result of this is that {{\--disable-optimize}} doesn't work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MESOS-2537) AC_ARG_ENABLED checks are broken

2015-06-08 Thread James Peach (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573449#comment-14573449
 ] 

James Peach edited comment on MESOS-2537 at 6/9/15 12:10 AM:
-

Initial change: https://reviews.apache.org/r/33752/
Updating bundled dependency detection: https://reviews.apache.org/r/35084/
Update for libprocess: https://reviews.apache.org/r/35234/

After these changes,
  * \--enable-bundled and --disable-bundled sets the default response for all 
bundled packages
  * \--with-$PACKAGE=bundled or --without-package forces the use of a bundled 
package

FWIW --without-package should disable the use of a package, not revert to a 
bundled version, but this semantic is consistent with MESOS-1071.

There's a bunch of unusual behavior around gmock and gtest that doesn't make 
sense to me. If anyone can explain what the right behaviors is in this case, 
I'd be terribly grateful.


was (Author: jamespeach):
Initial change: https://reviews.apache.org/r/33752/
Updating bundled dependency detection: https://reviews.apache.org/r/35084/
Update for libprocess: https://reviews.apache.org/r/35234/

After these changes,
  * --enable-bundled and --disable-bundled sets the default response for all 
bundled packages
  * --with-$PACKAGE=bundled or --without-package forces the use of a bundled 
package

FWIW --without-package should disable the use of a package, not revert to a 
bundled version, but this semantic is consistent with MESOS-1071.

There's a bunch of unusual behavior around gmock and gtest that doesn't make 
sense to me. If anyone can explain what the right behaviors is in this case, 
I'd be terribly grateful.

 AC_ARG_ENABLED checks are broken
 

 Key: MESOS-2537
 URL: https://issues.apache.org/jira/browse/MESOS-2537
 Project: Mesos
  Issue Type: Bug
  Components: build
Reporter: James Peach
Assignee: James Peach
Priority: Minor

 In a number of places, the Mesos configure script passes $foo=yes to the 
 2nd argument of {{AC_ARG_ENABLED}}. However, the 2nd argument is invoked when 
 the option is provided in any form, not just when the {{\--enable-foo}} form 
 is used. One result of this is that {{\--disable-optimize}} doesn't work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MESOS-2537) AC_ARG_ENABLED checks are broken

2015-06-08 Thread James Peach (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573449#comment-14573449
 ] 

James Peach edited comment on MESOS-2537 at 6/9/15 12:10 AM:
-

Initial change: https://reviews.apache.org/r/33752/
Updating bundled dependency detection: https://reviews.apache.org/r/35084/
Update for libprocess: https://reviews.apache.org/r/35234/

After these changes,
  * \--enable-bundled and --disable-bundled sets the default response for all 
bundled packages
  * \-\-with-$PACKAGE=bundled or --without-package forces the use of a bundled 
package

FWIW --without-package should disable the use of a package, not revert to a 
bundled version, but this semantic is consistent with MESOS-1071.

There's a bunch of unusual behavior around gmock and gtest that doesn't make 
sense to me. If anyone can explain what the right behaviors is in this case, 
I'd be terribly grateful.


was (Author: jamespeach):
Initial change: https://reviews.apache.org/r/33752/
Updating bundled dependency detection: https://reviews.apache.org/r/35084/
Update for libprocess: https://reviews.apache.org/r/35234/

After these changes,
  * \--enable-bundled and --disable-bundled sets the default response for all 
bundled packages
  * \--with-$PACKAGE=bundled or --without-package forces the use of a bundled 
package

FWIW --without-package should disable the use of a package, not revert to a 
bundled version, but this semantic is consistent with MESOS-1071.

There's a bunch of unusual behavior around gmock and gtest that doesn't make 
sense to me. If anyone can explain what the right behaviors is in this case, 
I'd be terribly grateful.

 AC_ARG_ENABLED checks are broken
 

 Key: MESOS-2537
 URL: https://issues.apache.org/jira/browse/MESOS-2537
 Project: Mesos
  Issue Type: Bug
  Components: build
Reporter: James Peach
Assignee: James Peach
Priority: Minor

 In a number of places, the Mesos configure script passes $foo=yes to the 
 2nd argument of {{AC_ARG_ENABLED}}. However, the 2nd argument is invoked when 
 the option is provided in any form, not just when the {{\--enable-foo}} form 
 is used. One result of this is that {{\--disable-optimize}} doesn't work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)